summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-09-18tdf#106945 TSA Dialog: Disable delete buttonSabin Frandes
Change-Id: Idce5ccc36254d80aaf4b5d5f81cfe201e5c27a5f Reviewed-on: https://gerrit.libreoffice.org/42315 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-15tdf#106946 Removed ability to resize Spellchecking-Options dialogAndreas Brandner
Change-Id: I89182eeb01f8639aa7d7af61f0fe99d96568b6e3 Reviewed-on: https://gerrit.libreoffice.org/42330 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-15Add space after text for better string concatOlivier Hallot
Change-Id: Ib8a9975091f3a17fbc90a0f1bf5eb4b736009099 Reviewed-on: https://gerrit.libreoffice.org/40095 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15tdf#112393: avoid leak in LangSelectHdl_Impl (cui)Julien Nabet
by deleting userdata of entries containing in m_pModulesCLB Change-Id: Ie903b0cd0ccf16839ac7bed42b7bdbc1db4fa5ef Reviewed-on: https://gerrit.libreoffice.org/42308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-15tdf#112392: avoid leak in SvxEditModulesDlg (cui)Julien Nabet
by using unique_ptr Change-Id: I07d71a6aa1fe1eef40280588e842b1a884eb499e Reviewed-on: https://gerrit.libreoffice.org/42307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-14improve redundantcast lopluginNoel Grandin
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13tdf#112133: Drop the Add and Remove labelsMuhammet Kara
and ensure consistent height of the controls in the first row of the Customize dialog. Change-Id: I6c2d75b647cad7a2ead8c875afc4fd38a182eef0 Reviewed-on: https://gerrit.libreoffice.org/42233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-13Enable -Wunreachable-codeStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-13Use "en-US" as the default for XHP's xml-lang attribute.Jan Holesovsky
Change-Id: I765e1cc25ac79d2cebf54f7a247a200647c984da Reviewed-on: https://gerrit.libreoffice.org/32296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-12tdf#112241: Improve column width behaviour in Customize dialogMuhammet Kara
Also: * Remove unnecessary frame "contents" * Remove unnecessary alignment * Remove extra column from the left grid (grid4) * Move all into a new grid for better sizing Change-Id: I4d805a800ca6e487bf788cd9401e5f77303ddd1d Reviewed-on: https://gerrit.libreoffice.org/42186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-12down/up/focus/first/last handler not needed nowCaolán McNamara
Change-Id: Ie8cb8e1bfb32669c2b4487f02d107b08c60b2399
2017-09-12disable thousand separator for this year spinfieldCaolán McNamara
and then the manual removal of ,|. is unnecessary Change-Id: I40d96beb895f815bb7aad9c0f36c3722b614f9a2
2017-09-11Fix typosAndrea Gelmini
Change-Id: I7bb62814c8cdf635d1c54f0a1cbb09a3d06a0d5d Reviewed-on: https://gerrit.libreoffice.org/42178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-11tdf#108011: Customize dialog's commands list should respond to keyboardMuhammet Kara
Change-Id: I58cd779714624e7b37c7920df622aa454afb9f29 Reviewed-on: https://gerrit.libreoffice.org/42163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-11add missing context attributes to .ui filesAndras Timar
Change-Id: If66a4e867b3b406aed90ab2259637e536e236ea3 Reviewed-on: https://gerrit.libreoffice.org/42164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-09-11clang-tidy modernize-use-emplace in c*Noel Grandin
Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-10tdf#112254: fix memory leak in optaboutconfig (cui)Julien Nabet
Store UserData objects in a member defined as vector of unique_ptr so we're sure UserData objects will be destroyed when out of the scope Change-Id: Ib5494ad563272adcf64035300f3213688437fcfc Reviewed-on: https://gerrit.libreoffice.org/42123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10cppcheck: knownConditionTrueFalse 'bValid' is always trueJochen Nitschke
Change-Id: I3f73641286020a06a605867726d54376c47a06dc Reviewed-on: https://gerrit.libreoffice.org/42134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09tdf#108406 offline help-images helpimg are no longer selectable as iconsetAndreas Brandner
Change-Id: I6733ed2a04c01c288de2cd6af938a6c6ff1b4481 Reviewed-on: https://gerrit.libreoffice.org/42117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-09tdf#112133: Polish the visual appearance of the Customize dialogMuhammet Kara
* Vertically align the dual list controls at top and bottom * Vertically center align small controls' captions (search, category) * Vertically top align captions of large controls (description) * Horizontally align captions at the keyboard tab For labels: * Drop all colons * Remove the bold font style at the keyboard tab * Provide mnemonics for all captions with focusable controls (add, remove, insert, modify, reset... but not description) * Take care of unique mnemonics (alt+C = category & cancel) Functional * Disable the description when nothing is to show there (no offline help installed), and inform the user via tooltips Change-Id: I5862f97ec8e5e866f5e56bcdaf386a793f6040d1 Reviewed-on: https://gerrit.libreoffice.org/42099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-08set parent for file dialog helperCaolán McNamara
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08loplugin:constantparamNoel Grandin
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-07Don't use PostUserEvent to show message box in Customize dialogMuhammet Kara
Otherwise, it causes (I think) some clean-up issues, and causes the menu bar not to be refreshed on delete of a custom menu after trying to add an already existing command to the custom menu, and getting the warning message box. And clicking the non-existent menu causes the whole application to crash because of the dangling reference, I think. The exact error message on crash was an "out of range" error of a vector." And we don't need the D&D stuff any more. (At least for now.) Change-Id: I74b8b414e28349065b7408e21e07245fc40f2c75 Reviewed-on: https://gerrit.libreoffice.org/41930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-05tdf#39674 find / fix all German spellings in internal APIsAndreas Brandner
Change-Id: Idcbfe301c13ffa1260ba3ab0665570db5ccc8112 Reviewed-on: https://gerrit.libreoffice.org/41929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-05Polish the Customize dialogMuhammet Kara
with some padding, filling etc. on the .ui file, and some size modifications on the .cxx file Change-Id: I8fdfc298c06162fd847b338a523542bb1ce7ada9 Reviewed-on: https://gerrit.libreoffice.org/41923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-05cui: fix loplugin:constparams warningMiklos Vajna
Change-Id: Ibd61a5e3659b74c67909e351472acdee752a5abc
2017-09-05cui: fix loplugin:unnecessaryparen warningsMiklos Vajna
Change-Id: I7eaee88006c57bb063108aefe28b19ac72363076
2017-09-04Make the Modify button functional in the Customize dialogMuhammet Kara
By adding "rename", "change icon", "reset icon", and "restore default command" options to the Modify button at the bottom of the right (toolbar/menu entries) list. Change icon / Reset icon / Restore default command options are not supported in the menu/context menu tabs yet. Change-Id: Iade3d1aca722c7f8eddcadf251b9562c5366d8ad Reviewed-on: https://gerrit.libreoffice.org/41620 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Disable the individual reset button for the menubar menusMuhammet Kara
And: * Cut m_pDescriptionField's ties to the entries list on the right. * Disable Add and Remove buttons depending on current command selection * Display the description of the selected command Change-Id: I65a06f2f143c335f26de9007c6067f3116465c30 Reviewed-on: https://gerrit.libreoffice.org/41582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Make toolbar/menu addition/removal functional again in the Customize dialogMuhammet Kara
"+" and "-" buttons next to the menu/toolbar listbox can be used to add new toolbars/menus or remove existing toolbars/menus. Most of the code was borrowed from the previous implementation, and adapted to fit the current structure. Change-Id: I7e7f51a46251c2d010154f2a0bab3bb20280bf7c Reviewed-on: https://gerrit.libreoffice.org/41431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Reset" button in the Customize dialogMuhammet Kara
For now, it works for the Toolbar and the Context Menu tabs. Normal top-level menus cannot be reset individually at the moment because they are sharing a single xml file, and the removeSettings() mathod doesn't provide per-item removal from within a single file. Change-Id: I42d62dc26130e4c03cf75a1ce6dc9ff367a58d47 Reviewed-on: https://gerrit.libreoffice.org/41367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Insert" button in the Customize dialogMuhammet Kara
Now the Insert button allows the user to insert separators to the toolbars, and separators and submenus to the menus and context menus. Change-Id: Ic520c78dee2152a0294e86d3bc7098a29155e4b9 Reviewed-on: https://gerrit.libreoffice.org/41360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement Search/Filter feature in the Customize dialogMuhammet Kara
Now commands in the list (left box) are filtered/updated in the Menu, Context Menu, and the Toolbar tabs as you type. Instead of filling the box, and then removing non-matching items (as in the current search feature in the keyboard tab), we filter out items during the Fill process, and don't add them to the sequence att all. This should give a performance boost to the filter operations. Change-Id: I473596a2c897f1cd96a7d55fd3ab11ee3db39863 Reviewed-on: https://gerrit.libreoffice.org/41321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Remove" button in the Customize dialogMuhammet Kara
By using the already implemented DeleteSelectedContent function. Now toolbar and menu/context menu items can be removed by using the "Remove" (Left Arrow) button which is between the commands list and the enrtries list boxes. Change-Id: If445ec6d431bc10263d961563bdd204e7868b931 Reviewed-on: https://gerrit.libreoffice.org/41272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Add" button in the Customize dialogMuhammet Kara
Now new commands can be added to Toolbars, Menus, and Context Menus by using the Add (right arrow) button which is between the commands list and the menu/toolbar entries list. Change-Id: I9c094a5142f82922c5e5bc3075a35442875a5fec Reviewed-on: https://gerrit.libreoffice.org/41240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Initialize and update command categories and functions for the Toolbar tabMuhammet Kara
Change-Id: I27a12fc9e337796fc153e1d243eeba37564ef5c1 Reviewed-on: https://gerrit.libreoffice.org/41104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Initialize and update Function list box properlyMuhammet Kara
* Add dispose methods to CommandCategortListBox * Cast the commands list to SfxConfigFunctionListBox * Update the glade catalog to include CommandCategoryListBox widget * Borrow and adapt FillFunctionsList method from SfxConfigGroupListBox * Create and setup proper SelectHDL(s) Now the command list box (Function box on the left) is properly populated and updated upon selection of a category from the categories list box. Implemented for the Menu and Context Menu tabs. Change-Id: I30ebe89e80bdb2c5b686a26acb7c1ab1178b7525 Reviewed-on: https://gerrit.libreoffice.org/40968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Add custom widget class: CommandCategoryListBoxMuhammet Kara
It now lists all command categories which can be added based on the current module (writer, calc etc.) This class will be expanded later with macros and styles handling stuff. It will also update the commands listbox when it is added. Change-Id: I4f50408641db067118f63fe0e9a1ee755873412f Reviewed-on: https://gerrit.libreoffice.org/40833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Convert UI of Customize Dialog to the new designMuhammet Kara
* Elements of the old design have been removed from both the .ui file and the .cxx/.hxx files. * New elements for the new design have been added to the .ui file. * Menu, Toolbar and Context menu tabs now resemble the new design Change-Id: Ib602e0a4b9419d16adaa4ff6aa23b74097a3b88d Reviewed-on: https://gerrit.libreoffice.org/40468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04new loplugin:redundantpointeropsNoel Grandin
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03Removed duplicated includeAndrea Gelmini
Change-Id: Id17744f8c2d48a04e1b5e64a11739605709fb6c3 Reviewed-on: https://gerrit.libreoffice.org/41865 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-02set parent for insert ole object file dialogCaolán McNamara
Change-Id: Iffa30802f65c950290d74a79c66d679b0ff9d5ea Reviewed-on: https://gerrit.libreoffice.org/41814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25Get rid of need to use initial :: for ::opencl to avoid clash with sc::openclTor Lillqvist
Rename the global opencl namespace to openclwrapper. Its public API is after all declared in a file called openclwrapper.hxx. The confusion started when part of the OpenCL code was moved out from sc some years ago. Change-Id: I98ebd8498b2244804411e5de9169eb619f86070b
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-25tdf#111795 - Special character preview control background colorAkshay Deep
Change-Id: Id5c3448b0cf82e5ed3aa9afabc5bfb093eddf2e9 Reviewed-on: https://gerrit.libreoffice.org/41524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-24tdf#87648 Spelling and Grammarheiko tietze
Renamed to just Spelling Change-Id: I4433d75a8fd697e8d4dd25fa5d26411ed15b6c1b Reviewed-on: https://gerrit.libreoffice.org/40717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-23tdf#111795 - Special character preview control should have borderAkshay Deep
Change-Id: Ic26888829c24f65b3d8039e74a632c14be338d44 Reviewed-on: https://gerrit.libreoffice.org/41356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2025-01-04 05:51:53 +0000