summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-03-31sd theme: add UI (area dialog) for shape fill colorMiklos Vajna
SvxColorTabPage::FillItemSet() has to produce a color item that has the theme index, which means SvxColorTabPage::SelectValSetHdl_Impl() has to change the current color to an svx::NamedThemedColor. The rest is just fallout from this, now that the current color has theming metadata. Change-Id: If0018c651239ba74f45745e69e41ff7040ac9b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132327 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-24Clean up unused translatable stringsAdolfo Jayme Barrientos
These icon themes no longer exist, and these items are ignored anyway since the list was made dynamic in tdf#63962, back in 2014. Change-Id: I5a4dd5001b449f94775447f22b726b99a4fe63ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132025 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-23loplugin:unusedfieldsNoel Grandin
Change-Id: Ifa2e2b35b725a877ef43526ad243cbfd02148807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-22tdf#135234 : Change initial focus of SpellDialogSarrah Bastawala
Change-Id: Ic316a8d99ad12a51a79b2e2680aa5cec5eac5c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131182 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-18tdf#114441 Convert sal_uLong to other typesVaibhavMalik4187
Change-Id: I5651788dad4386aa325e20fa8bbfc0908dbfa629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128767 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-17sw image dialog: fix fallback width/height for images with relative sizesMiklos Vajna
Make sure that we work with the up to date layout size of the image in the dialog, otherwise 80% shows up as 237%. Also fix SfxMacroTabPage::FillItemSet() to not put anything to the output item set when the macro table is empty, this way clicking OK in the image dialog results in an unmodified document when the user doesn't change anything. Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-17Call corresponding base class method in SpellDialog::DeactivateMichael Weghorn
At a quick glance, the fact that `SpellDialog::Deactivate` previously did the same as `SpellDialog::Activate` looks like a copy-paste mistake; both were added in commit 5261417cbb3051b812164838d19c0f748573df45 Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog Change-Id: Ib06d19e46470141d5bfcfc7e790160c1879b6a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-17cui: Use more range-based for in SpellDialogMichael Weghorn
Change-Id: I566af40d67154ee8891c97257b6ef232556fe1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131688 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-17cui: Use range-based for in SentenceEditWindow_ImplMichael Weghorn
Change-Id: I0e324d6b961f632130974d90f22345122650b666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131687 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-17cui: Use range-based for in SpellDialogMichael Weghorn
None of the widgets should be nullptr. Change-Id: Iaaa2528571a7f301c5fab5ddf938494ed1c57f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131686 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-16tdf#109214 - Highlight the favorites in the grid of special charactersAndreas Heinisch
Change-Id: Ie1bb019495d2db4acd92da4bccf44ece2bd1d976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131446 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-16Resolves tdf#35030 - Hide Reset button for keyboard customizationHeiko Tietze
Change-Id: Id69f2fd6ed5d33a622088886b25d1f61d7eb2516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131534 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-15Related: tdf#35030 - add tooltip and improve extended tooltip for resetSeth Chaiklin
Change-Id: I3153785bd5d7420bb6ec89cdf1592362acbbb5b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131480 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-03-14add TypedWhichId version of QueryStateNoel Grandin
Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-13Fix location of commands in a tip of the dayAdolfo Jayme Barrientos
Thanks Jean-Baptiste Faure and Mihkel Tõnnov. Change-Id: I17c3f9009e5ca044f3858cbee605dc53c0398d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131455 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-10tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroGautham Krishnan
Change-Id: If35c679839b39a01e474f7b0b0abee570e85bdd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130798 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-09Fix some mistakes in strings reported by translatorsAdolfo Jayme Barrientos
Change-Id: I56defd20865ddfcefd51dae624f3331abc8dd93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131228 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-09Update a string I forgot to include in 9f16c3b5ac3ae1c9d24fe137ff48b67f54e4899bAdolfo Jayme Barrientos
Change-Id: If0a281ec47f856720ec7baabfdfd4f9d77a9ada2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131227 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-08remove some member-of a11y relationsCaolán McNamara
In some cases the widgets are in frames now so that hierarchical relationship is captured already. In others labelled-by is a better match and/or is already labelled by the widget. Change-Id: I65cbeab514a443edd96c6f9353f892317ac5f775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08resave with latest gladeCaolán McNamara
and drop empty column Change-Id: I05aeb12fecf044aa8a95aa8bf35bf605c35f2498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-07do not pass XComponentContext to officecfg::...::get() callsLuboš Luňák
It's used only for the ConfigurationWrapper singleton, so it's used only the first time and then ignored. It also causes calls to comphelper::getProcessComponentContext() for every single invocation despite the value not being needed, and the calls may not be cheap (it's ~5% CPU during ODS save because relatively frequent calls to officecfg::Office::Common::Save::ODF::DefaultVersion::get()). Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-04cid#1500632 Using a moved objectCaolán McNamara
Change-Id: I5e7dd51c9f9b2b295ded161307bbe9a6a23c42de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130997 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-01use SfxItemSet::GetItemIfSet in cuiNoel Grandin
Change-Id: I0a6dbf50d29adf9da9512a9136709bf563e478f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-27add translator notes for "Key", the K of the CYMK color modelCaolán McNamara
and so on Change-Id: Ia1104f5c92becee8e94c4e2988203149e6b1406d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-27resave with latest gladeCaolán McNamara
Change-Id: If9dfbe8199993a400563bae51f5afbfaea293cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-25Advanced Diagram support: cleanup/consolidate with existing codeArmin Le Grand (Allotropia)
Reorganized and streamlined, use IDiagramHelper as main interface now also for existing code. Had to adapt oox::Shape && Diagram handling since there the import gets handled very different. This ensures that a Diagram is detected at export and that the same happens for now as before Had to add a detection that resetting the GrabBag is meant to disable the Diagam functionality. That is very indirect, but has to stay for compaibility reasons for now Change-Id: I620b7d61cd84b5f9dd8ae4dc890ebf70ce779cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130389 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-24use more TypedWhichIdNoel Grandin
Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22Advanced Diagram support: first additions/reorganizationsArmin Le Grand (Allotropia)
To allow advanced Diagram/SmartArt support in the future this is a first step to organize imported SmartArt Data in a way that will allow to re-layout loaded SmartArts, under re-usage of the oox::Theme (held available). It is designed to work without holding available the original XML snippets defining the imported Diagram in any way, also for performance reasons. It tries to re-use some of the already basically added functionality, including the systematic layouting using the generic layout algorithm, plus some already available text extraction. Before being sure that the former state can be completely replaced this is optoinal and used when SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff is already done but e.g. the redefined reLayout method will not (yet) be triggered. It works and reliably produces a re-layouted identical version, also preserving transformations. Change-Id: I08cfbae04afa663d0589530aae549216d853128d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-21cid#1500465 Dereference after null checkCaolán McNamara
Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17sd theme: add doc model for shape fill colorMiklos Vajna
In preparation of adding UNO API for this. Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130050 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-15add typed GetWhich operationsNoel Grandin
to reduce boilerplate at call sites Change-Id: I290c2bf60ad5e6ddb000aa26cf543830ed39120a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-14tdf#143266 Use correct menu item's names in ToDRoman Kuznetsov
Change-Id: I0796e6c8b2dc2b6e56e7e69611cbcb97ff3e7e34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129842 Tested-by: Jenkins Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-14sw: prefix members of ConditionEdit, SwView, SwXFilterOptions and ...Miklos Vajna
... SwXViewSettings See tdf#94879 for motivation. Change-Id: I68f647d13edf156cfc471a54f247ac686cd6cd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129893 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-14cui: show image pixel size below logic sizeTomaž Vajngerl
Change-Id: If919d1fade2ed85aec7437b429a648ca658e2c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129885 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-14cui: prefix member variables of SvxGrfCropPage classTomaž Vajngerl
Change-Id: If6f4a32df97c352d30958fb27dc90ffec5bbf44d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129884 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-11svx::PropertyChangeNotifier improvementsNoel Grandin
(*) rename the enum to make it's purpose more obvious (*) remove the enum header - it belongs to this class, no need to have it somewhere else (*) return property name by const&, no need to copy here (*) use a o3tl::enumarray instead of a std::unordered_map - there are only 3 entries here, and two of them are ALWAYS used, so just flatten the data structure. Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10add more TypedWhichIdNoel Grandin
Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-06Simplify sequence of PropertyValue in cui/editeng/extensionsJulien Nabet
Change-Id: I0c8f46d2671f3623ff3dd1ee6ec84cde7db41003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129580 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-06Simplify sequence in cuiJulien Nabet
Change-Id: I47e6e6bd2743a380bb316612230bd1e968ed7084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129568 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-04use some more add toId/fromIdCaolán McNamara
Change-Id: I3a21e2aa5a2c482c0bac1d4c9bf84f8b56261408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton valuesCaolán McNamara
for these cases where draw wants to massively scale the units the underlying "metric conversion" are already using sal_Int64 anyway Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-03tools::Long -> sal_Int32Noel Grandin
Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29gtk4: remove stray xalignCaolán McNamara
Change-Id: Ie4dbcdd97f815760370babb225c0cb287fecf1bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129149 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29used TypedWhichId in the constructor of various svx *Item classesNoel Grandin
to act as an extra check that we have the association of Item and TypedWhichId annotations correct. (*) requires that I add an upcasting constructor to TypedWhichId (*) Make the field dialog stuff in writer use a new item id FN_FIELD_DIALOG_DOC_PROPS instead of abusing the existing SID_DOCINFO Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29gtk4: remove stray xalignCaolán McNamara
Change-Id: If1b09a8697a813e5b5bca55f84d1c816a2081e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29gtk4: drop unnecessary stray 0.5 yalignCaolán McNamara
Change-Id: I931332b95f96091b82944f5ef02420ea336c22b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129142 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29unwanted 'end' vertical alignCaolán McNamara
Change-Id: Ia1c6f0182f5006b68c6d963f41f53f7c0a8ae128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29resave with latest gladeCaolán McNamara
Change-Id: I7b8c189e5949c2266ea079eefa3239e4b801bb1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129139 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-31 19:26:16 +0000