summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2024-11-21tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Iced153f4258e2f27007cfbb7a63b78db7f6985dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176962 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-21tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I5c109872713b51cde54ad4617627e72070163601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176783 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-21tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I94ef2c1465698dca75925845be0a4b4cdd9f40d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176959 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-21remove OutDevSupportType::TransparentRectNoel Grandin
all our backends support transparency, and have some time, XRender support became mandatory a couple of years ago. Change-Id: Ie2db7e4665068fe88a926e9791d74a82c2e75834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-20Resolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-17Drop DECL_LINK missed in commitJim Raykowski
60a77c7ef46f6fa82b016c7605ec3451de291344 Change-Id: I9141380327aa111bee02257ea2dda53a19bcb0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176687 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-11-14tdf#36709 GUI changes for font-relative first-line indentJonathan Clark
This change includes GUI element changes to support viewing and editing first-line indent values with font-relative units in the paragraph style dialog. Change-Id: I72ada2565f51d70475eb17096a1317be9316b770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176595 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-11-13tdf#36709 editeng: Layout for font-relative first-line indentJonathan Clark
This change extends layout for font-relative paragraph first-line indentation into Edit Engine. Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#36709 sw: Writer layout for font-relative first-line indentJonathan Clark
This change implements layout for font-relative paragraph first-line indentation in Writer. Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#103916 tdf#163824 cui tparea: always save changed Fill ListsJustin Luth
This was only working for some EditEng components. This change makes it work for all uses of Area Fill. I put this in the destructor because the current implementation (for SvxAreaTabDialog) SavePalettes() on both OK and CANCEL. I first tried putting it in DeactivatePage, but that is not called on a CANCEL, or on a switch to another AREA type. [ColorListState doesn't need this treatment since we don't save to disk here, plus it needs to be shared between SvxAreaTabDialog pages.] NOTE: the rename/delete fix for bug 157467 is probably a dependency because this patch will significantly increase the likelihood that people will try to manage these lists. Change-Id: I65a84eb6befe91620fd43f3cec2d3ce4dd7ae92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176325 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-12tdf#157467 SvxPresetListBox: contextmenu must affect item under mouseJustin Luth
Yikes - especially when delete is involved. Previously it was deleting the in-use background, regardless of where the mouse right-click happened. You might wonder why not just query GetHighlightedItemId? That is because (at least for GTK) the highlightedItem is zero'd out as soon as the pop-up starts, i.e. when the mouse is moved over top of the context menu. Change-Id: Ib88cb0edb8c2c8f854c35821d8125a1991d12a55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176447 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-12tdf#162753 - Hyperlink dialog: trim leading/trailing whitespaces of URLsAndreas Heinisch
Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in cuiNoel Grandin
Change-Id: Idbce2978dee6c485e50dc6ceccf67d7d3722bb17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-11tdf#162753 - Propose clipboard content only for option internetAndreas Heinisch
Change-Id: I030bc4c824ba8946104fe2e6adfd3b445de2b238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176348 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-10tdf#162753 - Propose clipboard content only for options internet and mailAndreas Heinisch
Change-Id: I11ac10ac4321f15cdd9f5096457f6ea4ab8204b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176269 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-11-10com::sun::star -> cssMike Kaganski
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08tdf#163802 cui: Don't set temporary title for spelling dialogMichael Weghorn
The window title set using SpellingDialog::SetTitle_Impl was overwritten right away by the next call to `m_xDialog->set_title(...)`, so was never meant to be used in practice anyway. The // use this function to apply the correct image to be used... comment suggests that SpellingDialog::SetTitle_Impl also sets some image, which was actually the case when the code was initially introduced in commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui , but that's no longer the case since commit bc3c10b5ce88869871761000e9724bcad9a0d556 Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr> Date: Sun Oct 23 07:35:06 2011 -0700 Grammar checking dialog: reworked how explanations are shown , so there's no more reason to call SpellingDialog::SetTitle_Impl before setting the actual title. Change-Id: I56d7478271b53a6ec033a8ead9b05d3eff6ad5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176256 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-08loplugin:reftotemp in cppcanvas..cuiNoel Grandin
Change-Id: I6c9ded2252462bcdeee6520bb7b7fa1752aa583b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08tdf#155447 a11y: Set accessible ID that Orca expectsMichael Weghorn
Orca commit [1] commit 40a2d302eb52295433fd84e6c254a7dbe5108a24 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Nov 7 14:15:07 2024 +0100 Spellcheck: Check for accessible id in more places Do the following case-insensitive checks: * If the object's accessible id starts with "suggestions" treat it as the suggestions list. * If the object's accessible id starts with "replacement" treat it as the object (likely entry) which contains the proposed replacement. * If the label's/widget's accessible id starts with "error" treat it as the container displaying the misspelled word. Note that the first of the three is based on what LO 25.2 currently exposes ("suggestionslb"). The other two are not in use yet, but adding them facilitates implementation in, and getting feedback from, apps and toolkits. Also modify the existing check for the window. We were doing an exact match on "SpellingDialog". Making that case insensitive and limiting to starts with "spelling" works with the current LO implementation and removes an implementation detail ("dialog"). introduced logic to identify more UI elements in the spelling dialog by their accessible ID. Adjust the GtkBuilder ID (which gets reported as accessible ID as well) of the drawing area that holds the misspelt text to match the expectations as mentioned in the commit message above. [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24 Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08cui: Resave insertrowcolumn.ui with glade 3.40Michael Weghorn
Change-Id: I0fd60e103be55b773274c830441a46f2a14c5980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176247 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-07loplugin:passstuffbyref in cui..dbaccessNoel Grandin
Change-Id: Ie15974919f7c0764e661225ef14a9f50917ab083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176189 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-07cid#1634480 Use of auto that causes a copyCaolán McNamara
and cid#1634481 Use of auto that causes a copy Change-Id: Ia301cc4ffae4ad451dfafb90c63cc8feb0eb0ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176194 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-07tdf#130857 tipofthedaydialog.ui: Move checkbox out of button boxMichael Weghorn
Move the checkbox in the "Help" > "Show Tip of the Day" dialog above the button box rather than having it inside of the button box. That is consistent with e.g. the "LibreOfficeDev Help not installed" dialog that gets shown when pressing F1 in a build not including the local help, and it makes this work with the native Qt version of the dialog (SAL_VCL_QT_USE_WELDED_WIDGETS=1) which doesn't support arbitrary widgets inside of the button box. Change-Id: I79541d986df31325b43a17dbec81466ec8bfdca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176177 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-07cui: Resave tipofthedaydialog.ui with glade 3.40Michael Weghorn
Change-Id: Icad97adfd0c4cb50a12ba8eda25d3802ed00dc55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176176 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-06Libreoffice Theme Part 1.0: Make registry colors accessible from VCLSahil Gautam
Enable UI color customization via an extension. This patch doesn't include any UI changes as that needs to be discussed with the community first (ticket: https://bugs.documentfoundation.org/show_bug.cgi?id=163620) Part 1.0 (this change) is responsible for loading all the ThemeColors from the registry into a `static ThemeColors` object, which then is accessed in various VCL_PLUGINS as a source for the application colors. The user now has to go to the registry (expert configuration), and enable the theme by setting "LibreofficeTheme" to "true". It can also be enabled via an extension (demonstrated in the Theme Template). `testGetViewRenderState` changes to "Dark" scheme which is not present. Changes in this patch don't allow that and use 'Automatic' as the fallback. This caused the unit test to fail. So the test was changed to have "Dark" scheme before changing to it. Theme Template: https://github.com/printfdebugging/libreoffice-theme-template Project Report: https://printfdebugging.in/libreoffice/01-themes-gsoc-2024/ Change-Id: I5193d4d34fcd2f4c5d6f124a871bd5c7f14e95a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168016 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-06loplugin:passstuffbyref in svxNoel Grandin
Change-Id: Ic5fd72cb64208c278ffc129591cd3d1131efdc08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06cid#1556442 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607753 COPY_INSTEAD_OF_MOVE cid#1554790 COPY_INSTEAD_OF_MOVE cid#1556463 COPY_INSTEAD_OF_MOVE cid#1554838 COPY_INSTEAD_OF_MOVE cid#1556231 COPY_INSTEAD_OF_MOVE cid#1556878 COPY_INSTEAD_OF_MOVE cid#1554913 COPY_INSTEAD_OF_MOVE cid#1558064 COPY_INSTEAD_OF_MOVE cid#1557043 COPY_INSTEAD_OF_MOVE cid#1556985 COPY_INSTEAD_OF_MOVE cid#1556766 COPY_INSTEAD_OF_MOVE cid#1557351 COPY_INSTEAD_OF_MOVE cid#1554863 COPY_INSTEAD_OF_MOVE cid#1556764 COPY_INSTEAD_OF_MOVE cid#1556279 COPY_INSTEAD_OF_MOVE cid#1555970 COPY_INSTEAD_OF_MOVE cid#1556942 COPY_INSTEAD_OF_MOVE cid#1557964 COPY_INSTEAD_OF_MOVE cid#1555166 COPY_INSTEAD_OF_MOVE cid#1556496 COPY_INSTEAD_OF_MOVE cid#1557175 COPY_INSTEAD_OF_MOVE cid#1558054 COPY_INSTEAD_OF_MOVE cid#1557392 COPY_INSTEAD_OF_MOVE cid#1557850 COPY_INSTEAD_OF_MOVE cid#1555118 COPY_INSTEAD_OF_MOVE cid#1557131 COPY_INSTEAD_OF_MOVE cid#1556614 COPY_INSTEAD_OF_MOVE cid#1609650 COPY_INSTEAD_OF_MOVE cid#1555114 COPY_INSTEAD_OF_MOVE cid#1555241 COPY_INSTEAD_OF_MOVE cid#1555442 COPY_INSTEAD_OF_MOVE cid#1556473 COPY_INSTEAD_OF_MOVE cid#1557654 COPY_INSTEAD_OF_MOVE cid#1554689 COPY_INSTEAD_OF_MOVE cid#1556316 COPY_INSTEAD_OF_MOVE cid#1557929 COPY_INSTEAD_OF_MOVE cid#1554807 COPY_INSTEAD_OF_MOVE cid#1554858 COPY_INSTEAD_OF_MOVE cid#1555103 COPY_INSTEAD_OF_MOVE cid#1555517 COPY_INSTEAD_OF_MOVE cid#1556424 COPY_INSTEAD_OF_MOVE cid#1557252 COPY_INSTEAD_OF_MOVE cid#1557566 COPY_INSTEAD_OF_MOVE cid#1608020 COPY_INSTEAD_OF_MOVE cid#1557742 COPY_INSTEAD_OF_MOVE cid#1555884 COPY_INSTEAD_OF_MOVE cid#1554809 COPY_INSTEAD_OF_MOVE cid#1555336 COPY_INSTEAD_OF_MOVE cid#1555173 COPY_INSTEAD_OF_MOVE cid#1556067 COPY_INSTEAD_OF_MOVE cid#1557040 COPY_INSTEAD_OF_MOVE cid#1556235 COPY_INSTEAD_OF_MOVE cid#1557366 COPY_INSTEAD_OF_MOVE cid#1555910 COPY_INSTEAD_OF_MOVE cid#1556716 COPY_INSTEAD_OF_MOVE cid#1558022 COPY_INSTEAD_OF_MOVE cid#1555769 COPY_INSTEAD_OF_MOVE cid#1555940 COPY_INSTEAD_OF_MOVE cid#1557077 COPY_INSTEAD_OF_MOVE cid#1555270 COPY_INSTEAD_OF_MOVE cid#1555660 COPY_INSTEAD_OF_MOVE cid#1556302 COPY_INSTEAD_OF_MOVE cid#1555678 COPY_INSTEAD_OF_MOVE cid#1556538 COPY_INSTEAD_OF_MOVE cid#1557689 COPY_INSTEAD_OF_MOVE cid#1555009 COPY_INSTEAD_OF_MOVE cid#1555433 COPY_INSTEAD_OF_MOVE cid#1555671 COPY_INSTEAD_OF_MOVE cid#1555255 COPY_INSTEAD_OF_MOVE cid#1557681 COPY_INSTEAD_OF_MOVE cid#1557512 COPY_INSTEAD_OF_MOVE cid#1554958 COPY_INSTEAD_OF_MOVE cid#1555758 COPY_INSTEAD_OF_MOVE cid#1555597 COPY_INSTEAD_OF_MOVE cid#1558040 COPY_INSTEAD_OF_MOVE cid#1556476 COPY_INSTEAD_OF_MOVE cid#1557646 COPY_INSTEAD_OF_MOVE cid#1557950 COPY_INSTEAD_OF_MOVE cid#1557019 COPY_INSTEAD_OF_MOVE cid#1557885 COPY_INSTEAD_OF_MOVE cid#1556402 COPY_INSTEAD_OF_MOVE cid#1557906 COPY_INSTEAD_OF_MOVE cid#1556619 COPY_INSTEAD_OF_MOVE cid#1554683 COPY_INSTEAD_OF_MOVE cid#1556549 COPY_INSTEAD_OF_MOVE cid#1554747 COPY_INSTEAD_OF_MOVE cid#1554929 COPY_INSTEAD_OF_MOVE cid#1555362 COPY_INSTEAD_OF_MOVE cid#1557053 COPY_INSTEAD_OF_MOVE cid#1557891 COPY_INSTEAD_OF_MOVE cid#1555043 COPY_INSTEAD_OF_MOVE cid#1555107 COPY_INSTEAD_OF_MOVE cid#1557203 COPY_INSTEAD_OF_MOVE cid#1556728 COPY_INSTEAD_OF_MOVE cid#1557773 COPY_INSTEAD_OF_MOVE cid#1556845 COPY_INSTEAD_OF_MOVE Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-06tdf#162753 - Hyperlink dialog: preset only syntactically valid hyperlinksAndreas Heinisch
Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-11-05Resolves tdf#163770 BASIC Macro dialog Assign should select the macroJim Raykowski
name in Function list box in the Customize dialog Keyboard tab In SfxAcceleratorConfigPage Reset, RadioHdl is called just before m_xGroupLBox->SelectMacro. In RadioHdl an idle timer is started whos handler gets fired after m_xGroupLBox->SelectMacro is called in Reset. This makes the selection made in the functions list box by m_xGroupLBox->SelectMacro in Reset get bonked by the call to m_xGroupLBox->GroupSelected in SelectHdl called from the idle timer handler. m_xGroupLBox->GroupSelected always selects the first function in the function list box. This patch fixes this selection bonk by calling SelectHdl directly from RadioHdl instead of calling SelectHdl from an idle timer handler. Change-Id: I15d26d4611948d61e0a258e9a350d8c952b2b211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176038 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-11-05tdf#137680 Add extended tips for Skia optionsOlivier Hallot
Change-Id: If525c808a1ad350c878cf8f80ee3289a0c6fcbb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175938 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-04cui: Fix a UI string in a11y check optionsMing Hua
Commit d14e79bf7680db2180e40ba52fc3305a84c586f6 (Correct grammar in strings for A11y, 2024-09-18) fixed many UI strings in the newly introduced a11y check options with correct English grammar, but mistakely changed this string from "heading order" (which means the chapter and section headings) to "table heading order". This commit reverts the change and slightly improved the wording. Change-Id: I2957004d6b82d35841f57a76ca25fbf9b851b9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-01no need to heap allocate theseNoel Grandin
Change-Id: I28127f5943a80aca1689d5982cd1f6e6e11eb2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-30tdf#130857 securityoptionsdialog.ui Define grid children in orderMichael Weghorn
Switch the order in which the children of the "grid3" grid in the .ui file are defined so that the order matches the visual appearance, which makes sure that tab focus order with the Qt-based VCL plugins is correct as well in the "Tools" -> "Options" -> "LibreOfficeDev" -> "Security" -> "Options..." dialog. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. Change-Id: Iffba59ba04ecfd3fcb900e09ad013e6f498beff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30win a11y: Drop "Enable AT Tool support" from options UIMichael Weghorn
Drop the "Support assistive technology tools (program restart required)" checkbox from the "Accessibility" options page. It was only shown on Windows. While having this in the UI seems to suggest that this is a setting that users explicitly toggle on and off, the setting is automatically switched on when an AT is active anyway, see `ImplHandleGetObject` in vcl/win/window/salframe.cxx. Therefore, only switching explicitly off after using an AT, but no longer planning to do so any more is the only case I can think of where changing this option via the UI might have been a use case. The plan is to rework the handling in an upcoming commit instead: to enable AT support when an AT is active, i.e. in `ImplHandleGetObject`, and not persist that setting any more across LO runs. Related change for the Windows registry: commit 77e1c0bfa2e643f017b829cd775d08c5a40d9b6b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 23 12:17:02 2024 +0100 win a11y: No longer read/write registry key Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175787 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 614, 624 Change-Id: I0171d19f151719bc6faf8909d14327b63b4ac2ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175354 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-29tdf#130857 cui: Move checkbox out of button boxMichael Weghorn
In the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer, move the "Do not show again" checkbox above the button box with the "No" and "Yes" buttons instead of having it inside of the button box. This aligns this with how it's done elsewhere, e.g. in the "LibreOfficeDev Help Not Installed" dialog (sfx2/uiconfig/ui/helpmanual.ui) that gets shown when pressing F1 without local help installed. It also prevents an issue with this case of a checkbox with quite some text inside a button box resulting in overlapping UI elements for the native Qt version of the dialog (once this gets enabled in QtInstanceBuilder::IsUIFileSupported). Change-Id: I005da330cca5a8d6ee468477472e0382c288b022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175791 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 aboutdialog.ui: Define grid children in orderMichael Weghorn
Reorder children of the top-level grid in the .ui file so that the order matches the visual appearance, which makes sure that tab focus order with the Qt-based VCL plugins is correct as well the "Help" -> "About LibreOffice(Dev)" dialog. dialog. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. Change-Id: I069fc7c290d2c98180345d350504068a2dc19d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175773 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-25cid#1633347 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1633346 COPY_INSTEAD_OF_MOVE cid#1633344 COPY_INSTEAD_OF_MOVE cid#1633343 COPY_INSTEAD_OF_MOVE cid#1633340 COPY_INSTEAD_OF_MOVE cid#1608137 COPY_INSTEAD_OF_MOVE cid#1608131 COPY_INSTEAD_OF_MOVE cid#1607860 COPY_INSTEAD_OF_MOVE cid#1607432 COPY_INSTEAD_OF_MOVE cid#1607394 COPY_INSTEAD_OF_MOVE cid#1607310 COPY_INSTEAD_OF_MOVE cid#1607156 COPY_INSTEAD_OF_MOVE cid#1607093 COPY_INSTEAD_OF_MOVE cid#1607090 COPY_INSTEAD_OF_MOVE cid#1607039 COPY_INSTEAD_OF_MOVE cid#1606709 COPY_INSTEAD_OF_MOVE cid#1558053 COPY_INSTEAD_OF_MOVE cid#1558052 COPY_INSTEAD_OF_MOVE cid#1558042 COPY_INSTEAD_OF_MOVE cid#1558038 COPY_INSTEAD_OF_MOVE cid#1558037 COPY_INSTEAD_OF_MOVE cid#1558034 COPY_INSTEAD_OF_MOVE cid#1558031 COPY_INSTEAD_OF_MOVE cid#1558027 COPY_INSTEAD_OF_MOVE cid#1557994 COPY_INSTEAD_OF_MOVE cid#1557977 COPY_INSTEAD_OF_MOVE cid#1557970 COPY_INSTEAD_OF_MOVE cid#1557966 COPY_INSTEAD_OF_MOVE cid#1557957 COPY_INSTEAD_OF_MOVE cid#1557954 COPY_INSTEAD_OF_MOVE cid#1557941 COPY_INSTEAD_OF_MOVE cid#1557933 COPY_INSTEAD_OF_MOVE cid#1557918 COPY_INSTEAD_OF_MOVE cid#1557907 COPY_INSTEAD_OF_MOVE cid#1557890 COPY_INSTEAD_OF_MOVE cid#1557883 COPY_INSTEAD_OF_MOVE cid#1557881 COPY_INSTEAD_OF_MOVE cid#1557861 COPY_INSTEAD_OF_MOVE cid#1557842 COPY_INSTEAD_OF_MOVE cid#1557840 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE Change-Id: If5ee3396eafdb8b338d9e6cf0705be6e2b431fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-25tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in orderMichael Weghorn
Switch the order that the widgets are defined in the .ui file to match their logical order (to be top to bottom, left to right) as also described by their "left-attach" and "top-attach" properties. This only rearranges the order without changing anything else for the single children and doesn't have any effect for the gtk3 and VCL implementations. But as described in more details in commit 0fe7b3cebc1a070b13b825635f4bd387a22e41ab Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 23 22:43:10 2024 +0200 tdf#130857 printersetupdialog.ui: Define focusable widgets in order , Qt uses the construction order of widgets to determine the tab order as well, meaning that focus would unexpectedly jump from the edit to the checkbox, then back to the combobox without this commit in place for the qt5 and qt6 VCL plugins in this dialog ("Tools" -> "Options" -> "Languages and Locales" -> "Writing Aids" -> "New") now that native Qt widgets are used. Change-Id: Ib09137cb11dab60c4a1af4fbc3b007e801dea33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175567 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-23tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 277, 297 Change-Id: Ie30c5da744cb29de5db4a2b1e0f4096daf8b6bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175425 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21vcl: move bitmap filter headers into vcl/bitmap global header directoryChris Sherlock
Use #pragma once instead of header guards Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-10-20FilterEntry is just an OUString, simplify this (cui)Julien Nabet
Change-Id: I189922791e5ef3db111aa95fb9dc5af4c757a9ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175257 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-18Relates tdf#162979 - Fix typoHeiko Tietze
Fixes patch 74e3f47723471f3ed4dc2dbffc95085bb04d9504 Change-Id: I3cd596f15c1d0ebc600b9b5f1bffa87b5225d0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175091 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-14cid#1554844 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554878 COPY_INSTEAD_OF_MOVE cid#1554907 COPY_INSTEAD_OF_MOVE cid#1555082 COPY_INSTEAD_OF_MOVE cid#1555224 COPY_INSTEAD_OF_MOVE cid#1555301 COPY_INSTEAD_OF_MOVE cid#1555378 COPY_INSTEAD_OF_MOVE cid#1555395 COPY_INSTEAD_OF_MOVE cid#1555452 COPY_INSTEAD_OF_MOVE cid#1555466 COPY_INSTEAD_OF_MOVE cid#1555514 COPY_INSTEAD_OF_MOVE cid#1555566 COPY_INSTEAD_OF_MOVE cid#1555753 COPY_INSTEAD_OF_MOVE cid#1555782 COPY_INSTEAD_OF_MOVE cid#1555825 COPY_INSTEAD_OF_MOVE cid#1555842 COPY_INSTEAD_OF_MOVE cid#1555891 COPY_INSTEAD_OF_MOVE cid#1555917 COPY_INSTEAD_OF_MOVE cid#1555961 COPY_INSTEAD_OF_MOVE cid#1556021 COPY_INSTEAD_OF_MOVE cid#1556055 COPY_INSTEAD_OF_MOVE cid#1556307 COPY_INSTEAD_OF_MOVE cid#1556349 COPY_INSTEAD_OF_MOVE cid#1556436 COPY_INSTEAD_OF_MOVE cid#1556665 COPY_INSTEAD_OF_MOVE cid#1556696 COPY_INSTEAD_OF_MOVE cid#1556718 COPY_INSTEAD_OF_MOVE cid#1556775 COPY_INSTEAD_OF_MOVE cid#1556835 COPY_INSTEAD_OF_MOVE cid#1556877 COPY_INSTEAD_OF_MOVE cid#1556994 COPY_INSTEAD_OF_MOVE cid#1557010 COPY_INSTEAD_OF_MOVE cid#1557074 COPY_INSTEAD_OF_MOVE cid#1557111 COPY_INSTEAD_OF_MOVE cid#1557142 COPY_INSTEAD_OF_MOVE cid#1557163 COPY_INSTEAD_OF_MOVE cid#1557164 COPY_INSTEAD_OF_MOVE cid#1557214 COPY_INSTEAD_OF_MOVE cid#1557254 COPY_INSTEAD_OF_MOVE cid#1557322 COPY_INSTEAD_OF_MOVE cid#1557327 COPY_INSTEAD_OF_MOVE cid#1557492 COPY_INSTEAD_OF_MOVE cid#1557565 COPY_INSTEAD_OF_MOVE cid#1557663 COPY_INSTEAD_OF_MOVE cid#1557798 COPY_INSTEAD_OF_MOVE Change-Id: I2ae9c184dcc18d44a65437e18c49e16b27f4d81d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08cid#1632259 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1632258 COPY_INSTEAD_OF_MOVE cid#1632257 COPY_INSTEAD_OF_MOVE cid#1632256 COPY_INSTEAD_OF_MOVE cid#1632255 COPY_INSTEAD_OF_MOVE cid#1632254 COPY_INSTEAD_OF_MOVE cid#1632253 COPY_INSTEAD_OF_MOVE cid#1632252 COPY_INSTEAD_OF_MOVE cid#1632251 COPY_INSTEAD_OF_MOVE cid#1632250 COPY_INSTEAD_OF_MOVE cid#1632249 COPY_INSTEAD_OF_MOVE cid#1632248 COPY_INSTEAD_OF_MOVE cid#1632247 COPY_INSTEAD_OF_MOVE cid#1632246 COPY_INSTEAD_OF_MOVE cid#1632245 COPY_INSTEAD_OF_MOVE cid#1632244 COPY_INSTEAD_OF_MOVE cid#1632243 COPY_INSTEAD_OF_MOVE cid#1632242 COPY_INSTEAD_OF_MOVE cid#1632241 COPY_INSTEAD_OF_MOVE cid#1632240 COPY_INSTEAD_OF_MOVE cid#1632239 COPY_INSTEAD_OF_MOVE cid#1632238 COPY_INSTEAD_OF_MOVE cid#1632237 COPY_INSTEAD_OF_MOVE cid#1632236 COPY_INSTEAD_OF_MOVE cid#1632235 COPY_INSTEAD_OF_MOVE cid#1632234 COPY_INSTEAD_OF_MOVE cid#1632233 COPY_INSTEAD_OF_MOVE cid#1632232 COPY_INSTEAD_OF_MOVE cid#1632231 COPY_INSTEAD_OF_MOVE cid#1558073 COPY_INSTEAD_OF_MOVE cid#1557945 COPY_INSTEAD_OF_MOVE cid#1557916 COPY_INSTEAD_OF_MOVE cid#1557898 COPY_INSTEAD_OF_MOVE cid#1557808 COPY_INSTEAD_OF_MOVE Change-Id: Ibf417c154255fe3b0598127df5b5805ed543c8d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174660 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-07a11y: Leave accessible description text view on simple tab keyMichael Weghorn
Set the "accepts-tab" property to false for the GtkTextView where an accessible description can be set, so pressing the tab key moves focus to the next field in the dialog, instead of inserting a literal tab character. This simplifies using the dialog when using the keyboard only. For the VCL and GTK implementations, pressing Ctrl+Tab would previously be needed to move focus, which is less intuitive. Setting the property does not technically prevent inserting tabs, they could still be inserted by copy-pasting text containing tabs; just pressing the tab key while the text view has focus won't insert them any more. (I can't think of any reason to use actual tab characters in the accessible description, however.) Do this for the .ui files used for the following 2 scenarios: * select QR code object in Writer, open context menu, select "Alt Text" context menu entry * select an image in Writer, open context menu, select "Options" context menu entry, go to the "Options" tab page Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-05tdf#119931: cui a11y: Specify mnenomic-widget in "Alt Text" dialogMichael Weghorn
Specify that the mnemonic widget for the "Alt Text" label is the text view where the description can be entered. This e.g. ensures that the a11y labelled-by label-for relations get reported. Drop the corresponding suppression for gla11y. When using the Orca screen reader with the gtk3 VCL plugin, Orca now announces "Alt Text" when the text view gets focus, while that was not the case before. Dialog can be triggered by e.g. selecting a QR code in Writer, then opening the context menu and choosing the "Alt Text" menu entry. Change-Id: I5c8b06198a45cfbe5e1fc4a85ac568094b596819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174506 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-01-10 06:28:33 +0000