summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-12-19tdf#145538 Use range based for loopsLeonid Ryzhov
Change-Id: I6d04185f14c3ec72b40426bd881cac80528cc736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143244 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-12-19tdf#152295 sw sd UI: don't reset tiled image size by Area tabTibor Nagy
The background tiling images become larger when opening and closing Area tab: reopening the image properties in the Area tab shows that the Width and Height got reset to the original values of the image. Regression from commit 686349476e03f951f4a9ff9755b9f71951b64ea5 "[GSoC] Move all fill style tabs inside area tab". Change-Id: Ibc4dfd73dedd81b1b7fe17574198dd4999aab967 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143819 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-16check SfxObjectShell::Current()Caolán McNamara
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16misc: check SfxViewFrame::Current()Caolán McNamara
these ones look potentially worth backporting Change-Id: Ie01c0b598c3408f4766318267de8438e997dd1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144278 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16misc: check SfxViewFrame::Current()Caolán McNamara
SfxViewFrame::Current() is a festering wound, these ones look like they were safe anyway, so no need to backport. But with enough checked static analysis will kick in to flag new unchecked ones. Change-Id: I2925c4fa4e2d48c1e676ffe7951e65120192517e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-14Add precisions in extended tipOlivier Hallot
Change-Id: Ic339db77ba4064f7a4cf7533740e7a0f98955453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143922 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-12resave with latest gladeCaolán McNamara
Change-Id: I612ebb175344db3fe233d3e35a9cf6d98883f585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-12Resolves: tdf#139749 set initial focus to comboboxCaolán McNamara
Change-Id: Ib8fd0dd4a4b5d4c137794c4538e61bfbf33b9a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144006 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10Related: tdf#152266 open 'event' page by default for SID_CONFIGEVENTCaolán McNamara
Change-Id: I7a3f6def8bda00588ef2846e5d3b5ed5d1da04de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10switch to the 'keyboard' tab if a SID_MACROINFO is setCaolán McNamara
Change-Id: Ie615ab2598309b0324daa11732e5345d1a927437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Related: tdf#146395 drop default textCaolán McNamara
Change-Id: Iaeedf11df5f1d5739ec247222cc4fc1f10abe1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Related: tdf#152266 add a remove all buttonCaolán McNamara
Change-Id: Ibf6b749089d2d6da71a9ce00779bce8886453856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09resave with latest gladeCaolán McNamara
Change-Id: Ia9dc0446c2dc69c0e04d67b0d4da30319807a6cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143852 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Related: tdf#152266 give feedback which events are assignedCaolán McNamara
where assigned is means an event is assigned to a non-empty url, now the delete button is only enabled when there is something to delete, bringing the customizie event page into line with the sheet event page and the writer frame event assignment page Change-Id: I7e016bf578dff24b7d47312fd5f7cc63883d1e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09drop unnecessary pThis indirectionCaolán McNamara
Change-Id: I28c338a4f09036c9365937af99cb85fd4be95901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09svx: fix unmaintainable TypeConstant definitionMichael Stahl
Add one new token and every test in CppunitTest_sd_import_tests-smartart fails. Change-Id: I0d79a5000fc2ef9b699ffca3d75199e9479cf561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143834 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-09make Notebookbar customize page match indent with the othersCaolán McNamara
remove intermediate grids with just one child, name the containers of the groups of widgets to be hidden and hide the container rather than the individual members so the container space doesn't push this page out of alignment with the others. Change-Id: Ie3fb291da49a6b43ca4516e5fe55b828543631e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09resave with latest gladeCaolán McNamara
Change-Id: I548fac08a9b4d62d6e71bf5fa687d5c1ff2e11b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-08tdf#114441 - Convert use of sal_uLong to better integer typesNalini Prasad Dash
The variable type of nHeight was changed as the return type of pFontHeightItem->GetHeight() is sal_uInt32.Also nBit was assigned the underlying datatype of LB(int) as it was checked against LB::LAST(Value converted to underlying datatype of LB) in the for loop . Change-Id: I657d545ac7af1786edd61569ba43b42e55d1f47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143145 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-08update assign/delete state after positioning cursor in treeviewCaolán McNamara
Change-Id: I9fe2d9d4a3575e0b67c8421d215f65f46c2ac1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-08resave with latest gladeCaolán McNamara
Change-Id: I089e6c872b52ef530d0e6279fa8fd10576ccc6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143831 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-08Resolves: tdf#146395 allow newlines in QR CodesCaolán McNamara
Change-Id: Ib390d97866ab013770e4f1cbdfb529296d64c140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143811 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-07Resolves: tdf#152301 allow using an existing ColorListBox to speed initCaolán McNamara
Change-Id: I31fb350fd69831e68ca7c60ec758126aab086895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-07Related: tdf#152301 cache color widget widthCaolán McNamara
Change-Id: I0030980e2259715aa1fa624eb0ee82d5dfc51810 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143778 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-07Related: tdf#152301 fix gtk warningsCaolán McNamara
Change-Id: I5d9354d1cf53be68a63a53b21f75cb5070df406c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143775 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-05Improve the layout of font features dialogKhaled Hosny
Make sure all sections have the same column alignments. Change-Id: I25bdc0ecf8f971f23d188999167df33476bea1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143662 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-05Mark ssXX and cvXX off by default in font features dialogKhaled Hosny
We know they are off by default. Change-Id: I77c8ecb0d65d46ec77ccc2570ecf5c05e6e577e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143660 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04it is not possible to install color palette extensions in Online or mobile appsAndras Timar
Change-Id: Ibb2e9bfcf4b8e8681f96e6863fd900181c278adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143309 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d3f3be20599e66d4d6eacc0fa73b5ab3fa6c2dee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143581 Tested-by: Jenkins
2022-12-04Use better variable namesKhaled Hosny
Change-Id: I99462a1f598affca1fe69908d3091af5fa219829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143618 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04Add and use Feature::isCharacterVariant/isStylisticSetKhaled Hosny
Change-Id: Ifd772da1f4b81aa08440025a5c960fb226281194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143613 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04Seperate Stylistic Sets and Character Variants in Font Features DialogKhaled Hosny
Makes clear what these features are when we use feature names provided by the font. Change-Id: I98a7294d3e1e7fef5293d0444c0fbbfcc131ed44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143611 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-03Save with newer gladeKhaled Hosny
Change-Id: I23ba9ed200c1336f35f470e2709b153daa0b0aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143610 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-11-28DeepL: Only enable Translate menu if it's set upAron Budea
Both the API URL and Authentication key have to be set. Plus: - align widgets in DeepL settings dialog, - rename .ui file to conform to other dialog names in Options. Change-Id: I8cfeaa64b05747b0113a6075b6fd241ca9ab3a70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143359 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-27cid#1517060 Unchecked return valueCaolán McNamara
Change-Id: Ic11f632270c65d5c4446771336e39999bc509617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-26Related tdf#145978 Fix workaround in kf5Rafael Lima
In commit 792e41314f321f54b3b2fc4d01c8b62a3b704e9e (about saving the last used macro) I used a workaround to make scroll_to_row work in kf5. However, this workaround based on hide() / show() calls was causing an error: qt.qpa.xcb: internal error: void QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window. As pointed out by Jim in the original patch, using resize_to_request has the same effect and does not cause the aforementioned error. Change-Id: Ie61e8529fccfdae88d56f223573eb0fd6a82b8b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143261 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-11-26tdf#152115 related: Make selected entry stay selected (gtk3 only)Jim Raykowski
For unknown reason the selected entry loses selection here only for gtk3. Swapping the order of the select and scroll_to_row functions makes the selection remain selected for gtk3. This patch replaces the select and scroll_to_row functions with the set_cursor function which makes the focused entry selected and shown in the visible range as expected for gtk3 as well as x11 and qt5. Change-Id: If003afa73851573e61704cc847d7152db90a0d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143207 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-11-23loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-22tdf#145978 Remember last run macro in Macro Selector dialogRafael Lima
This patch saves the last run macro using the Macro Selector dialog (via Tools - Macros - Run Macro). Change-Id: I9da9262daffec402fc5f76691473263f9319664e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142632 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-11-22loplugin:unusedfields update the post-process scriptNoel Grandin
(*) ignore temporary fields in lambdas (*) don't ignore the vcl/weld stuff anymore Change-Id: I4cda18f779588409891a2b2f8b1371e60f9b9ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-22loplugin:unusedfieldsNoel Grandin
Change-Id: I4487f1b3bb051e1eb48226eb52a6706b22493fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-21Drop comphelper::OWeakTypeObject, use cppu::WeakImplHelper<> insteadStephan Bergmann
Change-Id: Ie4152d7736ae3f2ffdd3489cd7a444e5035d2422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143030 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-21lok: allow password reset in properties>change passwordSzymon Kłos
Change-Id: I92a3c658e96f602549ff5282b6ed5bc9ee780bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141372 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142992 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-21lok: make properties>change password dialog asyncMert Tumer
* We now can set a password through properties->change password without having to have a password initially only for online because it needs a created file already, online works with files that are created before loading but the desktop does not need this. * The same dialog is still used as non-async for desktop version because it goes through an InteractionHandler and the result is expected not from the dialog but from the interaction handler. Therefore, making it async there did not make sense. Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I3d02822be0b71836b1592abca191b3b1c5f6374e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139884 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142991 Tested-by: Jenkins
2022-11-20Add a title to the widget test dialogSkyler Grey
- Previously the widget test dialog didn't have a title, however most of the other dialogs do. This commit adds a title to the dialog Signed-off-by: Skyler Grey <skyler3665@gmail.com> Change-Id: I8b61e00e93cd71a6a7bf068537d9cbcdc735753d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137534 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142975 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-11-20jsdialogs: added WidgetTestDialog to test different vcl widgets in online siderash419
Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I27cbb72b4ccd486b58934503b1d3d5d7ff47cbfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132865 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142970 Tested-by: Jenkins
2022-11-19Prepare the dialog for cell style editingMaxim Monastirsky
Change-Id: I54ec1486f49f240e1ab88662b9d1b0b741cf8878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142905 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-11-17tdf#151904 Make grammar mistake color configurableRafael Lima
This patch creates a new color entry in Tools - Options - Application Colors for "Grammar mistakes". Default values are also set for the "LibreOffice" and "LibreOffice dark" schemes. This patch also applies the selected color to the document, as well as in the SpellChecker dialog. Change-Id: I07f79da9858b675b330540cf08cf389dce39228d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142294 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-11-10tdf#107405 Allow kerning less than -2Samuel Mehrbrodt
Fallout from 9a745d54a5c7470180f41494283983a3b8b84a51 Change-Id: Ied4d83eb614830718cf304e7010f17516e4a9429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142388 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-11-09tdf#150494 LanguageTool: Add placeholder text with default value infoRafael Lima
With this patch, the Language Tool dialog works as follows: - The first time the tool is enabled, a default URL is entered as text - If the URL is left empty, a placeholder text is shown saying that leaving this entry empty will cause the default URL to be used - If another URL is defined by the user, than this is the one used Change-Id: Id31fca0e44091aff3c77a9be8b639a20437b1b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142197 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-11-08tdf#131688 Improve one tip of the dayBogdan B
Change-Id: I5f8796bd1cae65a2259a9695321f94cd24188eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142301 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-29 18:34:15 +0000