Age | Commit message (Collapse) | Author |
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
This patch fixes unsaveable booleans. Also fix the problem occurs when there is
multiple changes on page. Page was commiting only last added one, now
commits all.
Change-Id: Id1a15634e95d5ca9d54e7a90fa1bbbaf874e3f08
Reviewed-on: https://gerrit.libreoffice.org/6457
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0a9f69b8c2129329f742f18e7749484b6f3e5bf7
|
|
lineend and color
(cherry picked from commit 03fa6020a862b1b6faf69f33274022cb871e8f4b)
Conflicts:
cui/source/tabpages/tpbitmap.cxx
cui/source/tabpages/tpcolor.cxx
cui/source/tabpages/tplneend.cxx
Change-Id: Ib99e8f0a59fb611972133bab1e864d59d019457b
|
|
So there is no need to do this locally, too.
Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
|
|
Change-Id: I67a5457fa2f39b1d6ab0a635d9bdf78ffa90caea
|
|
Change-Id: I68110e2ff632d0446c127e428623fecb62aa14c5
|
|
Galaxy is our 'underlying' icon theme we use in LibreOffice. If an user
choose to have another theme, Galaxy icons will be overlapped by
that other theme. So in general the 'default' template _is_ galaxy, but
not for the end user. Different OS have different default theme and
are marked with '<themename>(automatic)'. To avoid misunderstandings
I delete the term 'default'.
Change-Id: If6a1ac781cb68eeb690edf1408c7ce4c62f2ec8e
Reviewed-on: https://gerrit.libreoffice.org/6321
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Convert places that call
aStr[aStr.getLength()-1] == 'x'
to use the shorter form
aStr.endsWith("x")
Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
hammer silver nails into coffin and bury in concrete
Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
|
|
Change-Id: Iec7a797581ab899e93ad6cebb06c3622ca2360b9
|
|
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f
Reviewed-on: https://gerrit.libreoffice.org/6364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I9747817edc76973af4a4ffdbf542b8d1467d7f08
|
|
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
|
|
This commit removes copy and paste code, creating a constructor for it
Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc
Reviewed-on: https://gerrit.libreoffice.org/6356
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I635235896853693dd7687e0b72ccb3caf4febb89
|
|
We have no online/offline concept for the office anymore.
Change-Id: Id7e71d9c4383b47d3fae6f8cb5dc18ec22a55934
|
|
Also label it with "Ok" which reflects the new behavior better.
Change-Id: If8adde315c2d822e3210a0dcae7055519e5e558d
|
|
Despite it's name, rProperties, the Sequence is not a reference in the
function signature.
Besides, some small improvements:
- instead of compareToAscii, use operator==, which is optimized for
performance
(cherry picked from commit a17e221225915c140c7840904cb9b46d75731edc)
Conflicts:
cui/source/options/optsave.cxx
Change-Id: Ifffd2b9014210c885f03ff8116ea97625b903cba
|
|
The point of this menu option is that locked Smart-Art shapes would
preserve the original XML files attached so they could be exported
back to docx with no loss.
The new menu option is located at Options -> Load/Save -> MS Office ->
SmartArt to LibreOffice shapes or reverse.
Change-Id: I6aafc2eb83404ee2c0b8538b2f6fbbbd4363e7d3
Reviewed-on: https://gerrit.libreoffice.org/6138
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
An extra InsertEntry method is added with parameters to enable or disable the
load and save checkboxes independently.
Change-Id: I49233ce31e2eaf361310f89887dcede86dec0edc
Reviewed-on: https://gerrit.libreoffice.org/6137
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Remove leading and trailing whitespaces in the hyperlink dialog, because
the resulting links would be unusable.
Change-Id: Icf617daf51508a37494536e02fb298fb3cf746c5
|
|
Change-Id: I766c01c3ea4c03f4c76ef70fd16037d8196242a1
|
|
Change-Id: I475bee35ca5d24903d85e7f2427fab0e47d8db4d
|
|
Change-Id: Ie30e4d67435808fd6c31e1ca7f10a58faad1c6ce
|
|
Change-Id: Ie599ddddca533db3a626ab63a9d47e10d76a4a94
|
|
Change-Id: Ife34807a447aae474f1df29ce22f50b9e9d9cacf
|
|
Change-Id: I27a6622f45ec3fdbb9153e1dcb1114c5dc71e884
|
|
Change-Id: I2894b7ffc186836890ab7b8117e2c7ca43bd21be
Reviewed-on: https://gerrit.libreoffice.org/6087
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I15c34278a3dca19547c77be7aca670fbbc2d2037
|
|
Change-Id: Ia73c38866b50e6986361909aa64f7a95c2ce8635
|
|
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
|
|
Change-Id: I72e497fb97edf8782c69000576f42896594e1556
|
|
This is the command that adds a Separator to the toolbar or menu
Change-Id: I38bb449b6f34b6fc80bbbe6c0161d3346f785888
Reviewed-on: https://gerrit.libreoffice.org/6088
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
|
|
Change-Id: I9a49699d0739afc754caa5012da1525aa7e5fc26
|
|
Change-Id: Ie3e9cb1e30af597e9086d5713b743fc416e19ade
|
|
(avoids warnings about std::auto_ptr ctor being deprecated)
Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
|
|
Change-Id: I5269abf769839f525d949b90e827f1322e44f2dd
|
|
Change-Id: I566f106bb5ea0836535b1fe1b42811fc5be3268e
|
|
Change-Id: Ib37eb4a2795840bff5b501ba468473f02100aaa2
|
|
Change-Id: I1aee738a0ecd761efaecf4b1b1c53918d8f9cf01
Reviewed-on: https://gerrit.libreoffice.org/6044
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8374a78268a48377c6c00c710a4fa28aa26c2fe6
|
|
Change-Id: I70f1592ac26428611c2d8f6fc0090f97b9cd0025
|
|
Change-Id: I067e1ddcf2c46ac55ed2c5b92db8edb19dc6a0f1
|
|
Change-Id: I79bdab414d448a0d619b80857d7b31633c116f81
|
|
Change-Id: I66fd6387c3fcd33c6ae0b431810abf6679345767
|
|
so that any window derived class, and not just dialogs, can trigger layouting
of their children. Merge together the handful of hacked-up impls of this.
Do that then for the sidebar PanelLayout so that when the label of the custom
animation frame changes that the frame allocates enough space for the new label
to display fully
Change-Id: I9a95f6c3f60cd6cea47656e66cb9ffcc154a3a5a
|
|
Conflicts:
sd/UIConfig_sdraw.mk
Change-Id: I5625420bb374c03da0095065444787d082df8038
Reviewed-on: https://gerrit.libreoffice.org/6066
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|