summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2023-04-03Hyphenate this compound adjectiveAdolfo Jayme Barrientos
Change-Id: I7e19c90fd0106f59398205579d7b5d60cbf4a07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149945 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#153806 a11y: Insert special char + close dialog on return keyMichael Weghorn
As discussed in tdf#153806, insert the currently selected character from the special characters dialog and close the dialog when the return key is pressed on the table of characters (either showing all characters or just the search result). Something similar should probably be done when the return key is pressed with one of the recent characters or favorite characters in the dialog having focus, but that needs to be handled separately, possibly along with the other remaining suggestions to improve keyboard handling in the special characters dialog as discussed in tdf#153806. Change-Id: Iccc19e4808ddf6f15c32710f9bea931e46b046bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149920 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03tdf#153806 cui: Deduplicate code for special char dialog handlersMichael Weghorn
Various handlers for `m_xShowSet` and `m_xSearchSet` are the same, except that they operate on the different objects. However, since a pointer to the `SvxShowCharSet`/`SvxSearchCharSet` is passed as an argument to the handler, use that and reuse the existing handlers instead of duplicating them. Also extract a `SvxCharacterMap::insertSelectedCharacter` method from the `CharDoubleClickHdl`, since that will be reused elsewhere in a follow-up commit for tdf#153806. Change-Id: I14e8e7fd7add33f86fa0246c65927ceb88bb7899 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149919 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03jsdialog: keep button under content in SpellCheck OptionsSzymon Kłos
Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149825 Tested-by: Jenkins
2023-04-03jsdialog: enable spelling options dialogSzymon Kłos
and make it async Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824 Tested-by: Jenkins
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-01gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failedCaolán McNamara
Change-Id: Ia8070c3c8102bc6bfb72531be450abd9fe47a1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29Resolves tdf#152184 - Application color should follow system colorHeiko Tietze
This patch reverts the previously added "LibreOffice Dark" application color set and adds it to the automatic colors. Switching between light and dark changes the Automatic color accordingly instead switching to another color scheme. The added System Theme option makes Light/Dark follow the actual OS appearance. Reverts 6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06 (Introduce dark color set), 546ad5d17d3e363b75337c336cfb2b2f8acc55e3 (color scheme translatable), 9f0cf00d29298ed55737928ec4dddc50ac850cd8 (Update view options string based on theme) Change-Id: Ibf491f2e510fac5f1d27a7166560c4ec281d98d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149059 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-29tdf#154115 use correct column for searchCaolán McNamara
Change-Id: Iaa390e63d269221b7273fe15362cfbdf20f235da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-28Simplify OfaTreeOptionsDialog ctors by delegationMike Kaganski
Change-Id: Iea1487bde1c5a15934c5678a53648f3597df5cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149643 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-28resave with latest gladeCaolán McNamara
Change-Id: Ib75edfa79a2beffcb1d5b4222901a7f2fd61d44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-25tdf#154294 Fix customize notebook bar regressionJim Raykowski
caused by commit e79741488cc740f49ebd4426c40b45e7139ff663 Change-Id: I04fe66124af831c73834b7f695458e1667198ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-03-24add 6px to Skia children optionsSeth Chaiklin
Change-Id: Ic7d3a63516aae263aaffec9fba9d9673469bede4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149445 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-24loplugin:stringadd in c*Noel Grandin
after my patch to merge the bufferadd loplugin into stringadd Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23tdf#135769 a11y: Set a11y name and tooltip for buttons in hyphenation dialogMichael Weghorn
Set accessible name and tooltip "Left" and "Right" for the left and right arrow buttons, as suggested in tdf#135769 comment 6. Change-Id: I233d7f9028b2336130475ce50a4161df0629a835 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149355 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-23Resave cui/uiconfig/ui/hyphenate.ui with glade 3.40.0Michael Weghorn
.. before doing any changes for tdf#135769 Change-Id: If9ae28a979c4d4c12120711b90a9361b2e90b6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149421 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-22tdf#153808 Fix numbering preview in dark modeRafael Lima
This patch fixes the color used for numbers and bullets in the preview of the Bullets and Numbering dialog in Impress. Currently the implementation causes the bullets and numbers to be rendered in white over a white background when using dark mode. The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of FieldColor and FieldTextColor. Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-21cid#1524485 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I3a4dfb0e35db481c94a1f5cb56f078cc9e060a73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-20tdf#147469 remove mouse "Positioning" from options pageCaolán McNamara
Change-Id: I929c62189e3e31358fe95c804457fcbcba85e4b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-20tdf#154071 UI rename gradient back to 'Rectangular'...Regina Henschel
Commit e97e62a4707e09739f9c00f8fc4a943f0123a9cf had wrongly changed 'Rectangular' to 'Square' (API RECT, ODF rectangle) and 'Square' to 'Quadratic' (API SQUARE, ODF square). This patch reverts 'Square' to 'Rectangular' and 'Quadratic' to 'Square (Quadratic)'. It uses 'Square (Quadratic)' instead of simple 'Square' to help users to find the correct type. In addition, use of the wrong type names in comments is fixed. Change-Id: Ibbd90be2cceb65c9857e473cb74c39df1b9530f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149004 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-03-20tdf#152898 remove "show context menu shortcuts" from options pageCaolán McNamara
Change-Id: I44acae51ca72ece735f264e826f8d254e85be8f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-19MCGR: Model data changes for ColorStepsArmin Le Grand (allotropia)
Added tooling replaceStart/EndColor to allow simple transition for code that does not immediately adapt to multi color gradients. Also added createColorStepsFromStartEndColor for the same purpose. Adapted XGradient to no longer have Start/EndColor at all, but only use ColorSteps. Adapted all usages of XGradient to no longer use Get/Set/Start/EndColor, but access the ColorSteps instead. Replaced quite some XGradient constructors that used XGradient() as Start/EndColor since this is already the default. Adapted ColorBlending to black AKA Start/EndIntens in XGradient to work now on all ColorSteps in the required linearly-scaled manner. UNO API changes: Added com::sun::star::awt::ColorStep as basic data element that holds a pair of Offset and Color. Added com::sun::star::awt::ColorStepSequence to handle an array of sorted entries. Added com::sun::star::awt::Gradient2 derived from com::sun::star::awt::Gradient, extended by the needed com::sun::star::awt::ColorStepSequence. Added MID_GRADIENT_COLORSTEPSEQUENCE to UNO API to provide access to ColorSteps directly. Adapted XFillGradientItem::QueryValue/PutValue to make use of new UNO API data structures. To do so, added tooling methods for data transition: - fillColorStepSequenceFromColorSteps - fillGradient2FromXGradient - fillColorStepsFromAny - fillXGradientFromAny and adapted - case '0' (all data) - MID_FILLGRADIENT - MID_GRADIENT_COLORSTEPSEQUENCE - MID_GRADIENT_START/ENDCOLOR to make use of these. Tested usage of these in the office. Renamed from GradientStep to GradientStop after discussions with members on the list to make this closer related to other norms/definitions. Also renamed classes and class members to better reflect to GradientStop, so grepping/finding will be easier (e.g. 'Color' just exists pretty often, but 'StopColor' is more precise). Changed the used UNO API class for reprsenting the Color to better reflect to ranges [0.0 .. 1.0] and usage of RGB. Change-Id: I1eeb3e97e81d6785967615d1ff256551fc3b882d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148849 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-15Use officecfg instead of SvxDeeplOptionsNoel Grandin
Change-Id: I977d9be45fa17b960cccb0915c5f2762bf11288f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-15Use officecfg instead of SvtTabAppearanceCfgNoel Grandin
but we need to keep a small chunk of logic which is used by two different classes Change-Id: I57390144eae2ecdb49b5b2ca3f4ce1fbc3d69420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14Related tdf#129547 and tdf#154136: add COLON keyJulien Nabet
Change-Id: I17978dbb100fbfa6f6ddbbbdf96872076bc2a289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86713 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-11Fix typoAndrea Gelmini
Change-Id: Iaee1ae3085caa5a416f2129e218658c4ad8e531b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148647 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-10Use officecfg instead of SvxChartOptionsNoel Grandin
Change-Id: Ie7fddd86baa029890cd6874fdfae186098d00407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-10Resolves: tdf#154087 update scrollbar range when search criteria changeCaolán McNamara
Change-Id: Iaf5f20c8952b15f3dcccb65277dadb171a705605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-10Use officecfg instead of MailMergeCfg_ImplNoel Grandin
Change-Id: I134bf9a0afc31e50629856416e0b52a7113f1e2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-09Use officecfg instead of SvxLanguageToolOptionsMike Kaganski
Change-Id: Ia9add4ff3ebe20ba491e33de1e9a2644a48ef7a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-09Resolves tdf#131177 - Replace Hard-Coded TotD bulb by themeable iconHeiko Tietze
Change-Id: I25006f64436a72f554450929b1b649478b02cbc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148536 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-09tdf#114441 Convert sal_uLong to better integer typesArvind K
This patch replaces sal_uLong usages in cui directory. changed m_nOldCount in cui/source/inc/dbregister.hxx to size_t. m_nOldCount has been used in dbregister.cxx where it is initially assigned a value 0, later on it has been assigned the value returned by registration.size() which returns type size_t. Line 272 in cuigaldlg.cxx mrTakenList with type TokenList_impl is pushed back with variable nPos of type sal_Int32 hence changed TokenList_impl to store sal_Int32 types. Change-Id: Ie0ba284dc4592cc69a1ded2fe232d18aaec3c92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148237 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I86611e14a32dda3ae2226bbfa775ad0234513888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-06The quotation marks aren’t needed hereAdolfo Jayme Barrientos
Change-Id: Id89b5e161d1d02da66138b16bc8ea34417c554c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148365 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-06remove unused BaseMutex from ColorPickerNoel Grandin
Change-Id: Ife43fad692d2c5651ae75fc675345ae3dd64aecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-03flatten SvxForbiddenChars_Impl and associated mapNoel Grandin
std::map is a node-based datastructure, and ForbiddenCharacters only contains two ref-counted string data types. No need for all this indirection. Change-Id: Ib4fa49e60557c7e5c41bb73ebeb23c4db6d33406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148179 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27Optional may be avoided here, tooMike Kaganski
Change-Id: I6320f8b745ead030cb7ae304bdf85e0064a57380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147751 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-27Use SAL_NEWLINE_STRING to avoid some wheel re-inventionMike Kaganski
Change-Id: Ib60ddf2b1111fb2d6caf22ac6e0848bd27373b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147750 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-27no need to hold CollatorWrapper by std::unique_ptrNoel Grandin
allocate it inline, it is only one pointer in size Change-Id: Idb6217e6c9c37da92427aa6c497223a84015c553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-26Revert "Mark ssXX and cvXX off by default in font features dialog"خالد حسني
This reverts commit 3f9a8a3b7656470cfcf04c18a46a7b7bbeca8950. Reason for revert: Needs more work, currently causes all ssXX and cvXX to be added to font string when the dialog is used. Change-Id: I07eff710a2813e60fa4de3c23eb0a3c31d40e41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147810 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-02-26Cleanup general options tab a bitMike Kaganski
The crashreporter feature (and thus, the whole frame visibility) depends not on OS, but on the HAVE_FEATURE_BREAKPAD define. No need to control the checkbox visibility separate from the label, when we can show the whole frame selectively. The quickstarter feature is only available on Windows, since the systray support was removed in commit 3e9c908b73f0fe0978c9980750a06bbc9e02295e (remove Linux ("UNX") systray "Quickstarter", 2018-05-23). Change-Id: Id990b53a6bbfa6b42defec0cc196e7fe817a1924 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-26Missing ":" for "Background color" option in Area/HatchJulien Nabet
Change-Id: I021c983337500adb0dce348e8b7e3f42a2316e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147736 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-26Hide Quickstarter from General options in Windows store appsMike Kaganski
In that environment, the shell:Startup shortcut created by us points to the quickstart.exe under Program Files\WindowsApps\<StoreSpecificAppDir>\program. The resulting shortcut can't launch, because of an inaccessible part in the path (the protected WindowsApps directory). So the feature does not work in the dialog. Windows store apps should advertise the Windows startup task in the manifest. Let's just hide the dialog entry in this case. A possible TODO would be to provide a button instead, which would open the Startup Apps system applet, similar to what we do for Default apps for file associations. Change-Id: Ieafdf6d23ced96506b01c6b3cf9fb12904696df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147735 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-24tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatCollMichael Stahl
Leave editengine and non-paragraph usages of SvxLRSpaceItem as-is for now. Add new items RES_MARGIN_LEFT etc., order them so that paragraphs can have 3 consecutive items RES_MARGIN_FIRSTLINE..RES_MARGIN_RIGHT and non-paragraphs also have 2-4 consecutive items RES_MARGIN_RIGHT..RES_MARGIN_LEFT (only the 3 paragraph ones are actually used now). The HTML import filter is particularly annoying because it parses CSS stuff into SfxItemSets without knowing where the items will be applied, so it can't know whether to create SvxLeftMarginItem or SvxTextLeftMarginItem... the split items are created in ParseCSS1_* functions and then converted later if necessary. WW8 import has some weird code as well, SwWW8ImplReader::Read_LR() creates 3 items and then something wants to set every item on its own so SwWW8FltControlStack::SetAttrInDoc() turned out rather weird. Convert the paragraph dialog to handle the split items (by mapping them to SID_ATTR_PARA_FIRSTLINESPACE/SID_ATTR_PARA_LEFTSPACE/ SID_ATTR_PARA_RIGHTSPACE), but the SvxRuler looks a bit more confusing so convert in sw shells for now and leave that for later (also unclear if changing these slot items like SID_ATTR_PARA_LRSPACE breaks any ABIs?). Change-Id: I40431821868fd3e1cceba121b5539ff9ae6befbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147024 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-23Don't call CuiResId() in a global static variable initialiserTor Lillqvist
Instead, have a function that returns a reference to a local static variable. That local static is then initialised only when the function is called for the first time. Calling CuiResId() in a global initialiser is a bit questionable, and causes an uncaught exception when LO core is used in a WASM app. Possibly it would also have been problematic on other uncommon platforms. Change-Id: I4fd799ba3aa8d63fd3db1eb8cf6211aeed904ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147512 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-22(related tdf#153417) rename "Back" to "Reset"Seth Chaiklin
Change-Id: I70c79f7a40889bcca3aed3d2309779091967a2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146532 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-02-22tdf#142942 Drop unused checkbox col in sw AutoCorrect opts dialogMichael Weghorn
While the extra checkbox column enabled by weld::TreeView::enable_toggle_buttons(weld::ColumnToggleType::Check) is used for the non-Writer case in the "Options" and "Localized Options" tabs in the AutoCorrect options dialog, they are not used in the case of Writer, where there are two columns of checkboxes handled separately ("[M]: Replace while modifying existing text" and "[T]: AutoCorrect while typing"). Before commit 714b2b617e9baef02510c482c6fd028e6e72acd8 Date: Tue Jun 30 15:03:31 2020 +0100 tdf#134270 rearrange so we know the final treeview width , setting column widths manually by calling `weld::TreeView::set_column_fixed_widths` would disable the extra space for the (unused) checkboxes (by setting `m_bDisableCheckBoxAutoWidth`). Since that commit, it no longer does, causing the separately handled real checkbox in the first visible column to be unnecessarily positioned further to the right in this dialog for Writer for the non-gtk case. Fix this by dropping the use of the unused checkbox column for the Writer case, i.e. the `bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and in `OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage`. The handling for the non-Writer modules (i.e. `!bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and `OfaAutocorrOptionsPage`) remains unchanged. Change-Id: If7bd216fc4efda506817cffb55230722bb2ac89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-02-21tdf#143660 Make color scheme names translatableRafael Lima
The color scheme names defined in UI.xcu are currently not translatable. This patch makes them translatable by mapping the names in the UI.xcu file to a translated string. Change-Id: I10ab3bbcc9b028955c3c179558f8040b3b1d6c9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145732 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2023-02-20cui: rework uitest to work with --without-javaXisco Fauli
Change-Id: I6ed187f515b47b7e54ed85c08ee9523f1b777575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147335 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-29 17:34:19 +0000