summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-07-25external qrcodegen looks under qrcodegenCaolán McNamara
Change-Id: I01f06c30a52f5e4cdb5b4b6304072aa0f3a63aa8 Reviewed-on: https://gerrit.libreoffice.org/76291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25QRCode Dialog Box featureShubham Goyal
The patch handles the created QR code as a Customized Shape (Graphic Object) Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390 Reviewed-on: https://gerrit.libreoffice.org/74167 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-24loplugin:unusedenumconstantsNoel Grandin
Change-Id: I484b39d1060e6a563dabdde03867989b8ba067f9 Reviewed-on: https://gerrit.libreoffice.org/76237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1451635 silence Dereference after null checkCaolán McNamara
Change-Id: Ie5978be908647fe1215e1517a2bf638c7936dae2 Reviewed-on: https://gerrit.libreoffice.org/76225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24tdf#126070 Show scroll bars when preview overflows.Gülşah Köse
Change-Id: Ibb904fc1c5d283d8ca9d8ff8b2249d25d7091b5b Reviewed-on: https://gerrit.libreoffice.org/75954 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-24"Basic macros" instead of "$Productname Basic macros"Samuel Mehrbrodt
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros". Remove that confusion by using just "Basic macro" in the UI. Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596 Reviewed-on: https://gerrit.libreoffice.org/76216 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-23Improve some tip_of_the_day stringsRoman Kuznetsov
Change-Id: I5177b41aa3be91f1b5003e49a729757405eae4d5 Reviewed-on: https://gerrit.libreoffice.org/75184 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-07-23cid#1448463 Dereference null return valueCaolán McNamara
Change-Id: I61285b8e34f58bbaaedb5fd67d181aee7e1e591d Reviewed-on: https://gerrit.libreoffice.org/76135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-21tdf#125922 rename kde5 to kf5 + plasma5Jan-Marek Glogowski
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as it is based on the KDE frameworks 5 libraries. This also includes: * a convenience alias to load the kf5 VCL plugin in case someone requests the kde5 plugin. * keep convenience kde5 configure switch, but warn about it * rename detected desktop from kde5 to plasma5 Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735 Reviewed-on: https://gerrit.libreoffice.org/75313 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-20cid#1448212 Improper use of negative valueCaolán McNamara
Change-Id: Ib707b7e29f72c90f100ac20eb9dada37a2460158 Reviewed-on: https://gerrit.libreoffice.org/76015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19Move static into the getter functionMike Kaganski
Change-Id: I6a4ed20cc8f208fa59f12d65d3ff8287726db594 Reviewed-on: https://gerrit.libreoffice.org/75939 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-19loplugin:referencecasting in cppcanvas..cuiNoel Grandin
Change-Id: Ib8a513d88575cef9c1479b91adff98170c9323e8 Reviewed-on: https://gerrit.libreoffice.org/75937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18Resolves: tdf#126448 set activates_default and correct focus settingsCaolán McNamara
Change-Id: Ia857c37b7f5947e7339ba5f80aad54112ff2c3f7 Reviewed-on: https://gerrit.libreoffice.org/75818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#126051 sync MINBODY copies to same valueCaolán McNamara
Change-Id: Id41da7b07dcb25e820e5fd20aed595b1170fa204 Reviewed-on: https://gerrit.libreoffice.org/75807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1451643 Uninitialized pointer fieldCaolán McNamara
Change-Id: I5bb3087e8ccd0de2e04df9596ddf860de29689fb Reviewed-on: https://gerrit.libreoffice.org/75799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18Unify wording: "Open hyperlink" instead of "Follow hyperlink"Samuel Mehrbrodt
Change-Id: If4ffb81537b0f8101af14c45c13bb8d0ea8454d2 Reviewed-on: https://gerrit.libreoffice.org/75781 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17loplugin:unusedfieldsNoel Grandin
Change-Id: I38abc54776cc605c76faf94e9e8c0f4fa75b8788 Reviewed-on: https://gerrit.libreoffice.org/75740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17loplugin:unusedmethodsNoel Grandin
Change-Id: Ie2285f64919d1c83b0a8df4ceb827f731e5cd609 Reviewed-on: https://gerrit.libreoffice.org/75739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16cid#1448481 Calling risky randCaolán McNamara
Change-Id: I07c9956d034a1b78c77608da57dea299572fea85 Reviewed-on: https://gerrit.libreoffice.org/75711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448491 Uninitialized scalar fieldCaolán McNamara
Change-Id: I629da8b1620f3ff76f7aea5ded87a11b925b93e4 Reviewed-on: https://gerrit.libreoffice.org/75694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16tdf#125871 - new Tooltip window has empty area selectedHeiko Tietze
Ok button focused by default Change-Id: Ibe7653c09dd9f76d6b9feda295b92c90a4b26058 Reviewed-on: https://gerrit.libreoffice.org/75637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-15Resolves: tdf#126202 url not sensitive, so not editableCaolán McNamara
Change-Id: Id211bf3e29bbf32720ca8216ffe6fe589fd85db9 Reviewed-on: https://gerrit.libreoffice.org/75644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15restore show expandersCaolán McNamara
Change-Id: Ied499bc79e3e445f632b0f1939f89a12df73f467 Reviewed-on: https://gerrit.libreoffice.org/75636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15tdf#126397 - Make labels unique at the customization dialogHeiko Tietze
Had to add some context information for translatable captions too Change-Id: I33117ea2455f8973742a73491b212818b9b4b9a5 Reviewed-on: https://gerrit.libreoffice.org/75622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-14Fix welded general option pageJan-Marek Glogowski
* replace the wrong m_xFileDlgFrame with m_xPrintDlgFrame (some search and replace error, I guess) * set filedlgframe's visibility to True, so hiding actually works Change-Id: I5f77f3930096acd885bf8c2fbbf798d6f1b110db Reviewed-on: https://gerrit.libreoffice.org/75574 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11lokdialog: Convert the Paste Special dialog to async exec for swMuhammet Kara
Change-Id: I0c75def6ea09bcb191a8023421b371b49205e712 Reviewed-on: https://gerrit.libreoffice.org/75378 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-11tdf#126234 up relative bullet size limit to 400%nd101
The legitimate value for MS Office document bullet relative size is between 0% and 400% But for ODF the value is normally between 0% and 250%. Per ODF 1.2 spec "19.761 text:bullet-relative-size" there is no limit placed on the relative size of the bullet. This change is to make the upper limit match MS Office to address the import issue. UI also changed to reflect the raise Change-Id: Ic4bbef47e86a04b9a6f9f6188326c8b66e034807 Reviewed-on: https://gerrit.libreoffice.org/75189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-10Prepare PasteSpecial for Async-ness (sw, basesh.cxx)Muhammet Kara
This change is needed to make the paste special dialog async exec because the current design relies on return values of inner functions/methods while moving on. After this patch, the dialog creation and execution will not be so deep, so that it will be able to be converted to async exec in the usual way. The duplication in SvPasteObjectDialog::PreGetFormat() coming from SvPasteObjectDialog::GetFormat() will go away when the conversion is complete for all modules. It is only temporarily needed. Change-Id: I55e8aee39c41be6035c89f217f90f79720f32196 Reviewed-on: https://gerrit.libreoffice.org/75016 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-08use BitmapEx in BackgroundPreviewImplNoel Grandin
Change-Id: Iecbb528c526389d7eed0205c06a21c3cd0753644 Reviewed-on: https://gerrit.libreoffice.org/75211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-05tdf#126069 Set fixed height level and preview frames.Gülşah Köse
Set fixed height for level and preview frames to avoid overlapping non-gtk backends. This change needed for when we set the spacing our list. To see real spacing, preview frame's height shouldn't be change. Change-Id: I78b5277f447f751f6e7e411cd6d5eef0b34e394a Reviewed-on: https://gerrit.libreoffice.org/75066 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-05tdf#83618 Make line spacing values agreeJim Raykowski
Change-Id: I372a673bbad442d28314498248b12ce7f86fce09 Reviewed-on: https://gerrit.libreoffice.org/73737 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-04remove some unneede vcl/bitmap.hxx includesNoel Grandin
Change-Id: Ibdc79538276992193e61f6dc16ddd3fd1ab80b82 Reviewed-on: https://gerrit.libreoffice.org/75069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03tdf#42949 Fix IWYU warnings in include/svx/x*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5b91a82d25601041b73444f602d033ef62484ba8 Reviewed-on: https://gerrit.libreoffice.org/74563 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-02Remove accidental newline from ui contextSamuel Mehrbrodt
Change-Id: I4ccd844e21ddd3052d0380d4ca98eda30cbeb49d Reviewed-on: https://gerrit.libreoffice.org/74959 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-01tdf#125552 Don't show deleted certificate folder in Certificate Path dialogIlhan Yesil
Added a check to ensure that certificate folder exists. Change-Id: I351a58bbc606ac48eb9bdc85aaf0dbf8533a3d10 Reviewed-on: https://gerrit.libreoffice.org/73149 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-01tdf#126088 Display InternalPaths in UISamuel Mehrbrodt
Change-Id: Ib729be9ff79a3e43d7ec838646b530be8beff2d8 Reviewed-on: https://gerrit.libreoffice.org/74952 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-28Category Target and Function Target enhanced in customization TabSumit Chauhan
Better filters available in Category Target for selecting category . We now have sfxlo-PriorityHBox , sfxlo-PriorityMergedHBox and svtlo-ManagedMenuButton as category.Changes are also done in Function Target, lists are now more generic. Change-Id: Ia52890c09bb8083c2f907b5a9fe90eab4ec86aeb Reviewed-on: https://gerrit.libreoffice.org/74836 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-06-27tdf#126112 expander missingCaolán McNamara
Change-Id: Id931cd2242db229cdf7ea7c7e3fe8ad822ffedcc Reviewed-on: https://gerrit.libreoffice.org/74758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25use common WeldEditViewCaolán McNamara
Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25weld HyperLink DialogCaolán McNamara
Change-Id: Ic861b0a593505828a900fe2163125d6f5584a956 Reviewed-on: https://gerrit.libreoffice.org/74634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-24tdf#109158 slow AutoCorrect table, speedup switching away from languageNoel Grandin
Switching from the large table to another language could result in freezing up for some time, so use the nice weld::TreeIter API here too Change-Id: I28f422dcdbc762b282ed6bd1dffc8140ee77900f Reviewed-on: https://gerrit.libreoffice.org/74646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24Category Target, now available for customization tabSumit Chauhan
The patch activates the category target i.e one can filter the widgets on the basis of categories. The patch also solves -> GtkMenuToolButton is added in treeview(customization dialog) -> Code refractor suggested by mike Change-Id: I0c9f80300cc1202f19e90abe42fb5c5f7ca53915 Reviewed-on: https://gerrit.libreoffice.org/74609 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-06-24Resolves: tdf#126059 extra empty widget is visibleCaolán McNamara
when it shouldn't be Change-Id: Ia78fd92699db535fe4cf715c3d34ef6689f92caa Reviewed-on: https://gerrit.libreoffice.org/74637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-24move SvtIconChoiceCtrl to vclCaolán McNamara
Change-Id: I5ed8af625cb46998649c4f11255d7676a11bdc94 Reviewed-on: https://gerrit.libreoffice.org/74605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-24merge IconChoiceDialog and SvxHpLinkDlgCaolán McNamara
Change-Id: I8ba8f2b589db8842da63a4ce6824d4f049081108 Reviewed-on: https://gerrit.libreoffice.org/74610 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22Related: tdf#126036 give options dialog consistent button orderCaolán McNamara
its not welded yet, but skip ahead and give it explicit consistent button order in the meantime Change-Id: Ia850a024cb5a87b9231b5ffdec701646d7014e08 Reviewed-on: https://gerrit.libreoffice.org/74573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21weld SpellDialogCaolán McNamara
a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1 Reviewed-on: https://gerrit.libreoffice.org/74119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21move the cursor by the length of the final replacementCaolán McNamara
rather than the length of the unprocessed replacement Change-Id: I43fe8d66d5a664b5e96877c17a00f65f395c086d Reviewed-on: https://gerrit.libreoffice.org/74495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>