summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-01-12show something for the link name if there is no link bodyCaolán McNamara
Change-Id: I9a445bed6072a48c2eca67ee403218e749ff3feb Reviewed-on: https://gerrit.libreoffice.org/47800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11loplugin:redundantcast: cuiStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I3742417cde8a35653b336cc2801dc43a06cfb45e
2018-01-11Use more unique_ptr in treeopt (cui)Julien Nabet
Change-Id: I2041bf8c5d0ddcc0fb62978055381280a64094c4 Reviewed-on: https://gerrit.libreoffice.org/47187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11tdf#114701 Missing widget labels in Customization dialogheiko tietze
Labels placed above controls Change-Id: If05d54a172a3d4f98231fc7a3fb30d097e4e216e Reviewed-on: https://gerrit.libreoffice.org/47391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-06tdf#114818 hold the mutex before executing the error dialogXisco Fauli
Also add an assert to ErrorBox to ensure the mutex is acquired Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018 Reviewed-on: https://gerrit.libreoffice.org/47388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04drop FrameDirListBox typedefNoel Grandin
and rename FrameDirListBoxWrapper->FrameDirectionListBoxWrapper Change-Id: I201ab2caeff0a3219efe8ee86024bc48b8701f7e Reviewed-on: https://gerrit.libreoffice.org/47346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03tdf#113357 cui: fix duplicate 'Formatted text [Richtext]' paste optionMiklos Vajna
Prefer RTF when we have both RICHTEXT and RTF. Change-Id: Ib4133ae4fdecc32429d89b56b0c9466dd3451522 Reviewed-on: https://gerrit.libreoffice.org/47316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01Fix typosbansan85
Change-Id: Idcc291dba5cb6d86e29d00f6b34905f6693f7540 Reviewed-on: https://gerrit.libreoffice.org/47207 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-01-01Bump copyright year to 2018Adolfo Jayme Barrientos
Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476
2017-12-31Fix indentbansan85
Change-Id: Ie92d9f6cafd0b0af7db9cdb846073762bd4ba7b9 Reviewed-on: https://gerrit.libreoffice.org/47204 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-30loplugin:passstuffbyref improved return in cui,dbaccessNoel Grandin
Change-Id: I1193ff91ccd548acf9492d9701b6411a24d6763e Reviewed-on: https://gerrit.libreoffice.org/47194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for VectorOfNodes (cui/treeopt)Julien Nabet
Change-Id: I318128452fc6d76038c0ed41fcb0a5e7999952c4 Reviewed-on: https://gerrit.libreoffice.org/47146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for m_aLeaves/m_aGroupedLeaves (cui)Julien Nabet
and perhaps avoid memory leaks (see https://bugs.documentfoundation.org/show_bug.cgi?id=114457) Change-Id: Ib413b0bf6cc65a2696e3429965a67899b7b72d73 Reviewed-on: https://gerrit.libreoffice.org/47094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27clang-tidy-modernize-use-equals-default in cuiJochen Nitschke
Change-Id: Ied4f0a548b303aac86052df58f9a81fddeab7b06 Reviewed-on: https://gerrit.libreoffice.org/47086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27Calling ActivatePage directly is unnecessaryTamás Zolnai
After this commit: b426b026b79a342c41f6f148bf17d5df66b22927 Change-Id: I15d491d4cf63db4436ad8d3db0320cd2e26bb3ea Reviewed-on: https://gerrit.libreoffice.org/47078 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-27tdf#111723 Fixed - Dialog does not remember the last opened tab pageekuiitr
Change-Id: Ife6d0eb9ea13d2a0534f316db001dbb3b6a716eb Reviewed-on: https://gerrit.libreoffice.org/47050 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22request installation of langpack via packagekitCaolán McNamara
if ui is set to track the locale automatically and the current locale has no match in installed resources but has a match in the list of languages that libreoffice was compiled to contain so e.g. de_AT locale shouldn't trigger the installation of anything if langpack-de is already installed and yue_HK shouldn't trigger install of anything cause that not supported (at time of writing) for libreoffice put Fedora/RHEL/Ubuntu naming schemes in here. I moved the lang code from svl to svtools so I could use the restart dialog to prompt to restart after the langpack is installed, but packagekit's blocking mode seems to be no longer blocking and control returns immediately which is a change since the last time I played with this stuff, so drop the restart thing for now. The lack of a blocking modal also makes the "run this on idle when there's a toplevel window up and running" a bit futile, but lets keep that for now anyway. caolanm->rene: I know you'd disable this anyway, so Debian is left out, there's also config key Office/Common/PackageKit/EnableLangpackInstallation to disable this too. Change-Id: Ice731be539850338ccdd8af87839e0b4d83f01e7 Reviewed-on: https://gerrit.libreoffice.org/46856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22Avoid crash without GPGTor Lillqvist
Change-Id: I5489012544fdf736784608b274359ea99f9ffe45
2017-12-21tdf#106784 Also handle automatic icon sizeMaxim Monastirsky
... like before b1426b5b502fd591402d666994e3f1fb3a8ad959 ("tdf#95014 initial support for 32 px icons in toolbar"). The original code used SvtMiscOptions::AreCurrentSymbolsLarge() which calls GetCurrentSymbolsSize() internally, thus properly resolves the icon size, when the current setting is "automatic". Change-Id: Iabcbbcff666eecc2e7534eb1533610f08ac28bf1 Reviewed-on: https://gerrit.libreoffice.org/46899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-21TypedWhichId in svx part 1Noel Grandin
and teach the idl compiler how to ignore the TypeWhichId<T1> part of the define Change-Id: I030f54080924d51e9f0ac09b19e14106648024db Reviewed-on: https://gerrit.libreoffice.org/46849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-20Fix typosAndrea Gelmini
Change-Id: I361b5283b092171eaaaf46fa3c1fb13faa53bd7a Reviewed-on: https://gerrit.libreoffice.org/46821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-20Revert "Related tdf#114457: fix leak in treeopt (cui)"Julien Nabet
According to Telesto's test, it's worse than before, so let's revert This reverts commit 41981d4cb48e66b6fdb32cdc3ae65632af9593dc. Change-Id: Iba2a364160816fe981de91e51487a78bd6ebe15c Reviewed-on: https://gerrit.libreoffice.org/46817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19sal_uLong->sal_Int32 for SfxAcceleratorConfigPageCaolán McNamara
Change-Id: I2ec647b140c6be6c5cb6727873cca4cad16a664e Reviewed-on: https://gerrit.libreoffice.org/46701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19fix bug in IconChoiceDialog::disposeNoel Grandin
after commit 12bb4bc980863d4338725cf5a5dcaf3acbfddc09 convert HyperLinkPageType to scoped enum Change-Id: Icb1afcdea38f231bf9b7119eb4c1bedbf7494962 Reviewed-on: https://gerrit.libreoffice.org/46707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Read/write 'encrypt to self' bitKatarina Behrens
use some template functions to avoid duplicate code Change-Id: Ia178ea3a0561e34e0431749262f5f8f1f49b4fe7 Reviewed-on: https://gerrit.libreoffice.org/46693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-19Read/write preferred GPG signing/encryption keysKatarina Behrens
Change-Id: I3e21469c5f4c4f199407bbe9faba2e2ddca531b3 Reviewed-on: https://gerrit.libreoffice.org/46692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-19List private GPG keys in crypto config dialogKatarina Behrens
Change-Id: I7cb6a14adcc5424b432589120c66deeddf86b652 Reviewed-on: https://gerrit.libreoffice.org/46691 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-18convert HyperLinkPageType to scoped enumNoel Grandin
Change-Id: I9554cdee56c7079ed8633ffb16074c99d5ab144e Reviewed-on: https://gerrit.libreoffice.org/46588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert ColorPickerMode to scoped enumNoel Grandin
and drop unused Add constant Change-Id: I4e4f0d35e4d081883b78e0205ffd7086c9cadf04 Reviewed-on: https://gerrit.libreoffice.org/46587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17tdf#98058 Respect menu:style="text" settingMaxim Monastirsky
It was implemented on the xml handling side, but ignored by the menubar code. In addition, make the menu:style attribute survive customization (similar to tdf#114261). Change-Id: I92a3517ee7ba2fe7a0782985d89fb5d0fdbac246 Reviewed-on: https://gerrit.libreoffice.org/46627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-17loplugin:unusedindex Remove useless outer loopMike Kaganski
Change-Id: I6e5e7162b1e0ea2b9f33866ea76e2614acdffb06 Reviewed-on: https://gerrit.libreoffice.org/46606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-16Related tdf#114457: fix leak in treeopt (cui)Julien Nabet
Change-Id: I28bd32d01bb3d90e68e816720b1b5af7d517760f Reviewed-on: https://gerrit.libreoffice.org/46602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15tdf#114484 - Make internal file and print dialogs obsoleteheiko tietze
Checkbox hidden in options dialog Change-Id: I918b328dec1a4fbb4ebbcc538ffa902160ee0b9b Reviewed-on: https://gerrit.libreoffice.org/46546 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-14Minor fix: unused local variableGergely Tarsoly
Change-Id: I42db2c6fd90686641cd6c2f7f45d960977557ab4 Reviewed-on: https://gerrit.libreoffice.org/46416 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-12tdf#113959 Use svxlo-FrameDirectionListBox instead of ListBoxGabor Kelemen
Final part. Here frmaddpage.ui is migrated, but to reuse the 2 other strings we need to shake up their original place in page.cxx Now all the stings are moved to svx and occur only once in the code base. Change-Id: I8b3942f96d43bf8d6f054c8410c3781bcefc3ccc Reviewed-on: https://gerrit.libreoffice.org/46189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-12sal_uIntPtr->sal_uInt32 in AbstractGalleryIdDialogNoel Grandin
to match the underlying call to SetId in GalleryTheme Change-Id: If862c1f7c2d7c05484347ef46a9d504e95686ec7 Reviewed-on: https://gerrit.libreoffice.org/46273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10tdf#114261 Retain toolbar:style after customizationMaxim Monastirsky
Change-Id: I50170a2433f5e20809dd5bca8cb764039e8e0d84 Reviewed-on: https://gerrit.libreoffice.org/46169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-09tdf#113959 Use svxlo-FrameDirectionListBox instead of ListBoxGabor Kelemen
To reduce the number of translatable stings Change-Id: I1aeea6767d3389dd24a5bf8b074817ef601502a7 Reviewed-on: https://gerrit.libreoffice.org/45823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08gpg4libre: rename GPGME_HAVE_GPGME to HAVE_FEATURE_GPGMEThorsten Behrens
Change-Id: I6f085b67c3477f427bd1efd96db93cbb89e20647 Reviewed-on: https://gerrit.libreoffice.org/46050 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-08Update recent characters only when the selected character is insertedTamás Zolnai
Change-Id: Ic8cd715553f995d8adc1e84381c00646c9c252af Reviewed-on: https://gerrit.libreoffice.org/46065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07lokdialog: Make hyperlink dialog workPranav Kant
Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76
generated by cgit (git 2.34.1) at 2024-12-28 21:53:57 +0000