summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-08tdf#129517 add "Preview" labels in BulletandNumberingStyle dialog box"Seth Chaiklin
added GtkFrame to include label with Preview Window in Customize tab added label in Position tab Change-Id: Id37a2c696832ebe9dcd3cb4910a7bc3292cb0143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-08Paragraph Dialog Alignment preview fixandreas kainz
Change-Id: I63c3c28dedf82bfc8e28c0a323aaa8c26b4c82d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86316 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07Fix SfxPoolItem use-after-freeStephan Bergmann
...as observed with -fsanitize=address in Draw, after drawing some rectangle (so that there is at least one marked object) doing "Format - Area... - Area - Bitmap": > ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8 > READ of size 4 at 0x6030004aca50 thread T0 > #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42 > #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124 > #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 > #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42 [...] > 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21 > #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13 > #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42 > #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9 > #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec "tdf#104615: there's no mpView when opening odc directly". Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-07Paragraph Dialog Text Flow Page updateandreas kainz
Change-Id: I0e47f9abb2e20da8ae3aef1ee927cb286a88ee8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86319 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07most has_tooltip uses are bogusCaolán McNamara
has_tooltip means to use "query-tooltip" to present a tooltip, not that the widget has a literal tooltip, the presence of which is sufficient to set the tooltip Change-Id: I49b35debd1bca1803464096fbc550eb50945509f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07halign 'Start'->'start'Caolán McNamara
Change-Id: Ia8547ffd08cc60ec8e6f791fcccaab35784de9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06Add include guards - follow-up for 0c4033a9c69da439b97378b0dc61e867953649ebMike Kaganski
Change-Id: I2910ac7e063b785c845723a2eb265cce96c94ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Resolves tdf#129622 - Layout problem in Options-LibreOffice-ViewHeiko Tietze
horizontal fill set for the questionable controls Change-Id: Iab194709ec3ad4881ace36a605ebb4a0d37fe8a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-06Fix Windows build with HAVE_FEATURE_BREAKPADMike Kaganski
This partially reverts commit ed1ece19d4983ea47b296086aaa0ea91fe11935d Change-Id: Ie945676f0618f80c3258f041fea9b91ee01031d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86263 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Removed redundant semicolonsAndrea Gelmini
Change-Id: Ife14b8c3f7d121deb390deb5f405dd42d3016acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-06tdf#42949 Fix IWYU warnings in cui/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I41ae36eb535cc64f4c4fa73333dbc8aa728865b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85791 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-06tdf#129593 Language settings dialog UI updateandreas kainz
Change-Id: Ie313237a92b0df3ca0ab3dfe876879114afb8af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85771 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-06tdf#129517 add "Preview" labels in BulletandNumberingStyle dialog boxSeth Chaiklin
- on Position tab - on Customize tab Change-Id: I62b316ec36c1c65c0028a16e9717f0fd363b550f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85861 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-02blackorwhitelistentrydialog never got usedCaolán McNamara
Change-Id: I5985bf966879fafa6472a8fb51ee63d07f7dd734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02weld SlideBackgroundCaolán McNamara
Change-Id: I6f8792d8212807b4be4a24885e237290e298dfa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02number format menu too narrowCaolán McNamara
Change-Id: I439f831677362427aff93b296be0643a27a76668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02Bump copyright year to 2020Adolfo Jayme Barrientos
Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-01weld PageStylesPanelCaolán McNamara
Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01missing previews in line comboboxesCaolán McNamara
since... commit 6cdc0dbfadfcbfa4f53a3c21a494ab225ba5d955 Date: Tue Nov 5 01:53:23 2019 +0100 linetab dialog page update and similar Change-Id: Iafb2933434d76472bab7297962e0803a6568e61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-31tdf#108458 related: Make command tooltip show in tooltipJim Raykowski
Make Customize > Keyboard > Function TreeView show command tooltip in the tooltip. Change-Id: I5d2ca7090e00d7c18d792da73c567cdfd6895da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85776 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-30rename SvxDialControl back to DialControlCaolán McNamara
Change-Id: I4dcf12b6eccf18a0659c5d5f9cd58bd104c4dc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30weld PosSizePropertyPanelCaolán McNamara
Change-Id: I32bba3a698a4cc78d4159c6f373b312540478ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-29tdf#124176 Use pragma once instead of header guarderto
Change-Id: I904c2b37a51c03d51503c0b460201392ec8894a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85628 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedmethodsNoel Grandin
Change-Id: Iad97bdbcbec4cbbccf3df9b9d682e744b0c1982e Reviewed-on: https://gerrit.libreoffice.org/85709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedfieldsNoel Grandin
Change-Id: Ib2314f23efe953398ed0a5e88305842c812e18bb Reviewed-on: https://gerrit.libreoffice.org/85708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20tdf#124176: Use pragma once instead of include guardsSıla Genç
Change-Id: I88d5517d42b6c5b6809f062a789e7dd85394f6db Reviewed-on: https://gerrit.libreoffice.org/85601 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#124176: Use pragma once instead of include guardsSelim Şeker
Change-Id: I626d4a08161a6c81b4bb014d847f0c05d90fda35 Reviewed-on: https://gerrit.libreoffice.org/85449 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#108458 Show tooltips in CuiConfigFunctionListBoxJim Raykowski
Change-Id: I6644e939c644c827e2b3ad019b975a3845585063 Reviewed-on: https://gerrit.libreoffice.org/84555 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-19tdf#124176: Use pragma once instead of header guardBatuhan Görkem Benzer
Change-Id: I720508aa4bfd77f15b5d713e4d948b06af0be4c2 Reviewed-on: https://gerrit.libreoffice.org/85414 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsMesut Çifci
Change-Id: I377809c01053ebaf2fe004478e144509adbbdd1f Reviewed-on: https://gerrit.libreoffice.org/85416 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: I47be8a0488b7ff7ce176f10aaf90b8be6913cc8a Reviewed-on: https://gerrit.libreoffice.org/85412 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsOnur Yilmaz
Change-Id: I2f58499164254eab1d2f628b3b64710e1d2efbeb Reviewed-on: https://gerrit.libreoffice.org/85415 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsDesmin Alpaslan
Change-Id: Ib14b28a9508b28460a6063f7ddd322869823b49a Reviewed-on: https://gerrit.libreoffice.org/85413 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsKemal Ayhan
Change-Id: I8f8641d41a3c394c494d0e5f6cd5a06949e22fa6 Reviewed-on: https://gerrit.libreoffice.org/85410 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: I1f6d66a0d4a06338671579e9be2dbdc5cd673d50 Reviewed-on: https://gerrit.libreoffice.org/85411 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsMuhammet Kara
Change-Id: I3df73c321efa7fa3e8a87608c3c7189f7d839ac8 Reviewed-on: https://gerrit.libreoffice.org/85384 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18sal_Char->char in cppcanvas..cuiNoel Grandin
Change-Id: I7e9fa7011f1e0bf143f86055718c772caebf8ee6 Reviewed-on: https://gerrit.libreoffice.org/85397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#127294 Remove spaces; follow design guidelines for tips-of-the-daySeth Chaiklin
- converted to design guidelines all quotes all menus items apostrophe (U+2019) em-dash (U+2014) minus (U+2212) expanded contractions - Corrected spelling and grammar mistakes. - Simplified wording in some tips - tried to clarify uri explanation in relation to help Change-Id: Ic9984fdc09813d2b43324a104d5c30420671c6b9 Reviewed-on: https://gerrit.libreoffice.org/85228 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-17Fix macro security UI usability problemsJan-Marek Glogowski
* Don't hide the option dialogs "Macro security" push button. I don't see any reason, why these settings should be hidden, if macros are disabled or settings locked. At least a user can now check, what is going on (still nothing shows disabled macros for a document in the UI AFAIK). * Don't scale the lock icons of the trusted list boxes. This just uses the same alignments, which the macro security level lock image uses, otherwise the image is scaled to fit the whole space of its layout cell. * Don't disable the trusted list boxes. If the setting is locked, it's sufficient to disable all the buttons, which allow modification (so View can stay enabled). This way you can still scroll the list. Correct button handling is already implemented and works for me. * Catch exceptions of broken certificate data. If your config contains certificates, which can't be correctly decoded, the NSS backend will throw an exception, which kills the dialog, but not the nested loop, resulting in a locked LO. Also show an error dialog with the broken base64-encoded data. Change-Id: I79002e0ce85cf9a9017caf858407f2f635a3a074 Reviewed-on: https://gerrit.libreoffice.org/85056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-17ui: show wait mouse pointer on operations in Expert ConfigurationVasily Melenchuk
Expert Configuration is loading, resetting and searching values very slowly, so will be great to indicate busy status to user. Change-Id: Ic0d428d01a9f71ff899979162e1b307cd7cd7401 Reviewed-on: https://gerrit.libreoffice.org/85242 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-16tdf#127294 replace one section tip of the day with 4 new section tipsSeth Chaiklin
Also adjusted wording on another section tip. Change-Id: I8e24656f2cbf86a5da3bc2b8e204b2bc8d29b33c Reviewed-on: https://gerrit.libreoffice.org/84965 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-16Related tdf#105225: Remove old background tab page codeJim Raykowski
All uses of SvxBackgroundTabPage have been replaced by a new background tab page derived from the SvxAreaTabPage. This patch removes the SvxBackgroundTabPage code and code used only by it. Change-Id: I83a2a04c0bf908cdc630fa091cd5ccdfb5d9381d Reviewed-on: https://gerrit.libreoffice.org/85194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-13size group is ignoring hidden widgets, leading to labels overlapping entriesCaolán McNamara
https://developer.gnome.org/gtk3/stable/GtkSizeGroup.html#gtk-size-group-set-ignore-hidden "Measuring the size of hidden widgets ... they will report a size of 0 nowadays, and thus, their size will not affect the other size group members" Which is unfortunate. So before we hide any labels, take the size group width and set it as explicit preferred size. Change-Id: If7c0f1ebd9f03914c74fde85b876549de76853c2 Reviewed-on: https://gerrit.libreoffice.org/85097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13Resolves tdf#129295 - Hyperlink Text below URLHeiko Tietze
Added also an a11y label for the protocol web/ftp Change-Id: I962de691156386e86707fdbd5a4198ca4bf45929 Reviewed-on: https://gerrit.libreoffice.org/85093 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-13loplugin:expandablemethodsNoel Grandin
Change-Id: I333d91ea5ce78c82e9bb107f934614efc7bfb8f7 Reviewed-on: https://gerrit.libreoffice.org/85078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12theChild->getName() already available as uiNameCaolán McNamara
Change-Id: I2792b2ac4f0d17dfc2fe68eeacb4dee2173fe5d2 Reviewed-on: https://gerrit.libreoffice.org/85068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12children[n] already available as theChildCaolán McNamara
Change-Id: I3eeb072ff393033fb681956b4ac7fe1c71745a0d Reviewed-on: https://gerrit.libreoffice.org/85067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-27 15:44:50 +0000