summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-10-02consistently apply std::unique_ptr to SvLBoxButtonDataCaolán McNamara
Change-Id: I307c9095aa562348ce1b9338203995d9d62eebb4 Reviewed-on: https://gerrit.libreoffice.org/43037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-01throw more useful uno::Exception'sNoel Grandin
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01simplify some OUString compareTo callsMuhammet Kara
to either startsWith or == or != Change-Id: I595dd9d89d32134827980c4ba10f88584430137d Reviewed-on: https://gerrit.libreoffice.org/42988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-30Related tdf#112393: avoid leak in SvxEditModulesDlg::CreateEntryJulien Nabet
by using unique_ptr bt: 0 0x00007fffee95a933 in SvLBoxButtonData::SvLBoxButtonData(Control const*) (this=0x55555c1c28d0, pControlForSettings=0x55555c1b9680) at /home/julien/lo/libreoffice/svtools/source/contnr/svlbitm.cxx:55 1 0x00007fff95cde826 in SvxEditModulesDlg::CreateEntry(rtl::OUString&, unsigned short) (this=0x55555c17f270, rTxt="Orthographe", nCol=1) at /home/julien/lo/libreoffice/cui/source/options/optlingu.cxx:1842 2 0x00007fff95cdf4dd in SvxEditModulesDlg::LangSelectHdl_Impl(ListBox const*) (this=0x55555c17f270, pBox=0x55555c19dc60) at /home/julien/lo/libreoffice/cui/source/options/optlingu.cxx:2004 Change-Id: I6f10d7adae4346b204e21bdaca16aacb2758003d Reviewed-on: https://gerrit.libreoffice.org/42962 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-28Remove dead code behind Calc "Live Data Streams" dialog's "scriptdata" buttonStephan Bergmann
...that has been disabled and hidden ever since 4c90ed782a09e2e4b8738b82028032c42d1a203d "Actually hide these two radio buttons (since there is no choice now)." This removes the sole user of SvScriptStream. (Unfortunately, removing the no longer needed #include <osl/process.h> from include/tools/stream.hxx triggered an avalanche of missing includes elsewhere.) Change-Id: I7b0e683b14c0eaf7f4737f62adc9d691826380c0 Reviewed-on: https://gerrit.libreoffice.org/42916 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-28tdf#112658: fix leak when calling TextEngine::SetAttribJulien Nabet
TextCharAttribList::RemoveAttrib lets a dangling pointer when release unique_ptr obj maAttribs[n] So retrieve a unique_ptr from the different layers until SentenceEditWindow_Impl::ChangeMarkedWord (SpellDialog.cxx). Change-Id: I734909dce86ec28d69c09b2a8c0fc4a6941f422a Reviewed-on: https://gerrit.libreoffice.org/42881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28Use sal_Int32 to stick with other SetAttrib methodsJulien Nabet
+ use size_t GetUndoActionCount like other existing ones Change-Id: Ibfae20e7fd75df980f395e055063f0bdba1047f7 Reviewed-on: https://gerrit.libreoffice.org/42873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28simplify Bitmap operator==/IsEqual (stage2)Noel Grandin
Now that we've sorted out which bits are rightfully internal (see commit 7a4064cf87d23bffac987b3e39bf87d9b4d158fc), and which bits need a comparison operator, rename IsEqual to operator==. Change-Id: Iec229a7571d76ee18fbc0a4fe672cc2e50a44948 Reviewed-on: https://gerrit.libreoffice.org/42851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27simplify Bitmap operator==/IsEqual (stage1)Noel Grandin
It looks like operator== is actually only useful internally. So inline that, and rename the other call sites to use IsEqual(). As a second stage, I will rename IsEqual to operator==, the intention being to make it obvious how the call sites are modified. Change-Id: I37f2920a8cafaffb25e8c5c16e6559546206684b Reviewed-on: https://gerrit.libreoffice.org/42846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27loplugin:unusedmethodsNoel Grandin
Change-Id: I5d75baa2af046f377b49e967783fb06cd9e885ef Reviewed-on: https://gerrit.libreoffice.org/42841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27Replace sal_uLong with sal_uInt32 in SpellDialogMuhammet Kara
It is now consistent with the param type of TextEngine::SetAttrib Change-Id: I3b0ef3fe01ee26cce8c3ec078f9ae93317d6ccdc Reviewed-on: https://gerrit.libreoffice.org/42787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Special character dialog small fixesTamás Zolnai
Use stock button for OK and identation fixes. Followup changes to: 4020945651b4f3c636980e2103db440b5c55459c Change-Id: I3fe2f2f9a4528d38086db453d7ea71f7ac8b7a9a Reviewed-on: https://gerrit.libreoffice.org/42800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26Cleanup unused strings in cuiMuhammet Kara
Change-Id: I7ab055f301785a73d189e58465056ac4b2e8b494 Reviewed-on: https://gerrit.libreoffice.org/42783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#111739 fix Selecting a custom character as a bullet symbol insertionDaniel
Change-Id: I638ef2467f27bd6214cde092be5a3055fd539ebc Reviewed-on: https://gerrit.libreoffice.org/42727 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Different take on tdf#108406: exclude helpimg from installed themesKatarina Behrens
as it still might get selected as default theme under some circumstances and removing it from list in optgdlg.cxx leads to crash This reverts commit 60adba3fb904ed66251ff39c82fe20bec151ef0b but allegedly still crashes on Debian Change-Id: Ib853cc27058d8635482f19a8db26075d64103e1b Reviewed-on: https://gerrit.libreoffice.org/42545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-21loplugin:flatten in connectivity..desktopNoel Grandin
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20unused sNumCharFmtName fieldsNoel Grandin
ever since commit 89ef4dea325a11c706ff9619ff4717124260f864 Date: Fri Jul 17 10:34:58 2015 +0200 loplugin:unusedmethods cui Change-Id: Ibfa3841168448d4f08075a684fa36262b303210f
2017-09-19inline some use-once fields in cuiNoel Grandin
Change-Id: Ib2abea6b1f68cf193325d312e67578b2d346e39a
2017-09-18tdf#108139 Remove Preview column from Application Colors config pageArkadiy Illarionov
Change-Id: Id342814f3a724a0534cd6fd43b49139af52c1d03 Reviewed-on: https://gerrit.libreoffice.org/42362 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-18tdf#106945 TSA Dialog: Disable delete buttonSabin Frandes
Change-Id: Idce5ccc36254d80aaf4b5d5f81cfe201e5c27a5f Reviewed-on: https://gerrit.libreoffice.org/42315 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-15tdf#106946 Removed ability to resize Spellchecking-Options dialogAndreas Brandner
Change-Id: I89182eeb01f8639aa7d7af61f0fe99d96568b6e3 Reviewed-on: https://gerrit.libreoffice.org/42330 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-15Add space after text for better string concatOlivier Hallot
Change-Id: Ib8a9975091f3a17fbc90a0f1bf5eb4b736009099 Reviewed-on: https://gerrit.libreoffice.org/40095 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15tdf#112393: avoid leak in LangSelectHdl_Impl (cui)Julien Nabet
by deleting userdata of entries containing in m_pModulesCLB Change-Id: Ie903b0cd0ccf16839ac7bed42b7bdbc1db4fa5ef Reviewed-on: https://gerrit.libreoffice.org/42308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-15tdf#112392: avoid leak in SvxEditModulesDlg (cui)Julien Nabet
by using unique_ptr Change-Id: I07d71a6aa1fe1eef40280588e842b1a884eb499e Reviewed-on: https://gerrit.libreoffice.org/42307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-14improve redundantcast lopluginNoel Grandin
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13tdf#112133: Drop the Add and Remove labelsMuhammet Kara
and ensure consistent height of the controls in the first row of the Customize dialog. Change-Id: I6c2d75b647cad7a2ead8c875afc4fd38a182eef0 Reviewed-on: https://gerrit.libreoffice.org/42233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-13Enable -Wunreachable-codeStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-13Use "en-US" as the default for XHP's xml-lang attribute.Jan Holesovsky
Change-Id: I765e1cc25ac79d2cebf54f7a247a200647c984da Reviewed-on: https://gerrit.libreoffice.org/32296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-12tdf#112241: Improve column width behaviour in Customize dialogMuhammet Kara
Also: * Remove unnecessary frame "contents" * Remove unnecessary alignment * Remove extra column from the left grid (grid4) * Move all into a new grid for better sizing Change-Id: I4d805a800ca6e487bf788cd9401e5f77303ddd1d Reviewed-on: https://gerrit.libreoffice.org/42186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-12down/up/focus/first/last handler not needed nowCaolán McNamara
Change-Id: Ie8cb8e1bfb32669c2b4487f02d107b08c60b2399
2017-09-12disable thousand separator for this year spinfieldCaolán McNamara
and then the manual removal of ,|. is unnecessary Change-Id: I40d96beb895f815bb7aad9c0f36c3722b614f9a2
2017-09-11Fix typosAndrea Gelmini
Change-Id: I7bb62814c8cdf635d1c54f0a1cbb09a3d06a0d5d Reviewed-on: https://gerrit.libreoffice.org/42178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-11tdf#108011: Customize dialog's commands list should respond to keyboardMuhammet Kara
Change-Id: I58cd779714624e7b37c7920df622aa454afb9f29 Reviewed-on: https://gerrit.libreoffice.org/42163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-11add missing context attributes to .ui filesAndras Timar
Change-Id: If66a4e867b3b406aed90ab2259637e536e236ea3 Reviewed-on: https://gerrit.libreoffice.org/42164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-09-11clang-tidy modernize-use-emplace in c*Noel Grandin
Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-10tdf#112254: fix memory leak in optaboutconfig (cui)Julien Nabet
Store UserData objects in a member defined as vector of unique_ptr so we're sure UserData objects will be destroyed when out of the scope Change-Id: Ib5494ad563272adcf64035300f3213688437fcfc Reviewed-on: https://gerrit.libreoffice.org/42123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10cppcheck: knownConditionTrueFalse 'bValid' is always trueJochen Nitschke
Change-Id: I3f73641286020a06a605867726d54376c47a06dc Reviewed-on: https://gerrit.libreoffice.org/42134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09tdf#108406 offline help-images helpimg are no longer selectable as iconsetAndreas Brandner
Change-Id: I6733ed2a04c01c288de2cd6af938a6c6ff1b4481 Reviewed-on: https://gerrit.libreoffice.org/42117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-09tdf#112133: Polish the visual appearance of the Customize dialogMuhammet Kara
* Vertically align the dual list controls at top and bottom * Vertically center align small controls' captions (search, category) * Vertically top align captions of large controls (description) * Horizontally align captions at the keyboard tab For labels: * Drop all colons * Remove the bold font style at the keyboard tab * Provide mnemonics for all captions with focusable controls (add, remove, insert, modify, reset... but not description) * Take care of unique mnemonics (alt+C = category & cancel) Functional * Disable the description when nothing is to show there (no offline help installed), and inform the user via tooltips Change-Id: I5862f97ec8e5e866f5e56bcdaf386a793f6040d1 Reviewed-on: https://gerrit.libreoffice.org/42099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-08set parent for file dialog helperCaolán McNamara
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-16 06:04:17 +0000