summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-11-27add GUI and configuration options for SkiaLuboš Luňák
Pretty much a copy&paste of OpenGL. There are no settings for choosing which backend Skia should use, as the plan is that simply the "best" one will be selected. Change-Id: I44fa876ab85de98de482a6ed9f814024334686ce
2019-11-27tdf#126043 use another bulk_insert_for_eachCaolán McNamara
Change-Id: I05c3fc6e708d000ba955981dbd8d11371ea99da2 Reviewed-on: https://gerrit.libreoffice.org/83686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#43021 WIN opt-out of OS recent folder usageJan-Marek Glogowski
The Microsoft documentation for SetFolder explicitly mentiones "In general, we do not recommended the use of this method. [...] SetDefaultFolder is the better method." If SetDefaultFolder is used the recently-used folder overwrites the value passed to SetDefaultFolder, which is shared between all file pickers. With this patch we rely on the LO internal mechanism to show the last used directory in the file picker. Regina's workaround basically does the same, as it just sets oRegistryKeyContent.WorkPathChanged, which triggers the internal path to use SetFolder instead of SetDefaultFolder. If you're wondering about the GetFolder() handling, the MS API docs have this: "Gets either the folder currently selected in the dialog, or, if the dialog is not currently displayed, the folder that is to be selected when the dialog is opened." So the call to GetFolder(), after the dialog is closed, returns the folder set by the SetFolder call, not the folder selected by the user, in case of the save dialog at least. Change-Id: Ia24f47848501df82727bfb2a99db723468bfe5b1 Reviewed-on: https://gerrit.libreoffice.org/83409 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-26loplugin:staticmethods (clang-cl)Stephan Bergmann
Change-Id: Ie3b1e7d8a048bc161770bfb01f4d94e14a3fdea9 Reviewed-on: https://gerrit.libreoffice.org/83768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I2e74a01c3500c1ac646479c571b6806c0fc566c1 Reviewed-on: https://gerrit.libreoffice.org/83769 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26tdf#126043 use bulk_insert_for_eachCaolán McNamara
Change-Id: I68b5a7805a2e0a76d1871448a011fdde7f7cdb1e Reviewed-on: https://gerrit.libreoffice.org/83685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 module identifier already knownCaolán McNamara
Change-Id: I710180ed125bbea250694cfb5f7d12cb1b07f782 Reviewed-on: https://gerrit.libreoffice.org/83675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 don't bother converting to OUStringCaolán McNamara
Change-Id: I179354659e4ee118138b994c7848c1dda39317bb Reviewed-on: https://gerrit.libreoffice.org/83678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 drop intermediate OUStringCaolán McNamara
Change-Id: I96906737bfe0f40b8a4c0b2f88dde7cc40daeab0 Reviewed-on: https://gerrit.libreoffice.org/83677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 freeze/thaw around bulk insertCaolán McNamara
Change-Id: I2dd9aedc305a4fe1992fe8c52fee85ade8589a5b Reviewed-on: https://gerrit.libreoffice.org/83674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 identify the frame module just onceCaolán McNamara
Change-Id: I7f68cf67838bb08672975e7a38cf213022e39ed8 Reviewed-on: https://gerrit.libreoffice.org/83672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 use CommandInfoProvider::GetModuleIdentifierCaolán McNamara
which probably already has a cached ModuleManager Change-Id: Id653e57ecf40061ace086881344a85d7413a5afc Reviewed-on: https://gerrit.libreoffice.org/83671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26use a better conversion to OUStringCaolán McNamara
Change-Id: I4a133c054700f72770380214cc794a691edac54e Reviewed-on: https://gerrit.libreoffice.org/83667 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 cache the appname and filenameCaolán McNamara
Change-Id: I10987f8a447785eb0d9887f94ee0ffb0da99649a Reviewed-on: https://gerrit.libreoffice.org/83658 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25tdf#127294 correct tip about removing multiple hyperlinksSeth Chaiklin
Change-Id: I40c23170ebb0b7fc9386efc1983eacef79a37f37 Reviewed-on: https://gerrit.libreoffice.org/83648 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-25tdf#126043 load the xml just onceCaolán McNamara
Change-Id: I98cfeeeddf2fb2d86259a11368bf3db752f5e556 Reviewed-on: https://gerrit.libreoffice.org/83656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25don't just truncate the unicode chars of the pathCaolán McNamara
instead convert to a systempath like we do for other uses of xmlParseFile drop the manual memory management Change-Id: I8c3329db4b47a2d212770297c96f066ccbe1ec77 Reviewed-on: https://gerrit.libreoffice.org/83653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25fix leakCaolán McNamara
Change-Id: I486fad57766c1314fde7c580fd06b2c5d225241a Reviewed-on: https://gerrit.libreoffice.org/83649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25constifyCaolán McNamara
Change-Id: I912ec27312a65bf065887af26b42122b5276d69f Reviewed-on: https://gerrit.libreoffice.org/83651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-23cppcheck: performing init in init list (comphelper/connectivity/cppu/cui)Julien Nabet
Change-Id: I786c2c10e8b37b48adf6d619c0fa6a905de1bf7f Reviewed-on: https://gerrit.libreoffice.org/83584 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23OfaTreeOptionsDialog::LoadModule: Use range-based forMichael Weghorn
Change-Id: I2b191dd55dcd9e085b2cde6bacd1e2e3c963fafa Reviewed-on: https://gerrit.libreoffice.org/83489 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23treeopt.cxx: Simplify 'ModuleMap' handlingMichael Weghorn
Use 'OUString' instead of 'const char*' for 'ModuleToGroupNameMap_Impl.m_pModule', and simplify the iteration using range-based for. Change-Id: I1756bc6ac8b163a68b79d6900738362db010d8a9 Reviewed-on: https://gerrit.libreoffice.org/83488 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23Use const OUString instead of const char[]Michael Weghorn
'SvtViewOptions::GetUserItem' and 'SvtViewOptions::SetUserItem' take a 'const OUString&' param anyway. Change-Id: Icdc4c578516c9fe1307b64eecdf3270142b4e823 Reviewed-on: https://gerrit.libreoffice.org/83487 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-22cui: add UI for semi-transparent shape textMiklos Vajna
- Make font color only work with the RGB color, otherwise the preview would be white for e.g. half-transparent red. - Add label and widget to see already set transparency. - Add a flag to show these only for Draw/Impress and leave Writer/Calc unchanged. - Update returned item set to contain transparency in case the widget changes. Change-Id: If77771076ff4b10a4a5d468a6583809a94deb57e Reviewed-on: https://gerrit.libreoffice.org/83520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-21tdf#128775 Writer Hyperlink dialog: fix encoding of inserted target URL Tünde Tóth
text, also its preview in the dialog window, when the URL contains anchor at the end. Change-Id: Ibedb86238f660177b3dd476cd6a13f1ca5f05e12 Reviewed-on: https://gerrit.libreoffice.org/82654 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-20linetab dialog page updateandreas kainz
Change-Id: I6e152f69850d1fd3671660decd4186d8cd29465e Reviewed-on: https://gerrit.libreoffice.org/82047 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-20Resolves: tdf#128811 Alignment option "Distributed" not working in calcCaolán McNamara
Change-Id: I605b62ef0dfa29db93e4d7df8285a05a12bda8e3 Reviewed-on: https://gerrit.libreoffice.org/83270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Page Dialog updateandreas kainz
Change-Id: I7789ad1d4facb966ddc9ed4ed7201052809ce375 Reviewed-on: https://gerrit.libreoffice.org/83246 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-20loplugin:unusedmethodsNoel Grandin
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20Line Shadow Dialog updateandreas kainz
Change-Id: I59294e8de213059cb0bdc28b5006ee202019210a Reviewed-on: https://gerrit.libreoffice.org/83234 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-19Options - User Data Dialog labels left alignandreas kainz
Change-Id: If18abdb3e6d23ada149a9cfc7b2744db9ec3b5f8 Reviewed-on: https://gerrit.libreoffice.org/83124 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Options - Language Aid Dialog make usefull section namesandreas kainz
Change-Id: I1afc30d7d1a52e8b862bcbfb3632a193ee3253e6 Reviewed-on: https://gerrit.libreoffice.org/83129 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19tdf#125449 Fix custom gradient fill settings being lostGabor Kelemen
Change-Id: Ia2377274e0fc9da5873bf55735af25ed6ae3d65c Reviewed-on: https://gerrit.libreoffice.org/82393 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-11-18Paragraph Align Tab fixandreas kainz
Change-Id: Ied02b9db154bd007399b8b3d567d692d4973d382 Reviewed-on: https://gerrit.libreoffice.org/83040 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-18tdf#127927 Character Dialog effect preview Alignmentandreas kainz
Change-Id: If4bf99711b09c61d00dafb65ba76f4673c99246b Reviewed-on: https://gerrit.libreoffice.org/83019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-17Fix typosAndrea Gelmini
Change-Id: I9251205c47f26be7695496b5887b849fcf1335f1 Reviewed-on: https://gerrit.libreoffice.org/82814 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16tdf#128257 Bullet and Numbering Dialogandreas kainz
Change-Id: I0931f7207e1533d6cb552cecbcf2872024f2bafe Reviewed-on: https://gerrit.libreoffice.org/82973 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-16tdf#44462: add a link to Windows Default apps settings appletMike Kaganski
Add "Windows Default apps" button to Options->General to run system applet to control file associations, in accordance to recommendation from MS [1]. On Windows 10, though, the call to LaunchAdvancedAssociationUI would only bring a system-modal infobanner suggesting the user to go to Settings > Apps > Default apps, as documented at [2]. Since this is what MS considers the correct way to manage application associations, the infobanner should be enough. [1] https://docs.microsoft.com/en-us/windows/win32/shell/default-programs [2] https://docs.microsoft.com/en-us/windows/win32/api/shobjidl/nf-shobjidl-iapplicationassociationregistrationui-launchadvancedassociationui Change-Id: I79cccdd00afac998c028b8e151db66bbd75be985 Reviewed-on: https://gerrit.libreoffice.org/82777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16tdf#128721 Options -> View Dialog updateandreas kainz
Change-Id: I3e769846c1dd5d57e62276a624fb209ca6bd7673 Reviewed-on: https://gerrit.libreoffice.org/82473 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-16tdf#128725 Options Update Dialog changeandreas kainz
Change-Id: If0fa8dddfc0c431b89fad071388f3f9c4fcb40c7 Reviewed-on: https://gerrit.libreoffice.org/82475 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-16tdf#127807 Border Dialog updateandreas kainz
Change-Id: I35219c6c59d1bb6614ad1fa64cc0689f2019c986 Reviewed-on: https://gerrit.libreoffice.org/81115 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-15Resolves: tdf#128802 manage dnd ourselfCaolán McNamara
instead of relying on the built-in dnd which is allowing toplevel entries to be dropped on other ones to become children of another entry, which is not what we want here. Change-Id: I8c5528d9b26e994b7eda9d2972af0b3783187f3e Reviewed-on: https://gerrit.libreoffice.org/82769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15tdf#127294 add tip about removing multiple hyperlinksSeth Chaiklin
Change-Id: I465d459dce8bd279cb3052d4563340efc3092ec7 Reviewed-on: https://gerrit.libreoffice.org/82691 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15Revert "tdf#126128 Reduce page properties dialog's height."Heiko Tietze
Discussion in BZ. This reverts commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368. Change-Id: I01e23a7eeaa78d60f106dfa67a54ff9d7904cb19 Reviewed-on: https://gerrit.libreoffice.org/82698 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-15Revert "ensure gtk creates a default label widget for the MenuButtons"Heiko Tietze
Discussion on BZ, have to revert this patch first. This reverts commit 3937d3d035a03530b78acc648c07b6e099fb6770. Change-Id: I8ab49e7296bc403f2706f986b2711025f468c4be Reviewed-on: https://gerrit.libreoffice.org/82699 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-14Options Dialog MSO Tab updateandreas kainz
Change-Id: I3bc0b2f5a42f6e01e0f78ef7d1b80a2bbe8ba7cc Reviewed-on: https://gerrit.libreoffice.org/82558 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-14simplificationSeth Chaiklin
Change-Id: I2936b64a3543f8b88fb7a44bd60871d4ec22f45c Reviewed-on: https://gerrit.libreoffice.org/82622 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>