summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2023-02-24tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatCollMichael Stahl
Leave editengine and non-paragraph usages of SvxLRSpaceItem as-is for now. Add new items RES_MARGIN_LEFT etc., order them so that paragraphs can have 3 consecutive items RES_MARGIN_FIRSTLINE..RES_MARGIN_RIGHT and non-paragraphs also have 2-4 consecutive items RES_MARGIN_RIGHT..RES_MARGIN_LEFT (only the 3 paragraph ones are actually used now). The HTML import filter is particularly annoying because it parses CSS stuff into SfxItemSets without knowing where the items will be applied, so it can't know whether to create SvxLeftMarginItem or SvxTextLeftMarginItem... the split items are created in ParseCSS1_* functions and then converted later if necessary. WW8 import has some weird code as well, SwWW8ImplReader::Read_LR() creates 3 items and then something wants to set every item on its own so SwWW8FltControlStack::SetAttrInDoc() turned out rather weird. Convert the paragraph dialog to handle the split items (by mapping them to SID_ATTR_PARA_FIRSTLINESPACE/SID_ATTR_PARA_LEFTSPACE/ SID_ATTR_PARA_RIGHTSPACE), but the SvxRuler looks a bit more confusing so convert in sw shells for now and leave that for later (also unclear if changing these slot items like SID_ATTR_PARA_LRSPACE breaks any ABIs?). Change-Id: I40431821868fd3e1cceba121b5539ff9ae6befbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147024 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-23Don't call CuiResId() in a global static variable initialiserTor Lillqvist
Instead, have a function that returns a reference to a local static variable. That local static is then initialised only when the function is called for the first time. Calling CuiResId() in a global initialiser is a bit questionable, and causes an uncaught exception when LO core is used in a WASM app. Possibly it would also have been problematic on other uncommon platforms. Change-Id: I4fd799ba3aa8d63fd3db1eb8cf6211aeed904ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147512 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-22(related tdf#153417) rename "Back" to "Reset"Seth Chaiklin
Change-Id: I70c79f7a40889bcca3aed3d2309779091967a2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146532 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-02-22tdf#142942 Drop unused checkbox col in sw AutoCorrect opts dialogMichael Weghorn
While the extra checkbox column enabled by weld::TreeView::enable_toggle_buttons(weld::ColumnToggleType::Check) is used for the non-Writer case in the "Options" and "Localized Options" tabs in the AutoCorrect options dialog, they are not used in the case of Writer, where there are two columns of checkboxes handled separately ("[M]: Replace while modifying existing text" and "[T]: AutoCorrect while typing"). Before commit 714b2b617e9baef02510c482c6fd028e6e72acd8 Date: Tue Jun 30 15:03:31 2020 +0100 tdf#134270 rearrange so we know the final treeview width , setting column widths manually by calling `weld::TreeView::set_column_fixed_widths` would disable the extra space for the (unused) checkboxes (by setting `m_bDisableCheckBoxAutoWidth`). Since that commit, it no longer does, causing the separately handled real checkbox in the first visible column to be unnecessarily positioned further to the right in this dialog for Writer for the non-gtk case. Fix this by dropping the use of the unused checkbox column for the Writer case, i.e. the `bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and in `OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage`. The handling for the non-Writer modules (i.e. `!bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and `OfaAutocorrOptionsPage`) remains unchanged. Change-Id: If7bd216fc4efda506817cffb55230722bb2ac89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-02-21tdf#143660 Make color scheme names translatableRafael Lima
The color scheme names defined in UI.xcu are currently not translatable. This patch makes them translatable by mapping the names in the UI.xcu file to a translated string. Change-Id: I10ab3bbcc9b028955c3c179558f8040b3b1d6c9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145732 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2023-02-20cui: rework uitest to work with --without-javaXisco Fauli
Change-Id: I6ed187f515b47b7e54ed85c08ee9523f1b777575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147335 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-19grammatical/typographical corrections to one tip of the daySeth Chaiklin
Change-Id: If2de87c859ca4cd59cfb92fd64648be400df187f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147252 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-02-17tdf#153549 change tip-of-day about chapter numberingSeth Chaiklin
- rewritten in form of a question - generalized to refer to headings, because not limited to chapters - added additional detail about relevant location in dialog, but did not attempt detailed explanation, because.... - added link to relevant help page - added missing period. Change-Id: Ie16c116b8e51e6b24de2c4060fee9617c6ef1e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147121 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-16tdf#152506 "titles" -> "headings" in tips of the daySeth Chaiklin
- one tip is generalised from "Heading 1" to all headings. - another tip has its formatting improved and a tab name corrected. - for both tips, link added to relevant help page. Change-Id: I394773d2b7af5434f708fe188f86d7f8a2b16e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146914 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-15list icons in .hlst files otherwise they might not get packed into iconsetCaolán McNamara
Change-Id: I64cb4b4f12189f402334fff185d8fdf0db4e4536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15move the sc_additionsdialog.png into the .uiCaolán McNamara
the mechanism for determining that an image is in use in order to not pack unused icons only scans .ui and .hlst files, not all source code, so this was fragile Change-Id: Ic06c6a451cff3def8547b3ab085be70f6870054e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147080 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15tdf#153172 Options > Charts > Default Colors no longer persistentNoel Grandin
regression from commit b95142c11e80c58b70dff68bfd7f3792657b9ee2 Author: Noel Grandin <noelgrandin@gmail.com> Date: Mon Jun 20 19:17:00 2022 +0200 tdf#58134 Reset Button in Options Dialogs Change-Id: Idef9880e29c322ae2d11641354baf8a241fc7fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-14tdf#150045 A few more supplemental labelsAdolfo Jayme Barrientos
Change-Id: Ifc0afe5c04145378b5fe32b12791c774d96f8a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146903 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-11set the image in the .ui instead of the .cxxCaolán McNamara
Change-Id: Id6c30fa9cad6bbfbfb4e5c1363f637868884b345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-11Related: tdf#153229 use 'System' instead of 'Automatic'Caolán McNamara
in the macOS desktop settings "Automatic" is used to indicate that the theme changes automatically from light to dark over time, "System" does seem a little less ambigious as to its meaning here. Change-Id: I38f6007cca1e8942d77066db200208ca463368d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146743 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-10Resolves: tdf#153497 update automatic icon-theme name on dark mode changeCaolán McNamara
Change-Id: I6b41d04ad902d5b123a110b52426ea2c2de79e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-09tdf#95936: Tooltip not updated in Toolbars after change ShortcutJuergen Funk
The update of all toobars after change the shortcut was missing, this patch update the toolbars now Change-Id: Ibc896dc48c9143307b028a3c271476482111c2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146678 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-02-09tdf#153229 add an extended tip for this new widgetCaolán McNamara
and fix mnemonic target Change-Id: Iad68048a6f0f824b774306033fdbbfe65b152804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-08tdf#153229 add a switch to override honoring system dark modeCaolán McNamara
Change-Id: Iafb6182e05dc65d20d0809476ee58908f7426d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-07improve readability of VirtualDevice constructorNoel Grandin
(a) It is not obvious what DeviceFormat::DEFAULT means (b) There are two parameters (each with two states), but only really 2 possible overall states So (1) use more useful names (2) combine the two parameters into one enum Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-03tdf#153023 Disable Thousand separator for NatNum12Laurent Balland
Add some helper to get NatNum12 state Modify both Number format dialog and Sidebar Transform CAT_ defines in enum Change-Id: Iaa3127bf07223caac60e409306a1bee2edc37428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145513 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-02-02Related: tdf#152642 match spacing and layout of other option pagesCaolán McNamara
Change-Id: I289303ec071e4bc48388ab34f5327b7648121338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146491 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02add missing mnemonic-widgetCaolán McNamara
Change-Id: Ib0b53fe8fed8ca1d53b7691a8609ce1e14bcce89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02match spacing and layout of other option pagesCaolán McNamara
Change-Id: I18c398762f92a28d72dae3ae76991553e9ebb04c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146489 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02resave with latest gladeCaolán McNamara
Change-Id: I747aabe874474151b52127840cf6235448c82a8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02use more standard spacing values and patternCaolán McNamara
Change-Id: I6e7b0f442c8551c1c989473f892c41dde7b55565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02resave with latest gladeCaolán McNamara
Change-Id: If8035f18e676e19ba9053accf8997a3fe297a4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-02add truncate-multiline for consistencyCaolán McNamara
Change-Id: I62de1820479f658076621ec0a62df967055adc4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-01fix invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
since: commit 660b7ed484efcac1e5b841e0b04f3c9628578448 Date: Fri Jan 6 11:08:36 2023 +0100 Resolves tdf#101731 - Rename Border/Midpoint Change-Id: Ie226e768ce902a8fff30f2883e0ea22b94e96949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-01add missing id-columnCaolán McNamara
Change-Id: Ia6b1a4daa2a3327faa33d60289c4dd4c12deefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146441 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-01add truncate-multiline for consistencyCaolán McNamara
Change-Id: I21263263ec9fc9d9e39e7b2ec32b54a7a75323a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146438 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-01reformat to the same indent as everything elseCaolán McNamara
git show -w is no change Change-Id: If9ed97301c6c6bb9a025bf61c747d0adf0a17762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146440 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-01cui: Make SimilaritySearch dialog async and enable use for jsdialogHannah Meeks
Change-Id: I89c6665138c94aa355efbbc4aa0947226c68af5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146130 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-01-31Restore changes accidentally overwritten in ↵Adolfo Jayme Barrientos
1fb964276c184b0fb052503fe7dbc05bf0331211 Change-Id: I3630a1fe1365593103b1670926d4e7aa318d9a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146374 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-31sd: use XTheme to transport the theme to xmloff import/exportTomaž Vajngerl
Refactor the existing places and tests in Impress code (sd) to use it instead. Also keep the old property of construction and view of the theme with a sequence of property values, but under the new property named "ThemeUnoRepresentation". This is needed by the UI tests currently. Change-Id: I484567f4a603f1a5e2e03955fdd2b63132dcc66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146225 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31svx: Refactor (sdr) views to access the SdrModel by referenceTomaž Vajngerl
In SdrPaintView (and subclasses) the mpModel variable is always the same as the input (reference) model, so there is no need for that extra variable. Change the strange and confusing var. name mrSdrModelFromSdrView (the input reference to SdrModel) to just mrModel and use that in GetModel(). Change the GetModel() to return a reference instead of a pointer and reactor the code to accomodate the change. This gets rid of many nullptr checks for the pointer that the GetModel() returns and makes the code more simple is some cases. Change-Id: I18351a417fd82f49262a83de036ec1420a65399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-30cui: add entry "RestProtocol" to language tool dialogHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I6511fc2b353c47b1ff537c42d3484b3a42c1b121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143106 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145596 Tested-by: Jenkins
2023-01-30Added option to disable ssl verification for languagetoolMert Tumer
This will allow to use self-signed certificates with local run languagetool APIs Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145594 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-01-27fix online crash in SpellDialogNoel Grandin
program/libmergedlo.so EditEngine::GetUndoManager() /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173 program/libcuilo.so svx::SpellDialog::InitHdl(void*) cui/source/dialogs/SpellDialog.cxx:2016 program/libmergedlo.so ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) include/rtl/ref.hxx:128 program/libmergedlo.so SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) vcl/headless/svpinst.cxx:317 Change-Id: Icd79faea8b066e0725c5d96f5d9b64445578f3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146091 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-26Upgrade mdds and orcus to 2.1.0 and 0.18.0, respectivelyKohei Yoshida
Change-Id: I288b5b54bd07d951bcc68afda7514bde730193dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146107 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-01-24tdf#153076 Make Basic editor background color independent from document colorRafael Lima
This patch creates a separate color configuration entry for the background of the Basic Editor (svtools::BASICEDITOR). This allows the user to set the color of the Basic Editor independently from the color used as document background. Currently the color used is DOCCOLOR, which means that if the user wants to use a different color in the Basic Editor, they must change the document color as well. However, the user may want to use f.i. a dark background in the Basic editor while maintaining a white color for documents, which is currently not possible. By default, both color schemes "LibreOffice" and "LibreOffice Dark" use the same color for DOCCOLOR and BASICEDITOR to replicate the existing behavior. But now, if the user wants to use a different color for the Basic Editor, than it's possible to change it without affecting the color of documents. Change-Id: I2f33b1ccb497d7e22faab7fa48cb96841785ce99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145590 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-19jsdialog: add TreeView to TestWidgetDialogSzymon Kłos
Change-Id: I5c4f70d98dd8ea03c137cd368a2c097cd866609d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144222 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145067 Tested-by: Jenkins
2023-01-18missing colons in Character - Position dialogSeth Chaiklin
Change-Id: I78634677fff9b1a2f4955e7a1483662fc6b231c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145717 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-17tdf#152637 format cells example text black on dark backgroundCaolán McNamara
with application colors, scheme: LibreOffice Dark enabled Change-Id: I56ac48ec2e6afd77f20a8581c6d872942618d802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145667 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12introduce docmodel comp., model::ThemeColor, use it in SvxColorItemTomaž Vajngerl
Added a new component docmodel, that has the document model types, which only depend on other basic components. This is needed so the types can be used in every relevant component - xmloff, oox, svx, editeng,... Introduces model::ThemeColor, which is a class used to store the theme color data, including transformations (svx::Transformation). For UNO use XThemeColor is added, and the implementation UnoThemeColor which wraps svx::ThemeColor, so it can be tranported around. Reactor all the code and tests to accomodate for this change. Change-Id: I7ce6752cdfaf5e4d3b8e4d90314afa469dd65cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144847 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-10Make DeepL translator experimental for nowAron Budea
Needs documentation. Change-Id: If77436a37b5ec40f3eb08a32f0315c1696428c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145184 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-06Resolves tdf#101731 - Rename Border/MidpointHeiko Tietze
Follow up to Icda875d3c6f03ffd29395ac5ce932475cc629361 changing "Midpoint" (formerly "Border") to "Transition start". Using the same name for transparency. Change-Id: I1f1c53ee357a9ead94100156598f43a0ac021d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145141 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-06tdf#56258: allow i18npool to define SvxAdjust for outlineJustin Luth
Deciding whether the numbering should be Left, Right, or Center is a rather important setting. Specifically for Roman numerals (which grow very wide as they increment to 7 and 8) the numbering styles set these to right aligned. This really helps for keeping the text nicely aligned. The numbering styles are built-in LO defaults, but locale files can define numbering and outline choices. This patch add the setting for "adjust" on the outline levels. For en_US, it makes sense to right-align roman numeral levels. [The only other highly likely candidate for this that I could find was old Hungarian (SZEKELY_ROVAS), but it doesn't seem to be used in any locale definitions.] I only changed en_US for now, but of course many other locales are also using NumType="3" and NumType="4". This only applies to the toolbar/sidebar SVX code path. The Bullets and Numbering dialog does not currently modify any spacing, so I didn't apply the adjustment either. It also doesn't make sense to do this on single numbering changes (aka ContinuousNumberingLevels or LC_NumberingLevel) because we don't know or control the first line indent there either. But at least for toolbar Outlines, we do change every level, and so can set a (somewhat) appropriate spacing. [Setting SvxAdjust without adjusting the spacing is pointless. Don't make any changes at all if the spacing ends up causing problems.] The Numbering IVX/ivx styles set the firstLineIndent to -174, so I did the same here. This is the scariest part of this change. AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default, so hardcoding that for undefined LC_OutlineNumberingLevel shouldn't be too scary. Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144978 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05tdf#56258 en_US: increase outline levels definitions to 6Justin Luth
There are 10 levels in numbering, so it only makes sense to allow outline definitions for all 10 levels. Note that DOC/X formats only allow 9 levels, There are two code paths that read these definitions. The SVX toolbar code to allow 10 levels (SVX_MAX_NUM) was already completed in the previous patch. This commit allows 10 levels for the Bullets and Numbering menu dialog. Since all choices MUST define the same number of levels, I only added one more. I hope that there isn't some secret kind of requirement that ALL LOCALE's must also use the same number of definitions - it doesn't seem to. [Although not a direct comparison, bg_BG defines 10 single number levels, compared to en_US's 8, and some Chinese locales also do more than 8.] Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-03jsdialog: fix validation error dialog in CalcSzymon Kłos
Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144951 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-02 21:49:53 +0000