summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxSearchFormatDialogNoel Grandin
Change-Id: Ie7da9255e27734f93f7a7758ca9ec25108c0e547 Reviewed-on: https://gerrit.libreoffice.org/56104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SfxAcceleratorConfigPageNoel Grandin
Change-Id: I12c6ca5542729d4af77a7d4253ea1bbaae81781c Reviewed-on: https://gerrit.libreoffice.org/56096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20fix new a11y warningCaolán McNamara
Change-Id: I637c48335bb8e532bb8bad3b05e60fb1c06f6414
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxFontSubstTabPageNoel Grandin
Change-Id: I3e9e1c91f541c7e191ceb3d7ee6974fa46d26c6b Reviewed-on: https://gerrit.libreoffice.org/56101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in AlignmentTabPageNoel Grandin
Change-Id: I78dc902ae41eb8d8423c83a4ec32a4ca932bbc5e Reviewed-on: https://gerrit.libreoffice.org/56103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxDefaultColorOptPageNoel Grandin
Change-Id: I398ba3828bddf295e99624d7caa8d636e96c360c Reviewed-on: https://gerrit.libreoffice.org/56100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxColorOptionsTabPageNoel Grandin
Change-Id: Iefd1719a4f9c529840b4c584df8c7f2104d29fb3 Reviewed-on: https://gerrit.libreoffice.org/56102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in IconChoiceDialogNoel Grandin
Change-Id: I4a97cd8497056b48f8fb6439b2dc428887e0a0b9 Reviewed-on: https://gerrit.libreoffice.org/56098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxCharacterMapNoel Grandin
Change-Id: I85e254fc59b4b0954bbed3876935f56e6480f525 Reviewed-on: https://gerrit.libreoffice.org/56097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in TPGalleryThemePropertiesNoel Grandin
Change-Id: I4a288f9bd1b8abd7c588c1c895c8b6a8ef399fc2 Reviewed-on: https://gerrit.libreoffice.org/56099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20personalization: disable "own theme" button if we don't have anyNoel Grandin
Change-Id: I3a5bfb757361208ce4ec193698a6e87b66285906 Reviewed-on: https://gerrit.libreoffice.org/55846 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-19tdf#118212: fix crash with character formatJulien Nabet
see bt: https://bugs.documentfoundation.org/attachment.cgi?id=142938 Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=3aa8a048776bdf0d4868847baac2a72aa55cd6a3 Change-Id: Id4705865dac5f337f30ca7118a6b29735075b295 Reviewed-on: https://gerrit.libreoffice.org/56124 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-18set explicit parent for signing warning messagesCaolán McNamara
Change-Id: Ifbd1aaec13e2f3a51963c4942face64847eefc07 Reviewed-on: https://gerrit.libreoffice.org/55989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17weld SvxPageDescPageCaolán McNamara
Change-Id: I5e2457b51a294cbdacc5c78db4ec0a048567b93d Reviewed-on: https://gerrit.libreoffice.org/55877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16tdf#58941 Manipulate with font features using FontFeatureDialogTomaž Vajngerl
This adds a font feature dialog activated on the Character page, which adds a way to manipulate the available font features for the current selected font (by adding them to the font name). Change-Id: Icd0eda31b235d3cc8ef6eaee582fb78b4b346d78 Reviewed-on: https://gerrit.libreoffice.org/55894 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-14weld SvxStdParagraphTabPageCaolán McNamara
Change-Id: I02b0f2e4f049b407a3ac0c7f304cbcd0cc652749 Reviewed-on: https://gerrit.libreoffice.org/55818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxParaAlignTabPageCaolán McNamara
Change-Id: I843b264d44266213e91b7e75bf35e4f6cf41dd88 Reviewed-on: https://gerrit.libreoffice.org/55792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14loplugin:unusedmethodsNoel Grandin
Change-Id: Ibd9f4757ec26da7acc645f33573ace3280e84834 Reviewed-on: https://gerrit.libreoffice.org/55788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14weld SvxExtParagraphTabPageCaolán McNamara
Change-Id: I6836bc659f28ebae35ed0ca33ffd9425212c3622 Reviewed-on: https://gerrit.libreoffice.org/55784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxAsianTabPageCaolán McNamara
Change-Id: Ib1e229a9780dd0959ce847a2d4c15eab7fb92c33 Reviewed-on: https://gerrit.libreoffice.org/55769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharTwoLinesPageCaolán McNamara
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12weld SvxTransparenceTabPageCaolán McNamara
Change-Id: If8c8a6cf74664f9acd360d877c57e8dd9de2f2b5 Reviewed-on: https://gerrit.libreoffice.org/55683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12fix leak in SfxApplication::OpenDocExec_ImplNoel Grandin
when calling Link on SfxLinkItem, none of the callee sites free the memory associated with the Clone()'ed SfxPoolItem, so just skip the cloning, and make the Link take a const pointer to make this more obvious. Change-Id: Icd187e9d8d3ace9bf2e6ff183489999b105708e4 Reviewed-on: https://gerrit.libreoffice.org/55671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unusedfieldsNoel Grandin
Change-Id: I42a55562747e6097c1193e285da67235f5364bea Reviewed-on: https://gerrit.libreoffice.org/55610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#114875 Added an option to not show "No offline help installed" popupNickson Thanda
Change-Id: I8067c0c374af57f5ad8e6f5fffd3a9783521824f Reviewed-on: https://gerrit.libreoffice.org/55254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-11new loplugin:shouldreturnboolNoel Grandin
look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in SvxToolbarEntriesListBoxNoel Grandin
Change-Id: Ied01f97a09d34c43f786c030fbdd256bcf849f04 Reviewed-on: https://gerrit.libreoffice.org/55535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in HangulHanjaEditDictDialogNoel Grandin
Change-Id: Ic1e98a7efdd75a6c940c5ce81bfb414711c4ab37 Reviewed-on: https://gerrit.libreoffice.org/55534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:useuniqueptr in FmSearchDialogNoel Grandin
Change-Id: Icf2a8f2b334b1a0b9a7028fb1718710dd67c7a81 Reviewed-on: https://gerrit.libreoffice.org/55533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09remove cargo cult OSL_ENSURE(pFact, "ScAbstractFactory create fail!"(Noel Grandin
Possibly this was useful once upon a time, but now it's just noise. If it failed, we're going to crash on the next line when we call a method on that pointer anyway. Change-Id: Ic601f0c3344f6895f8a6ffb3bc6f8bcb45d00a92 Reviewed-on: https://gerrit.libreoffice.org/55082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07tdf#88961 change table line style color to make it more visibleNickson Thanda
Table line styles are now black and 0.05pt. Change-Id: Ifa613c2c26ecb97e2d466e94a21c4120065969c9 Reviewed-on: https://gerrit.libreoffice.org/54461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-06-06tdf#37336 Added Apply button in options dialogDiadlo
Change-Id: Ibdcad8101fbd4a0344fb82d3e5d03774d1b125dc Reviewed-on: https://gerrit.libreoffice.org/54980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-06-05Related: tdf#117866 cui: use std::atomic for thread termination flagMiklos Vajna
Change-Id: Ia9185312b12fdbc1f5fe5ec48417aec3c5b8d4bf Reviewed-on: https://gerrit.libreoffice.org/55320 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04tdf#117866 cui: avoid deadlock in personalization dialogMiklos Vajna
The deadlock happened as the main thread wanted to join SearchAndParseThread (while owning the solar mutex), but SearchAndParseThread wanted to take the solar mutex to import a graphic. Fix the deadlock by checking for the termination flag earlier, so we don't take any new mutexes if termination was requested already. Change-Id: Idddaadadc693610d9f31a14300b22aff8d452756 Reviewed-on: https://gerrit.libreoffice.org/55284 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-03stray debug codeCaolán McNamara
Change-Id: Idc779be7522d7b3875be73aad2e703fc87d8c9bf
2018-06-02weld SwSectionFootnoteEndTabPageCaolán McNamara
Change-Id: Ib4246a2f90780a005e79e2d071b43a5629a3242c Reviewed-on: https://gerrit.libreoffice.org/55216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-02Removed executable permission on source fileAndrea Gelmini
Change-Id: I6f49685efe7b902f42229be000a5ef6f08923086 Reviewed-on: https://gerrit.libreoffice.org/54049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02tdf#105225 A section background tab page based on the area tab pageJim Raykowski
Change-Id: Ibe758cab371bc53207bd2ca617d123b7d660a774 Reviewed-on: https://gerrit.libreoffice.org/55149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-01tdf#96099 Remove some trivial typedef std::vectorArkadiy Illarionov
Change-Id: Iaba48932dde059c88401ee60f7aac0048a79e9eb Reviewed-on: https://gerrit.libreoffice.org/55045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01drop Image(Bitmap) constructorNoel Grandin
and convert some more code from Bitmap to BitmapEx Change-Id: Icf3c18608e0bb608408fe69722441cfa19f6b161 Reviewed-on: https://gerrit.libreoffice.org/55160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-31SOSAW080: Cleanup of SdrModelArmin Le Grand
First step: Find all constructors/derivations, mark all of them. Removed two-value-constructors, adapted code as needed Reduced constructors for SdrModel/FmFormModel to a single one. Removed PathName for List creation, this is not needed and anyways all calls used the default SvtPathOptions().GetPalettePath(). This is also true for usage of IsFuzzing() that is also part of the default creation process (without path). All usages that need an extra-List were setting it after construction explicitely. Removed UseExtColorTable. This prevents a single List to be not created by default, the ColorTable which is replaced later by all callers that used this. This is not needed since the default ColorTable gets constructed just by default, no expensive stuff is triggered (e.g. loading the ColorTable). Thus now a default ColorTable is created and kept for a short moment, destructed again when a ColorTable is explicitely set. Doing so is also more safe - it avoids not creating a default-ColorTable and then not setting one (what would be urgently required). f23c24a8548d5246b77b1cc359ba89564538e81a f124468c3898c5842d37123bdeb87d79a2b19c62 Change-Id: I865de4bb23f673c6684d83c2c6390439506dc5b6 Reviewed-on: https://gerrit.libreoffice.org/55028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-31drop Graphic::GetBitmapNoel Grandin
so that we flush out various code using Bitmap, in favour of using BitmapEx. This is part of the process of making Bitmap largely an internal detail of vcl Change-Id: Iaf2ead5e3d9960838723fb55b812b97108093d74 Reviewed-on: https://gerrit.libreoffice.org/55062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30Fix conditionSamuel Mehrbrodt
Change-Id: I977eae208bd12886d25679d4c75308d51245766a Reviewed-on: https://gerrit.libreoffice.org/55057 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-30use BitmapEx in the screenshot stuffNoel Grandin
part of the process of moving Bitmap usage to BitmapEx Change-Id: I4f02f8aa60d19a3639d623a998491447adf79e15 Reviewed-on: https://gerrit.libreoffice.org/55031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-15 06:05:11 +0000