summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-07-29Merge identical switch cases in SvxCaptionTabPageMuhammet Kara
Change-Id: I515c64191d7a9defc3e175c18d8be1f198e03160 Reviewed-on: https://gerrit.libreoffice.org/58267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29Merge identical switch cases in SvxTransparenceTabPageMuhammet Kara
Change-Id: I463a947de16fee3b361a429c7dc3ef69bd507617 Reviewed-on: https://gerrit.libreoffice.org/58268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28loplugin:stringloop cui,dbaccessNoel Grandin
Change-Id: I32b63d2435d36b869823ea022ebd7f8347a46ea0 Reviewed-on: https://gerrit.libreoffice.org/58211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28Remove unnecessary theUICommandDescription.hpp includesMuhammet Kara
from the Customize dialog Change-Id: Ie7e87872b2427d0dda3de5a8333129cba492b26e Reviewed-on: https://gerrit.libreoffice.org/58189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Merge identical conditional branches in ViewLayoutUserHdlMuhammet Kara
Change-Id: I7e4d92dd12b00fa4d60cd667af780201b3246312 Reviewed-on: https://gerrit.libreoffice.org/58200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26It doesn't make sense to have document links in the online version.George Wood
Change-Id: I893845570e4bd2961797fa1c2dd3e5316c9d262d Reviewed-on: https://gerrit.libreoffice.org/58008 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-25tdf#118777 cui: use right XText in SignatureLineDialogMichael Stahl
Writer has multiple nested XText and we have to call insertTextContent on the one that corresponds to the xCursor, so use the convenient getText() instead of hard-coding the body text. Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36 Reviewed-on: https://gerrit.libreoffice.org/57969 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-23Fix typosAndrea Gelmini
Change-Id: I4bb060a6a65ca27bba8d16c268660bedef8b0ed5 Reviewed-on: https://gerrit.libreoffice.org/57821 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Set can_focus true for Area tab page Bitmap listboxJim Raykowski
can_focus property needs to be true for tab navigation to stop here Change-Id: If9ed0cefc652369243d623a311ba92e2941bd43f Reviewed-on: https://gerrit.libreoffice.org/57834 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-22coverity#703935 Unchecked return valueCaolán McNamara
Change-Id: I31ce141955a3beadb60368fc8238bfe0507b1566 Reviewed-on: https://gerrit.libreoffice.org/57782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-19tdf#118304 reselect current glyph on changing fontCaolán McNamara
preview glyph will rerender the glyph if its there, or the glyph description changes to "missing glyph" if its not there anymore. Don't auto select first entry of the subset when font changes, leave it as unselected and let the glyph determine what's ends up there Change-Id: I33d7dd3a071100175ac9bc7c7e9d44684a1aff28 Reviewed-on: https://gerrit.libreoffice.org/57724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19tdf#117038 set button width to max possible content widthCaolán McNamara
Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba Reviewed-on: https://gerrit.libreoffice.org/57717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19tdf#118816 recover initial intent of enabled possibility of tristate as a flagCaolán McNamara
Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6 Reviewed-on: https://gerrit.libreoffice.org/57712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19Resolves: tdf#118115 add missing help response idCaolán McNamara
Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c Reviewed-on: https://gerrit.libreoffice.org/57715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#104277 - Added restart buttons to OpenCL restart dialogNickson Thanda
Change-Id: Icf31d0516deb7844c8be1003219cbacae1cdc5ec Reviewed-on: https://gerrit.libreoffice.org/57537 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-17Related: tdf#118681 use a case insensitive compare for hex digitsCaolán McNamara
Change-Id: I7b177d2772a86cada37c20056794bc1d8ab50991 Reviewed-on: https://gerrit.libreoffice.org/57563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17loplugin:useuniqueptr in SvxAsianLayoutPage_ImplNoel Grandin
Change-Id: I6380ccceabb9ce9c3c7c187e913e7384d8854b5b Reviewed-on: https://gerrit.libreoffice.org/57516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16tdf#118681 make sure we're using the right font char mapCaolán McNamara
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16tdf#118549 crash on dialog teardownCaolán McNamara
only an issue for the current partially complete interim case Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20 Reviewed-on: https://gerrit.libreoffice.org/57501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12SvTreeListBox::DoubleClickHdl: DbRegistrationOptionsPage more, tdf#115950 rel.Eike Rathke
Change-Id: I820ce28a4df108f17cbb65210834acae6b0f8946
2018-07-11font feat: prioritize Graphite descriptions, use UI lang., fixesTomaž Vajngerl
When collecting font feature description do prioritize Graphite collected descriptions over OT. This is important for descriptions for ssxx and cvxx only contain general description and not what exactly they do. When collecting for Graphite use the UI language for descriptions. Fix gathering the descriptions with graphite to include all of the descriptions available. Change-Id: I6b3b92eb160fc3fd70214edf0d37095865f9c563 Reviewed-on: https://gerrit.libreoffice.org/57250 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08loplugin:passstuffbyrefNoel Grandin
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed-on: https://gerrit.libreoffice.org/57088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt
Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06tdf#117903 Add signature line feature to calcSamuel Mehrbrodt
Change-Id: I4e9121803a26cba1f40f8f1c673c7809543ef2ec Reviewed-on: https://gerrit.libreoffice.org/57015 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29Clean up SvxChartColorTableStephan Bergmann
* nNextElementNumber is unused since d57dfa29c2ba47293eb12a853cdccf4196565ef7 "Improvement of adding and removing color charts". * There appears to be no compelling reason to store sDefaultNamePre-/Postfix as members (but which are not even copied by the copy ctor). Just compute them whenever they are needed in getDefaultName (which is understood to not be a hot code path). * With those changes, the user-provided default and copy ctor can be left implicitly-declared, which avoids -Wdeprecated-copy (because the copy assignment op was implicitly-declared while the copy ctor was not) with GCC trunk towards GCC 9. Change-Id: I2bfa5f19c967e24407bf5b79adaf171200822f45 Reviewed-on: https://gerrit.libreoffice.org/56666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#117866 cui personalization: fix a possible raceMiklos Vajna
The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. Change-Id: I494c123a6225da60407391771622208c055ae49b Reviewed-on: https://gerrit.libreoffice.org/56585 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-28tdf#118429 Provide unsigned signature imageSamuel Mehrbrodt
when creating signature line. OOXML Export expects this. Change-Id: Ib6ab1f879c5ef27e8347002576ba95104117cadd Reviewed-on: https://gerrit.libreoffice.org/56576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-26tdf#118309 freeze/thaw adding large amounts to ComboBoxTextCaolán McNamara
Change-Id: I3072630c769224be730e6ec16b1a02fa4f1b10e6 Reviewed-on: https://gerrit.libreoffice.org/56485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26personalisation: check "Own Theme" button when clicking "Select Theme"Noel Grandin
to make it more obvios that the two belong together Change-Id: I8e0590679950e96802bab48cd78a8ef6b0a0b681 Reviewed-on: https://gerrit.libreoffice.org/55847 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-26loplugin:useuniqueptr in SvxEditModulesDlgNoel Grandin
Change-Id: I02f85df8e28ba53e22874b02c3134b1c48805ddf Reviewed-on: https://gerrit.libreoffice.org/56322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25followup fix for "tdf#109269 very slow loading of user-defined dictionary"Noel Grandin
i.e. commit 3b1f5ce3a37b09880b63f829bc0a349075fb6245 Change-Id: Ic03c9518fec2ca066bf31272cddd611b05c4773b Reviewed-on: https://gerrit.libreoffice.org/56391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25tdf#109269 very slow loading of user-defined dictionary word listNoel Grandin
this is about 10x faster for me Change-Id: I1d308c78dbdd04beaa432b546ba3b89bd617d57e Reviewed-on: https://gerrit.libreoffice.org/56378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in OfaViewTabPageNoel Grandin
Change-Id: I0a9f7fd5738a06ac60762b3242721df1634b4264 Reviewed-on: https://gerrit.libreoffice.org/56326 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in OfaAutocorrExceptPageNoel Grandin
Change-Id: If59ebc6cd5f73534e3e6c7e3765133c84d839958 Reviewed-on: https://gerrit.libreoffice.org/56325 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in cui numpagesNoel Grandin
Change-Id: I22eaeecb06bcf46cc494e8a0326922600e131cf3 Reviewed-on: https://gerrit.libreoffice.org/56324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SvxLineTabPageNoel Grandin
and move SvxBmpItemInfo inside cui/ since it is only used there. Change-Id: Ic80a8cace9e4664af18baddce3398e826e4c4851 Reviewed-on: https://gerrit.libreoffice.org/56323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in BackgroundPreviewImplNoel Grandin
Change-Id: If7a36baa663d052a9a41c126312abff185a14bdc Reviewed-on: https://gerrit.libreoffice.org/56321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22use Application::GetFrameWeld to tunnel weld::Window through XWindowCaolán McNamara
Change-Id: I137afe61acfb71337a45bedbe539b0096080e6cc Reviewed-on: https://gerrit.libreoffice.org/56246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21loplugin:useuniqueptr in SvxPatternTabPageNoel Grandin
Change-Id: I8b2493c723c65f90fd2dbef588c1fa1c669bcceb Reviewed-on: https://gerrit.libreoffice.org/56194 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxLinguTabPageNoel Grandin
Change-Id: I98e683bd23e854507c37e4d88a42a4c249bf5c44 Reviewed-on: https://gerrit.libreoffice.org/56195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxBackgroundTabPageNoel Grandin
Change-Id: Icfabf2bcbe49142871d6bef70ce0d73ed371a5b3 Reviewed-on: https://gerrit.libreoffice.org/56193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxMacroTabPage_Noel Grandin
Change-Id: I1720d624efee71611e8c2f7dab2aed22a0ecee10 Reviewed-on: https://gerrit.libreoffice.org/56192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxSecurityTabPageNoel Grandin
Change-Id: I36fc9076e2190e37bf002a384ee503442c5781df Reviewed-on: https://gerrit.libreoffice.org/56191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxNumberFormatTabPageNoel Grandin
Change-Id: If0fefe4a1e7af7331c708e7e944483ec3ce07614 Reviewed-on: https://gerrit.libreoffice.org/56190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>