summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-05-12tdf#130778 update About Dialogandreas kainz
Change-Id: I1ca538a3c5589b30d53404f1f8d8ab2dcc2586f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94018 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-11color drop downs missing their labelsCaolán McNamara
since... commit 1eb6210d678bbb0c875f0f72bd876a9e7795dfbe Date: Thu Apr 23 00:39:33 2020 +0200 tdf#132373 Remove blinking character property from the UI/editor Change-Id: I841577c0f8c58a8b742257775b6335603b9541db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08improve loplugin:referencecastingNoel Grandin
to catch a few more cases Change-Id: I0323fba51bb2b4ba255e1db5aa0d890c5c6a2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in canvas..cuiNoel Grandin
Change-Id: I7bd0c2a55b936896fcfe7e1a374871008a18618f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07Copy build ID in full lengthHeiko Tietze
Change-Id: Ic64f62cb0acc30efaaf24f9ce17c1f2d983c4e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93628 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-06tdf#132373 Remove blinking character property from the UI/editorGabor Kelemen
So far from document body and Character properties tab only. Importing and exporting existing files still works. Change-Id: I42179b47c64fe5c7db0393d0d4373363d772b51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92875 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05sw from-bottom relative orientation: add UIMiklos Vajna
And fix the value of LAST: it seems this went wrong in commit c2fc91664f71c447209d2cd29c0df1d7faba4927 (Convert LB flags to scoped enum, 2016-05-14), where the upper limit went from 0x80000000 to 0x080000, which means it started to matter if we allow equality or not. Other places compare LAST without allowing equality, so leave that unchanged and instead give LAST its own value. Change-Id: I0ceac18475f5f50b792c7a8442648c9ba2a25236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93477 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05Some improvements to About box and brandingHeiko Tietze
* Label left-aligned (tdf#132322) * Long build string cut at 25 chars * Extra text such as Tinderbox info wraps now at Misc * UI-Language shortened to just UI * More padding between about image and text * Splash screen uses Vegur font * Splash with small border * Non-TDF logos have a "Community Edition" text Change-Id: I1ec31e22052e365f28fe91de3e083252975911c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93444 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-04remove checkboxes for enabling OpenGLLuboš Luňák
The expert options still stay, but the checkboxes are a bit confusing when also the Skia checkbox is there, Skia is for now the default, and if Skia drawing goes well then the OpenGL drawing method can be slowly phased out. Change-Id: Iaea7e471f27010291abedb644d4728189345e3b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93408 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-03Related tdf#131125: Improperly used ampersandJulien Nabet
Really search all occurences of Find & Replace Change-Id: I1c1301451afa4d339902a275594ecb4cd46030db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93331 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-01Resolves: tdf#129702 take text from correct model columnCaolán McNamara
Change-Id: If9af51348e5a254a0c5ab621fa162cdda4565e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-30Drop obsolete variable stringsHeiko Tietze
Change-Id: I0cd96b3466f94681567663625aa662717630e92f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93220 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-29Remove tango icon theme, tdf#132022Rizal Muttaqin
Change-Id: Ifd1d3999d1c6eb9aba7919850859e6b7cb652e3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-29Resolves tdf#132322 - Link to Gerrit hash reintroducedHeiko Tietze
Mulit-line label split, Build realized as link_button Required changes also solve tdf#132066 partially as many localized strings are not anymore copied to clipboard Change-Id: I346fdc65cd1734f17854eccd587fe0b7e216e720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93119 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-29tdf#132288 preservation of footnote depends on reverse iterationCaolán McNamara
like TextCharAttribList::FindAttrib does which spell checking used before commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog converted to use an EditEngine instead of a TextEngine in order to be able to host it in a native widget Change-Id: I190429fdab6e32572f2d6df94ab8e375bb4c0c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-29weld SfxTemplatePanelControlCaolán McNamara
Change-Id: Ib3f6d01ddec37afc3987423dc15ab84ad6475f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-29tdf#131733 Show only CN part of X.509 subject infoGabor Kelemen
The problem was that the whole Subject info was returned from X.509 certs if they did not start with one of "CN", "OU", "O", "E" Instead of extending this list with random keys, pass the type of cert and only return the whole Subject info if it's an OpenGPG one, and process the info unconditionally if it's X.509 like before the OpenGPG integration Change-Id: I1aa5d7285e48b0f4a769a073cdfb7732e482792c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92675 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-28nStartPosition and nEndPosition are always the sameCaolán McNamara
Change-Id: I6129a6696c36e3f907a0e7b5209613cdc858ff4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-28loplugin:makeshared in cuiNoel Grandin
Change-Id: I018df0fc3ee6e07d48d9f30544e7aa8492a6ade0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26update pchesCaolán McNamara
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename SvtValueSet back to ValueSetCaolán McNamara
Change-Id: I51ab96ffef7acc0d416d13ac8e380e49381f4d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename ColorValueSet back to SvxColorValueSetCaolán McNamara
Change-Id: I2036a8986d2d53fc97f1c7724e4e0ab837edc1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25remove newly unused ValueSetCaolán McNamara
Change-Id: Ia2c587af9846129278caf66ab504d1a1a1ac6256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92897 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25remove newly unused SvxColorValueSetCaolán McNamara
Change-Id: Iaf7243430e50df4db84f7032eaf52728cc779c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25weld SvxColorDockingWindowCaolán McNamara
Change-Id: Iabefa16f850d3d76017adfd77fb6be30ed467887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24Resolves: tdf#132288 don't merge adjacent properties for spell checkingCaolán McNamara
spell checking relies on each attribute chunk being unmerged with identical adjacent chunks Change-Id: Ia835fa054cad0dee4304f16724b9eb0c29b46102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24loplugin:unusedmethodsNoel Grandin
Change-Id: Ieec5099a8ce9fa3f07e36be244071efc1b101cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23pass SvxBrushItem around by unique_ptrNoel Grandin
we never create an object that is actually shared, so this is wasted Note1: in IMPL_LINK_NOARG(SwEditRegionDlg, OkHdl, weld::Button&, void) there was a comparison if( aBrush != pRepr->GetBackground() || ... which I removed Note2: In bool SwDoc::GetBoxAttr( const SwCursor& rCursor, std::shared_ptr<SfxPoolItem>& rToFill ) which had a condition else if( rToFill != xBack ) I changed to compare contents Change-Id: Idd769f44917c5ccc7e9f4bfbaddf12f9cd4151cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23sd position ad size dialog updateandreas kainz
Change-Id: I7bbfa7999d5b10db48d2c6aa6d66dc04c3891f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92630 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22Resolves build error from I4c2107b8120797a7cd532b59ca5ccb58ab61a2aeHeiko Tietze
Change-Id: I2791a51104d73daae5f140ee5b396aa2a64857ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92656 Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-21weld FontNameBoxCaolán McNamara
with custom row rendering Change-Id: Ia909b5b9ad56b6ea4611e9ea0a1e2cb0064a8cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20Resolves tdf#132180 - Stretched brand image at the ABout dialogHeiko Tietze
Explicitly centering the image solves the issue Change-Id: Ib5c4a7e772f01de72c19d74490f6a802378885ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92565 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-20Resolves tdf#132179 - Improve accessibility for the About dialogHeiko Tietze
Button added to copy version info Static text made non-selectable to avoid uncommon tabbing Change-Id: I4c2107b8120797a7cd532b59ca5ccb58ab61a2ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92418 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-17loplugin:flatten in cuiNoel Grandin
Change-Id: I0ea0784ab8c4542747da1e15fa7c60c60bccb602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16cui about dialog: don't ellipsize any textMiklos Vajna
I got "gt..." instead of "gtk3" without this. Change-Id: I1c666dec88f7cf2dbc48e864ce1a8ae724140697 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-14loplugin:buriedassign in c*Noel Grandin
Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09unnecessary usingCaolán McNamara
Change-Id: I3009edf99f6626a518941131a57b11e868622485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-05don't need vcl/lstbox.hxx in cuiCaolán McNamara
Change-Id: I631ff73fe49a8a3f41962c78887455f3d89a4e3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-01Avoid XOR paint in Crop dialogArmin Le Grand
Change-Id: I9d3709f9d2a09de1eaace916dc6033de13dbff86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91528 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-04-01fix ubsan after 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8Noel Grandin
ubsan exposed some bugs in commit 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8 Date: Mon Mar 30 15:11:55 2020 +0200 convert enum to scoped in SvBaseLink where I had converted the bit operations incorrectly Change-Id: I85bc0f0d69c34d9d714f983f82d4d26dd967f892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Related tdf#131333: Cannot change data point icons in Calc's XY chartJulien Nabet
Don't know if it's related but thought this log should be taken into account: warn:legacy.osl:68288:68288:svx/source/svdraw/svdpage.cxx:770: OSL_ASSERT: nNum<maList.size() At least, since we can know the number of objects, just use it to limit the loop Change-Id: I79ca467b6da8e22e3e7cd9fb5dc2451e2514316f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91327 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-24 17:30:43 +0000