summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-05-17tdf#107877: Don't crash if all bitmaps are deletedXisco Fauli
Change-Id: Ie21f8cf1ead7c75017ee09436102f87f5d5dc04c Reviewed-on: https://gerrit.libreoffice.org/37673 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-16tdf#107853 tdf#107854 Hide useless style familiesMaxim Monastirsky
Change-Id: I9918cbbf6b030e0f1f0a5dee153bedc8a53f91d8 Reviewed-on: https://gerrit.libreoffice.org/37688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-16loplugin:checkunusedparams variousNoel Grandin
Change-Id: I5d1cc807134230d86e0226a12fada204004312d3 Reviewed-on: https://gerrit.libreoffice.org/37675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16cleanup code in IconChoiceDialog::ActivatePageImplNoel Grandin
which has been this way ever since commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui And pass the SfxItemSet as a pointer up the constructor hierarchy, instead of a reference, since the base class wants a pointer anyway Change-Id: Iac4081fb5f3fc9cb9b0223f903d74ba84cdd5f6c Reviewed-on: https://gerrit.libreoffice.org/37664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-14tdf#107847 Make sure m_xContext is not emptyMaxim Monastirsky
Change-Id: I21d87b3a3d9732266e8c7d18cc07924700aaaafc
2017-05-14tdf#58134 Reset Button in Options Dialogues does not Work with all Options.melikeyurtoglu
Reset Button in Language Settings > Languages > Language Of > User interface option. Change-Id: I3bc18af185330035cfd0a14b50912ef7a2847fab Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14fix gdi resource leak with unreleased virtual deviceJulien Nabet
(copycat Markus https://cgit.freedesktop.org/libreoffice/core/commit/?id=289711c2a469bfbe06aef3b3870b65f9c788f56d) Change-Id: I3974609559dd44257d7c3e9e9544348d622953f6 Reviewed-on: https://gerrit.libreoffice.org/37586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-13tdf#107811: expert config, deal no parent caseJulien Nabet
bt part: 3 0x00007ffff73c7ee2 in __GI___assert_fail (assertion=0x7ffff7ba5107 "false", file=0x7ffff7ba4ef8 "/home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx", line=1399, function=0x7ffff7ba6d00 <rtl_uString_newFromSubString::__PRETTY_FUNCTION__> "void rtl_uString_newFromSubString(rtl_uString**, const rtl_uString*, sal_Int32, sal_Int32)") at assert.c:101 4 0x00007ffff7b6a28b in rtl_uString_newFromSubString (ppThis=0x7ffffffef1b0, pFrom=0x55555e122230, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx:1399 5 0x00007fffa6e69136 in rtl::OUString::copy (this=0x7ffffffef1f8, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00007fffa6fed67b in CuiAboutConfigTabPage::InsertEntry (this=0x55555bda0b20, pEntry=0x55555e13eb40) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:874 7 0x00007fffa6fed415 in CuiAboutConfigTabPage::SearchHdl_Impl (this=0x55555bda0b20) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:848 Change-Id: Id9d1003a0e5e52abb878229e710e3fd4612789a1 Reviewed-on: https://gerrit.libreoffice.org/37568 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-12remove unused uno::Reference varsNoel Grandin
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11SearchForAlreadyLoadedDoc does nothing usefulNoel Grandin
at least as far back as commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui Change-Id: Ic8284d722a6222d26fc33ef62be62435dde8e0bd Reviewed-on: https://gerrit.libreoffice.org/37462 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09tdf#103491 Show correct label for the current UI element typeMaxim Monastirsky
Change-Id: Ia7ad3c9e6d70fd47aa8346403682a17a70c5c237 Reviewed-on: https://gerrit.libreoffice.org/37432 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-09Resolves: tdf#62702 allow ole objects to be inserted as iconsCaolán McNamara
under windows on "create new", "further objects" you get the native windows insert object dialog which has the "Display As Icon" option, but on Linux etc (or using our own dialog) there isn't that option so add a "Display as icon" checkbox in our own dialog and generate an icon through SvFileInformationManager::GetImage Change-Id: I0a400189031900bd1e387465ec4ba57847cb5394
2017-05-09tdf#106225 Rename Table Format to Table Properties in Impress/DrawFakabbir Amin
Change-Id: I454d0d258f3948968ec4387f0ab655aa35087d23 Reviewed-on: https://gerrit.libreoffice.org/37416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-09tdf#106681 Styles category for the Add Commands dialogMaxim Monastirsky
Change-Id: I7332967863697d3ad68a533b9fc603de2fdc87ef Reviewed-on: https://gerrit.libreoffice.org/37422 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-09loplugin:constantparamNoel Grandin
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2 Reviewed-on: https://gerrit.libreoffice.org/37390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08cppcheck nitpicks variableScope and redundantAssignmentJochen Nitschke
Change-Id: I1399e066a96bbd9a3b59e2670a75b0022c882a1d Reviewed-on: https://gerrit.libreoffice.org/37354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08Set modified flag on entry renameMaxim Monastirsky
Tools > Customize... > Context Menus. Rename some entry, click OK. Open the dialog again, notice that the label modification wasn't saved. Change-Id: I78a7093e958d9d8709192ac34b6e0f178b7956de
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert cui module away from OSL_ASSERT to assertChris Sherlock
Change-Id: I685a9f9e352531d69e4a46bf305140f32d4ef642
2017-05-05loplugin:checkunusedparams in svx(part4)Noel Grandin
Change-Id: I032b49f4e1228ef275d7ff8d87ba969dcef687ab Reviewed-on: https://gerrit.libreoffice.org/37248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04document /italic/ and -strikeout- markupTiagoSantos
added in commit https://gerrit.libreoffice.org/#/c/31076/ former changes verified in: https://bugs.documentfoundation.org/show_bug.cgi?id=83037 Change-Id: I4b5973137edbec7bb430264867bf55b766248e1f Reviewed-on: https://gerrit.libreoffice.org/37127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-03these errors resources are in svx, not cuiCaolán McNamara
Change-Id: Ic11296b2536f1c90361bb8d31c25a73dd3e65e8e
2017-05-03fix missing gallery iconsCaolán McNamara
Change-Id: Ie0d8acebcf9d30802296814c58a35244eb813748
2017-05-01tdf#79766 Use consistent wording in Asian Layout Kerning optionTakeshi Abe
Change-Id: I4ed78efc82a9dad490930351175dc5d501fdc499 Reviewed-on: https://gerrit.libreoffice.org/37114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-29tdf#39468: Translate some German comments and termsJens Carl
Change-Id: I5f33f24aa6fd1685e32c9df11855a26ad891eb5b Reviewed-on: https://gerrit.libreoffice.org/37096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-04-28loplugin:salunicodeliteral: cuiStephan Bergmann
Change-Id: I06e94b663402b65b7487b314cc71217e43f2de4e
2017-04-28move builder attributes from OString to OUStringCaolán McNamara
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28Fix indentationTor Lillqvist
Change-Id: I9d4b933e6a1a108427ac6583ff8305b40a620409
2017-04-28tdf#105841: Avoid REGRESSION!!!Tor Lillqvist
Let's reinstate the name charade instead. Pitäkää tunkkinne. This reverts commit 5941496601600269296dde3e4ff8b615a8bb45ca. This reverts commit db231633af4667e24281e0be69ab63ad3081fdc3. Change-Id: I7d9890f3bd478bac195c1a7a59ff9822c2c83653
2017-04-28tdf#107437 Fix display of Start/End Quote window titlesGabor Kelemen
Drop this string surgery nonsense. We translators can surely handle four more words. Change-Id: I44be5fae7cc61dcac960cc5c33c60f0b5d354675 Reviewed-on: https://gerrit.libreoffice.org/37003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27Add custom HIDs for Customize - Toolbars pageGabor Kelemen
All items should have one as this page is reusing the ui file of the Menus page Change-Id: I9b691db70391eda90035761098ebc4d91d6a5b5b Reviewed-on: https://gerrit.libreoffice.org/36397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-04-27remove svx bitmaps from .src filesCaolán McNamara
Change-Id: Ie3795870484648e62dea483f9976af31cd1be167 Reviewed-on: https://gerrit.libreoffice.org/37006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25remove bitmaps from .src filesCaolán McNamara
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24coverity#1405477 Uninitialized pointer fieldCaolán McNamara
and coverity#1405476 Uninitialized pointer field Change-Id: I6f6a13f5c3037ff11636938135bad72f8b3419d2
2017-04-24loplugin:checkunusedparams in i18nlangtag and l10ntoolsNoel Grandin
Change-Id: If7c7404b1cc1cf9445a2af8106f7326b76524388 Reviewed-on: https://gerrit.libreoffice.org/36883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-23Toolbars can't be nestedMaxim Monastirsky
This is not supported by framework. Change-Id: I4afde5243130e1ec1ac5c3126d755331842601e5
2017-04-23tdf#101374 Don't confuse "Label" with "Name"Maxim Monastirsky
We compare the actual label of a command with the default one, in order to determine whether the label was changed by the user. The problem is that commands that were inserted via the "Add Commands" dialog might have different label by default, because it uses the "Name" command property (from the theUICommandDescription singleton), but the customization dialog assumes usage of the "Label" property. Which means that if these properties differ for some command, it will be considered as having a modified label, and such label will be written to the user profile, and stay there even after UI language change. This commit does 2 things: - Prefer using the "Label" property for inserted commands, instead of copying the label that's shown in the "Add Commands" dialog. - Properly track whether we're using the default label or a custom one. Change-Id: I16ceb4d0bc92ad2a9f833fb09753962ad21a903b
2017-04-23Customization of notebookbar menu always possibleMaxim Monastirsky
i.e. even when experimental features disabled. That's the same behavior as for the notebookbar shortcuts toolbar. Change-Id: Ic87e5c8015f796f33042d1e348ea567681ae240d
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20convert EDynamicMenuType to scoped enumNoel Grandin
and drop unused E_HELPBOOKMARKS Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc Reviewed-on: https://gerrit.libreoffice.org/36728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19This doesn't have to be member variable, it is used just onceKatarina Behrens
and then forgotten again Change-Id: Id94639415bd1679b67d5d3094dee8b8f8f3d3167 Reviewed-on: https://gerrit.libreoffice.org/36690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-19clang-tidy readability-simplify-boolean-expr in accessibility..cuiNoel Grandin
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-14 00:40:02 +0000