summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-11-27loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: I5452235287fd5986de25ee542edd57bf1abded52 Reviewed-on: https://gerrit.libreoffice.org/45338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27tdf#113860 - Selecting a recent or favorite special character is not appliedMark Vecsernyes
Change-Id: Ia000e4d83b8012eff54647205f6e044920aed74b Reviewed-on: https://gerrit.libreoffice.org/45259 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23gpg4libre: UI and config for adding GPG keys to user's identityKatarina Behrens
Change-Id: I1a176ca998f49b68c6ca8129fba4eb56445892a2 Reviewed-on: https://gerrit.libreoffice.org/45145 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22add missing context to translatable strings in .ui fileChristian Lohmaier
Change-Id: I52f01046ccc1da8aec483766371e12fe06c82b8a
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22tdf#113880 a11y: improve accessibility of table background tabYousuf Philips
Change-Id: I978340f88a8e007dbf080113a933063c5546fd51 Reviewed-on: https://gerrit.libreoffice.org/45011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-22tdf#112207: Allow assigning styles to ui elementsMuhammet Kara
Change-Id: I777059e2c5139dcf1b24504023fb417b9b56b3d8 Reviewed-on: https://gerrit.libreoffice.org/42594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Remove space before colon in gradient tab of area tabYousuf Philips
Change-Id: I9699d4065850f953e71a581488d0ca7cc62351f8 Reviewed-on: https://gerrit.libreoffice.org/45034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-21tdf#113880 a11y: make gradient tab of area tab accessibleYousuf Philips
Change-Id: I45ac3770851ff25f576190abe73c59e30fc78879 Reviewed-on: https://gerrit.libreoffice.org/44857 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-21Display the threaded calculation state in Help:AboutTor Lillqvist
Change-Id: I299e555392bb4b09325ad2c92f843b1e12ee4d31
2017-11-21TypedWhichId for SDRATTR* constants (2)Noel Grandin
Change-Id: I9926d55568f8b5bbc67f448bbf7fb660e74505fd Reviewed-on: https://gerrit.libreoffice.org/44964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20tdf#113880 a11y: make bitmap tab of area tab accessibleYousuf Philips
Change-Id: Icfdb3f68bb0660b20ebe3f98e5e4fb8fcf3e54f1 Reviewed-on: https://gerrit.libreoffice.org/44897 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-20l10n: dont translate non-text character tab fill characters (2)Yousuf Philips
Change-Id: Ib46cef900e681664e50b06c2e4a5af2b63a8f83f Reviewed-on: https://gerrit.libreoffice.org/44953 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20cosmetics: Drop duplicate semicolonTakeshi Abe
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f Reviewed-on: https://gerrit.libreoffice.org/44914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20tdf#113909 Fix label alignment in Shadow tab of drawing object propertiesGabor Kelemen
Change-Id: I38afb0f193147243dc45bca461fc47d91d70e4e6 Reviewed-on: https://gerrit.libreoffice.org/44900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-19tdf#113777 dont translate 'Family:' and 'Style:' stringsYousuf Philips
these strings are replaced by strings in the code, so no need to translate them 4 additional times Change-Id: I6cd28b76367a950a2075cf5ef4ee021fe1a89fe0 Reviewed-on: https://gerrit.libreoffice.org/44761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-18silence some coverity warningsCaolán McNamara
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18tdf#113777 Add colon after family and style labelsYousuf Philips
Change-Id: I27a58b9c6f63275f3901d00e807588c2f4c278af Reviewed-on: https://gerrit.libreoffice.org/44905 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-17tdf#106890 Page orientation of User page sizeheiko tietze
Radio buttons are adjusted when width/height is modified Change-Id: Ia660a25314a46f2bb04b248a4fef937f10c4941d Reviewed-on: https://gerrit.libreoffice.org/44876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-17tdf#113739 add "Grammar By" feature to user dictionariesLászló Németh
Language-specific user dictionaries (en-US, de-DE, etc.) have got a new "Grammar By" field to specify optional automatic affixation and compounding of the new words by adding an example dictionary word. Test example: Create an en-US user dictionary. Add the new word "crowdfund" to it, also an example, the Hunspell en-US dictionary word "fund" in the optional "Grammar By" field. This way, the word "crowdfund" will be recognized by the spell checker with suffixes of the word "fund", too: crowdfund’s, crowdfunds, crowdfunder, crowdfunders and crowdfunding. Hunspell dictionaries with compound flag usage (German, Hungarian, etc.) can support automatic compounding of the new words, too. Change-Id: Id70dbee4544643967153f730ae64938e5cee0c82 Reviewed-on: https://gerrit.libreoffice.org/44562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2017-11-17l10n: dont translate non-text character tab fill charactersYousuf Philips
Change-Id: I529fe96d98e85119373e220ba8ddd7a4d4629a7c Reviewed-on: https://gerrit.libreoffice.org/44858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-11-16tdf#111740 Wrong preview of graphic bullet symbol in ImpressMark Vecsernyes
Change-Id: I9e713163395852478e233227440a802c255b3070 Reviewed-on: https://gerrit.libreoffice.org/44762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-14related tdf#113807: Clean up Links dialog: remove useless hidden buttonSerge Krot
Change-Id: I0e8f9d7b538dd094d53cda69517e94fbafd0d752 Reviewed-on: https://gerrit.libreoffice.org/44725 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-14tdf#113807 Enable clicking on pathfile-names in "Links" dialogSerge Krot
Improved: * Very long pathfilename now do not overwrite its label on the dialog * Full pathfilename could be clicked to show attachment/image with default viewer. Change-Id: I6e5398ed2a2013aae0d9b51a719e694b3206dcce Reviewed-on: https://gerrit.libreoffice.org/44689 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-13Fix typosAndrea Gelmini
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-12use copy constructor to clone PoolItemsJochen Nitschke
Change-Id: I2a45a62fd56cc5a768406c7a6e4c72456f962367 Reviewed-on: https://gerrit.libreoffice.org/44648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-11tdf#111738: Duplicated numbering alignment option on numbering dialogTamás Zolnai
Change-Id: Ifb18d5da84cc47da59448549f3c617e8040c246c Reviewed-on: https://gerrit.libreoffice.org/44636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-10-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I545fb159960974841008d2a0e7843b71a59698aa
2017-11-10loplugin:unusedmethodsNoel Grandin
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454 Reviewed-on: https://gerrit.libreoffice.org/44553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09tdf#113647 set parent for modal gallery dialogCaolán McNamara
Change-Id: I1de801eefba135819aee992ffce826309c1c7400 Reviewed-on: https://gerrit.libreoffice.org/44550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-09Related: tdf#110448: move Quickstart options to General pageMike Kaganski
Change-Id: Ib1eab8202903adb5bfcf9bfcabab5d12a773d3bb Reviewed-on: https://gerrit.libreoffice.org/44508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-07loplugin:finalclasses in cuiNoel Grandin
Change-Id: I59c148dbc2bfc1dff554efe7e7c974dc557b2aeb Reviewed-on: https://gerrit.libreoffice.org/44362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06loplugin:constparams in various(2)Noel Grandin
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c Reviewed-on: https://gerrit.libreoffice.org/44313 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-05Remove GetNextSubset and create GetSubsetMapJulien Nabet
To avoid to store an iterator and simplify loops Change-Id: I9b160714125176841961a56905d81dcb876c68b6 Reviewed-on: https://gerrit.libreoffice.org/44326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-31loplugin:constantparam in editengNoel Grandin
Change-Id: I0a07326d5b63e82ef16e02f75fd8523e3b73e1f4 Reviewed-on: https://gerrit.libreoffice.org/44096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26More loplugin:unnecessaryparenStephan Bergmann
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-26cpp check, fix redundantAssignmentBán Róbert
Change-Id: I7cf826ecae59f501e1a240840d3ba186f2c65ed6 Reviewed-on: https://gerrit.libreoffice.org/43839 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-25cpp check, fix redundantAssignmentGábor Koruhely
Change-Id: I26d8353461d938e327baecf1ca0f529da45eb069 Reviewed-on: https://gerrit.libreoffice.org/43833 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-25Resolves: tdf#113378 wrong table border preset iconsCaolán McNamara
Change-Id: Ibb9d0bcab6720fd85d5d3e2ae82821ff1c003c5b Reviewed-on: https://gerrit.libreoffice.org/43820 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-25tdf#107569 Fix missing res/colorslider.pngMaxim Monastirsky
Change-Id: I83c719594a29cde8385a22793f17812e7d5c12bb Reviewed-on: https://gerrit.libreoffice.org/43796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>