summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-02-22Advanced Diagram support: first additions/reorganizationsArmin Le Grand (Allotropia)
To allow advanced Diagram/SmartArt support in the future this is a first step to organize imported SmartArt Data in a way that will allow to re-layout loaded SmartArts, under re-usage of the oox::Theme (held available). It is designed to work without holding available the original XML snippets defining the imported Diagram in any way, also for performance reasons. It tries to re-use some of the already basically added functionality, including the systematic layouting using the generic layout algorithm, plus some already available text extraction. Before being sure that the former state can be completely replaced this is optoinal and used when SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff is already done but e.g. the redefined reLayout method will not (yet) be triggered. It works and reliably produces a re-layouted identical version, also preserving transformations. Change-Id: I08cfbae04afa663d0589530aae549216d853128d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-21cid#1500465 Dereference after null checkCaolán McNamara
Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17sd theme: add doc model for shape fill colorMiklos Vajna
In preparation of adding UNO API for this. Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130050 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-15add typed GetWhich operationsNoel Grandin
to reduce boilerplate at call sites Change-Id: I290c2bf60ad5e6ddb000aa26cf543830ed39120a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-14tdf#143266 Use correct menu item's names in ToDRoman Kuznetsov
Change-Id: I0796e6c8b2dc2b6e56e7e69611cbcb97ff3e7e34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129842 Tested-by: Jenkins Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-14sw: prefix members of ConditionEdit, SwView, SwXFilterOptions and ...Miklos Vajna
... SwXViewSettings See tdf#94879 for motivation. Change-Id: I68f647d13edf156cfc471a54f247ac686cd6cd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129893 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-14cui: show image pixel size below logic sizeTomaž Vajngerl
Change-Id: If919d1fade2ed85aec7437b429a648ca658e2c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129885 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-14cui: prefix member variables of SvxGrfCropPage classTomaž Vajngerl
Change-Id: If6f4a32df97c352d30958fb27dc90ffec5bbf44d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129884 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-11svx::PropertyChangeNotifier improvementsNoel Grandin
(*) rename the enum to make it's purpose more obvious (*) remove the enum header - it belongs to this class, no need to have it somewhere else (*) return property name by const&, no need to copy here (*) use a o3tl::enumarray instead of a std::unordered_map - there are only 3 entries here, and two of them are ALWAYS used, so just flatten the data structure. Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-10add more TypedWhichIdNoel Grandin
Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-06Simplify sequence of PropertyValue in cui/editeng/extensionsJulien Nabet
Change-Id: I0c8f46d2671f3623ff3dd1ee6ec84cde7db41003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129580 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-06Simplify sequence in cuiJulien Nabet
Change-Id: I47e6e6bd2743a380bb316612230bd1e968ed7084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129568 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-04use some more add toId/fromIdCaolán McNamara
Change-Id: I3a21e2aa5a2c482c0bac1d4c9bf84f8b56261408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton valuesCaolán McNamara
for these cases where draw wants to massively scale the units the underlying "metric conversion" are already using sal_Int64 anyway Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-03tools::Long -> sal_Int32Noel Grandin
Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29gtk4: remove stray xalignCaolán McNamara
Change-Id: Ie4dbcdd97f815760370babb225c0cb287fecf1bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129149 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29used TypedWhichId in the constructor of various svx *Item classesNoel Grandin
to act as an extra check that we have the association of Item and TypedWhichId annotations correct. (*) requires that I add an upcasting constructor to TypedWhichId (*) Make the field dialog stuff in writer use a new item id FN_FIELD_DIALOG_DOC_PROPS instead of abusing the existing SID_DOCINFO Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29gtk4: remove stray xalignCaolán McNamara
Change-Id: If1b09a8697a813e5b5bca55f84d1c816a2081e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29gtk4: drop unnecessary stray 0.5 yalignCaolán McNamara
Change-Id: I931332b95f96091b82944f5ef02420ea336c22b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129142 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29unwanted 'end' vertical alignCaolán McNamara
Change-Id: Ia1c6f0182f5006b68c6d963f41f53f7c0a8ae128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29resave with latest gladeCaolán McNamara
Change-Id: I7b8c189e5949c2266ea079eefa3239e4b801bb1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129139 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-28no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic4f1b13e1f35f7e67195a12c727ea2f088f8ddc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27add some more TypeWhichId annotationsNoel Grandin
and update the idl compiler to cope with namespaced class names Change-Id: I7b5242f872e358bc3c5584f543767719172aac83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27Resolves tdf#128258 - Draw a dotted line before hidden columns/rowsHeiko Tietze
Color and on/off configurable via Tools > Options > Application Colors Change-Id: Ia4b1e1c86f36d1b0f508a5b3e866a79418f16c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128553 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-25Related: tdf#146971 remove %PRODUCTNAME from accessible-descriptionCaolán McNamara
Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25Related: tdf#146971 rename %PRODUCTNAME Macros to Application MacrosCaolán McNamara
Change-Id: I6a11c335b28cfaeaceba93b22e7d2db30ee803db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-24gtk4: adapt to window_[g|s]et_default_widgetCaolán McNamara
Change-Id: I916e5db05f8ea10ecc8b319cc77a671ca7cbcb93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128859 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-21tdf#145517 Reduce overload of term “style” in Options > LO > ViewAdolfo Jayme Barrientos
Change-Id: I23e43e4fdbfb7caded2537e6b92ec74a5b996675
2022-01-20Move credits link to configSamuel Mehrbrodt
as all other related URLs and replace with a hub link, see https://redmine.documentfoundation.org/issues/3569 Change-Id: Ic30f2a5980ae17b5dfff184ead391b21cff7ab7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128660 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18tdf#146612 Drop confirmation question when applying new doc hyperlinkGabor Kelemen
To be consistent with other tabs of the dialog where Apply does not show a similar question Change-Id: Id3bced8ec861b7166974da5ad223513dbfec25c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128424 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-18Use "smart" INetURLObject ctor for user input right awayMike Kaganski
... instead of trying to process it strict, falling back to smart processing on error. Similar change was implemented to SvxHyperlinkInternetTp in commit 6b973753d407d66dfa5fda86547246c486ab7087. Trying to parse it strict initially there resulted in wrong detection of "generic" protocol in incomplete URLs missing scheme and having port. This change simply unifies the code, no specific behavior change intended. Change-Id: I48ba4187a27644f42f3fd5a3b6cd77e55038cb0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-16add missing placeholder labelsCaolán McNamara
Change-Id: Iae743fd6d7e13f91501e386e609e5965ef742db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16restore the explicit translatable="no" for some labelsCaolán McNamara
Change-Id: Ifbb05dc12a02afd11470e868b88d72fa18c1a388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-14tdf#146703 Rework previous fix to query extension metadataGabor Kelemen
to limit its error potential by encoding only the category string Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-14resave with latest gladeCaolán McNamara
Change-Id: I7d41fa2fbfd188c75b690be34f7c9baf6ae20044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13Related: tdf#145625 adapt the reportdesign color section marginsCaolán McNamara
to the changes of: commit 8d2bf9b679dec223a78e1fd8f3684f76c5802bae Date: Wed Jan 12 13:32:13 2022 +0100 Resolves tdf#145625 - Alignment issue at color options Change-Id: I66c43e964b19da3bdfd4f13cc343dc399ae9cd5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13restore some placeholder labelsCaolán McNamara
glade tends to clobber the GtkMenuButtons placeholder labels Change-Id: I2f1e8dd3f9b86e09a9fe7ce311b40a84f298b4a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128377 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13Recheck modules [a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-13Resolves tdf#145625 - Alignment issue at color optionsHeiko Tietze
* Label "On" cleared (kept internally for size calculation) * Deprecated xalign removed * margin-start set to 0, halign=start, valign=center for color labels and checkboxes * margin set to 12 at the right edge to have more space for the scrollbar Change-Id: I32b7c1fc4ad93b1e9fa7b78968eedbbc3580a379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128322 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-12Bump Glade version to 3.38Heiko Tietze
Change-Id: Icddb8f9ee67d929a4fcacde72263439976ff2f4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128315 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-12tdf#142564 Localize extension category namesGabor Kelemen
Change-Id: I57ca7cb194bd325f621841edc24e3af9ef7c3b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128305 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12tdf#146703 Fix URL encoding when querying extensionsGabor Kelemen
so that extension information files are properly downloaded such as: https://extensions.libreoffice.org/api/v0/Color Palette.json Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-11tdf#145919 Localize strings in Graphics Test dialogGabor Kelemen
but not in the saved log file Change-Id: I65c580e7b8762b654f1812c96bc53841b882a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128087 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-10cui: no need to fetch the property from the map twiceTomaž Vajngerl
Change-Id: I7597c352b2ae166657f1e431e3405fc690520afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128206 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>