summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-08-17Always display highlighted JRE's locationStephan Bergmann
...when opening the Advanced options page and after adding a new JRE via the "Add..." button, not only after highlighting another JRE line. (I suspect this broke with 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03 "weld SvxJavaOptionsPage" towards LO 6.4.) Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16tdf#133026: Additions: Set the maximum length for extension nameYusuf Keten
Change-Id: I52c6fe32e7737e1e0160cfd585d8616a035320c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100657 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-16tdf133275: Additions: Sorting menu ui implementationYusuf Keten
Change-Id: I41b0887d0bc6bf4618bd1cf9afd06f4b1ddbabb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100778 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13Remove some unused includesMiklos Vajna
Change-Id: Iea6b931b1f2328886354f70ad81a3e07367db717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-13tdf#133026: Additions: Install Button HandlerYusuf Keten
Change-Id: If4e9b192557b6c9f56bd04ccf9f6a5a8273d7515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100340 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-13loplugin:stringstatic also look for local staticsNoel Grandin
Add some API to O*StringLiteral, to make it easier to use in some places that were using O*String Change-Id: I1fb93bd47ac2065c9220d509aad3f4320326d99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12cleanup some unused leftoversCaolán McNamara
Change-Id: I5971ec431471c528c33b2f3a3f2353a3a825f286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12fix memory leaks in CuiConfigGroupListBoxJim Raykowski
Change-Id: I47dab54764de24bccc42513373b65657c241a8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-11tdf#135442 min supported version of gtk3 is 3.18 not 3.20Caolán McNamara
Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11tdf#135313: Crash on opening the tight integration dialogYusuf Keten
The crash problem in MacOS and Windows is fixed. Change-Id: I2968880b77f723f2caf6dc77f4904411392c4008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100449 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-10Resolves: tdf#135603 crash on rename item in customize dialogCaolán McNamara
Change-Id: Ib5b04ec8ce974c87646b6bf4989094c8334a0006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08Clean-up of abstdlgHeiko Tietze
Unnecessary functions regarding the about dialog removed Change-Id: I739a6b1383a0096ec46e2316da3c5327dafe1675 Follow-up to 39e83e2e4257c56adef13ed1dfeee013a4f45376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99985 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-07tdf#133071 DOCX import: fix vertical alignment to bottom page marginTibor Nagy
The relative vertical alignment (top, center and bottom) of bottom page margin wasn't handled. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ib41a8790f88ef004390787e3673a209dadd86457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100170 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-07tdf#133026: Additions: Disable install buttons of the existing extensionsYusuf Keten
If the extension exists, the install button will be disabled. Change-Id: Ide88faeabe86d9cdb6a3cb99257710d92e3b4769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99809 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-05tdf#135367 enable_toggle_buttons sets SvTreeFlags::CHKBTNCaolán McNamara
designating that the special auto-sized toggle column is in use Change-Id: I23aa927c56e706590f397d15ef7329d20e0b18a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100136 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04tdf#134420 select neighbour when deletedCaolán McNamara
Change-Id: I55c6135360d3d77b7b3d2e54012ad82e1a4813ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04loplugin:simplifybool a little more aggressiveNoel Grandin
with expressions like !(a && b) Change-Id: Id2acec2a8d0eaaa8e5e37dbd2cae7281be36572e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03correctly mark the "New menu" dialog as modalMarkus Mohrhard
The dialog is called from a modal dialog which means a modeless dialog does not make sense. Some of our internal dialog tracking code is confused by that case which confused the UI tests. Change-Id: I705877e8a751c55bfbd00ddeaf18ab86c95321c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99944 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03Clean-up of abstdlgHeiko Tietze
Unnecessary functions removed Change-Id: I32dab4b4c5fe8ff351277cbbd32e0b462443d031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99959 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-01Reliably set up controls of hyperlink dialog in constructorStephan Bergmann
The recently added test_insert_hyperlink in sw/qa/uitest/writer_tests3/hyperlinkdialog.py (UITest_writer_tests3) has often failed on slow builds like <https://ci.libreoffice.org/job/lo_ubsan/>, by hitting the assert in rtl_uString_newFromSubString as described at <https://lists.freedesktop.org/archives/libreoffice/2020-July/085594.html> "Race with SwEditWinUIObject::get_state during UITest_writer_tests3?" However, it turns out that the actual race is rather different from what was assumed there: The initial content of the dialog's controls like "target" and "indication" were only set during the first SvxHlinkCtrl::StateChanged(SID_HYERLINK_GETLINK), which is called from the SfxBindings machinery based on a timer. When that happens, any text that has already been typed into those controls by the user would be overwritten again. But in normal GUI operations, the timer fires so quickly that the user has not yet typed anything into those controls. On the other hand, for a typical (fast) execution of test_insert_hyperlink, the whole test has already been executed when the timer fires, so the overwriting is not noticed. But for a slow execution of the test, the timer may e.g. fire after the "indication" control's content ("link") has been typed in (which SvxHlinkCtrl::StateChanged will reset to the empty string) and before the dialog is closed (so instead of "link", the empty string will be added to the Writer document, and obtaining the text selection of length 4 will crash as described in the email). (Also, the two calls to wait_until_property_is_updated added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" and 1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with test_insert_hyperlink" probably just address other symptoms caused by the same underlying issue, and should no longer be necessary with this fix. But cleaning that up is left for a follow-up commit.) The solution is to set up the controls' initial content already in the constructor, so when the SfxBindings timer fires for the first time, it no longer calls StateChanged because that state has already been recorded. However, that caused the focus no longer to be set to the "target" control when the dialog is opened, at least for the gen and svp VCL backends (which caused the .uno:HyperlinkDialog-related tests in desktop/qa/desktop_lib/test_desktop_lib.cxx, CppunitTest_desktop_lib, to fail because GetFocusControl returned null): The first call to SvxHlinkCtrl::StateChanged -> SvxHplinkDlg::SetPage now happens during the constructor, before the dialog is shown, so the request to grab the focus in SetInitFocus was ignored. The solution to that problem is to shift setting the initial focus to the first call of SvxHpLInkDlg::Activate, which is called whenever the dialog gains focus. Change-Id: Ib4d5e06dfc21014ccec546565426fa2d27e63ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99903 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-31Resolves tdf#132066 - Localization of special text in about windowHeiko Tietze
Copy all version infos in English Follow-up to 56b2214c3aa40c2e2522eba5584063fb34e003ba Change-Id: Id093305261ec957137c56f61048c660e80e5c795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99773 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-31tdf#135321: fix crash when right click empty in Command listJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=163797 Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d54202ff690e4e97e018461cc6dc3dfadd36a702 author Sarper Akdemir <q.sarperakdemir@gmail.com> 2020-02-14 13:17:46 +0300 committer Muhammet Kara <muhammet.kara@collabora.com> 2020-02-28 18:32:54 +0100 commit d54202ff690e4e97e018461cc6dc3dfadd36a702 (patch) tree 5f60f9c473b30e0f59bbf13a6f773595e1e4e759 parent 531f078f3371e909b03b358bc5c9d70df083555f (diff) tdf#112135: Provide controls through context menu in lists of Customize dialog Change-Id: I73031811257e1d128bb6bdc11c481f7a63bbc05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99850 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-29replace and drop SvtExtendedSecurityOptions classCaolán McNamara
Change-Id: Ibe3443531c83eb44080217b61f5746be9cce9c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29replace and drop MiscCfgCaolán McNamara
Change-Id: I5ea9e3663fc5d30d725cf18757badb9b9802da18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Removed duplicated includeAndrea Gelmini
Change-Id: Icb8d98103b40574f7120e2c93c03e4147cd9b5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29replace and drop SvtPrintWarningOptionsCaolán McNamara
Change-Id: I17fd4156eb940fbdc925d9761301096e5349135f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#133958 only move the selection to the error if its not already thereCaolán McNamara
Change-Id: I3046c842cc6c8bcc867c79989a8978d382b08269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Change e-mail to email in UIOlivier Hallot
Change-Id: Ie729acccc942c16b177a6bcbbcceb822d667157f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99626 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-28Resolves tdf#132066 - Localization of special text in about windowHeiko Tietze
Copy all version infos in English Change-Id: I6719e27f721b0ff9f06efb4ea63e286e6d58ebf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98498 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-28drop use of SvtFontOptionsCaolán McNamara
Change-Id: Ib3ef6ec415d5e61d484e338290030fac2ed7b215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-28tdf#133026: Additions: Better Search FunctionYusuf Keten
Old search function was demo to test something. This function uses the JSON response to search, not the API call to search. Change-Id: I0f4163a55331667a73f15dd220302f58a27831c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99388 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-28Add spin button for shadow blur radius in area dialogA_GAN
Update shadow tab in area dialog with spin button to control blur radius of the shadow. Change-Id: I41f072ef10d280df4b118afae7a7c058eb975417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99557 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-26tdf#118148 Add extended tips to optuserpage.uiOlivier Hallot
Pick from text/shared/optionen/01010100.xhp and add missing ET's Change-Id: I8f188e2b2f64b570db90dca6b98240f6e9a86793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99341 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-25move getUIRootDir to AllSettingsCaolán McNamara
Change-Id: I3b7774a043a2c99531e1c76b531df4358699bba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25cid#1465509 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0c5db5c3252a2d544a2f22327db6f89b1a26af39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-23tdf#133026: Additions: Add Show More button and refactorYusuf Keten
After this patch, not all extensions that come with JSON will be shown. Instead, a certain number (currently 30) of extensions will be shown and the Show More button will appear after the last extension. If the user presses the button, a certain number of extensions will be added again. Change-Id: Icf8f549d585a5bca1d55b85acf9b72478b507444 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99338 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-23Fix Android build, no extension dialog in this partJulien Nabet
Change-Id: If531bcc84eaa15642d9e304a05dac4484f34f511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99284 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-23tdf#133026: Additions - Thread Execution TerminationYusuf Keten
After press the close button, the search thread will be terminated after this patch. Change-Id: Ic79928bf0604203de9497c34cb18dbd76e3f376c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99250 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-21tdf#133026: Additions - Parameter support to UNO CommandYusuf Keten
After this patch, parameter support to uno command(.uno:AdditionsDialog) will be available. To use parameter, add "?AdditionsTag:string=YourParameter" to UNO command. Parameters are the tags of extensions on webpage. Change-Id: I0072c7340bda14ee13c21c347e06a04545cba69a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99007 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-21Remove markup in extended tipOlivier Hallot
Change-Id: Ifcf1ed97521d7a3d5c71dce9a8457d2bfbb7fd55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99069 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-21Revert "configure: add a --with-product-flavor switch"Heiko Tietze
This reverts commit c540483134482d437ea6e02390ff429f4300cbb0. Reason for revert: https://blog.documentfoundation.org/blog/2020/07/20/update-on-marketing-and-communication-plans-for-the-libreoffice-7-x-series/ Conflicts: icon-themes/colibre/brand/shell/logo_flavor.svg Change-Id: If435d4c4c16fb1b52635fae2d966151970729daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99053 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-20make gen gear menubutton's smallerCaolán McNamara
Change-Id: Iefa9e143e03a7a3027cd10b45c2a3fcaed7f3693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99042 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-19tdf#133026: Tight integration of extensions - Add the search functionsYusuf Keten
The search function added. However, I added a case for checking (UI change occurs when "2" is written) because the API is not ready at the moment. The finalURL variable will be activated when the API is ready. Change-Id: I23c83e28d6ad8dea6c52813b4c98d219299fa9f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98554 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-15tdf#118148 Extended tips to colorpickerdialog.uiOlivier Hallot
Change-Id: Ia38caf54bf20814a0bc08555dcde438c577a5e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98777 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-14Fix number decimal separatorOlivier Hallot
Change-Id: I1f241264639c80f30fa1bfd8e9d5966bfee12197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98695 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-13tdf#118148 Add extended tips to selectpathdialog.uiOlivier Hallot
also multiplathdialog.ui Change-Id: I3e3baf1779d4f0c77ddec3829adbf4b06daa58e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98550 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-17 05:40:46 +0000