summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2014-11-14coverity#1242900 Unused valueCaolán McNamara
Change-Id: I4276f5dabedac97c0508aa7904473a4e20767e62
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13Remove unhelpful tooltipsAdolfo Jayme Barrientos
These buttons should be self-explanatory. Change-Id: I3ae973f093430cb3c1c88284267cff005caf7bff Reviewed-on: https://gerrit.libreoffice.org/12397 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11fdo#85907 Tweak size requestsAdolfo Jayme Barrientos
... and remove an unneeded grid that I added. Change-Id: Ibc3b98a1f87d61464d652168546235e5c183c80f Reviewed-on: https://gerrit.libreoffice.org/12334 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-11fdo#76658 fix bad conversion of old-style UNO service..Noel Grandin
in my commit 0394cb37a2d378511f265004b285fd93df37e5ca "fdo#46808, Convert ui::ImageManager to new style" Change-Id: I77d3189723403221e7388969b1eb892a244b90af Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07Resolves: fdo#85939 its not an OKButton anymoreCaolán McNamara
Change-Id: Idecd7dc056749b2135e0690c54560aedf7f653a2
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#85907 Better use of space in Special Characters dialogAdolfo Jayme Barrientos
Change-Id: Iaa42e8ef7727291ba112fc92db5051951046f86f Reviewed-on: https://gerrit.libreoffice.org/12265 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-05Use basegfx library function to clamp numbersKatarina Behrens
Change-Id: I3142f55ecf94ce2143e92492243bc5959322704f
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#1250409 Explicit null dereferencedCaolán McNamara
Change-Id: Iab78e3ec447b8a32f43dff3e30c5be254f6d0a48
2014-11-03HIG fixes for the rest of cui (and a bit of sw)Adolfo Jayme Barrientos
* Standardize spacing and make some dialogs waste less space * Add missing colons to labels that precede controls (fdo#78826) * Disable manual resizing where it doesn’t make sense * Standardize Help button’s position (fdo#76486) Change-Id: Ib3f7f830e890e67f72aab970571793f495bab956 Reviewed-on: https://gerrit.libreoffice.org/12207 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-01fdo#78826 HIG: missing colons and capitalization in cui, filterAdolfo Jayme Barrientos
* Fix capitalization * Standardize spacing * Standardize Help button’s position Change-Id: Ibc7152acbe460a9564ab6b97a637f38ea5e7144a Reviewed-on: https://gerrit.libreoffice.org/12075 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-01coverity#1250409 Explicit null dereferencedCaolán McNamara
Change-Id: Ib32e7c9eb979b9d6ab60d81423292be5fac87a54
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30Remove checks for HTMLMODE_SOME_STYLESHarri Pitkänen
HTMLMODE_SOME_STYLES is enabled for all supported HTML export modes so there is never need to disable these elements in the paragraph dialog. Change-Id: I43df54a6ce900c8a9f957522eb85ca67b6cd756f Reviewed-on: https://gerrit.libreoffice.org/12091 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-30Better label for OK button in Special Characters dialogAdolfo Jayme Barrientos
Also, added missing colons and changed Help button’s position, according to the HIG. Didn’t disable resizing here because it’s actually useful. Change-Id: I33306eb558f51d3c9889337f4c39465d6c201ff2 Reviewed-on: https://gerrit.libreoffice.org/12143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-30Improve SvSimpleTable classPalenik Mihály
It is possible to order columns. This is set in Expert Configuration dialog. The header's itembits weren't set correctly therefore mouse click handler didn't do anything. The comparsion was slow on big table. Conflicts: include/svtools/treelist.hxx svtools/source/contnr/simptabl.cxx Change-Id: I7e1301d40433ef45b3d0a3fb300909345ede9d4d Reviewed-on: https://gerrit.libreoffice.org/12070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28cui: clean up gradient parts of the background tab pageMiklos Vajna
I forgot to clean this up when cherry-picking 6e61ecd09679a66060f932835622821d39e92f01 (Merge back branch alg_writerframes to trunk, 2014-03-19). Change-Id: I531dea63d3b62d16f11d414758012432bb4b2503
2014-10-28cid#1242780 Uninitialized pointer fieldNoel Grandin
Change-Id: I6478f8f2ead1d87365f84aacdfef2bdcccd61248
2014-10-28rename class field pEntries to mpEntriesNoel Grandin
Change-Id: Iea8643dfa472a663023afb57654fccdda85ca601
2014-10-28loplugin: cstylecastNoel Grandin
Change-Id: I287dcb0ca728747ec91b5c3cdd986e60998e3928
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-24coverity#703936 Unchecked return valueCaolán McNamara
Change-Id: I238cdaeab269bcf3ef7a8969ee6077104c12c8a3
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-23fdo#78214 - rename of '1.2 extended (compat mode)'Yousuf Philips
Change-Id: I2c0d14f8e015304489d2b199db620bf046758331 Reviewed-on: https://gerrit.libreoffice.org/12069 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-22Avoid unnecessary #includeStephan Bergmann
Change-Id: I6ec5de40ce2f4cbcce751dcae16dae60abbc1a37
2014-10-22Save precious vertical space by removing some redundant heading labelsAdolfo Jayme Barrientos
Change-Id: I6aaa7602f57f6cb2d0f9bc3ee897a9c3576d47d3 Reviewed-on: https://gerrit.libreoffice.org/12012 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18convert SV_BMP_ constants to enumNoel Grandin
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18vcl/layout.hxx was included twiceAndras Timar
Change-Id: I03a30793e02def731cb6c8f130c48aeb325a2528
2014-10-17fdo#60664 HIG fixes for Thesaurus dialogAdolfo Jayme Barrientos
* Disable manual resizing * Standardize column width to 12 * Reduce a widget’s size request a little * Add missing colons to labels that precede controls (fdo#78826) * Unrelated tweaks to the XML are courtesy of Glade. Change-Id: I6d746b909adebde284e1848417373dd8b06e75fe Reviewed-on: https://gerrit.libreoffice.org/11992 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16usage info: Checkbox to turn it on and off (Tools -> Options... -> General).Jan Holesovsky
Change-Id: I67143e604314f5553026c369bbed3fdd683c39a6
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-16 03:29:48 +0000