summaryrefslogtreecommitdiff
path: root/dbaccess/qa
AgeCommit message (Collapse)Author
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I5cd8fd979fd4caa3d7cde599096627bfdd0dec7e
2016-04-04tdf#97361 Refactor dbaccess test againslideon
Remove duplicate code, add helper functions and constants Change-Id: Ib8702e2ce9918b47a608f6eb6fd2af7fd4dd1d0d Reviewed-on: https://gerrit.libreoffice.org/23727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-01Remove erroneously added dbaccess/qa/unit/data/hsqldb_empty.odb.lckStephan Bergmann
...from 9e596250a6e968c5d1e2fb0de582ae242e02acf9 "tdf#97966 Drop static keywords" Change-Id: I04d3559bceb214743695e2a008c1a1383535a635
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: Icff7c0308843d6a7608be24d7fcf11fa079c7b72 Reviewed-on: https://gerrit.libreoffice.org/23672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06Fix typosAndrea Gelmini
Change-Id: I54c32259750c0863a39f56fabaa1a0df7d208c9a
2015-09-17boost->stdCaolán McNamara
Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09remove some unnecessary exception wrapping in the Java testsNoel Grandin
Modify createTestEnvironment so that it throws Exception. This is appropriate for unit testing. The wrapping adds no value and the calling method already has a catch(Exception) to handle anything. Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
2015-06-05Let JUnit take care of exceptionsNoel Grandin
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04Let JUnit take care of exceptionsStephan Bergmann
Change-Id: Ic628e4eccab59dce5d6d5e77656cac1f0006a491
2015-06-02inline simple Java methodNoel Grandin
Change-Id: I496fa3223ed97d4d2cf8d64649ce30da22331dbd Reviewed-on: https://gerrit.libreoffice.org/16039 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01minor simplificationStephan Bergmann
Change-Id: Iad908728d63b0dcf3bef0a76c9d2fa3c892bf986
2015-06-01Do not lose AssertionError from sub-threadsStephan Bergmann
Change-Id: I8ca7194be6d22b72b73e76e5067273090b087b96
2015-05-30tweaksLionel Elie Mamane
Change-Id: I84ca5d1f3247d3ba3ed76bf3d39be14b47613703
2015-05-30janitorialLionel Elie Mamane
Change-Id: I72cc8b84332442920eb5bb793474de0e9ec0fc86
2015-05-30tdf#82591 ORowSetBase::getRow handles insert row correctlyLionel Elie Mamane
and critically for this bug, modified row, too. Change-Id: I11c418d8926cabe81fcdb65d7293a4283e566f7a
2015-03-10V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I85993df91bd14966f9175c356966fbd8eb1a927d
2015-02-09Fuck that left-behind .lck fileStephan Bergmann
Change-Id: I6ceab61500397cae687fb4356e5dcb48f8090a48
2015-02-09Adapt file URL hackery to WindowsStephan Bergmann
Change-Id: Icee10aae97e9bcef7a3db7e966c1c4ef6780fc1d
2015-02-03Fix PythonTest_dbaccess_pythonStephan Bergmann
Change-Id: Id1ab4496c5a8fa5bf97ac00e57cb89afe82b232b
2015-02-03copy test file to workdir to avoid overwritingLionel Elie Mamane
Change-Id: I2acc5cd6a57bb6a18f3f20177b3bcf2b8469a834 Reviewed-on: https://gerrit.libreoffice.org/14272 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-22fdo#88475 add UnitTestLionel Elie Mamane
Change-Id: Icc2b80cfdcb3ff6a8a4fa8d1fb30a8ce9c865c95
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05java: these fields can become local variablesNoel Grandin
found by PMD Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-18dbaccess: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I1d63c9123ad985cb3424b0ac0ad30c12e39f8170
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-08fdo#38835 strip out OUString globalsNoel Grandin
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
2014-12-05fdo#38835 strip out OUString globalsNoel Grandin
Change-Id: I8bc386ffa88e31988bdc778a845403bec0772799
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-22Revert "PythonTest_dbaccess_python: don't modify source document"Michael Stahl
This reverts commit 29474c7a227050b16fc341bdf7df68112793a23d. Removing the lock file fails on Windows because it is opened; it ought be possible to close the document instead to clean up the lock file? Change-Id: I2c93fc893c62d6a267be9723761e5ed7577086a7
2014-10-21PythonTest_dbaccess_python: don't modify source documentMiklos Vajna
Change-Id: I4e8f94554141e41863c474c5f99be4b1974f3dd7
2014-10-21dbaccess: make sure fdo84315.odb.lck is removed after the test passedMiklos Vajna
Change-Id: I6c9a42625f10a3a30e2636a2a2be2b9bcba8f6af
2014-10-21connectivity: firebird: fix temp directory leakMichael Stahl
Dispose the dbaccess document, and recursively delete the temp directory in Connection::dispose(). Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-09forgotten part of previous commitLionel Elie Mamane
Change-Id: If050e630edacef67ab194c0b6941a6542e4ebceb
2014-10-07fdo84315: add integration test for basic LibreOffice Base functionalityBjoern Michaelsen
Thanks to Stephan for helping with the test environment setup: sbergman@redhat.com: Do the same "set UserInstallation to user profile dir in test/user-template" in UnoInProcess's setUp as is done in test::BootstrapFixtureBase::setUp (unotest/source/cpp/bootstrapfixturebase.cxx) for CppunitTests. That way, these tests all use the workdir/unittest/ UserInstallation concurrently, but they at least do not run into the gotcha in SubstitutePathVariables::SetPredefinedPathVariables (framework/source/services/substitutepathvars.cxx) to only set the PREDEFVAR_USERPATH if PATH_EXISTS. Change-Id: Iad058098a4c69cb567e2d3222af3c7d4ba993271
2014-09-17TyposJulien Nabet
Change-Id: Icf850c4b7b146a82a5638a3cd88ad02f3171aff3