summaryrefslogtreecommitdiff
path: root/dbaccess/source/ui
AgeCommit message (Collapse)Author
2013-07-24Mark as constTakeshi Abe
Change-Id: Ia3996b997ebbd10ca02ec5a24d1969822bc39273
2013-07-17Move hasBigImages() from ToolboxController to SfxToolBoxController.Jan Holesovsky
We want to decide whether the images are big or not based on the real (underlying) ToolBox, not on the global setting, because we can have both toolbars with large as well as small icons visible at the same time (small in sidebar, large in toolbars). Change-Id: I046a12a495f2038df9a571f5779794a639bae6dc
2013-07-16Add embedded firebird loading code, set as default db.Andrzej J.R. Hunt
Change-Id: I993d7d7bacec710bb57d9e8f91d3cd01b0fbf616
2013-07-15fdo#63690 drop RTL_LOGFILE_CONTEXT_AUTHORRicardo Montania
Change-Id: I46823bb2c6fc44a4871d9535c1f59bd24ba75858 Reviewed-on: https://gerrit.libreoffice.org/4908 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-07-14String::SearchAndReplaceAllAscii -> OUString::replaceAllCaolán McNamara
Change-Id: I5091835c9f71c712f15996e5c6263fc5f21f6f96
2013-07-11ORDER BY columns are prioritarily *SELECT* columnsLionel Elie Mamane
as opposed to *table* columns, and notwithstanding HSQLDB 1.8 (our embedded database) bugs. Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs (but quite common) Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
2013-07-11delete in destructor checkbox created in constructorLionel Elie Mamane
Change-Id: Ifceae4c7ffe15bfc62ce34f4463fd4e071403359 fixes: debug build aborts when closing that window
2013-07-11XubString->OUStringCaolán McNamara
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
2013-07-10Fix error: reference to 'ErrorCondition' is ambiguousTor Lillqvist
Either 'connectivity::ErrorCondition' or 'com::sun::star::sdb::ErrorCondition'. Change-Id: Ifeaa895497c8635b7801b2e79400634b11541373
2013-07-05cleanup src filesThomas Arnhold
Those items are unused. Change-Id: If4fce0f91309d2ca09cbb636d4a5d9f86f38eb9a
2013-07-03fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFORadu Ioan
- replaced RTL_CONTEXT_ with SAL_INFO - replace OSL_* with SAL_* Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e Reviewed-on: https://gerrit.libreoffice.org/4620 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-02i#112615 table names are allowed slashesLionel Elie Mamane
Change-Id: I1b69c4575d79ba1b6a6e9cd83abaf18bad54fd79
2013-07-02Resolves: #i122589# check if element is added before...Armin Le Grand
removing and deleting it (well, put it in undo) (cherry picked from commit 48558dc3e09ec442bc4caf867df4b97354b4d334) Conflicts: dbaccess/source/ui/inc/QueryTableView.hxx dbaccess/source/ui/querydesign/QueryTableView.cxx Change-Id: Id8ef54c0a223548affc007d25131a23618c5fe01
2013-06-30Clean String and sal_Bool in toolsNorbert Thiebaud
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655 Reviewed-on: https://gerrit.libreoffice.org/4627 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29remove some createFromAscii usageThomas Arnhold
there are a lot more of them: git grep 'createFromAscii[^)]*"' Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-28remove pointless external guards for standard headersMichael Stahl
Change-Id: I509984a6029b6a86fd1ee3f947394af9cdf71c6a
2013-06-28remove toolkit/unohlp.hxx hackThomas Arnhold
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913 Reviewed-on: https://gerrit.libreoffice.org/4601 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-27add missing VclBuilder::stringmap argument to some builder functionsCaolán McNamara
Change-Id: I57e13920b4707ebe5b6a7149dbdbfc45593c0d9d
2013-06-24Remove dbaui::OStatusbarControllerAriel Constenla-Haile
It actually does not override any method in svt::StatusbarController, so there is no point in keeping it (cherry picked from commit 83bf5a7b85a0e3430cc807415e081a10a1775f9f) Conflicts: dbaccess/source/ui/control/makefile.mk dbaccess/source/ui/control/statusbarontroller.cxx dbaccess/source/ui/inc/statusbarontroller.hxx Change-Id: Id6adc11c3a54f642ebdec9c6016996134908da71
2013-06-17fdo#43460 dbaccess: use isEmpty()Jelle van der Waa
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1 Reviewed-on: https://gerrit.libreoffice.org/4321 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-14fix limit bug: selecting "All" has no effect to sqlZolnai Tamás
LimitBox set its value to -1 if the current text is "All" but just when it loses its focus so dispatching its value to the controller must be after this setting. (see limitboxcontroller.cxx) Plus some clean up in LimitBox.cxx Change-Id: Ic1d314a5a67c2b261b2e9c50973f51de2bfb8db8
2013-06-10mingw64: long -> sal_IntPtr in dbaccessFridrich Štrba
Change-Id: Ic9e049b6b79a8ae3777d8b2a6e918289445c21da
2013-06-07typosJulien Nabet
Change-Id: I3ebe1c03be3b7e84666ca6a19442c376f21a5491
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ia83fb8615dbe937b4b4478fd7bf128780f8c5289
2013-06-07cppcheck: reduce scopeJulien Nabet
Change-Id: Ie1eab551a2d5dce21b55226b17d62d9a78c1ffdd
2013-06-06Fix previous fixStephan Bergmann
Change-Id: I2d7ea38b743d78327fd19886019c1106bc1316d6
2013-06-06-Werror=sign-compareStephan Bergmann
(ListBox::GetSelectEntryPos returns sal_uInt16) Change-Id: Ia6e4bf4354523f5112ee3ade1d3da6db0f9ab2c4
2013-06-06Prevent out-of-range values coming from ListBox GetSelectEntryPos.Javier Fernandez
Change-Id: Ia787c412408ef53db3c8458f54c7843c669c81ad Reviewed-on: https://gerrit.libreoffice.org/4174 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-06-05fdo#64447 when changing setup mode, trigger changed DatasourceType eventLionel Elie Mamane
Change-Id: I961118331f534de103b83766a2c21a6bec479241
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-05-31dbaccess: unused variableZolnai Tamás
Change-Id: I4bd8863bac0f5b4a5ff1936a9d6a240dbc40be72
2013-05-30dbaccess: this can happen, that's why we check for itMiklos Vajna
Change-Id: Icc85dde5cc53a6880ac83d687bad498ab984c4cf
2013-05-24WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist
Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
2013-05-23Resolves: #i120859# Advance the wizard when Socket edit field has textAriel Constenla-Haile
(cherry picked from commit a9c651aa7f7a05049229c0169e439dccde3b4d51) Change-Id: Ia027dc549e3157eeb7b1d924550ed89122ae1a23
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21allow to create new database using the wizard again (fdo#62937)Petr Mladek
To be honest, I do not userstand the code much. Julien pointed out that the setParentTitle and onTypeSelected were newer called. The condition looked like an optimisation and it helped to remove it. It would be great to put it back. It might be enough to hand the intial values. Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-10Potty mouthChris Sherlock
Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a Reviewed-on: https://gerrit.libreoffice.org/3843 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-05-07dbaccess: remove Package_incMichael Stahl
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-06fix typos (wich instead of which)Philipp Riemer
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-01convert message box return types to an enumCaolán McNamara
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-29fdo#63391 deadlock on opening .odb file that auto-connects to the databaseLionel Elie Mamane
Let foo.odb be a database file that has a macro that connects to the Database on "Open Document" event (and needs to prompt user for user/password). There was a race condition between two actions: 1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController, which tries to get dbaui::OApplicationController's mutex 2) the StarBasic macro calling dbaui::OApplicationController::connect which needs to display a dialog (to get username and password), and thus puts that dialog in the main thread's event queue and waits for it ... with dbaui::OApplicationController's mutex held Now, if "1)" is before "2)" in the event queue of the the main thread, *but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock. Fix: 1) Make OnFirstControllerConnected synchronous. Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph) that nothing else will happen with the OApplicationController as long as it is not finished. ---> it does not need to take mutex itself anymore This avoids the "order in the asynchronous events" dependency. 2) Change dbaui::OApplicationController::ensureConnection to do the user prompting WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning the connection to m_xDataSourceConnection. Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>. ensureConnection will never return the discarded connection, though. (I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) This keeps it from locking on another condition while holding the mutex. Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32 Reviewed-on: https://gerrit.libreoffice.org/3310 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26remove never-generated "predicate_check" entryLionel Elie Mamane
Change-Id: Ib3957fbadf6bfebfaabd5bef09aaf7ab21862cd6
2013-04-26QueryDesign: in criteria, remove column_ref when table *and* column name matchLionel Elie Mamane
As opposed to only the column name Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
2013-04-26String -> OUStringLionel Elie Mamane
Change-Id: Ibf566a11a383b77a930d46967e496752c88b39e4
2013-04-25dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer neededMiklos Vajna
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25fdo#46808, Convert form::ControlFontDialog to new styleNoel Grandin
Change-Id: I83487cddbd6b3fce1fdcdfa48623b63a0e026d90
2013-04-23fdo#46808, convert svx::DbGridControl to XComponentContextNoel Grandin