summaryrefslogtreecommitdiff
path: root/dbaccess/source/ui
AgeCommit message (Collapse)Author
2018-10-24weld OTextDetailsPageCaolán McNamara
Change-Id: I81abd72fb7843aebcf093e421472ecca6998847e Reviewed-on: https://gerrit.libreoffice.org/62291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OMySQLODBCDetailsPageCaolán McNamara
Change-Id: I8f0c291a9bfc3c9cc5edb6095fd31aba68a6feac Reviewed-on: https://gerrit.libreoffice.org/62290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: I0db0801167d36a04ebbe467b29862efcbb54e599 Reviewed-on: https://gerrit.libreoffice.org/62289 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OUserDriverDetailsPageCaolán McNamara
Change-Id: I05db75b90dbb4302f968f129437630adb47a35a8 Reviewed-on: https://gerrit.libreoffice.org/62288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OOdbcDetailsPageCaolán McNamara
Change-Id: I798fa10a1cb4288b0a73e8439b71851c56113129 Reviewed-on: https://gerrit.libreoffice.org/62287 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OAdoDetailsPageCaolán McNamara
Change-Id: I81cbac086a00cdaa649c2794a9192dce8e7c5efe Reviewed-on: https://gerrit.libreoffice.org/62286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OLDAPDetailsPageCaolán McNamara
Change-Id: I9477a52419db08812ccef95107c410685449fa6c Reviewed-on: https://gerrit.libreoffice.org/62285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld ODbaseDetailsPageCaolán McNamara
Change-Id: Ia0d953ee2d4a4f35ba6f59bb6bd6b1a04ed25f63 Reviewed-on: https://gerrit.libreoffice.org/62284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OConnectionTabPageCaolán McNamara
Change-Id: Icdbe5d95d0850d131018d21d0a21cb12109d565c Reviewed-on: https://gerrit.libreoffice.org/62283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24DSID_DATASOURCE_UNO is deadNoel Grandin
ever since it's introduction in commit 1519f106cad10c9832089a8bcad63e6890f7135b Date: Mon Feb 5 12:57:41 2001 +0000 #83430# +DSID_DATASOURCE_UNO Change-Id: If9573e259c8897c6cd5cce649bfde7ff3aef7f77 Reviewed-on: https://gerrit.libreoffice.org/62230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23clang-tidy performance-unnecessary-copy-init in dbaccess..drawinglayerNoel Grandin
Change-Id: I49a152b2aea93d30b16192260f4f659c7e5fcaee Reviewed-on: https://gerrit.libreoffice.org/62215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23weld SpecialSettingsPage and GeneratedValuesPageCaolán McNamara
Change-Id: I3b4c2a4d553032128efe25c008df30d6f1f77628 Reviewed-on: https://gerrit.libreoffice.org/61018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-23tdf#120773: simplify condition in sbagrid.cxx:1265Julien Nabet
Change-Id: If907fe0310f4983ddf1917c6ca88f2cebf4c45aa Reviewed-on: https://gerrit.libreoffice.org/62206 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-22pvs-studio: V668 no sense testing against null as memory was allocated by newCaolán McNamara
category V668 complete Change-Id: I986d4cb89a7c72d54d71ea01fc598a9958deee24 Reviewed-on: https://gerrit.libreoffice.org/62138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V785 Constant expression in switch statementCaolán McNamara
Change-Id: I2ac33db8d265f1af1c8fc8def2d3a45c5be37741 Reviewed-on: https://gerrit.libreoffice.org/62154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: _pView was already dereferencedCaolán McNamara
Change-Id: I72511a46524d02007c7b8e8b0e6486d62cbc7fa0 Reviewed-on: https://gerrit.libreoffice.org/62103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:staticvar in cppuhelper..desktopNoel Grandin
Change-Id: I21cf6bafab6e865b90b29caa73183a8e00b538d1 Reviewed-on: https://gerrit.libreoffice.org/61865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15Fix typosAndrea Gelmini
Change-Id: Iffa6d87339f7ba338e74b2b9d061dd2815b19408 Reviewed-on: https://gerrit.libreoffice.org/61790 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-15loplugin:constantparamNoel Grandin
Change-Id: I895ceffa468d84d22e4a81b7a6b06eaed0bd839d Reviewed-on: https://gerrit.libreoffice.org/61776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14Revert removal of mysql jdbc connectorTamas Bunth
And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: I866add99a699150c6550ee7f7ff2ee947e07117c Reviewed-on: https://gerrit.libreoffice.org/61648 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12weld ODbaseIndexDialogCaolán McNamara
Change-Id: I5cf97cc9f0b7123675bd2dbeb472419ffda9a459 Reviewed-on: https://gerrit.libreoffice.org/61708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12weld OPasswordDialogCaolán McNamara
Change-Id: Id08853ec1789a7a3a361263a4a61329a849f8658 Reviewed-on: https://gerrit.libreoffice.org/61704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11weld DlgFilterCrit and DlgOrderCritCaolán McNamara
Change-Id: Icb96b47cb20a1a80877f693156a3395aba4c70d5 Reviewed-on: https://gerrit.libreoffice.org/61685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11weld OParameterDialogCaolán McNamara
Change-Id: I46b38a4adb4e1e825918029c7b4aba1d267a6e62 Reviewed-on: https://gerrit.libreoffice.org/61665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11tdf#120478: fix wrong icon when JDBC driver test failsJulien Nabet
Change-Id: I1d96e4a5e091caddf46131385ff5274521844fa9 Reviewed-on: https://gerrit.libreoffice.org/61637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-10clean up column pos vs column idLionel Elie Mamane
everywhere GetColumnAtXPosPixel is used; see also tdf#119564 fix Change-Id: Ibab57c7305bf4dce9ea9f3df66e6214b0d1585b2 Reviewed-on: https://gerrit.libreoffice.org/61390 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-06drop some now unnecessary includeCaolán McNamara
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06make OGenericUnoDialog take an awt::XWindowCaolán McNamara
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05weld QueryPropertiesDialogCaolán McNamara
Change-Id: Id523fdb25a24e2ef205bd24e594c8e01772d7a58 Reviewed-on: https://gerrit.libreoffice.org/61406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SbaSbAttrDlgCaolán McNamara
Change-Id: Ic1478d92fcf829bebdf8ada1051a4373d47077cf Reviewed-on: https://gerrit.libreoffice.org/61330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld DlgSizeCaolán McNamara
Change-Id: I5e27d2a27810af98bd0cf59f9e9cbe1cf75d7f1b Reviewed-on: https://gerrit.libreoffice.org/61329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#93372 pass in parent to base's table format dialogCaolán McNamara
Change-Id: I06a39b6517aabac321c45b1a3ab92f13903b9daa Reviewed-on: https://gerrit.libreoffice.org/61265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#119850 show missing mysql connector optionsTamas Bunth
For MYSQL connections there is an extra window which determines how to connect to a mysql/mariadb database. This functionality is handled in OGeneralPageWizard::approveDatasourceType. Change-Id: Ia3c548103b694731cba47ff5390c34b072a938a0 Reviewed-on: https://gerrit.libreoffice.org/60893 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14Fix warning out-of-range value from the DatasourceType selectionJulien Nabet
Fix warn:dbaccess.ui.generalpage:19437:19437:dbaccess/source/ui/dlg/generalpage.cxx:405: Got out-of-range value '2147483647' from the DatasourceType selection ListBox's GetSelectedEntryPos(): no corresponding URL prefix Just Launch Base and select "Open an existing database file" and see this log If there's nothing to display, we get 2147483647 which corresponds to LISTBOX_ENTRY_NOTFOUND Change-Id: Iaab680695d9816c6375d9ef04f02845890f99dda Reviewed-on: https://gerrit.libreoffice.org/60464 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I3d4ae7495f43cae35e8a149c6523bc0337621724
2018-09-09Remove return variableMatteo Casalin
Change-Id: I322386e103e21e2660716419dd0747765ee087de
2018-09-09Reduce OUString operationsMatteo Casalin
Change-Id: Ia95ced36201ee78d511604a33992be0eff4810df
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: Ib84104ea0c523729c3a7fe6019ed2e788ff7b189
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I30b9a9122a1e20f50471d1864b8c08af985fc5d7
2018-09-09Avoid getTokenCount()Matteo Casalin
Change-Id: I13318d43d3c572bd81080d5bb164fdcd9cd7d27b
2018-09-08loplugin:useuniqueptr in OGenericAdministrationPageNoel Grandin
Change-Id: I3028aa7d40b5fea763a93b54bf5f4c5bc4294822 Reviewed-on: https://gerrit.libreoffice.org/60193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-03 21:46:57 +0000