summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-25parameter names are useless in DECL_LINK declarationsNoel Grandin
Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254
2015-08-21Remove demonstrated-useless comphelper::compareStephan Bergmann
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-19comphelper: remove unnecessary include <stack>Michael Stahl
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-19Remove two silly typedefsStephan Bergmann
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-17o3tl: rename compat_functional headerThorsten Behrens
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17convert Link<> to typedNoel Grandin
Change-Id: Ib0bf56a0e642720ff5daafdfc2dc12809be87e43
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Ia66788f5db2da8c6259cd08f655b3cb7cb12ed59
2015-08-11tdf#92459 Cleanup unclear lambdasDaniel Robertson
Replace lambdas used to select the first/second member of a pair with the new simplified select1st/2nd from o3tl/compat_functional. There should be no side effects due to this change. Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89 Reviewed-on: https://gerrit.libreoffice.org/17656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-06-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I0dd91ba9f7b3cbe9c6799c40b7e16a8a58f9d89e
2015-08-05improve refcounting loplugin to check SvRef-based classesNoel Grandin
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883 Reviewed-on: https://gerrit.libreoffice.org/17521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05loplugin:unusedmethodsNoel Grandin
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04filter,desktop,dbaccess: inline some use-once typedefsNoel Grandin
Change-Id: I35f256a11b211c3cb977ae76b5b561efbfd13b9d
2015-08-03com::sun::star->css in dbaccessNoel Grandin
Change-Id: I4fbdd3fb7d1e0ad4423148aaaed3a15aebb26d14
2015-08-03remove some unused definesNoel Grandin
Change-Id: I85a9a2bc12681e13fc482374165ff9bd6858dc93
2015-08-03tdf#91112: pass by const reference to lambdasJorenz Paragas
Since the function returned by o3tl::compose1 had its parameter passed by const reference, the same should be done for the lambda expressions that replace o3tl::compose1. I overlooked this detail in my previous commits. Change-Id: I0db5eec4e74d4835e786742ee6de3805215f377f Reviewed-on: https://gerrit.libreoffice.org/17465 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03tdf92459 replace select1st/2nd in dbaccessDaniel Robertson
Replace all uses of deprecated features in the o3tl with lambda expressions in dbaccess. Change-Id: I865bb5db5257e985a0eed0110874d6b29892fcfb Reviewed-on: https://gerrit.libreoffice.org/17483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-31dbaccess: replace boost::function with std::functionMichael Stahl
Change-Id: I4bea36a9add24f9144c8e222e9ce42c7c9f3678b
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27inline a bunch of use-once macrosNoel Grandin
no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27remove some unused definesNoel Grandin
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24loplugin:unusedmethodsNoel Grandin
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24convert ImageAlign to enum classNoel Grandin
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
2015-07-22cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib80e7f6d055bead246db3028b4eab6edfabe3d2c
2015-07-20svtools: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I895c950c11499afb278b989565f3eae33aaf4a76
2015-07-20svtools: change these SvTreeListEntry functions to unique_ptrMichael Stahl
... parameters to make it clear that they take ownership. Change-Id: I572c5fa6268438a86d0a4fa1d2aef15382cb5607
2015-07-20cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I45f2d96c7bd558405d0b5dfea3beb97ad720a82b
2015-07-20loplugin:unusedmethods dbaccessNoel Grandin
Change-Id: Ifa16acc6d90ebd4f56c5662959010f6228228cb5 Reviewed-on: https://gerrit.libreoffice.org/17209 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I6f25d8cf14e3e12eecb29eb02e018ecfa73539dd
2015-07-20cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib9373a5a75eea998a86156ff742e7950369ddc88
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-17tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants, for dbaccess. Change-Id: I60921b1b1d3b65fb9087552ed118c60dc9f89032 Reviewed-on: https://gerrit.libreoffice.org/17146 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Ifaae5adf238dd24438cc321202271e898fd01543
2015-07-16loplugin:unusedmethods sfx2Noel Grandin
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62 Reviewed-on: https://gerrit.libreoffice.org/17069 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-12Missing dependencyStephan Bergmann
Change-Id: I7ff00286fa160a46a735b2a3e59bf0f6e1089c9f
2015-07-09tdf#92434 - dispose the table contents.Michael Meeks
fix issue from: 6d0c89123f353aed80d3a8a08ef5cd1ffaa1eea9 Change-Id: Ia5b7bb91c366ecbbb3111d6f5239d5360640ca2d Reviewed-on: https://gerrit.libreoffice.org/16893 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-07Related: tdf#92434 children cleared but parent hasn't completed dispose yetCaolán McNamara
Table::dispose is being executed, so its not IsDisposed yet, but this a11y code gets called during the dispose and the children have been cleared at this point Change-Id: I20aa9b15b1c5c3da91af58ac61f59fcf52619d58
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I999923031c573f361bc421eab84e68a4a130d688
2015-07-04tdf#92520: LibO crash when editing .odb database propertiesZolnai Tamás
Regression from: f7424ed710e54bb2437a28380b03ed7c26290edc Change-Id: I7665d579696f21846abaed21ca8c4f14acdc964c
2015-07-03Fix typosAndrea Gelmini
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-02some other coverity thingsCaolán McNamara
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02tdf#92434 - A series of hideous knock-on dbaccess crasher fixes.Michael Meeks
Focus events during dispose, unfortunate incoming a11y events, etc. Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c Reviewed-on: https://gerrit.libreoffice.org/16672 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-02tdf#92434 - fix iteration, and remember to disposeAndClear.Michael Meeks
Change-Id: Id9c7b33689ea51a18394a96acbb9c08d67992942 Reviewed-on: https://gerrit.libreoffice.org/16671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>