summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23use rtl::Reference in SbaXGridControlNoel Grandin
instead of manual acquire/release Change-Id: Ie103377d89419648d5f1d786933030b6f6166515
2017-01-20use rtl::Reference in ORowSetCacheNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: Ib3a4314a3d05e3c14a674b3d87baad245863ec6e
2017-01-19New loplugin:dynexcspec: Add @throws documentation, dbaccessStephan Bergmann
Change-Id: I117be0dca3cc5e204414613123422b4b0716d8ed
2017-01-18d*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Ibf741af5e5043fae6139a19cec3d244dee06f225
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-16new loplugin: useuniqueptr: dbaccessNoel Grandin
Change-Id: I2421cd032066c41f80e8b6560c8c4a73f26edeb2 Reviewed-on: https://gerrit.libreoffice.org/33151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13unixODBC changed soname to .2 so reflect itTomáš Chvátal
we dlopen this library and thus we should be able to find it with any soname, so far .1 and .2 seem to be used. Also now the load order on linux is: .so.2 -> .so.1 -> .so Change-Id: Idcd284fada1acdfe8dde46c3056c21b792777280 Reviewed-on: https://gerrit.libreoffice.org/32755 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11Some loplugin:conststringvar/stringconstant improvements: dbaccessStephan Bergmann
Change-Id: I30fee1c51ff3e0b8e3e74b4293227a5bfbfe0837
2017-01-10Resolves: rhbz#1409634 crash on close storing clipboard of database tableCaolán McNamara
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f
2017-01-09New loplugin:externvar: dbaccessStephan Bergmann
Change-Id: Ie1b87180b68c1f106128f0fc7a3a591c055b735f
2017-01-07Typo: Acess->AccessJulien Nabet
Found thanks to Buovjaga Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3 Reviewed-on: https://gerrit.libreoffice.org/32810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07Typo: Postion->PositionJulien Nabet
Found thanks to Buovjaga Change-Id: Iacf09325cdb58e0dbdcc9bf0570b2e02ed275132 Reviewed-on: https://gerrit.libreoffice.org/32808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05require firebird 3.0 for build (don't allow 2.5)Lionel Elie Mamane
Keep firebird_integer_x64le.odb around for a future 3.x firebird that will allow opening Firebird 2.5 databases, so that we can test this capacity in our tests. Change-Id: I05dbef51284bdb25132ff6cb661659430eea6a92
2017-01-02micro optCaolán McNamara
Change-Id: I2d713783f1ad533c23a3fe319e7c37b7fd0e0e0d
2017-01-02Remove newly added SAL_WARN_IFJulien Nabet
Following Stephan's comment from https://gerrit.libreoffice.org/#/c/32643/ Change-Id: I6bb5c243313c3f0793286c6bae2967a6208dc854 Reviewed-on: https://gerrit.libreoffice.org/32651 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02Typo: m_nColumnPostion->m_nColumnPositionJulien Nabet
Change-Id: Iab83a89b5cfa1ca379cb59366682d5d2adeb0e31 Reviewed-on: https://gerrit.libreoffice.org/32645 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02Remove some OSL legacies in dbaccessJulien Nabet
Change-Id: Id809265c1df7df48e77ac2d8fbff685c599f8432 Reviewed-on: https://gerrit.libreoffice.org/32643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02Translate German logs in QueryTabWinUndoAct (dbaccess)Julien Nabet
Change-Id: Ia9a0dfac2174de6b0edc03d99cae0b9729cef36b Reviewed-on: https://gerrit.libreoffice.org/32644 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02osl/diagnose.h useless in userinformation (dbaccess)Julien Nabet
Change-Id: I44c83f3655d49af9d28dd34a52e9266294b21552 Reviewed-on: https://gerrit.libreoffice.org/32639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-26use std::vector instead of naked array in SfxItemPoolNoel Grandin
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-23remove unused ImageListsCaolán McNamara
since... commit 0dc13e9c06bf5bc188b427f0760d0dc2eee8f75e Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jun 10 12:32:03 2014 +0100 tweak things to allow switching between small and large toolbar icons Change-Id: I3e1821297c5f7ea1a00356e51167d75265462ee7
2016-12-22Dispose component when doneStephan Bergmann
Change-Id: I3ea2004556b01ba992215b9142b9c8a6aabb63c0
2016-12-22Dispose document when doneStephan Bergmann
Change-Id: I73a1cb1c206a2f55ec0c8948fca29b3976a51e75
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21remove newly unused SfxImageManagerCaolán McNamara
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-17Minor simplificationStephan Bergmann
Change-Id: Ia953a09f708fd83a2a5b2655dec2ed626891bb7c Reviewed-on: https://gerrit.libreoffice.org/32099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12dbaccess: fix testCloneMovesPlusDeletions testMichael Stahl
JunitTest_dbaccess_complex spuriously fails 1% of the time with: 1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet) java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756) The problem is that line RowSet.java:750 deleteRow() manages to delete the last row in the set, because the positionRandom() is tricked to position itself on the last row (which it tries not to do), becuase the RowSet is currently positioned past-the-end on a deleted row and the ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the result in this special case. Funnily both the ORowSetBase::impl_getRowCount() and the test using positionRandom() were added in CWS rowsetdel. Yay for randomized tests! Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e
2016-12-12Prevent use of ORowSetValue with sal_Bool as TINYINTStephan Bergmann
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of ORowSetValue with sal_Bool instead of bool, apparently intending to treat the value as a boolean, actually treated it as a TINYINT. (See e.g. recent 7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit bool-to-ORowSetValue conversion".) Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the m_uInt8 union member can probably go away, too. Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3 Reviewed-on: https://gerrit.libreoffice.org/31909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05only IMG_PRIMARY_KEY is actually usedCaolán McNamara
Change-Id: Ie888ed93f0d511e0c040af32f41e8350113b586c
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in dbaccessStephan Bergmann
Change-Id: I22cf2fec8e543582a32b9a4f00221f1b2d864f7a
2016-11-29Use Size::Width/Height instead of inherited Pair::A/BStephan Bergmann
Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-23convert SAD constants to o3tl::typed_flagsNoel Grandin
and drop unused SAD_TITLE_STORE_AS Change-Id: I5114958b3954e3dc3ffd941334c6c4dbfbed7aea
2016-11-23convert EF constants to o3tl::typed_flagsNoel Grandin
and remove now unused ByteVector typedef Change-Id: I9c4b30aea2608cf97e597b00b4a4ea800efac4ec
2016-11-23convert CBTP constants to o3tl::typed_flagsNoel Grandin
Change-Id: I453a9bacef737a56e381c4172710ec6acf225f0b
generated by cgit (git 2.34.1) at 2025-01-26 22:27:40 +0000