summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2018-07-08Fix typoAndrea Gelmini
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-06HSQLDB Migration: overwrite backup xmlTamas Bunth
Change-Id: I080568f2d278e8a7153188497e3987217d9d188f Reviewed-on: https://gerrit.libreoffice.org/56464 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06dbahsql: Look for properties only after nameTamas Bunth
Additional properties in SQL string like "DEFAULT" or "NOT NULL" should be searched only after column name, because what if a column name is "myEvilNOT NULLColumn" Change-Id: I21f0755ba14c7267243d9999f044db4d16963387 Reviewed-on: https://gerrit.libreoffice.org/56462 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06dbahsql: refactor, around parseColumnpartTamas Bunth
Change-Id: I663da1474d3f1c3bde8a3d3c041e8fd0fe4c7d43 Reviewed-on: https://gerrit.libreoffice.org/56459 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06tdf#117867 dbahsql: Migrate default valuesTamas Bunth
Default Value "NOW" is a special case, because Firebird likes it with single quotes. In contrast, HSQLDB uses the keyword without quotes. Add unit test for parsing default value "NOW" Change-Id: I34886f8ae53e98addb52bf5e85030a03721d6a45 Reviewed-on: https://gerrit.libreoffice.org/56454 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-03no need to switch models in the SvTreeListBoxNoel Grandin
since we're replacing it completely anyhow. which means we can remove DisconnectFromModel Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087 Reviewed-on: https://gerrit.libreoffice.org/56849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29tdf#96099 Remove trivial std::map typedefs in [cd]*Arkadiy Illarionov
Change-Id: I043d265d3d73a3e16f05d5ca7e29a09341651d82 Reviewed-on: https://gerrit.libreoffice.org/56639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21Skip CppunitTest_dbaccess_hsqlbinary_import unless ENABLE_JAVATor Lillqvist
Change-Id: Ib31f2bb1234607f0da4806f2e991ecc5d323f9e6 Reviewed-on: https://gerrit.libreoffice.org/56239 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-20Resolves: tdf#118120 RET_ALL shares same value as RET_HELPCaolán McNamara
Change-Id: I766c379171ac25eb9c1d8036e052fb8f2b4e1459 Reviewed-on: https://gerrit.libreoffice.org/56167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-19tdf#118220 Base : Tools -> Table Filter crashesNoel Grandin
regression from commit b69457c1a5cb31c8b0fb3d047e2826bc3d61fea4 loplugin:useuniqueptr in OTableSubscriptionDialog Change-Id: I9f29452736554b18dbc207c870ed1799fe38b6e1 Reviewed-on: https://gerrit.libreoffice.org/56110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-19Fix typoAndrea Gelmini
Change-Id: I95b12975f6444e7eb6a8de6053d8e8ca021eacfb Reviewed-on: https://gerrit.libreoffice.org/56069 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-18Back up content.xml when migrating databaseTamas Bunth
Change-Id: I4eacbf689989d20142c04dc8fe586d0054c46350 Reviewed-on: https://gerrit.libreoffice.org/55962 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-14menubar: update and sync all base menubarsandreas kainz
Change-Id: I9b7e31f2335f01e20ee71137fdb2fd0315f3bd91 Reviewed-on: https://gerrit.libreoffice.org/55542 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-14tdf#118043 dbahsql: Fix putDot funcitonTamas Bunth
Change-Id: Ia49b7e852446b05a4e20a7ff0c32d8acc6da52b2 Reviewed-on: https://gerrit.libreoffice.org/55594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#117115 dbahsql: respect escaped '\'Tamas Bunth
Change-Id: Id408f7a98011d806f01b6c63ae67008c4dba4b0d Reviewed-on: https://gerrit.libreoffice.org/55595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-06-10fix CppunitTest_dbaccess_hsqlbinary_importRene Engelhard
at least with system-hsqldb. add missing connectivity/source/drivers/hsqldb/hsqldb to gb_CppunitTest_use_components Change-Id: I6e845dadd67276b137734f68ba922a1d5890c809 Reviewed-on: https://gerrit.libreoffice.org/55551 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-06Translate German comments and debug stringsJohnny_M
And correct a few comments (translation and grammar) Change-Id: Ifafa521c683e9ca65aeba8031cd4cbfc1fadc137 Reviewed-on: https://gerrit.libreoffice.org/54888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-06enable incremental linking on windowsNoel Grandin
requires a handful of workarounds Change-Id: I77c25580135eeec437716eceea1412607f8d14ca Reviewed-on: https://gerrit.libreoffice.org/55244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04Properly decompose vnd.sun.star.pkg URLStephan Bergmann
When the URL encoded in the vnd.sun.star.pkg URL's authority contains a "@" (e.g., because it is a file URL denoting a pathname containging a "@" in one of the segments), that "@" need not be encoded (cf. the grammar at the top of tools/source/fsys/urlobj.cxx) and INetURLObject::GetHost would only return the part following the "@". When constructing sBaseURI in ODatabaseContext::loadObjectFromURL (dbaccess/source/core/dataaccess/databasecontext.cxx), the path part shall obviously not be decoded (but which the original code erroneously did). However, when obtaining sStreamRelPath in ODBFilter::implImport (dbaccess/source/filter/xml/xmlfilter.cxx), it isn't clear to me whether the path should be decoded, so I left that in (and added a TODO). (Caused `make CppunitTest_sw_uiwriter CPPUNIT_TEST_NAME=SwUiWriterTest::testEmbeddedDataSource` to fail when SRCDIR is such a pathname containing a "@" in one of the segments.) Change-Id: I6ffd842f3f3d37d2682e7cf14399fb3dbfa0a2aa Reviewed-on: https://gerrit.libreoffice.org/55286 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-03tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov
Change-Id: I21171bd90b5e19fe8e5b8f2d125b6dfcb9a8b766 Reviewed-on: https://gerrit.libreoffice.org/55198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-29loplugin:useuniqueptr in OTableSubscriptionDialogNoel Grandin
Change-Id: If8fa9edc62f75f41de1392688a169458ce003bda Reviewed-on: https://gerrit.libreoffice.org/54852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in ODbTypeWizDialogSetupNoel Grandin
Change-Id: I5d1e737510d423f9caa44ad5b498ef5e781c24d0 Reviewed-on: https://gerrit.libreoffice.org/54856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in DbaIndexDialogNoel Grandin
Change-Id: Ife795db29256a50a93b668890c85473872d350a9 Reviewed-on: https://gerrit.libreoffice.org/54853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29loplugin:useuniqueptr in dbaui::SbaSbAttrDlgNoel Grandin
Change-Id: Ia24f948370b30ccc3870e36c19312e9eebb309b3 Reviewed-on: https://gerrit.libreoffice.org/54851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28tdf#117732: Mig FB, fix reading of timeJulien Nabet
Change-Id: Ie67b50d899c4684f6fadd0c42337f54ef952078e Reviewed-on: https://gerrit.libreoffice.org/54646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-28loplugin:useuniqueptr in ODbTypeWizDialogNoel Grandin
Change-Id: I4c364ddbad4881cc8a70a1827d7c51e7cc9313f1 Reviewed-on: https://gerrit.libreoffice.org/54850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28tdf#96099 Remove some trivial typedef std::vectorArkadiy Illarionov
Change-Id: I41fff78c10d46bde50063536d8cf1a3942dbf6af Reviewed-on: https://gerrit.libreoffice.org/54834 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-28loplugin:useuniqueptr in OMarkableTreeListBoxNoel Grandin
Change-Id: Ifd3ea7fa32e9b254ff901a014f559ab211948929 Reviewed-on: https://gerrit.libreoffice.org/54849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:useuniqueptr in OQueryControllerNoel Grandin
Change-Id: I13ca3ea6c27d4572274b70b0481a8479852b569a Reviewed-on: https://gerrit.libreoffice.org/54857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:useuniqueptr in DlgQryJoinNoel Grandin
Change-Id: Ia9a5534b6d69dde163fae54fbd2764dc9b279a5d Reviewed-on: https://gerrit.libreoffice.org/54855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:useuniqueptr in OTableConnectionNoel Grandin
Change-Id: I4fe5c706d0aec4b2b81bdbe9e9a59e771af4a02e Reviewed-on: https://gerrit.libreoffice.org/54854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25Improve re-throwing of UNO exceptionsNoel Grandin
(*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25loplugin:passstuffbyrefNoel Grandin
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25tdf#117115 dbahsql: respect unicode in columnsTamas Bunth
Change-Id: I6a1dcba0afda88eaf083f0d4c73c1e74b0c78f56 Reviewed-on: https://gerrit.libreoffice.org/54297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-24tdf#117670: migration Firebird, deal with multiword columnJulien Nabet
by changing parsing process a bit Change-Id: I77c06ba218e9bc0d241dbff10f76860d0ca5ed44 Reviewed-on: https://gerrit.libreoffice.org/54542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-24tdf117333 dbahsql: Chain SQLExceptionsTamas Bunth
Change-Id: Ic24d79f39d9cc36cf229c7410e1f96c4c3d316f9 Reviewed-on: https://gerrit.libreoffice.org/54671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-23toolbar:id is not valid attribute of toolbar:toolbarChristian Lohmaier
according to framework/dtd/toolbar.dtd – and having the same ID everywhere also is kinda pointless.. Change-Id: Ia7768be2f951886e39e24d78fc6d69b4f3c84235 Reviewed-on: https://gerrit.libreoffice.org/54665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-23Fix typosAndrea Gelmini
Change-Id: Ibe94c7379a9389a0506c33666bf2bfb033f96f08 Reviewed-on: https://gerrit.libreoffice.org/54670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-05-20tdf#117298: migration Firebird, fix time dataJulien Nabet
by just adjusting nColIndex like other datatypes Change-Id: Ia7947b3498818bac2f033eac81ac3835f98bbab3 Reviewed-on: https://gerrit.libreoffice.org/54581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-17weld SvxJavaClassPathDlgCaolán McNamara
Change-Id: I3938a05d96cb1fc171611e54fa34f780ba569268
2018-05-17loplugin:unusedfields in dbaccess..drawinglayerNoel Grandin
Change-Id: I069badbce9b899d176fd3db91243139579dec6b1 Reviewed-on: https://gerrit.libreoffice.org/54456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16Fix typosAndrea Gelmini
Change-Id: I979323310cbb3473f7dc0f3d9ae1ea3f4c1642db Reviewed-on: https://gerrit.libreoffice.org/54420 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-05-16tdf#117333, tdf#117325 dbahsql: exception handlingTamas Bunth
Add proper exception handling for importing HSQL database. If there are errors during migration, the migration process should continue anyway. The first error should be shown to the user. All the others can be seen as a warning. Popping up several error messages would be just annoying for the user. Change-Id: Ia726ad777fd798f064a8fde1c0062c5b05fe59d0 Reviewed-on: https://gerrit.libreoffice.org/54396 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-05-16tdf#116987 dbahsql: check for table names..Tamas Bunth
..longer than 30 characters. In that case throw SQLException which indicates that the currently used Firebird version cannot handle table names longer than 30 characters. Change-Id: Ib2978feaeef22b70de9f2351042c25206a041105 Reviewed-on: https://gerrit.libreoffice.org/54398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-14loplugin:useuniqueptr in SaveDBDocPageNoel Grandin
Change-Id: I750e6de1cce5355281336343b1ec03596113e311 Reviewed-on: https://gerrit.libreoffice.org/54170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-14loplugin:useuniqueptr in ORowSetNoel Grandin
hold this by rtl::Reference since we are taking references to it elsewhere and passing them around. Change-Id: Iae68d7da67cf84f01deb6bb42c00e4c74d7a99d7 Reviewed-on: https://gerrit.libreoffice.org/54169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-19 23:05:23 +0000