summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21allow to create new database using the wizard again (fdo#62937)Petr Mladek
To be honest, I do not userstand the code much. Julien pointed out that the setParentTitle and onTypeSelected were newer called. The condition looked like an optimisation and it helped to remove it. It would be great to put it back. It might be enough to hand the intial values. Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-19make OSingleSelectQueryComposer use *system* parse contextLionel Elie Mamane
and pass it to the parser and PredicateInput constructors. This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale. Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-14SolarMutex does not belong into the URE interfaceStephan Bergmann
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an abstract interface to be used to implement a SolarMutex" put it here in the first place. I do not consider this an incompatible change really, as no external URE client code should have used SolarMutex anyway. (Also included some clean up, like removing unused {Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places it is used.) Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14fdo#46808, fix call to sdb::tools::ConnectionToolsNoel Grandin
In my previous conversion to new style I forgot to pass arguments into the service constructor. Change-Id: Ibbf750315b3e62869b1eb4c520808327002f2dcc
2013-05-14Initialise the default-constructed ConnectionToolsLionel Elie Mamane
Regression from the "convert to new style", which led to ignoring aArguments Change-Id: I09477578f77b253b8c6435d52e1e636d2e212023
2013-05-13Fix namingStephan Bergmann
Change-Id: Id167385e832b1cd78d0612fc2a7611aa76bf0601
2013-05-12Fix possible inefficient checking for variables emptinessJulien Nabet
Change-Id: I95a6784d5448b63b0cdde436484915692f8633be
2013-05-10Potty mouthChris Sherlock
Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a Reviewed-on: https://gerrit.libreoffice.org/3843 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-05-07connectivity: remove Package_generatedMichael Stahl
This one is ugly, the Yacc generated header is used in lots of places; the dependencies are already right because using the header requires using the dbtools library which builds the YaccTarget, so just yet another include path has to be added. Change-Id: I031fde80ac326551d4719533305b1ae35351ca43
2013-05-07officecfg: remove Package_cppheaderMichael Stahl
Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-07dbaccess: remove Package_incMichael Stahl
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-06fix typos (wich instead of which)Philipp Riemer
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06Java cleanup, remove unnecessary @SuppressWarnings annotationsNoel Grandin
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
2013-05-01convert message box return types to an enumCaolán McNamara
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-29fdo#63391 deadlock on opening .odb file that auto-connects to the databaseLionel Elie Mamane
Let foo.odb be a database file that has a macro that connects to the Database on "Open Document" event (and needs to prompt user for user/password). There was a race condition between two actions: 1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController, which tries to get dbaui::OApplicationController's mutex 2) the StarBasic macro calling dbaui::OApplicationController::connect which needs to display a dialog (to get username and password), and thus puts that dialog in the main thread's event queue and waits for it ... with dbaui::OApplicationController's mutex held Now, if "1)" is before "2)" in the event queue of the the main thread, *but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock. Fix: 1) Make OnFirstControllerConnected synchronous. Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph) that nothing else will happen with the OApplicationController as long as it is not finished. ---> it does not need to take mutex itself anymore This avoids the "order in the asynchronous events" dependency. 2) Change dbaui::OApplicationController::ensureConnection to do the user prompting WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning the connection to m_xDataSourceConnection. Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>. ensureConnection will never return the discarded connection, though. (I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) This keeps it from locking on another condition while holding the mutex. Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32 Reviewed-on: https://gerrit.libreoffice.org/3310 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26remove never-generated "predicate_check" entryLionel Elie Mamane
Change-Id: Ib3957fbadf6bfebfaabd5bef09aaf7ab21862cd6
2013-04-26QueryDesign: in criteria, remove column_ref when table *and* column name matchLionel Elie Mamane
As opposed to only the column name Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
2013-04-26String -> OUStringLionel Elie Mamane
Change-Id: Ibf566a11a383b77a930d46967e496752c88b39e4
2013-04-26Java cleanup, remove unused importsNoel Grandin
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
2013-04-25Fix compilation error when OSL_DEBUG_LEVEL > 0Tor Lillqvist
Just use SAL_WARN, building up the message using chained << operators instead of constructing it into a OStringBuffer (or OUStringBuffer) and then passing that to OSL_FAIL. Or should we have a real assert() here? Change-Id: I2c3f64ff2b29a3d81ba444d98c2a38ef49e6d7af
2013-04-25update pchThomas Arnhold
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
2013-04-25dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer neededMiklos Vajna
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25add missing deps on sqlbison.hxxDavid Tardon
Change-Id: I098a4514b9b32b1ecf96b1f2275f77bac540d557
2013-04-25fdo#46808, Convert form::ControlFontDialog to new styleNoel Grandin
Change-Id: I83487cddbd6b3fce1fdcdfa48623b63a0e026d90
2013-04-24gbuild: drop empty use_packages callsDavid Tardon
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: https://gerrit.libreoffice.org/3503 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23Access Query Properties Dialog from toolbar tooZolnai Tamás
Change-Id: Ide4697e6903c9550d31ea22ff0a5881878fddacf
2013-04-23fdo#46808, convert svx::DbGridControl to XComponentContextNoel Grandin
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-20fdo#63154: Change Min/Max/Abs for std::min/max/absMarcos Paulo de Souza
Now all these usages were removed from LO. Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Reviewed-on: https://gerrit.libreoffice.org/3326 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-19Remove any remaining remnants of unused component_canUnload featureStephan Bergmann
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19Java cleanup, remove unnecessary castsNoel Grandin
Change-Id: Id12089bc7df16631737e6acaee0973fb91dd953f Reviewed-on: https://gerrit.libreoffice.org/3431 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-17Update pchAurimas Fišeras
Change-Id: Ice80350184f7a514d5beab0a5e1da5b98d5733e4 Reviewed-on: https://gerrit.libreoffice.org/3427 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-04-16merge duplicated CreateFontDescriptor methodsCaolán McNamara
Change-Id: I33f9df7f17158eedc4a4c0dedfd0fc4cddc6180f
2013-04-15FontWeigth->FontWeightCaolán McNamara
Change-Id: I6250c3e3de81c33e8f4d73e2f80570521fdb6ea6
2013-04-15fdo#60724 successfull -> successfulThomas Arnhold
Change-Id: I287bef5b7f2baf5aaaab47141267ae2cadfe2451
2013-04-15fdo#60724 correct spellingThomas Arnhold
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15fdo#60724 informations -> informationThomas Arnhold
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
2013-04-11deliver all uiconfig files by UIConfigDavid Tardon
Change-Id: Ie78b7ce399ba34485146ca7622c59d31f8105d02 Reviewed-on: https://gerrit.libreoffice.org/3229 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-11rename UI to UIConfigDavid Tardon
I plan to use it to deliver all */uiconfig files, not just .ui, as a preliminary step to get rid of postprocess/packconfig. Change-Id: Ie7b4434b2f247165e3ab69a4d0c193418720a149 Reviewed-on: https://gerrit.libreoffice.org/3225 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-09WaE: unused variable 'insert_result'Tor Lillqvist
Change-Id: I5b0b7eeaa44e3e9e215b8d0bba7e7189c63c766c
2013-04-08The library we want is called dbulo, not dbauiTor Lillqvist
Change-Id: Iaf57030a228d9c03c132976293d5e01e2fb287f4
2013-04-08fdo#46808, Convert frame::Frame to new styleNoel Grandin
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
2013-04-08fdo#46808, Convert svt::ToolboxController to XComponentContextNoel Grandin
.. and all of it's friends Change-Id: I408d9308d1d1a4f8ed0055ac5f4042d729c44d1e
2013-04-08fdo#46808, Convert beans::PropertyBag to new styleNoel Grandin
Change-Id: Ibb2466af4c9289cba93b8330d10db033d296bfc1
2013-04-08fdo#46808, convert sdb::tools::ConnectionTools to new styleNoel Grandin
service already existed, just needed an IDL file Change-Id: I9000cff76056efecf7ac748bcfc6dd5b8e902e65