Age | Commit message (Collapse) | Author |
|
because this is used during sorting of the tree elements so its position
isn't necessarily meaningful during the sort. DBTreeListUserData is
supposed to exist for elements not staged for removal and that already
has the type as a member
Change-Id: Ie1004dbcdca2fae8711941d98a084103a0b15815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122355
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
(cherry picked from commit 7d5a4c031221d8099c554a84684ce42b0390be1f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122744
|
|
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=174832
Change-Id: Ia0a52b1e6aafc043f6be2d8406a98e7d4ebf55dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121735
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 970883a85ad1d714683a1d98fb45efc89cbdeb3b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121758
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Before this fix, date categories imported in oox's DataSourceContext were
stored as formatted strings according to number format code in <c:formatCode>
under the <c:cat> tree. As a result chart2 could not recognize them
as dates. This causes problems like:
* The axis that is linked to date categories cannot use the
scaling/range-selection(min/max)/increments specs mentioned as axis
properties. This results in distorted/unreadable chart renders w.r.t
the date axis.
* No re-formatting is attempted as per the number format provided for axis.
This patch introduces a role qualifer argument to the XDataProvider
interface method createDataSequenceByValueArray to support categories of
date type via this method.
When exporting to oox, write date categories and format code under
<c:cat>
<c:numRef>
<c:numCache>
This patch also fixes some discrepancies in date axis interval
computation (auto mode) found by already existing unit tests.
Conflicts:
chart2/qa/extras/chart2export2.cxx
chart2/source/inc/InternalDataProvider.hxx
chart2/source/tools/InternalDataProvider.cxx
Change-Id: Ibc53b0a56fdddba80ba452d5567ce98d80460ea7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121525
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit f547cf17a179ebd7de5c2b4dd2d00d0027a25429)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121723
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
|
|
revert...
commit f97dbac73fe149e8fed0932890d0c1d6be4869a3
Author: Caolán McNamara <caolanm@redhat.com>
Date: Wed Jun 26 21:00:02 2019 +0100
infinite focus changing in toc biblio page
which blocked calling focus-changed callbacks when grab_focus is called
explicitly analogous to how we block value-changed callbacks setting
values through code but don't block them when the value is changed by
user interaction.
In retrospect that was a poor choice, so revert that and subsequent
workarounds in favour of just not calling gtk_grab_focus if the widget
already has focus.
checked:
a) tdf#138427 focus set to wrong input box
b) tdf#138078 only call GetFocus if we gained focus from an unfocused state
c) tdf#137993 ensure the toplevel vcl::Window is activated
d) tdf#136941 call focus in handler explicitly
Change-Id: I411480e2d627aa9995fb41b0aa17e9fb6d34d73f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114524
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit db1cf111666847ce5ce93d18ae5ae8c29a4c44d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120079
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic827cb967a9a9cb78f28a23707813aeec8381cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117019
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
drop odb load tests of experimental era odbs that only contain fdb and
not fbk, that ends up only proving that was a bad idea which we know
so that's why we stopped doing it
this squashed commit contains...
HAVE_FIREBIRD_30 is not used anymore
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
and...
drop firebird test of initial experimental period fdb-only format
Initially when the firebird embedded database support was first
experimental we saved the fdb firebird file format.
A test was added by 3f114eb4a2f3994b980aa607f2d4afc58e5aaa1d around then
(2013) to test loading firebird odbs
Then with
commit de899f0b350e51b1932fa4674f7ce2ae386cd1ce
Date: Thu Jun 2 11:56:10 2016 +0200
connectivity: firebird: use ODS12 test database for Firebird 3
if building with firebird 3 a replacement odb was created in firebird
3.X ODS12 format to use instead of the 2.X ODS11 file.
Those fdb file formats were endian specific and database version
specific. Which was a well known problem documented in tdf#72987 and a
blocker for leaving 'experimental' at that point in time.
So finally with
commit 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
Date: Thu Aug 11 12:02:56 2016 +0200
tdf#72987 GSoC Use Firebird backup format
the save was changed to save the backup fbk file format and load
restores the database from that fbk file format (2016) when available.
later in
commit 860ecb9e583627ab43097784ad98b41afd983ff6
Date: Thu Jan 5 12:58:26 2017 +0100
require firebird 3.0 for build (don't allow 2.5)
the firebird 2.X (ODS11) test of loading the fdb format was
dropped leaving just the firebird 3.X (ODS12) fdb case because firebird
3.X cannot directly load the ODS11 format
Now with the appearance of firebird 4 the same problem arises that
firebird doesn't load older binary formats directly.
In the end all we established here is that an odb containing only a fdb
is endian and version specific and a bad idea wrt compatibility so we
shouldn't do that. But we knew that, so embedded firebird databases were
an experiemental curosity until 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
enabled use of the fbk format.
We're not gaining anything with the test of loading the binary only case
because we know that's an unsustainable route we abandoned.
Change-Id: I330065f61d2d0fdfeeaeba4ee2e739e222d1c665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116895
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
xmllint --noout dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml:24: namespace error : Namespace prefix menu on menuseparator is not defined
<menu:menuseparator/>
should be a toolbarseparator here
a problem since...
commit 4f810905fa74128871f2fe924a3d28a79f4e4261
Date: Tue Mar 5 15:42:19 2019 +0100
sync dbaccess ui files with swriter ui file structure
Change-Id: I000efac56a0af10bca7c22fba6f88f469ae9b272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116711
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I9474553e595780fa61bac955d2d5ebf691408ede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107437
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess
when storing form documents it has loaded from ODF 1.3 documents: the
XML parts are stored as ODF 1.2, but the storage (and therefore manifest
entry) keeps version 1.3.
To avoid this, store form documents as ODF 1.2 extended by default.
Unfortunately a bunch of ODF export code accesses the global
SvtSaveOptions variable; with this version override, only
SvXMLExport::getSaneDefaultVersion() must be used.
Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 16de54a5c47fbc4691ee099c1f7bb559a8fe11ac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115390
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
In order to prevent that the frame action listener
holds the object reference count when removed,
ensure they are removed when disposing the object.
Change-Id: If83574e31230d9c683adaf36af36485650fd2c50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113389
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
in the relationships view
Change-Id: I1d4a34dbf86a797573705c202719f5159b5a8bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113651
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... and remove Help - Get Involved menu item, too
Change-Id: I7a701173f596306ee628ae4a12ad81d2d756caca
|
|
Change-Id: I85c0d178c3d6e375beb3ad50c4bae9ba0ac29937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111033
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
to reproduce: under gen launch base wizard, "open an existing database
file", and use the "open" button, double click a .odb.
base launches on the 2nd button down, on mouse *release* base has
appeared and has a treeview under the mouse which gets button up and
triggers "onSelected" with the unexpected no-row selected case
https: //crashreport.libreoffice.org/stats/crash_details/a6282ff5-d0aa-4beb-9b44-6c5fd2ca0130
Change-Id: Ic4a5fa9fc8c9c6bb0e33c165559eda966b83e3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110689
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I69703228a942f16efd7a9c6270639fadd5c6c51e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110214
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
i.e. input fr/de 12,34 should be stored as 12.34
Change-Id: I20c97d2d604998a40e3a15963aa3d8716101e3c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109750
Tested-by: Jenkins
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
|
|
regression from...
commit 5f7cf9ccba25a94c275ec67936dc29f0adb4129a
Author: Caolán McNamara <caolanm@redhat.com>
Date: Mon Aug 10 19:49:25 2020 +0100
use InterimDBTreeListBox
Change-Id: I755879699aa6fcc9b42b5845ae60406794e11cc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109688
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: Idd351405dbdccdf75d350ace876f8a8d00d9e549
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109680
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
|
|
if we truly want it to be modeless, then unset this bit and use
the runAsync mechanism
Change-Id: I7d1cae1975d6ac20ef34b7744981ee72b9f52c78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109525
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
except for extensions/uiconfig/spropctrlr/ui/multiline.ui
Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109311
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
use has_child_focus instead, which didn't exist at the time of...
commit 3fc63a7463149685b04c676968a82bc00a48a9af
Date: Fri Aug 28 10:29:55 2020 +0100
weld OTableBorderWindow
and so sidestep that m_pActFocusWindow has always fallen out of sync
when OFieldDescControl clears its contents
Change-Id: I274131c314a00bdfec2e877a2baa3758d45c325f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109127
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I5fd2b3cec7dd0c2c10c88006ef1812e57b547e0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109128
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Recently xmloff started to use XML_DATASOURCE for "form:datasource"
but it actually means "data-source".
Add XML_DATA_SOURCE and use it for "db:data-source".
(regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a)
Change-Id: I893efd3fb0fb7c19ae998442459bf36cb1da0b20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit db283d2e3f5cd8be412c5204f358cd06af761b13)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109000
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
since...
commit 9714e7460c3ff67f2683483bf3634b2f31cda361
Date: Tue Apr 18 10:34:10 2017 +0100
convert table design row menu to .ui
Change-Id: I772da4b8f97f0e416e72af35e59dfbb8d127a32c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108004
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
See https://bugs.documentfoundation.org/show_bug.cgi?id=54021#c42
for more details.
Of course there's still the main pb to fix, moving columns
Change-Id: I2308efa47cbb9b80f278cf2644bb9cf24ab831e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106849
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 44f1ed1928d4d32b1a1962f413df69e2ae851789)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107014
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=168082
Change-Id: Icc89803bd89ce82d4699eef3cfe7892395d0634f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107625
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I05064f7e9216c9c43b49950b309afe72466857a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106241
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7056dc36b68021bdf16cc6c496645a2797958ab8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105660
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: Idf412dc5f235230512160cb4fb7e1a00baa1cfa7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
this thread has been in the wars before:
commit 490f83d4807a4223bae61d34913e5bd2bf952f3a
Date: Fri Mar 9 09:12:54 2012 +0100
fdo#47021: the naive join attempt leads to deadlock
commit a2095b151409f0fb57aa8feaa4c6282f84040245
Date: Tue Jul 26 23:42:36 2016 +0200
comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threads
current backtrace is...
Thread 1 (Thread 0x7fb9d9af6700 (LWP 32393)):
0 0x00007fb9eff83705 in () at /lib/x86_64-linux-gnu/libstdc++.so.6
1 0x00007fb9eff8375e in () at /lib/x86_64-linux-gnu/libstdc++.so.6
2 0x00007fb9dcc308df in __gnu_debug::_Safe_iterator_base::_Safe_iterator_base(__gnu_debug::_Safe_sequence_base const*, bool) (__constant=false, __seq=<optimized out>, this=0x7fb9d9af4338) at /usr/include/c++/8/debug/safe_base.h:91
3 0x00007fb9dcc308df in __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > >, std::__debug::map<rtl::OUString, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > > >::_Safe_iterator(std::_Rb_tree_iterator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > const&, __gnu_debug::_Safe_sequence_base const*) (__seq=<optimized out>, __i=..., this=0x7fb9d9af4330) at /usr/include/c++/8/debug/safe_iterator.h:130
4 0x00007fb9dcc308df in std::__debug::map<rtl::OUString, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > >::end() (this=<optimized out>) at /usr/include/c++/8/debug/map.h:181
5 0x00007fb9dcc308df in dbaccess::DocumentEvents::hasByName(rtl::OUString const&) (this=0x559229945690, Name="OnLoad") at /home/buildslave/source/libo-core/dbaccess/source/core/dataaccess/documentevents.cxx:199
6 0x00007fb9dcc2a4de in dbaccess::DocumentEventExecutor::documentEventOccured(com::sun::star::document::DocumentEvent const&) (this=0x559229981050, Event=...) at /home/buildslave/source/libo-core/include/com/sun/star/uno/Reference.h:380
aScriptDescriptor = {m_pImpl = std::unique_ptr<struct comphelper::NamedValueCollection_Impl> = {get() = 0x5592297d7700}}
bScriptAssigned = <optimized out>
bDispatchScriptURL = <optimized out>
bNonEmptyScript = <optimized out>
sEventType = "\004\000晦晦⦾喒\000\000\000\000\000䄨\xdce2ç¾¹\000°⧘喒\000èŒâ§’å–’\000°⧘喒\000\001晦晦晦䅨\xdce2ç¾¹\000ä† \xdce2ç¾¹\000ä‰ \xdce2ç¾¹\000䊨\xdce2ç¾¹\000䌀\xdce2ç¾¹\000䌸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000䎸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä‘°\xdce2ç¾¹\000ä’ \xdce2ç¾¹\000䓘\xdce2ç¾¹\000䔈\xdce2ç¾¹\000ä• \xdce2ç¾¹\000ä– \xdce2ç¾¹\000ä—\xdce2ç¾¹\000䘀\xdce2ç¾¹\000䘰\xdce2ç¾¹\000䙨\xdce2ç¾¹\000䚨\xdce2ç¾¹\000ä› \xdce2ç¾¹\000䜘\xdce2ç¾¹\000ä\xdce2ç¾¹\000\000\000\000\000\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦åšâ¦”å–’\000á⦘喒\000닰⦨喒", '\000' <repeats 13 times>, "\001\000晦晦\000\000\000\000"...
sScript = "\004\000晦晦⦾喒\000\000\000\000\000䄨\xdce2ç¾¹\000°⧘喒\000èŒâ§’å–’\000°⧘喒\000\001晦晦晦䅨\xdce2ç¾¹\000ä† \xdce2ç¾¹\000ä‰ \xdce2ç¾¹\000䊨\xdce2ç¾¹\000䌀\xdce2ç¾¹\000䌸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000䎸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä¸\xdce2ç¾¹\000ä‘°\xdce2ç¾¹\000ä’ \xdce2ç¾¹\000䓘\xdce2ç¾¹\000䔈\xdce2ç¾¹\000ä• \xdce2ç¾¹\000ä– \xdce2ç¾¹\000ä—\xdce2ç¾¹\000䘀\xdce2ç¾¹\000䘰\xdce2ç¾¹\000䙨\xdce2ç¾¹\000䚨\xdce2ç¾¹\000ä› \xdce2ç¾¹\000䜘\xdce2ç¾¹\000ä\xdce2ç¾¹\000\000\000\000\000\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦\000\000\000\000°⧘喒\000\000晦晦晦åšâ¦”å–’\000á⦘喒\000닰⦨喒", '\000' <repeats 13 times>, "\001\000晦晦\000\000\000\000"...
xEventsSupplier = uno::Reference to (class dbaccess::ODatabaseDocument *) 0x559229d80188
xDocument = uno::Reference to (class dbaccess::ODatabaseDocument *) 0x559229d80108
__func__ = "documentEventOccured"
7 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (listener=#8 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> const&) (func=..., this=0x559229a8b340) at /home/buildslave/source/libo-core/include/comphelper/interfacecontainer2.hxx:266
iter = {rCont = @0x559229a8b340, aData = {pAsVector = 0x559229b71540, pAsInterface = 0x559229b71540}, nRemain = 0, bIsList = true}
__func__ = "impl_notifyEvent_nothrow"
9 0x00007fb9dcc2b3cb in comphelper::OInterfaceContainerHelper2::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (Event=..., NotificationMethod=<optimized out>, this=0x559229a8b340) at /home/buildslave/source/libo-core/include/comphelper/interfacecontainer2.hxx:279
__func__ = "impl_notifyEvent_nothrow"
10 0x00007fb9dcc2b3cb in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x559229a8b2f0, _rEvent=...) at /home/buildslave/source/libo-core/dbaccess/source/core/dataaccess/documenteventnotifier.cxx:196
__func__ = "impl_notifyEvent_nothrow"
11 0x00007fb9dcc2b638 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=0x559229a8b2f0, _rEvent=...) at /home/buildslave/source/libo-core/include/comphelper/asyncnotification.hxx:215
rEventHolder = <optimized out>
12 0x00007fb9ef271835 in comphelper::AsyncEventNotifierBase::execute() (this=0x559229a8c460) at /home/buildslave/source/libo-core/comphelper/source/misc/asyncnotification.cxx:163
aEvent = {aEvent = rtl::Reference to 0x559229872990, xProcessor = rtl::Reference to 0x559229a8b2f0}
__PRETTY_FUNCTION__ = "virtual void comphelper::AsyncEventNotifierBase::execute()"
13 0x00007fb9ef26ffb9 in comphelper::AsyncEventNotifierAutoJoin::run() (this=0x559229a8c460) at /home/buildslave/source/libo-core/comphelper/source/misc/asyncnotification.cxx:268
14 0x00007fb9ef27d4ab in osl::threadFunc(void*) (param=0x559229a8c470) at /home/buildslave/source/libo-core/include/osl/thread.hxx:185
pObj = 0x559229a8c470
15 0x00007fb9f04645b6 in osl_thread_start_Impl(void*) (pData=0x559229aaa9e0) at /home/buildslave/source/libo-core/sal/osl/unx/thread.cxx:258
terminate = false
pImpl = 0x559229aaa9e0
__PRETTY_FUNCTION__ = "void* osl_thread_start_Impl(void*)"
16 0x00007fb9efd12fa3 in start_thread () at /lib/x86_64-linux-gnu/libpthread.so.0
17 0x00007fb9f01574cf in clone () at /lib/x86_64-linux-gnu/libc.so.6
Change-Id: I265c6d35d5690750454920e4155d99073d9e51ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103868
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Change-Id: Ia573921566ec6079b843cbcc0401d9d0f5c62089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
just use a GtkComboBoxText which comes with one by default
Change-Id: I041d37be137aed4c888336c62db574ea3d730e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105916
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done
so we get the same behavior in glade as before 3.38 in that the grid preview
don't show any unoccupied grid squares
replace all existing n-columns=X n-rows=Y lines because they are
all wrong, except for
cui/uiconfig/ui/additionsfragment.ui
sw/uiconfig/swriter/ui/pageheaderpanel.ui
sw/uiconfig/swriter/ui/pagefooterpanel.ui
which are correct.
Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
...to "Find functions that take rtl::O[U]String parameters that can be
generalized to take std::[u16]string_view instead." (Which in turn can avoid
costly O[U]String constructions, see e.g. loplugin:stringview and subView.)
Some of those functions' call sites, passing plain char string literals, needed
to be adapted when converting them.
Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
in favour of the more widely used, and better optimised, operator+
Change-Id: I6a1b37e0f3d253af1f7a0892443f59b620efea63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105523
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I8f3cd05dbd86bd22fd84d767adc44fc2b0c89404
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105468
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
instead of repeating the code everywhere
Change-Id: Idb94054b392ed256e64259cdb17d1522bf3c52b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so I can convert even *ImportContext subclasses in the middle of
a context stack, and thus break the cyclic dependency nature
of the writer import.
and adjust the xmlimport loplugin for the new rules.
As a consequence of the loplugin:xmlimport's checking, we remove
a bunch of now unnecessary overrides of startFastElement.
Change-Id: I97464522ede8ec5e345e928cdafa4b18364b1b80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104730
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
move IsShowOutlineContentVisibilityButton out of header to
avoid having to add extra include paths to all the unit
test makefiles.
Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
in places where it is obvious we only need a sal_Int32, because
we are dealing with rows and columns, and not even calc needs
more than 32 bits for that.
Change-Id: I114417e639c224d45bfd9fc6838122ab195eefa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104584
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
grepping for stuff in template params this time
Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and update the version mentioned in our min req in the readme.xrm
follow up to
commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Oct 2 21:21:45 2020 +0100
raise min version of gtk to 3.20.0
Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
which is how this traditionally worked before
commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b
Author: Caolán McNamara <caolanm@redhat.com>
Date: Wed Aug 19 14:59:33 2020 +0100
weld OApplicationSwapWindow
Change-Id: Ib844f903bf160eb7a58c2860e41b0b7acf4aa783
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104688
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I07251905c3bf5bccb23c684d47ed34e79dde55fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104645
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I15760da167e7d0b4c410acccd1c8c90210e28b2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104623
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
In Apple Store version or in case --without-java and
disable-firebird-sdbc we cannot have Java based HSQLDB or Firebird.
Instead of the empty list, there should be a static text label.
Change-Id: I6034a749f28a3c29c9c9e50929cb42aa1312a46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104359
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make
the OUString ctors taking raw sal_Unicode pointer/non-const array explicit".
Interestingly, these occurrences were accepted by MSVC and only cause errors
with clang-cl, so happened to go unnoticed until now.
Change-Id: I33e7653e28a21541ef793b4b0750abb6037752db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104314
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|