Age | Commit message (Collapse) | Author |
|
since it is just a wrapper around PointerStyle
Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267
Reviewed-on: https://gerrit.libreoffice.org/67711
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
As found out in 98c0b20864af965c3bb99a32f8ea57be7402e534 "Make Firebird the
(unconditional) default for new databases": "(Curiously,
ODsnTypeCollection::getEmbeddedDatabase would read a DefaultEmbeddedDatabase
value from the configuration before resorting to the hardcoded default, but
`git log -SDefaultEmbeddedDatabase` makes it look like there has never been any
code to actually write that setting.)"
Digging deeper, the story appears to be as follows: First, "INTEGRATION: CWS
hsqldb" commits in 2004 had addded the EmbeddedDatabases group (and accompanying
templates) to officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs
(ee11cb6373f6bbb28b1cdf57daa73465d030fda5), corresponding values (for HSQLDB)
to officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(60c5f0af740265ab81b620208205fe9e74be452f), and code to read those values
(lcl_getEmbeddedDatabase in dbaccess/source/ui/misc/dsntypes.cxx;
ODsnTypeCollection::getEmbeddedDatabaseURL et al in
dbaccess/source/ui/misc/dsntypes.cxx; all
a68938bc908c8f852912f3310d2f4bec779a3cea). This looks like it actually worked.
Then, "INTEGRATION: CWS dba24b" commits in 2007 removed the EmbeddedDatabases
configuration data from
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(473a3ccf63cc36ac3fa992dcb72d581496cb1bbf, "during #i80930#: The approach to
read the concrete type of the embedded DB from the configuration does not work,
there are enough places where we silently assume 'embedded == embedded HSQLDB'")
and removed the code reading it (79bbd382beb13a8f4031cc9b61332d0794878699), but
left the EmbeddedDatabases schema data in
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs untouched.
Then, b88a62cc97613e5dc00c806f59982cb57f9d1dc8 "CWS-TOOLING: integrate CWS
dbaperf2" in 2009 reintroduced code that attempts to read the configuration data
as ODsnTypeCollection::getEmbeddedDatabase
(dbaccess/source/core/misc/dsntypes.cxx). The reason for that may be
"2009-05-06 14:22:21 +0200 oj r271589 : #i101587# use config for the drivers"
as listed in the commit message. The code added as
ODsnTypeCollection::getEmbeddedDatabase back then remained effectively unchanged
until today, but looks fundamentally broken: It starts out with trying to read
an /org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase/
Value property that can never be present per the schema (an
/org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase
property could be); so no data is ever actually read from the configuration by
ODsnTypeCollection::getEmbeddedDatabase. (And the commit also didn't add back
any configuration data to
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu that could have
been read in the first place, nor any code to generate such data
programmatically.)
So remove the broken code to read configuration data from
ODsnTypeCollection::getEmbeddedDatabase (which means it can be a static member
function now) and also remove the obviously unused EmbeddedDatabases group (and
accompanying templates) from
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs.
Change-Id: Icc9b34075b9b7e960df6c236d3595b7fabe71f9d
Reviewed-on: https://gerrit.libreoffice.org/67494
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ibb296611c152807d143fa1e212554fd54aea45fb
Reviewed-on: https://gerrit.libreoffice.org/67301
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
largely based on the relevant portion of the unusedfields loplugin, but
adapted for local vars
Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1
Reviewed-on: https://gerrit.libreoffice.org/66835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f
Reviewed-on: https://gerrit.libreoffice.org/67486
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
and just use our normal handlers, instead of this weird magic
Change-Id: I8245787bec2a755ce6aba31ed681577771537ca1
Reviewed-on: https://gerrit.libreoffice.org/67534
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If7e87f725ea44732080fc0c57e4503c82b0cf4a0
Reviewed-on: https://gerrit.libreoffice.org/67595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ief40b8f83defb223c9f6cba4bab89486e1c73f99
Reviewed-on: https://gerrit.libreoffice.org/67605
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I05de6c01e827e596c9802c04964f43508dfd4d64
Reviewed-on: https://gerrit.libreoffice.org/67537
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
60db3d2cc3bc4f124bd4d819fbd0285e7f19c8c4 "dbu: Set Firebird to default in
wizard.." had done so only "..in case experimental feature is checked in", but
Firebird has been made non-experimental meanwhile as documented at <https://
wiki.documentfoundation.org/index.php?title=ReleaseNotes/6.2&oldid=169290#Base>.
<https://bugs.documentfoundation.org/show_bug.cgi?id=123099> "Creating new
'HSQLDB Embedded' database immediately brings up migration-to-Firebird dialog"
discusses that changing the default to Firebird may be beneficial, so lets do
that unconditionally now.
But 60db3d2cc3bc4f124bd4d819fbd0285e7f19c8c4 had apparently made a mistake,
setting the value returned from OGeneralPageWizard::getDatasourceName to
"sdbc:embedded:firebird" even though the corresponding "Connect to an exisiting
database" list in the new database wizard doesn't even support that (instead of
"sdbc:firebird:", which matches "Firebird File" in that list). Fixed that now.
(Curiously, ODsnTypeCollection::getEmbeddedDatabase would read a
DefaultEmbeddedDatabase value from the configuration before resorting to the
hardcoded default, but `git log -SDefaultEmbeddedDatabase` makes it look like
there has never been any code to actually write that setting.)
Change-Id: I49b7430f5f8288a6a166ed9184cb438208d56ca1
Reviewed-on: https://gerrit.libreoffice.org/67449
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I26959d3604a581f1528e575239970ab364c7fd50
Reviewed-on: https://gerrit.libreoffice.org/67413
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
No "PRIMARY KEY" keyword is needed, when composing a parsed sql which
did not contain any primary key definition.
Change-Id: Ife8b898806edba41a52d47dc04b1170606ea8aae
Reviewed-on: https://gerrit.libreoffice.org/67379
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57
Reviewed-on: https://gerrit.libreoffice.org/67102
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ic6f95a226e0d900fbc633796d7e27edcd13f5482
Reviewed-on: https://gerrit.libreoffice.org/67286
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
This patch is wrong (see comments on gerrit)
This reverts commit b35a64be6025b59e88231a4dc0f025273adb63c5.
Change-Id: Ib093e83cf68460671e9a14b3f1dc2a8d884de0b9
Reviewed-on: https://gerrit.libreoffice.org/67300
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If02bf119f5e9dfcefe95c22240f55a1d241a123c
Reviewed-on: https://gerrit.libreoffice.org/67259
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...which are apparently encoded as two consecutive \uXXXX\uXXXX escape sequences
representing a UTF-16 surrogate pair
Change-Id: Ic47a678dee5e28ab4dc43e115ae5c4efefb1db96
Reviewed-on: https://gerrit.libreoffice.org/67245
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
dbahsql: Decode UTF8 characters stored as unicode code point values in
schema file.
Change-Id: I90db2345a6de9bee7aae8ae6a7c046a03eebc0a7
Reviewed-on: https://gerrit.libreoffice.org/67197
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
It's going to throw IOException anyway.
This fixes CppunitTest_dbaccess_hsqldb_test on read-only file system.
Change-Id: Ifc8a4791ab9a1a8d3e0f1e67d65e10dac458147c
Reviewed-on: https://gerrit.libreoffice.org/67028
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
The buildLowLevelConnection() will try to modify the read-only storage
and throw IOException.
Change-Id: I9b8ec840bebcac3c8a69bc6921d32e692d9d9e86
Reviewed-on: https://gerrit.libreoffice.org/67027
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
|
|
Change-Id: I9c04906dd492c6f8a816f57f40bc31406a871a78
Reviewed-on: https://gerrit.libreoffice.org/66793
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
4 0x00007fffdfddf846 in (anonymous namespace)::lcl_makeStringFromBigint(std::__debug::vector<unsigned char, std::allocator<unsigned char> > const&)
(bytes=std::__debug::vector of length 3, capacity 3 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:104
5 0x00007fffdfde04e2 in dbahsql::HsqlRowInputStream::readOneRow(std::__debug::vector<dbahsql::ColumnDefinition, std::allocator<dbahsql::ColumnDefinition> > const&)
(this=0x7fffffff0350, nColTypes=std::__debug::vector of length 9, capacity 9 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:312
6 0x00007fffdfdf39f0 in dbahsql::HsqlBinaryNode::readRow(dbahsql::HsqlRowInputStream&, std::__debug::vector<dbahsql::ColumnDefinition, std::allocator<dbahsql::ColumnDefinition> > const&, int) (this=0x7ffffffefc74, input=..., aColTypes=std::__debug::vector of length 9, capacity 9 = {...}, nIndexCount=2)
at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx:56
See complete bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=148530
Change-Id: I0b0373a81d9299fd7bf3107d2262f5836e52e459
Reviewed-on: https://gerrit.libreoffice.org/66752
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Id20e0bc42e39f868a7c5d49d756f2ad5e14a86c0
Reviewed-on: https://gerrit.libreoffice.org/66637
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one
Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e
Reviewed-on: https://gerrit.libreoffice.org/66545
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If58a22a3d9536ade5f63a3708fd0b6c53f2e21c3
Reviewed-on: https://gerrit.libreoffice.org/66585
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Some new headers were added since I begun the cleanup here
Also blacklist the header from commit 403e3c04420c4d20c77427c43df52d554d7329ff
Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5
Reviewed-on: https://gerrit.libreoffice.org/66255
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Icebcf1a6ab073dce935a74ce79ee0f302b62e8a8
Reviewed-on: https://gerrit.libreoffice.org/65947
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I2782dc02bfc9ef7f9a4a3efd8f90a4193a80cbad
Reviewed-on: https://gerrit.libreoffice.org/66219
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: Ic770f944db5dfedc933b3f6d79816da5fc77c2c3
Reviewed-on: https://gerrit.libreoffice.org/66220
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I92f3af3cf9b0b5d7bc7b903403b1b93e0b432366
Reviewed-on: https://gerrit.libreoffice.org/66218
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
ellipise only when we have to
Change-Id: I79820dc84fc9ac0a755700c70bca9edbb14cf371
Reviewed-on: https://gerrit.libreoffice.org/66000
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9
Reviewed-on: https://gerrit.libreoffice.org/65951
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4
Reviewed-on: https://gerrit.libreoffice.org/65614
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I9a2ce0edb615b53e579060d76898e4a8e491749c
Reviewed-on: https://gerrit.libreoffice.org/65829
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6603f108a3079dd2329b6b6b7f88289e0a913683
Reviewed-on: https://gerrit.libreoffice.org/65678
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I86012d0e70e67c33dbc90aa7e3b2263bed9d133c
Reviewed-on: https://gerrit.libreoffice.org/65682
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I9f1fed85673e36bc5e552cb0db176b137033cfca
Reviewed-on: https://gerrit.libreoffice.org/65683
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I128a7d67fe23cc1a5806765fc710cc6cadc46a50
Reviewed-on: https://gerrit.libreoffice.org/65681
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I50de21b635d791ca8f7299dcc8dafaf4e89a9fc6
Reviewed-on: https://gerrit.libreoffice.org/65680
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: Ia024ded766b57f1e93e171e7d1299069505c06dc
Reviewed-on: https://gerrit.libreoffice.org/65679
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
|
|
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093
Reviewed-on: https://gerrit.libreoffice.org/65592
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
there are a bunch of resizes as base starts up, and base will position
the splitwin on the first time its big enough to place it and gets stuck
too high up, before it goes full size.
We don't want this jumping around on every subsequent user size, but we do
want it to get placed at the final size during the load.
So post the resize event to occur on idle, and when it finally gets a chance
to run we'll be at our final size and the placement is good
Change-Id: Iccb169bac93a5cf8bc931945bc7e1b71c6c9dd23
Reviewed-on: https://gerrit.libreoffice.org/65586
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
in database migration
Change-Id: Ied42d1436f14012fb918e8e6775fcbe0f7d5fac5
Reviewed-on: https://gerrit.libreoffice.org/65545
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
I think 27995e638e1582b443befa93bc5dfd5970a38ef2
tdf#122020 - avoid nullptr deref
is unnecessary with the other fix for tdf#122020
Change-Id: Ibc6773c9e3a0cb234331aa988ce009967123f1da
Reviewed-on: https://gerrit.libreoffice.org/65515
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
a PostUserEvent of DBTreeListBox::OnResetEntry with a SvTreeListEntry* pEntry as
payload, then the DBTreeListBox is disposed and then the UserEvent arrives and
the, by now deleted, pEntry is processed by the disposed DBTreeListBox
Change-Id: I951639eb633920aa3536cd44320f36f6b2e910aa
Reviewed-on: https://gerrit.libreoffice.org/65512
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8ffb9e04614472c3645d24bebdc88f91059d12ad
Reviewed-on: https://gerrit.libreoffice.org/65436
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f
Reviewed-on: https://gerrit.libreoffice.org/65386
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I7b61b39d1057d4dd68887a2a0254592d8bdab33c
Reviewed-on: https://gerrit.libreoffice.org/65405
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I15f6d577c3584d28f667a04b5571de80effe53fe
Reviewed-on: https://gerrit.libreoffice.org/65274
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I32212113e3591bde81b47ea89df4977713a49700
Reviewed-on: https://gerrit.libreoffice.org/65283
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|