summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2016-08-16loplugin:stringstaticStephan Bergmann
Change-Id: I00cb0310c90601472472c570e6c3452605258059
2016-08-15tdf#89329: use unique_ptr for pImpl in odbcconfigArnold Dumas
Change-Id: Ieba9b60dfa8e61d41a18096e1bddc3c8c70b2e2f Reviewed-on: https://gerrit.libreoffice.org/28113 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-15tdf#89329: use unique_ptr for pImpl in dlgsaveArnold Dumas
Change-Id: I3743637b2ad5747073e61a46cdb28604dd9fb95f Reviewed-on: https://gerrit.libreoffice.org/28114 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-10tdf#67647 getStructuredFilter returns operatorFabio Buso
Change-Id: I010ea3c24b4d5411711a93e35d4b173f5bde9e55 Reviewed-on: https://gerrit.libreoffice.org/28000 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#100726: Improve readability of OUString concatenationnadith
module cui and dbaccess fixed Change-Id: Ief6fca46622fe4e0da804c9a874f7ec93a0fd7af Reviewed-on: https://gerrit.libreoffice.org/27770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#101185 OString concatanations for efficiently codingnadith
Change-Id: I1d3dd633b7de2dcd64f6cde892da3a5f02fcf80d Reviewed-on: https://gerrit.libreoffice.org/27844 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-08-03tdf#101136 dbaccess: use SolarMutex in ModelMethodGuardMichael Stahl
There is a deadlock here when storing a ODatabaseDocument on a non-main-thread while the main thread dispatches some event that calls into ODatabaseDocument, while holding SolarMutex. The storing of the document also stores BASIC libraries, and since commit fca62934f492125ea6728fd6d09f0c66c9e4fa69 the SfxLibraryContainer uses SolarMutex for locking. Now we could re-investigate that problem, but it seems unrealistic to expect ODatabaseDocument's implementation will never call anything that acquires SolarMutex. Resistance is futile. Your locking scheme will be assimilated. Change-Id: I337d286f3e96c6b2e0dde8682b31faab3f508d20 Reviewed-on: https://gerrit.libreoffice.org/27590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-01svl: avoid defaulted parameter in SfxUndoManager::EnterListAction()Miklos Vajna
It's a virtual function, and defaulted parameters there are problematic. Change-Id: I3f110c7ac36dfda90811b033620286ad9fce1af1 Reviewed-on: https://gerrit.libreoffice.org/27772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29comphelper,vcl: let DeInitVCL() join some AsyncEventNotifier threadsMichael Stahl
comphelper::AsyncEventNotifier is an amazing class that dispatches events in separate threads, no doubt implemented during times of exuberant optimism about the tractability of shared-state multi-threading. Unfortunately the authors forgot to think about how all those awesome threads will be joined, so if they are somehow blocked, then it may well happen that the events are dispatched when the main thread is already in DeInitVCL, and the objects required for the dispatching already smell somewhat funny. This happens quite reproducibly when changing dbaccess' ModelMethodGuard to lock the SolarMutex too, then CppunitTest_dbaccess_RowSetClones crashes in DeInitVCL() because one AsyncEventNotifier thread was blocked until then by SolarMutexGuard, and this test never Yields once its document is loaded. Try to fix this by joining the "DocumentEventNotifier" threads from DeInitVCL() itself. Since there's no rtl::WeakReference to go with rtl::Reference, refactor the AsyncEventNotifier and create a new AsyncEventNotifierAutoJoin that has to be used with std::shared_ptr and std::weak_ptr. Change-Id: I50a0749795acb04b0776e543f7125767b697ea35 Reviewed-on: https://gerrit.libreoffice.org/27581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-28Revert "temp tinderbox fix"Caolán McNamara
This reverts commit d4cb9c3a8851cb874fd8b6c77d4d7521da7579b7. Change-Id: Ifd11427ea6b4137d0e0c007e7f140fbc6caa3f31
2016-07-27add uui component to some other placesCaolán McNamara
Change-Id: Ic703b509bac0a57e0780bbb83537e7e4323a79d0
2016-07-27add uui component to some other placesCaolán McNamara
Change-Id: Ia1e449f8f52e7d353944b8e80f9fc586f1eab2f7
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25inconsistent default param vals in SetMaxTextLenNoel Grandin
so just remove them, only one call site was using them. Change-Id: Ife00ad7f14d73f865058d1262f71dff1fd2a6abd Reviewed-on: https://gerrit.libreoffice.org/27458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19improve unnecessaryoverride pluginNoel Grandin
to ignore ImplicitCastExpr when calling superclass method Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1 Reviewed-on: https://gerrit.libreoffice.org/27279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18Resolves: tdf#100964 singlevalfields cleanup took wrong branchCaolán McNamara
regression since commit 22864b44fd00b5a778ef597f8dfcb407d4166306 Date: Fri Jun 24 12:57:04 2016 +0200 loplugin:singlevalfields in dbaccess Change-Id: Ie00bb7a8c2bc268dac876ff21657c987406dac7d
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-14there is no "FormularProperties", math is called "FormulaProperties"Michael Stahl
Change-Id: Id44ec98c5f2588918ee6253df9accc9d8ea94ab8
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-13tdf#84635 - Slow layout of large tablesNoel Grandin
Based on suggestion from Aron Budea. And do something similar to most other places keeping vectors of weak references where the code looks like it will hold more than a few entries. Measurements: the 26 page file file takes 51s without my path 15s with this patch the 69 page file file takes 5m28 without my path 51s with this patch the 84 page file file takes 8m28 without my path 58s with this patch Change-Id: I8da94c525fc73ebd969e0343c6f074be4f0063b1 Reviewed-on: https://gerrit.libreoffice.org/27093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-08loplugin:redundantcast: redundant static_casts in dbaccessStephan Bergmann
Change-Id: Ia959a92044ba2fb7fef1938bd236e4a3a9f55908
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I8726896e20b6a6c122ffbfbc4213856f826bd8c7
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05when disposing popup menus, don't leave dangling pointersNoel Grandin
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf Reviewed-on: https://gerrit.libreoffice.org/26960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-04merge dbaui::OQueryView with dbaui::OQueryDesignViewNoel Grandin
Change-Id: I9982d6c27863f533bfdb929d99602f0188972950 Reviewed-on: https://gerrit.libreoffice.org/26895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-30Improve readability of OUString concatanation in ODatabaseExportMuhammet Kara
It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I3cf18cfb6879ea1598ad98a0bccd3ec91c88c875 Reviewed-on: https://gerrit.libreoffice.org/26760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27loplugin:singlevalfields in dbaccessNoel Grandin
Change-Id: I5c8990187b2b488eb75369c2a3e3dc7f855ce06a Reviewed-on: https://gerrit.libreoffice.org/26633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24compilerplugins: add OWeakObject::release() override checkMichael Stahl
Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6 Reviewed-on: https://gerrit.libreoffice.org/26555 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22Increase width of Copy Table dialog in BaseMuhammet Kara
Currently the "Help" button is cropped and partially visible on the Copy Table wizard. Increasing the width to 700 seems to make it fully visible again. Change-Id: Ib64ab0724d944f310f1c76a01ee91f00087bc320 Reviewed-on: https://gerrit.libreoffice.org/26548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17Simplify OPropertyContainerHelper::registerPropertyNoMember's _pInitialValueStephan Bergmann
Change-Id: Ibfb27b3eded45e2646dada37ce3663f427985ae9
2016-06-16tdf#42949: clean up includes in include/dbaccess with iwyuJorenz Paragas
Change-Id: I40de14b82b698b927cb461376470dc177c16d58c Reviewed-on: https://gerrit.libreoffice.org/26345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13coverity#1362680 Pointer to local outside scopeCaolán McNamara
this doesn't seem to make sense anymore since... commit 4d49c9601c9b3e26a336e08e057d299895683480 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Jun 8 17:14:34 2016 +0200 Let loplugin:passstuffbyref also look at fn defn not preceded by any decl so lets revert that to be safe Change-Id: I78fe8ae48dc4c4f3d5786c7232d7e791ff50d9b4 Reviewed-on: https://gerrit.libreoffice.org/26189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13Fix typosAndrea Gelmini
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-10Clean up uses of Any::getValue() in dbaccessStephan Bergmann
Change-Id: Icaad71e51301e017a48ab3f87b151f5e0de26cd9
2016-06-09tdf#100286 Fix deactivate flagsMaxim Monastirsky
regression of 11b4a6ddce31f173f10b703eb63fde2c88c0bc70 Change-Id: I4981fee4264c833cd3166491d3812c40c78e3d67
2016-06-09convert some manual ref-counting in dbaccessNoel Grandin
Change-Id: I2df7b6b79bff4a5c7358288518c5518b6a7032bf Reviewed-on: https://gerrit.libreoffice.org/26051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08split AddRemoveListener into two methodsNoel Grandin
Change-Id: I247dc8a9033b39d5e49dc06e725f638644fcd02d
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-14 00:52:07 +0000