summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2018-11-04Replace preprocessor macro with short function definitionsMike Kaganski
a2058e7516a01167c2d20ed157500b38db967c64 follow-up. Change-Id: I402cbab4f78daf0de9d1bfa88698d2b071fcabaf Reviewed-on: https://gerrit.libreoffice.org/62840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04replace double-checked locking patterns with thread safe local staticsMike Kaganski
Change-Id: Ie1aae7ecbd065a88b371d8c0deb586f54f7eff65 Reviewed-on: https://gerrit.libreoffice.org/62835 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I856345576ff5c10a41509a97ad4539272bd55568 Reviewed-on: https://gerrit.libreoffice.org/62803 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01gbuild: rename value OS=IOS to OS=iOSMichael Stahl
This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-30loplugin:returnconstantNoel Grandin
Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3 Reviewed-on: https://gerrit.libreoffice.org/62539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30dbaccess: CppunitTest_tdf119625 requires firebirdMichael Stahl
Change-Id: I21a100209d9177b80cfb9f4a629fb320626df1b7 Reviewed-on: https://gerrit.libreoffice.org/62511 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-30Missing test dependencyStephan Bergmann
Change-Id: I822a71fcf6d3de93081046cdc9b4b8a07ed2c1d0 Reviewed-on: https://gerrit.libreoffice.org/62521 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-29loplugin:oncevarNoel Grandin
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29tdf#120691 Migrate tables which contain spacesTamas Bunth
Change-Id: I115d765bc781a926189605990e91c8e47f24d474 Reviewed-on: https://gerrit.libreoffice.org/62403 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-28drop unnecessary requires lib="LibreOffice"Caolán McNamara
Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef Reviewed-on: https://gerrit.libreoffice.org/62445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28update old 'interface-requires' comments to <requires> tagCaolán McNamara
Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I66ef078794ed1eb44dbfa854c589545e5f9ba78e Reviewed-on: https://gerrit.libreoffice.org/62407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26fix build --without-java - CppunitTest_dbaccess_tdf119625 uses hsqldbChristian Lohmaier
introduced with 4d7dd4e1e4e072db8bcfe4d52b8c185187353e74 Change-Id: I118b6185fc01b2234d2a20da76b0e19929f9812a
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26loplugin:unusedfieldsNoel Grandin
Change-Id: I36d3e874aac2d57d4e6f24a0e89c9836704bb7a6 Reviewed-on: https://gerrit.libreoffice.org/62383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26Fix typosAndrea Gelmini
Change-Id: I537871602282f85f2947f91f9b579b0e8cf12fe8 Reviewed-on: https://gerrit.libreoffice.org/62378 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-25weld OUserAdminDlgCaolán McNamara
Change-Id: I3e190db7c00ebff55296fe1ffb8999d9892c7723 Reviewed-on: https://gerrit.libreoffice.org/62329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOConnectionURLEdit and DBOConnectionHelper backCaolán McNamara
Change-Id: I9353efc407d9dab04b72d7ddedd43bfa125c63ca Reviewed-on: https://gerrit.libreoffice.org/62328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25drop OConnectionURLEdit and OConnectionHelperCaolán McNamara
Change-Id: I028b243b21a41f3fbd23dea57ea90f77e4a5317c Reviewed-on: https://gerrit.libreoffice.org/62327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOConnectionTabPageSetup back to OConnectionTabPageSetupCaolán McNamara
Change-Id: I3d5c90e51922350ca3bb6f59fc94bf5768c995f1 Reviewed-on: https://gerrit.libreoffice.org/62326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25fix up wizards pagesCaolán McNamara
Change-Id: Icea2c91d06af4fc5d190186d4f6d624ebfc991ff Reviewed-on: https://gerrit.libreoffice.org/62325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25drop unused stuffCaolán McNamara
Change-Id: Icd92801dc88c603c369bfb6c85bf4278ea609ea9 Reviewed-on: https://gerrit.libreoffice.org/62324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OJDBCConnectionPageSetupCaolán McNamara
Change-Id: I8c194c8efa17079253c857e171af203c17d3aff3 Reviewed-on: https://gerrit.libreoffice.org/62323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OSpreadSheetConnectionPageSetupCaolán McNamara
Change-Id: Ibcf63af2bb1272d35420ac1b6f71aaa6f147ec16 Reviewed-on: https://gerrit.libreoffice.org/62322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOTextConnectionHelper back to OTextConnectionHelperCaolán McNamara
Change-Id: Ie20403b88c8510465ab7cccbb431072331dbc96f Reviewed-on: https://gerrit.libreoffice.org/62321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBCharSetListBox back to CharSetListBoxCaolán McNamara
Change-Id: I14c8b95ee166b75aa309f701be569f54b57538aa Reviewed-on: https://gerrit.libreoffice.org/62300 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25remove unused stuffCaolán McNamara
Change-Id: I5ae616f46cb86b35435e007f98e4b0f882a75751 Reviewed-on: https://gerrit.libreoffice.org/62299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OTextConnectionPageSetupCaolán McNamara
Change-Id: Iaa4fdc97be23ccd50471c26923745fd565e10653 Reviewed-on: https://gerrit.libreoffice.org/62298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld ODbAdminDialogCaolán McNamara
Change-Id: I691ce67b55fb16d06d7266ebe671ac31e30c05d5 Reviewed-on: https://gerrit.libreoffice.org/62297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24fix OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: Iee83dcd992ff5d66ff4090019ceb764051a9c776 Reviewed-on: https://gerrit.libreoffice.org/62296 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld TextConnectionSettingsDialogCaolán McNamara
Change-Id: Iaa08d066d9c2198bca7e21f619fb89808620fba9 Reviewed-on: https://gerrit.libreoffice.org/62295 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24rename DBOCommonBehaviourTabPage back to OCommonBehaviourTabPageCaolán McNamara
Change-Id: I7877f746280b76bce73998e1ad48f21b02eb521c Reviewed-on: https://gerrit.libreoffice.org/62294 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24drop now unused OCommonBehaviourTabPageCaolán McNamara
Change-Id: I0a7ff8a018cbe20481360196f6f2ed919f11ded8 Reviewed-on: https://gerrit.libreoffice.org/62293 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld DBMySQLNativeSettingsCaolán McNamara
Change-Id: I0c4f27e02f9dd6c7bb42ffe49043e98e043d9084 Reviewed-on: https://gerrit.libreoffice.org/62292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OTextDetailsPageCaolán McNamara
Change-Id: I81abd72fb7843aebcf093e421472ecca6998847e Reviewed-on: https://gerrit.libreoffice.org/62291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OMySQLODBCDetailsPageCaolán McNamara
Change-Id: I8f0c291a9bfc3c9cc5edb6095fd31aba68a6feac Reviewed-on: https://gerrit.libreoffice.org/62290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: I0db0801167d36a04ebbe467b29862efcbb54e599 Reviewed-on: https://gerrit.libreoffice.org/62289 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OUserDriverDetailsPageCaolán McNamara
Change-Id: I05db75b90dbb4302f968f129437630adb47a35a8 Reviewed-on: https://gerrit.libreoffice.org/62288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OOdbcDetailsPageCaolán McNamara
Change-Id: I798fa10a1cb4288b0a73e8439b71851c56113129 Reviewed-on: https://gerrit.libreoffice.org/62287 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OAdoDetailsPageCaolán McNamara
Change-Id: I81cbac086a00cdaa649c2794a9192dce8e7c5efe Reviewed-on: https://gerrit.libreoffice.org/62286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OLDAPDetailsPageCaolán McNamara
Change-Id: I9477a52419db08812ccef95107c410685449fa6c Reviewed-on: https://gerrit.libreoffice.org/62285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld ODbaseDetailsPageCaolán McNamara
Change-Id: Ia0d953ee2d4a4f35ba6f59bb6bd6b1a04ed25f63 Reviewed-on: https://gerrit.libreoffice.org/62284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OConnectionTabPageCaolán McNamara
Change-Id: Icdbe5d95d0850d131018d21d0a21cb12109d565c Reviewed-on: https://gerrit.libreoffice.org/62283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24add adjustment to specialsettingspageCaolán McNamara
Change-Id: Ia897b8f01618e499817f16e8ac2d1e0a8bef3367 Reviewed-on: https://gerrit.libreoffice.org/62282 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I8d2ff75a7b185daf331724616b4c61c5569c0664 Reviewed-on: https://gerrit.libreoffice.org/62226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>