summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I331c96a09be7a4971c3cc3c577f8f9d91333d175
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10coverity#1242423 Dereference after null checkCaolán McNamara
Change-Id: If9c09fc56067610d36e3f8bd2a4e22ea743ddf5b
2014-11-10Resolves fdo#82500: Operators missing in Standard FilterJulien Nabet
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=be88126e80b1f6b9a3090ba4617d9a87dfb0a0bd Change-Id: I4f03fbf4e6e6a0f6a901cadb87494baa92d66895
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06loplugin:salboolNoel Grandin
Change-Id: Ib1cb796c53ace96002c3c99c84ce090a11fb1e84
2014-11-06WaE: VarDecl, use bool instead of sal_Bool [loplugin:salbool]Tor Lillqvist
Apparently the salbool plug-in warns if a sal_Bool is initialized in the C++ fashion. Change to the C fashion and no warning, huh? Change-Id: I0f4e33cb33ffb1e0d5571d3757a6bb3bc9c44a64
2014-11-05coverity#706401 Uncaught exceptionCaolán McNamara
Change-Id: Iacbaf56a23d6f1878c5a5ec6f00db8211cb8ed62
2014-11-05coverity#706388 Uncaught exceptionCaolán McNamara
Change-Id: I4382645e47ae81e3f15bf69aaa2432dcebd40712
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04covertiy#705369: dbaccess: move XML_TOK_ENCODING to enum XMLDataSourceInfoMichael Stahl
Looks like Commit 94e8385d56098b6a51c539b5374dbf03151d2559 added this to the wrong enum. Change-Id: I46dd82313aaa659e84c719ba9215682becf8ec6c
2014-11-03I think this should be Left()David Tardon
Change-Id: I603215180e86ca28b94b129378ec48b7658e37b5
2014-11-03I think this should be Left()David Tardon
Change-Id: Ifd83a4a28414ffa5d8cc3cec3def4361737a333e
2014-11-03coverity#1242510 arguments in wrong orderDavid Tardon
Change-Id: I898f3e383f5ff3451860e49b0ea00111ed1b52c2
2014-11-03callcatcher: update unused codeCaolán McNamara
Change-Id: Ida4221bfbfe30f7e1abd5c367d8cb8b9edd310bb
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-28coverity#706465 Uncaught exceptionCaolán McNamara
Change-Id: Ic328c8a68fac462c402b70f85093cd8b14d2882d
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-22Revert "PythonTest_dbaccess_python: don't modify source document"Michael Stahl
This reverts commit 29474c7a227050b16fc341bdf7df68112793a23d. Removing the lock file fails on Windows because it is opened; it ought be possible to close the document instead to clean up the lock file? Change-Id: I2c93fc893c62d6a267be9723761e5ed7577086a7
2014-10-22Save precious vertical space by removing some redundant heading labelsAdolfo Jayme Barrientos
Change-Id: I6aaa7602f57f6cb2d0f9bc3ee897a9c3576d47d3 Reviewed-on: https://gerrit.libreoffice.org/12012 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21PythonTest_dbaccess_python: don't modify source documentMiklos Vajna
Change-Id: I4e8f94554141e41863c474c5f99be4b1974f3dd7
2014-10-21dbaccess: make sure fdo84315.odb.lck is removed after the test passedMiklos Vajna
Change-Id: I6c9a42625f10a3a30e2636a2a2be2b9bcba8f6af
2014-10-21connectivity: firebird: fix temp directory leakMichael Stahl
Dispose the dbaccess document, and recursively delete the temp directory in Connection::dispose(). Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-21dbaccess: surely the problem is that the storage could _not_ be committed?Michael Stahl
Change-Id: I03e7e09e185e9cb25868c86de0b402b89e7f5d75
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-12coverity#706421 Uncaught exceptionCaolán McNamara
Change-Id: I91a6ac9d9bda0ea25f1f5385bbac71ea9d22d573
2014-10-12coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I7717b61e89d95cb6d89bb273c22c0503b0853d96
2014-10-12coverity#706478 Uncaught exceptionCaolán McNamara
Change-Id: Ie37ebac80afb3e52668ae6ebeeb61eaddc892ef6
2014-10-12coverity#706476 Uncaught exceptionCaolán McNamara
Change-Id: I1461c99fccb57ccf5375e372e50948b0b355d4bb
generated by cgit (git 2.34.1) at 2025-03-01 15:57:51 +0000