summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2015-06-22Add variadic PartialWeakComponentImplHelper, remove need for implbase_var.hxxStephan Bergmann
Change-Id: Iad3417822b2ab3afb75da09c311a0bf07af5e2e4
2015-06-22gtk3: native render the comically oversized gtk3 spinbuttonsCaolán McNamara
Change-Id: I3e97200d59a97271617a6e9a88c807a07a33edfe
2015-06-22cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I913f983bb0f55e05bb5ec8994ee75a7e7d69bd1b
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22new uno sidebar api tdf#91806Laurent Godard
the entry point is SfxBaseController::getSidebar() the Decks and panels are now per SidebarController and not global anymore ' macro example Sub testSidebarApi controller = thisComponent.currentcontroller frameIni = thisComponent.currentcontroller.frame sidebar = thisComponent.currentcontroller.getSidebar() sidebar.setVisible(true) frame = sidebar.getFrame() decks = sidebar.getdecks() c = decks.count h = decks.hasElements() e = decks.getElementNames() a = decks.hasByName("MyDeck") deck = decks.getByName("MyDeck") deck.activate(true) t = deck.getTitle() deck.setTitle("new deck title") deck.moveFirst() deck.moveLast() deck.moveUp() deck.moveDown() index = deck.getOrderIndex() panels = deck.getPanels() ep = panels.getElementnames() ap = panels.hasByName("aPanelName") panel = panels.getByName("aPanelName") panel.setTitle("new panel title") panel.collapse() panel.expand(true) ' expand and collapse other index = panel.getOrderIndex() panel.moveLast() panel.moveFirst() panel.moveDown() panel.moveUp() End Sub Change-Id: I7a4b953f2277dea483bb296ba6ead35de7205ace Reviewed-on: https://gerrit.libreoffice.org/15856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2015-06-20callcatcher: update unused codeCaolán McNamara
Change-Id: I29b3f1408b814a1424d8bab232e9ac618901b4c2
2015-06-19Shall this produce a string representation of a number?Stephan Bergmann
On the one hand, the code had apparently treated nIdx as a sal_Unicode character value ever since its inception in e718950884fa2db240822e1711f301b39a70ad3e "new querydesign." On the other hand, the preceding BROW_VIS_ROW case does produce strings "0" and "1". Change-Id: Ife6e98ba32146cc469b722fa4f013c12152b5505
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-12spellingAntoine Cœur
Change-Id: I5ccbb5a2b31192cea96fbb0f4ab926af86e94c9d Reviewed-on: https://gerrit.libreoffice.org/16223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10Remove FastLoader optimizationStephan Bergmann
...that was introduced in b88a62cc97613e5dc00c806f59982cb57f9d1dc8 "CWS-TOOLING: integrate CWS dbaperf2," apparently to speed up later activity by pre-loading a JVM or Calc. The problem is that any spawned FastLoader thread was never joined, so could still run during exit. That caused many spurious failures of CppunitTest_sw_uiwriter after df726c8b3e80bf2e1696f901ea01f192dcb8a77e "CppunitTest_sw_uiwriter: add embedded data source definition testcase" triggered spawning such FastLoader threads there. Adding code to join any spawned FastLoader thread is not easy, though. For one, it is not clear whether there would not be very many (terminated, waiting to be joined, thus still holding up system resources) such treads when doing the join in ~DatasourceURLListener or DatasourceURLListener::disposing. For another, a naive attempt at joining in ~DatasourceURLListener leads to deadlock, as it is called with the SolarMutex locked and the E_CALC branch in FastLoader::run blocks waiting to acquire it. Thus, the best approach appears to be to remove this optimization. Hopefully, that does not have too dire performance impacts on typcial user scenarios. Change-Id: Ifeab013ddd8acee1289423facba0c120684e9325
2015-06-09dbaccess: gcc-4.7 error: '<::' cannot begin a template-argument listMiklos Vajna
Change-Id: I27547009862b50a1cb0244c144c46c0aadef65f3
2015-06-09remove some unnecessary exception wrapping in the Java testsNoel Grandin
Modify createTestEnvironment so that it throws Exception. This is appropriate for unit testing. The wrapping adds no value and the calling method already has a catch(Exception) to handle anything. Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: If951c1982314c5a045d51bc4fff62a3e2b265e08
2015-06-08\<the the\> -> theJan Holesovsky
Change-Id: I9d820446411eb7dfca37bb3baf5e994f4ba6f421
2015-06-08dbaccess: avoid pointless ucbhelper::Content instance in case of embeddingMiklos Vajna
Change-Id: Ibc3d7a0d9b3373f17aa8d1da081946814904e6d5
2015-06-08dbaccess: set correct BaseURI for vnd.sun.star.pkg:// URLs on loadMiklos Vajna
With this, in case the embedded data source definition has an URL like: <db:file-based-database xlink:href="../../calc-data-source.ods/" db:media-type="application/vnd.oasis.opendocument.spreadsheet"/> That's resolved to file:///path/to/directory/of/Writer/doc/calc-data-source.ods correctly. Change-Id: Ieb67f9f5ae104689c6dadc14ec84c66bec70a687
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05Let JUnit take care of exceptionsNoel Grandin
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-05dbaccess: let ODatabaseDocument::impl_writeStorage_throw() respect BaseURIMiklos Vajna
Change-Id: Id30aaa624b9a1b0bbef016ef0b35bd39f19f6439
2015-06-04Revert "disable JunitTest_dbaccess_complex part RowSet"Stephan Bergmann
This reverts commit 217dbf61ece9318f4430780d10cef60920086de7, the test should work now reliably after the preceeding "Finalizers must not access UNO objects" commit.
2015-06-04Let JUnit take care of exceptionsStephan Bergmann
Change-Id: Ic628e4eccab59dce5d6d5e77656cac1f0006a491
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-02inline simple Java methodNoel Grandin
Change-Id: I496fa3223ed97d4d2cf8d64649ce30da22331dbd Reviewed-on: https://gerrit.libreoffice.org/16039 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-02A small hint on how to specify the database URL should be helpful to usersumairshahid
Change-Id: I7a84951b571b8c0a583907283f3b69fab1b5984b Reviewed-on: https://gerrit.libreoffice.org/15978 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01minor simplificationStephan Bergmann
Change-Id: Iad908728d63b0dcf3bef0a76c9d2fa3c892bf986
2015-06-01dbaccess: add support for storing ODatabaseDocument to a sub-storageMiklos Vajna
When Writer creates an embedded data source definition, it should be stored on the storage of the Writer document, so Writer sets the TargetStorage and StreamRelPath parameters of the storeAsURL() call. Let ODatabaseDocument::impl_storeAs_throw() and ODatabaseDocument::impl_writeStorage_throw() respect these, so the save actually succeeds. Change-Id: I4568ef96204a219b813142d7b5eebe9f1ec5e22e
2015-06-01Do not lose AssertionError from sub-threadsStephan Bergmann
Change-Id: I8ca7194be6d22b72b73e76e5067273090b087b96
2015-06-01disable JunitTest_dbaccess_complex part RowSetMiklos Vajna
Fails locally + on Jenkins_Linux_Dbg, and commit 9b06d36571bbfa2d722f36610375e7cd24be81a7 (reenable JunitTest_dbaccess_complex part RowSet, 2015-05-30) just enabled it recently, so disable it again for now. Change-Id: Ie746eac0bdc613e2ffc6c2a1450db637d134a5c1
2015-05-31loplugin:implicitboolconversionStephan Bergmann
Change-Id: Ic0c6487661286efa04452427fc3a64da747c2ce8
2015-05-30reenable JunitTest_dbaccess_complex part RowSetLionel Elie Mamane
Change-Id: I82a1af0cd6b068e9f349ec6b068e78d55e8ab969
2015-05-30tweaksLionel Elie Mamane
Change-Id: I84ca5d1f3247d3ba3ed76bf3d39be14b47613703
2015-05-30do not try to get bookmark when in invalid positionLionel Elie Mamane
Change-Id: I64fc14e527af4f0f846bbfae84cf8d1d2914b6b9
2015-05-30handle getParameters being called before execute()Lionel Elie Mamane
Change-Id: If81e745ee15df3848c6577a9e979672523718daf
2015-05-30janitorialLionel Elie Mamane
Change-Id: I72cc8b84332442920eb5bb793474de0e9ec0fc86
2015-05-30tdf#82591 ORowSetBase::getRow handles insert row correctlyLionel Elie Mamane
and critically for this bug, modified row, too. Change-Id: I11c418d8926cabe81fcdb65d7293a4283e566f7a
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann
Change-Id: Ib80d28bf3680fc7ff1f11f3d143a103075b7ef75
generated by cgit (git 2.34.1) at 2025-02-27 20:40:03 +0000