summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2014-02-03Prevent SolarMutex deadlock in unit testStephan Bergmann
Seen once a deadlock between d 12 (Thread 0x2af5a4c8a700 (LWP 7618)): > #0 0x00002af58ac97ddd in __lll_lock_wait () from /lib64/libpthread.so.0 > #1 0x00002af58ac93bbc in _L_lock_839 () from /lib64/libpthread.so.0 > #2 0x00002af58ac93ad9 in pthread_mutex_lock () from /lib64/libpthread.so.0 > #3 0x00002af589e2383a in osl_acquireMutex (pMutex=0x9329b0) at sal/osl/unx/mutex.c:104 > #4 0x00002af598d577ec in vcl::SolarMutexObject::acquire (this=0x8dd120) at vcl/source/app/solarmutex.cxx:35 > #5 0x00002af599305c82 in SalYieldMutex::acquire (this=0x8dd120) at vcl/generic/app/geninst.cxx:49 > #6 0x00002af59e9bfb7b in framework::LockHelper::acquireReadAccess (this=0x2af5a2406088) at framework/source/fwi/threadhelp/lockhelper.cxx:150 > #7 0x00002af59ca29ccf in framework::ReadGuard::lock (this=0x2af5a4c894c0) at framework/inc/threadhelp/readguard.hxx:113 > #8 0x00002af59ca29c81 in framework::ReadGuard::ReadGuard (this=0x2af5a4c894c0, rLock=...) at framework/inc/threadhelp/readguard.hxx:79 > #9 0x00002af59cb52fce in (anonymous namespace)::Frame::getContainerWindow (this=0x2af5a2406010) at framework/source/services/frame.cxx:985 > #10 0x00002af5a32582d2 in tdoc_ucp::OfficeDocumentsManager::isWithoutOrInTopLevelFrame (this=0x2af5a24a1f18, xModel=uno::Reference to (dbaccess::ODatabaseDocument *) 0x2af5a4edc5a8) at ucb/source/ucp/tdoc/tdoc_docmgr.cxx:626 > #11 0x00002af5a325870f in tdoc_ucp::OfficeDocumentsManager::isOfficeDocument (this=0x2af5a24a1f18, xDoc=uno::Reference to (dbaccess::ODatabaseDocument *) 0x2af5a4edc558) at ucb/source/ucp/tdoc/tdoc_docmgr.cxx:697 > #12 0x00002af5a325651e in tdoc_ucp::OfficeDocumentsManager::notifyEvent (this=0x2af5a24a1f18, Event=...) at ucb/source/ucp/tdoc/tdoc_docmgr.cxx:305 > #13 0x00002af594251195 in cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::document::XEventListener, com::sun::star::document::EventObject>::operator() (this=0x2af5a4c89b20, listener=uno::Reference to (tdoc_ucp::OfficeDocumentsManager *) 0x2af5a24a1f40) at include/cppuhelper/interfacecontainer.h:262 > #14 0x00002af59425023e in cppu::OInterfaceContainerHelper::forEach<com::sun::star::document::XEventListener, cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> > (this=0x2af5a24a36a0, func=...) at include/cppuhelper/interfacecontainer.h:276 > #15 0x00002af59424f4da in cppu::OInterfaceContainerHelper::notifyEach<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> (this=0x2af5a24a36a0, NotificationMethod=&virtual com::sun::star::document::XEventListener::notifyEvent(com::sun::star::document::EventObject const&), Event=...) at include/cppuhelper/interfacecontainer.h:289 > #16 0x00002af59424d864 in (anonymous namespace)::SfxGlobalEvents_Impl::implts_notifyListener (this=0x2af5a24a3628, aEvent=...) at sfx2/source/notify/globalevents.cxx:505 > #17 0x00002af59424c543 in (anonymous namespace)::SfxGlobalEvents_Impl::documentEventOccured (this=0x2af5a24a3628, _Event=...) at sfx2/source/notify/globalevents.cxx:315 > #18 0x00002af59016a5a5 in cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator() (this=0x2af5a4c89c90, listener=uno::Reference to ((anonymous namespace)::SfxGlobalEvents_Impl *) 0x2af5a24a3678) at include/cppuhelper/interfacecontainer.h:262 > #19 0x00002af59016a35e in cppu::OInterfaceContainerHelper::forEach<com::sun::star::document::XDocumentEventListener, cppu::OInterfaceContainerHelper::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> > (this=0x11c0378, func=...) at include/cppuhelper/interfacecontainer.h:276 > #20 0x00002af590169ed6 in cppu::OInterfaceContainerHelper::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> (this=0x11c0378, NotificationMethod=&virtual com::sun::star::document::XDocumentEventListener::documentEventOccured(com::sun::star::document::DocumentEvent const&), Event=...) at include/cppuhelper/interfacecontainer.h:289 > #21 0x00002af5901690ed in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow (this=0x11c0330, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:200 > #22 0x00002af5901693fa in dbaccess::DocumentEventNotifier_Impl::processEvent (this=0x11c0330, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:231 > #23 0x00002af58cba5de9 in comphelper::AsyncEventNotifier::execute (this=0x128c4e0) at comphelper/source/misc/asyncnotification.cxx:221 > #24 0x00002af58bcfe9c4 in salhelper::Thread::run (this=0x128c4e0) at salhelper/source/thread.cxx:40 > #25 0x00002af58bcfed8d in osl::threadFunc (param=0x128c4f0) at include/osl/thread.hxx:187 > #26 0x00002af589e2e2e7 in osl_thread_start_Impl (pData=0x128db40) at sal/osl/unx/thread.c:236 > #27 0x00002af58ac91c53 in start_thread () from /lib64/libpthread.so.0 > #28 0x00002af58a9bedbd in clone () from /lib64/libc.so.6 and > Thread 1 (Thread 0x2af589931980 (LWP 7598)): > #0 0x00002af58ac95565 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0 > #1 0x00002af589e67146 in osl_waitCondition (Condition=0x11a22a0, pTimeout=0x0) at sal/osl/unx/conditn.cxx:275 > #2 0x00002af59e9c0866 in osl::Condition::wait (this=0x2af5a24060d0, pTimeout=0x0) at include/osl/conditn.hxx:82 > #3 0x00002af59e9c0bf5 in framework::Gate::wait (this=0x2af5a24060c0, pTimeOut=0x0) at framework/inc/threadhelp/gate.hxx:197 > #4 0x00002af59e9c0041 in framework::TransactionManager::setWorkingMode (this=0x2af5a24060b0, eMode=framework::E_BEFORECLOSE) at framework/source/fwi/threadhelp/transactionmanager.cxx:119 > #5 0x00002af59cb56c8f in (anonymous namespace)::Frame::dispose (this=0x2af5a2406010) at framework/source/services/frame.cxx:2229 > #6 0x00002af59cb55bec in (anonymous namespace)::Frame::close (this=0x2af5a2406010, bDeliverOwnership=0 '\000') at framework/source/services/frame.cxx:2002 > #7 0x00002af59010f9cc in dbaccess::ODatabaseDocument::impl_closeControllerFrames_nolck_throw (this=0x2af5a4edc538, _bDeliverOwnership=0 '\000') at dbaccess/source/core/dataaccess/databasedocument.cxx:1441 > #8 0x00002af59010fe24 in dbaccess::ODatabaseDocument::close (this=0x2af5a4edc538, _bDeliverOwnership=0 '\000') at dbaccess/source/core/dataaccess/databasedocument.cxx:1498 > #9 0x00002af58f6c59c6 in DialogSaveTest::test (this=0x922c10) at dbaccess/qa/extras/dialog-save.cxx:104 > #10 0x00002af58f6cc8d4 in CppUnit::TestCaller<DialogSaveTest>::runTest (this=0x879cc0) at workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166 > #11 0x00002af589bb41b4 in CppUnit::TestCaseMethodFunctor::operator() (this=0x7fff58142f30) at TestCase.cpp:32 > #12 0x00002af58c8ab9e3 in (anonymous namespace)::Prot::protect (this=0x879da0, functor=...) at unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88 > #13 0x00002af589bac2ef in CppUnit::ProtectorChain::ProtectFunctor::operator() (this=0x922aa0) at ProtectorChain.cpp:20 > #14 0x00002af58b4b5536 in (anonymous namespace)::Prot::protect (this=0x879dc0, functor=..., context=...) at unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:64 > #15 0x00002af589bac2ef in CppUnit::ProtectorChain::ProtectFunctor::operator() (this=0x922ca0) at ProtectorChain.cpp:20 > #16 0x00002af589b9dc64 in CppUnit::DefaultProtector::protect (this=0x8756a0, functor=..., context=...) at DefaultProtector.cpp:15 > #17 0x00002af589bac2ef in CppUnit::ProtectorChain::ProtectFunctor::operator() (this=0x922c70) at ProtectorChain.cpp:20 > #18 0x00002af589bac184 in CppUnit::ProtectorChain::protect (this=0x8753c0, functor=..., context=...) at ProtectorChain.cpp:77 > #19 0x00002af589bc339a in CppUnit::TestResult::protect (this=0x7fff58143450, functor=..., test=0x879cc0, shortDescription="") at TestResult.cpp:181 > #20 0x00002af589bb3c84 in CppUnit::TestCase::run (this=0x879cc0, result=0x7fff58143450) at TestCase.cpp:92 > #21 0x00002af589bb4a20 in CppUnit::TestComposite::doRunChildTests (this=0x922b50, controller=0x7fff58143450) at TestComposite.cpp:64 > #22 0x00002af589bb48aa in CppUnit::TestComposite::run (this=0x922b50, result=0x7fff58143450) at TestComposite.cpp:23 > #23 0x00002af589bb4a20 in CppUnit::TestComposite::doRunChildTests (this=0x922ad0, controller=0x7fff58143450) at TestComposite.cpp:64 > #24 0x00002af589bb48aa in CppUnit::TestComposite::run (this=0x922ad0, result=0x7fff58143450) at TestComposite.cpp:23 > #25 0x00002af589bca586 in CppUnit::TestRunner::WrappingSuite::run (this=0x879d30, result=0x7fff58143450) at TestRunner.cpp:47 > #26 0x00002af589bc30a4 in CppUnit::TestResult::runTest (this=0x7fff58143450, test=0x879d30) at TestResult.cpp:148 > #27 0x00002af589bca7e4 in CppUnit::TestRunner::run (this=0x7fff581432e0, controller=..., testPath="") at TestRunner.cpp:96 > #28 0x0000000000403ecf in (anonymous namespace)::ProtectedFixtureFunctor::run (this=0x7fff581433a0) at sal/cppunittester/cppunittester.cxx:150 > #29 0x0000000000404561 in sal_main () at sal/cppunittester/cppunittester.cxx:242 > #30 0x00000000004041a9 in main (argc=18, argv=0x7fff581436a8) at sal/cppunittester/cppunittester.cxx:166 and indeed UnoApiTest::setUp -> test::BootstrapFixture::setUp -> test_init_impl -> InitVCL -> CreateSalInstance -> SalGenericInstance::AcquireYieldMutex causes all such UnoApiTests to be run with the SolarMutex locked. This reverts acdfb2593564ea23d4bbb999856922568d7ab2c3 "dbaccess: disable hanging close() for now." Change-Id: Ifac49da2c55b0b27b780a348074f69de86967aa1
2014-02-01coverity#707745 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: If59d4018da0c406ecaa8e8348aa8ca95db72c5f1
2014-02-01coverity#707743 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I80661c2b88b7c10175e4622db7e843699d6c1686
2014-02-01coverity#707742 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I52bc7ec4326e212a93df3be9b2232bac584d9ee0
2014-02-01coverity#707741 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I1165102386aa5f6a9a35613ef199a1a5caad4ce3
2014-02-01coverity#707737-38 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Ifb3704f73835886d4c27b6cd59bb918576e0f1ac
2014-02-01coverity#707736 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Iab4b7e52d2a3a77589341d8956a8a835163c7bc5
2014-02-01coverity#707735 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Ie34247ba1d0b9b10183897c4fab0a7b10c0576b5
2014-02-01coverity#707734 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Ic2333fbdcbd3265185f382c947166e6580050ff5
2014-02-01coverity#707731 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I048ad8477df070dd77a36620ea239fcd8bd9da60
2014-02-01coverity#707730 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Iaf0d1bd80d0d27f61790fc716f2ad3faed048a5a
2014-02-01coverity#707729 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: I4411b8d36a184391e2be2be9be82016958607fda
2014-02-01coverity#707725 : Uninitialized scalar fieldNorbert Thiebaud
Change-Id: Ia5ebaca5bbb35946250854abf78ab9ab2041757f
2014-01-30merge property map for import and exportLionel Elie Mamane
why would they ever need to be different? There was maybe/probably a bug lurking behind their being different. Change-Id: I5db7f1596aec0d2a504ec7901c001054fd7fd121
2014-01-30Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-29WaE: unused variable 'aUnrelatedControls'Tor Lillqvist
Change-Id: I2078c5bcf69c9d186f3bc8b8f6552bff41a732b6
2014-01-29convert user admin dialog to .uiCaolán McNamara
Change-Id: Iee1a8b5f1fac024fb5983063f032b344e5814fbc
2014-01-29convert generated values page to .uiCaolán McNamara
Change-Id: I1193183c593f316550799dd20d8350b86e761436
2014-01-29convert special settings page to .uiCaolán McNamara
Change-Id: Ic69f35f4bd6c27bffa407c6d6c5046c66ca1173a
2014-01-29remove explicit AdjustLayout calls post .ui-ificationCaolán McNamara
Change-Id: Iab4e3b661d99d1a84b1d11853d1abdf28436d895
2014-01-29convert database properties dialog .to uiCaolán McNamara
Change-Id: I63c046f1637248e274698dbe13130124669e0712
2014-01-29missed a non-local STR_PAGETITLE_CONNECTION conversionCaolán McNamara
Change-Id: If711a458aa5c099621e4833117985d111a8f8d05
2014-01-29make these resources non-local, simplifies for ui conversionCaolán McNamara
Change-Id: I2654cf0522f2f04cd4a14d0e04f18f26e175e354
2014-01-28bool improvementsStephan Bergmann
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
2014-01-28Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28coverity#707747 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6bc4dbdd46a945d77b85ef8ec9c6333784cd0039
2014-01-28coverity#705144 Missing break in switchCaolán McNamara
Change-Id: Ie3c28d7172ec17ed7de6033c6eada6fb66d1cdf2
2014-01-28coverity#705141 Missing break in switchCaolán McNamara
Change-Id: I9b94f1056fa62b2c0c609f6d448e1750bb0e9ce5
2014-01-28coverity#705140 Missing break in switchCaolán McNamara
Change-Id: I1b08e9afda2eeb3c4c79154376f34cad3e1f0a4c
2014-01-26Workaround for MSVC error C2216: 'override' cannot be used with 'inline'Tor Lillqvist
That error is as such apparently bogus, but using 'inline' is pointless cargo cult there anyway, so drop it. Change-Id: I37b826050006e853db724248bac4f22cceece792
2014-01-26Edit::IsModified should return boolStephan Bergmann
Change-Id: I0aafdd37c73cd47b9dc68b60a32db35c8c11f455
2014-01-24dbaccess: disable hanging close() for nowMiklos Vajna
I don't know why it hangs, but seems even without closing, the test still fails after reverting fc9080a0c60f263d00eb71111fcda72b3c0a2ebb (fdo#67685 open xSourceLibrariesStor only when needed, 2013-08-02). Once the test no longer hangs, of course feel free to add this back. Change-Id: If124b7f57a8fa2d522ebdb448366aec6f1ff4987
2014-01-24Introduce com.sun.star.task.theJobExecutor singleton.Matúš Kukan
To replace com.sun.star.task.JobExecutor single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <sbergman@redhat.com>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: https://gerrit.libreoffice.org/7609 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-24convert dbwizard final page to .uiCaolán McNamara
Change-Id: Ib31810170574e46b84a9847b25585fee791d630d
2014-01-24bool improvementsStephan Bergmann
Change-Id: I20fbe8d5b25460959d4192f18431a585dbfb260f
2014-01-23SfxNoLayoutSingleTabDialog not needed anymoreCaolán McNamara
all single tab dialogs are .ui enabled now. So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog and ~SfxNoLayoutSingleTabDialogBase together Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini
Valgrind is capable of detecting such bugs. No need for extra macros. Conflicts: dbaccess/source/ui/dlg/tablespage.cxx Change-Id: I25ea9174a042050efdb371246417ee7f2edae997 Reviewed-on: https://gerrit.libreoffice.org/7532 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21wrap long text in tables filter dialogCaolán McNamara
Change-Id: I64f513969ff8eae48da4b55449439ea61b828645
2014-01-21convert table filter page to .uiCaolán McNamara
Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52
2014-01-21tidy up OTableTreeListBox to make it easier to .ui-ifyCaolán McNamara
Change-Id: I2463d665c857425bc4cf9df89338a0aab89f0a90
2014-01-21convert OTableSubscriptionDialog to SfxSingleTabDialogCaolán McNamara
Change-Id: I8335012139ccaf58bc18d0779e63a5bc388c9fb4
2014-01-20convert advanced db settings dialog to .ui formatCaolán McNamara
Change-Id: Ia3152b7cc5edd89f37c78841e10bb5feacc6fc12
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Be explicit when using bool as integral value (as Link return value)Stephan Bergmann
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17convert field dialog to .uiCaolán McNamara
Change-Id: Ic268c17941038319240bb70d59d04c9b9a7a2412
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
generated by cgit (git 2.34.1) at 2025-02-19 19:46:03 +0000