summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-07Related: tdf#92434 children cleared but parent hasn't completed dispose yetCaolán McNamara
Table::dispose is being executed, so its not IsDisposed yet, but this a11y code gets called during the dispose and the children have been cleared at this point Change-Id: I20aa9b15b1c5c3da91af58ac61f59fcf52619d58
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I999923031c573f361bc421eab84e68a4a130d688
2015-07-04tdf#92520: LibO crash when editing .odb database propertiesZolnai Tamás
Regression from: f7424ed710e54bb2437a28380b03ed7c26290edc Change-Id: I7665d579696f21846abaed21ca8c4f14acdc964c
2015-07-03Fix typosAndrea Gelmini
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-02some other coverity thingsCaolán McNamara
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02tdf#92434 - A series of hideous knock-on dbaccess crasher fixes.Michael Meeks
Focus events during dispose, unfortunate incoming a11y events, etc. Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c Reviewed-on: https://gerrit.libreoffice.org/16672 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-02tdf#92434 - fix iteration, and remember to disposeAndClear.Michael Meeks
Change-Id: Id9c7b33689ea51a18394a96acbb9c08d67992942 Reviewed-on: https://gerrit.libreoffice.org/16671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-01tdf#92431 Keep thumbnail for modified but unsaved docMaxim Monastirsky
A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2. We need to consider 2 use-cases: 1. Protecting an existing document with a password (by overwriting the original file). In this case we don't want to generate a thumbnail from the now encrypted file, but we do want to erase the stored thumbnail and show a generic icon instead. 2. Closing a modified document without saving the changes. Here we don't want to generate a thumbnail either, because it may contain the unsaved changes, but either we don't want to replace the stored thumbnail, because most likely it correctly represents the last saved state of the document. Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826 Reviewed-on: https://gerrit.libreoffice.org/16659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29sal_uLong->sal_Int32 in SvtIconChoiceCtrlNoel Grandin
and drop the pass-by-reference param from GetSelected, nothing uses it Change-Id: I6d616a2b147912af9305410625af6e7afae34e59 Reviewed-on: https://gerrit.libreoffice.org/16312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-28coverity#1308523 Uncaught exceptionCaolán McNamara
Change-Id: I965a4e86dd48ebec22ca9dccc77374a6e117fc7e
2015-06-28coverity#1308522 Uncaught exceptionCaolán McNamara
Change-Id: I2cab6b55aebc50bd024fe68553040292e40acb4b
2015-06-28coverity#1308510 Uncaught exceptionCaolán McNamara
Change-Id: I6734b2953e9a262e7661782c92318f54e14181eb
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-27coverity#1308442 Uncaught exceptionCaolán McNamara
Change-Id: Id86fbd119c5da322dadadbfd65cbb09dcc403f38
2015-06-27coverity#1308441 Uncaught exceptionCaolán McNamara
Change-Id: I861cc6d427782d52f098542371f13d6fde1280f0
2015-06-27coverity#1308440 Uncaught exceptionCaolán McNamara
Change-Id: Id0392763efa7041db0dc96a2b08d94274030cdee
2015-06-27coverity#1308439 Uncaught exceptionCaolán McNamara
Change-Id: Ibb5e04c49efddbf4e30615f4e4560414026f520c
2015-06-27coverity#1308436 Uncaught exceptionCaolán McNamara
Change-Id: Icdcd3deee724eddbed776db4ee4a77fae2dcc2ee
2015-06-27coverity#1308434 Uncaught exceptionCaolán McNamara
Change-Id: I7014f77a194af6aae43051b680c02c4f2b97b597
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: Idcbd6b31a3147fc883fed49095e518af170daf38
2015-06-26no need to capture _rTablesTakeshi Abe
Change-Id: I78b4051ffdb625481b238cc3a5313aa4d086b87e
2015-06-25Remove spurious negation operator againStephan Bergmann
...which had been introduced with 3f4978f8c660c595773c92b99d45d0631cac04b0 "loplugin:implicitboolconversion" when changing return name.second == sal_True; to return !name.second; Change-Id: I3d4cfb613efcc72cf01176556c678a97e5817528
2015-06-25loplugin:implicitboolconversionNoel Grandin
Change-Id: Ib266bc70a99d84d4e3d845573f39e612dc6595f8
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: Ifd804fb45fb032dddbf2ba3643ec0964e0e24724
2015-06-25tdf#91112 replace o3tl::compose1 with lambdas in dbaccessJorenz Paragas
Change-Id: Ic4a95272e88cda0080f0faddfb0671e3ff3f9d7c Reviewed-on: https://gerrit.libreoffice.org/16418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-24Simplify uses of comphelper::string::equals with constant argumentStephan Bergmann
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-22Add variadic PartialWeakComponentImplHelper, remove need for implbase_var.hxxStephan Bergmann
Change-Id: Iad3417822b2ab3afb75da09c311a0bf07af5e2e4
2015-06-22gtk3: native render the comically oversized gtk3 spinbuttonsCaolán McNamara
Change-Id: I3e97200d59a97271617a6e9a88c807a07a33edfe
2015-06-22cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I913f983bb0f55e05bb5ec8994ee75a7e7d69bd1b
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22new uno sidebar api tdf#91806Laurent Godard
the entry point is SfxBaseController::getSidebar() the Decks and panels are now per SidebarController and not global anymore ' macro example Sub testSidebarApi controller = thisComponent.currentcontroller frameIni = thisComponent.currentcontroller.frame sidebar = thisComponent.currentcontroller.getSidebar() sidebar.setVisible(true) frame = sidebar.getFrame() decks = sidebar.getdecks() c = decks.count h = decks.hasElements() e = decks.getElementNames() a = decks.hasByName("MyDeck") deck = decks.getByName("MyDeck") deck.activate(true) t = deck.getTitle() deck.setTitle("new deck title") deck.moveFirst() deck.moveLast() deck.moveUp() deck.moveDown() index = deck.getOrderIndex() panels = deck.getPanels() ep = panels.getElementnames() ap = panels.hasByName("aPanelName") panel = panels.getByName("aPanelName") panel.setTitle("new panel title") panel.collapse() panel.expand(true) ' expand and collapse other index = panel.getOrderIndex() panel.moveLast() panel.moveFirst() panel.moveDown() panel.moveUp() End Sub Change-Id: I7a4b953f2277dea483bb296ba6ead35de7205ace Reviewed-on: https://gerrit.libreoffice.org/15856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2015-06-20callcatcher: update unused codeCaolán McNamara
Change-Id: I29b3f1408b814a1424d8bab232e9ac618901b4c2
2015-06-19Shall this produce a string representation of a number?Stephan Bergmann
On the one hand, the code had apparently treated nIdx as a sal_Unicode character value ever since its inception in e718950884fa2db240822e1711f301b39a70ad3e "new querydesign." On the other hand, the preceding BROW_VIS_ROW case does produce strings "0" and "1". Change-Id: Ife6e98ba32146cc469b722fa4f013c12152b5505
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-19 20:58:01 +0000