summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2019-07-18cid#703937 Unchecked return valueCaolán McNamara
Change-Id: I38be419c6ed4857c52ac555696a614008aaad907 Reviewed-on: https://gerrit.libreoffice.org/75835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448482 silence Using invalid iteratorCaolán McNamara
Change-Id: I78c5fa16e035cebe71869bfea57ef2741b5b7f58 Reviewed-on: https://gerrit.libreoffice.org/75829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#123020 dbahsql: Support string delimiterTamas Bunth
Support multi-word table names while migrating HSQLDB data. Change-Id: I5129f995ea90a3fdbcbcb844774cf074f3ffddb2 Reviewed-on: https://gerrit.libreoffice.org/75734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-13dbaccess: use local variable aBytesXisco Fauli
Change-Id: Idffdb1cf7edf2c6cd39c1c417158069fed5445fa Reviewed-on: https://gerrit.libreoffice.org/75528 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-12tdf#126268: Add support for negative decimalXisco Fauli
basically reintroduce the code deleted in 2e26ef34bf1a2e5d1293e45cf3b1415d9514b056 and check at the right place the sign values Change-Id: Idf613a3a087b428d1f85abe9b43342fb67538a63 Reviewed-on: https://gerrit.libreoffice.org/75488 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-11tdf#126268: first byte is not used for the sign symbolXisco Fauli
This code is just broken, negative numbers and positive numbers above 25 are incorrectly migrated if using decimal. E.g: -1 -> 24,6 26 -> -6527'6 thus, delete it and pass the 8 bytes as they are to lcl_double_dabble. Note: this only fixes the positive numbers, -1 still returns 24,6 Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09 Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650 Reviewed-on: https://gerrit.libreoffice.org/75375 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24move SvtIconChoiceCtrl to vclCaolán McNamara
Change-Id: I5ed8af625cb46998649c4f11255d7676a11bdc94 Reviewed-on: https://gerrit.libreoffice.org/74605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Resolves: tdf#125168 label mnemonic appearing in database urlCaolán McNamara
Change-Id: I39531ae2a656c16c7355d73b76cb918d3535f7b0 Reviewed-on: https://gerrit.libreoffice.org/74602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23tdf#39593 Remove dbaccess::OContentHelper::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I533bfcd3959037a2621eb3fd42bf7172b5396c5f Reviewed-on: https://gerrit.libreoffice.org/74539 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-15Removed duplicated includeAndrea Gelmini
Change-Id: I9054caf8ae1ed5833399de1f749c82ac367b5dd9 Reviewed-on: https://gerrit.libreoffice.org/74106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15loplugin:logexceptionnicely in dbaccessNoel Grandin
Change-Id: I2d702b699c2e61dbb363eff671bb43d4ddbf8ee3 Reviewed-on: https://gerrit.libreoffice.org/74045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-13add link to hsqldb->firebird migration dialogCaolán McNamara
1. keep presenting the migration dialog 2. but, default to 'later' 3. add a link to a URL that someone will have to fill in Change-Id: I4c67fe0b65fd78e942ca0760c0f9e128e5ac7be6 Reviewed-on: https://gerrit.libreoffice.org/73610 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12has_default needs can_defaultCaolán McNamara
Change-Id: Id841d214b8d88a986c07d2827b281e5805c3c941 Reviewed-on: https://gerrit.libreoffice.org/73810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-11Fix typoAndrea Gelmini
Change-Id: I47dc0bc0b94dd1ceb40efdae4b5e0e14ac920e81 Reviewed-on: https://gerrit.libreoffice.org/73789 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-09loplugin:constantparamNoel Grandin
Change-Id: I7bbc4e1546acf58f1ca24bfec5e465bad5ca90de Reviewed-on: https://gerrit.libreoffice.org/73732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08tdf#125381: Manage URLs beginning with an "~" in cutPrefix (dbaccess/dsntypes)Julien Nabet
On Windows or with other renderings than gtk3, the urls may begin with an ~ In this case, cutPrefix returns only empty string When trying to access Index management for odb files related to dBase indexes don't display because cutPrefix returns empty url in dbaccess/source/ui/dlg/detailpages.cxx line 200 198 ::dbaccess::ODsnTypeCollection* pTypeCollection = pTypesItem ? pTypesItem->getCollection() : nullptr; 199 if (pTypeCollection && pUrlItem && pUrlItem->GetValue().getLength()) 200 m_sDsn = pTypeCollection->cutPrefix(pUrlItem->GetValue()); Change-Id: I47360e205ddea7b060a31da697bbe9857ad3f4c0 Reviewed-on: https://gerrit.libreoffice.org/72568 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06drop never used dialogCaolán McNamara
Change-Id: I2474887914ec74e62667fd6f68ecb57bad89ca0d Reviewed-on: https://gerrit.libreoffice.org/73561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-05Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-31dbaccess: fix more memory leaks caused by circular ReferenceMichael Stahl
Followup to 96ae2a3300811897c24cccb20f8c2faf382483df; more overridden acquire() creating cycles in dbaccess. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) Change-Id: I134343b3afbcd5ee3f71212ec18e551455eaee5b Reviewed-on: https://gerrit.libreoffice.org/73158 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-29tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)Xisco Fauli
Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53 Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890 Reviewed-on: https://gerrit.libreoffice.org/73146 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-05-28Fix domain in ui files (cui, dbaccess, svx)Julien Nabet
Change-Id: I6c09bf2af4b902fdc215ec31bf2dad490e41384e Reviewed-on: https://gerrit.libreoffice.org/73066 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-22tdf#124951: Enable children depending on parentXisco Fauli
Change-Id: I221b7ae202d6dbd08d0496561652b2471b093b46 Reviewed-on: https://gerrit.libreoffice.org/72783 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-22tdf#125436: Do not disable type options listXisco Fauli
Change-Id: I2080f3c04a04cea626d4969b59e54612cbefe03b Reviewed-on: https://gerrit.libreoffice.org/72780 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-22New loplugin:dataStephan Bergmann
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18remove remaining '0' responsesCaolán McNamara
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18tdf#124951 Open button on Database Wizard dialog is enabled..Noel Grandin
..when it should be disabled regression from commit 7df04009b98165f89c89f1e506ebafd2fecc8f5a Date: Fri Feb 8 11:55:18 2019 +0200 remove ControlDependencyManager Change-Id: Ic84d8c8a5f0615753e323d3aa1e9da0d0c76bb42 Reviewed-on: https://gerrit.libreoffice.org/72532 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-17tdf#125267: relax the requirement of fixed value of current filterKatarina Behrens
In a filepicker, user can select any file filter ('All files' for example) and still choose to open .odb file. Specific UIName of the current filter ('ODF Database' in this case) shouldn't therefore be a hard requirement, the correct file extension is enough. Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24 Reviewed-on: https://gerrit.libreoffice.org/72377 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-17Replace list by deque in dbfindex (dbaccess)Julien Nabet
Change-Id: I9503cce6eff31f08c2762940b881ba1dc8633288 goal: to get rid of std::list when not mandatory Reviewed-on: https://gerrit.libreoffice.org/72434 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-17tdf#125325: fix crash about index managements for dBaseJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=151468 Pb is aSearch becomes invalid after _rList.erase(aSearch); line 101 so just test aReturn.GetIndexFileName() isn't empty Change-Id: Iae5b3a7f76fe565f890bd23bfb2ce5d9c6134986 Reviewed-on: https://gerrit.libreoffice.org/72427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib286a2151fe19a91b4e9db8db9f92ac0d5264d36 Reviewed-on: https://gerrit.libreoffice.org/72330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-15Fix typoAndrea Gelmini
Change-Id: I407e8aa9c75fd5598321294437d9340f3f8e9456 Reviewed-on: https://gerrit.libreoffice.org/72325 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-15Fix typoAndrea Gelmini
Change-Id: I2b7f2d9eb1290c25c48867f17694fe5e6b1826bf Reviewed-on: https://gerrit.libreoffice.org/72324 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-12Fix typoAndrea Gelmini
Change-Id: I66429d273adf969fb54d6e378021b1db6da28969 Reviewed-on: https://gerrit.libreoffice.org/72171 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini
Change-Id: I6f6042e57821e4deeeb41ab4ce14ac355ddf432c Reviewed-on: https://gerrit.libreoffice.org/72175 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini
Change-Id: I89f281b85a735847572e10f0622eb115f8615b24 Reviewed-on: https://gerrit.libreoffice.org/72176 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini
Change-Id: Ib203bf75d44d5741ebeb107e2e672f00bf4211ff Reviewed-on: https://gerrit.libreoffice.org/72177 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini
Change-Id: Ic575e060a6f4d19213182acc32e4e9e6374f2ae2 Reviewed-on: https://gerrit.libreoffice.org/72178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini
Change-Id: I3292e784ff82c5e71d9b3b931f21db963d681016 Reviewed-on: https://gerrit.libreoffice.org/72170 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini
Change-Id: I572453ea9cac59f7dce0abe79e6f034960555081 Reviewed-on: https://gerrit.libreoffice.org/72169 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini
Change-Id: I988a205025cd62d479adc2fbc9c2c86f05414fb5 Reviewed-on: https://gerrit.libreoffice.org/72166 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini
Change-Id: If7ecd8501a6dfae0d56d98f6f5fa134ed7bbc60b Reviewed-on: https://gerrit.libreoffice.org/72168 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-03-01 20:20:55 +0000