summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22Increase width of Copy Table dialog in BaseMuhammet Kara
Currently the "Help" button is cropped and partially visible on the Copy Table wizard. Increasing the width to 700 seems to make it fully visible again. Change-Id: Ib64ab0724d944f310f1c76a01ee91f00087bc320 Reviewed-on: https://gerrit.libreoffice.org/26548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-17Simplify OPropertyContainerHelper::registerPropertyNoMember's _pInitialValueStephan Bergmann
Change-Id: Ibfb27b3eded45e2646dada37ce3663f427985ae9
2016-06-16tdf#42949: clean up includes in include/dbaccess with iwyuJorenz Paragas
Change-Id: I40de14b82b698b927cb461376470dc177c16d58c Reviewed-on: https://gerrit.libreoffice.org/26345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13coverity#1362680 Pointer to local outside scopeCaolán McNamara
this doesn't seem to make sense anymore since... commit 4d49c9601c9b3e26a336e08e057d299895683480 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Jun 8 17:14:34 2016 +0200 Let loplugin:passstuffbyref also look at fn defn not preceded by any decl so lets revert that to be safe Change-Id: I78fe8ae48dc4c4f3d5786c7232d7e791ff50d9b4 Reviewed-on: https://gerrit.libreoffice.org/26189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13Fix typosAndrea Gelmini
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-10Clean up uses of Any::getValue() in dbaccessStephan Bergmann
Change-Id: Icaad71e51301e017a48ab3f87b151f5e0de26cd9
2016-06-09tdf#100286 Fix deactivate flagsMaxim Monastirsky
regression of 11b4a6ddce31f173f10b703eb63fde2c88c0bc70 Change-Id: I4981fee4264c833cd3166491d3812c40c78e3d67
2016-06-09convert some manual ref-counting in dbaccessNoel Grandin
Change-Id: I2df7b6b79bff4a5c7358288518c5518b6a7032bf Reviewed-on: https://gerrit.libreoffice.org/26051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08split AddRemoveListener into two methodsNoel Grandin
Change-Id: I247dc8a9033b39d5e49dc06e725f638644fcd02d
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06Normalize on using @throws instead of @raise[s]Stephan Bergmann
...as the former is used almost exclusively Change-Id: I38ff11cd0d5125534550df99dd427666011c3b7b
2016-06-06Convert DeactivePage return code to scoped enumNoel Grandin
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd Reviewed-on: https://gerrit.libreoffice.org/25918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-04tdf#96516 fixup: when removing entry, entry count does not stay constantLionel Elie Mamane
Change-Id: I192a2d14787581545e66c46a84507f6dfd191c57
2016-06-03connectivity: firebird: use ODS12 test database for Firebird 3Michal Kubecek
Firebird 3.0 uses new database file format (ODS, On Disk Structure) so that we need to use either ODS11 or ODS12 version of test database for dbaccess_firebird test, depending on whether building against Firebird 2.5 or 3.0 libraries. Change-Id: Idecdc35b0ac87ab7f46cb79b5c044c65423a2c7e Reviewed-on: https://gerrit.libreoffice.org/25846 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-02coverity#1362486 Unchecked dynamic_castCaolán McNamara
Change-Id: Ia495ac1434500048ce2f6ffd8d85e3ece13d2bad
2016-06-02loplugin:unusedfieldsNoel Grandin
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30move the one single use of EnableMenuStrings to its call siteCaolán McNamara
Change-Id: Ie5087f564c024cae526757ed1445c97113e8a68e
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27tdf#96516 do not increment position counter when an entry is removedLionel Elie Mamane
Change-Id: I81a4455df1fd5962d0362f4e5fa3396764a0ae5a
2016-05-26Related: tdf#97854 confirm that on !bDelete there's a ref to the connectionCaolán McNamara
so that its not deleted on removal from the vector Change-Id: I6c1f7691ee415abf0f419fdd7fcf2341fe2bd1f3
2016-05-26Resolves: tdf#97854 crash on deleting inner join relationshipCaolán McNamara
seems to be a regression from... commit 356bc0f697299e5fb6156ce25dc69845eaa6f9e6 Author: Michael Meeks <michael.meeks@collabora.com> Date: Wed Jul 1 19:03:55 2015 +0100 tdf#92434 - fix iteration, and remember to disposeAndClear. which is part of the VclPtr stuff so hold the connection by VclPtr when removing it from m_vTableConnection and only call dispose on it when _bDelete is true, not always. Change-Id: I38e65c6928499dc1e8bbf6b71e9901a4eaa5d913
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12in non-debug build, leave sPath emptyStephan Bergmann
(avoid -Wimplicit-fallthrough with NDEBUG) Change-Id: I60332c4b05c805a7972189774283cdd518f77af0
2016-05-12dbaccess: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: I468f9c7af9c8c8189c51790e0301dd8c60a9f83c
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Avoid some OUString temporariesMatteo Casalin
Change-Id: Icd7a63ac144c9ef365e64ab09d611cdfe3edf739
2016-05-10Avoid some OUString temporaries and constifyMatteo Casalin
Change-Id: I4789e9c0a4c2978e703ad4f8a088c8d267cd0972
2016-05-10Avoid some temporaries and constifyMatteo Casalin
Change-Id: Ie9ae7edb78e3c5768e4d253ab43a1dcdcf44078c
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
generated by cgit (git 2.34.1) at 2025-01-31 01:15:24 +0000