summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2021-02-25tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktopMoaz
MacrosTest::loadFromDesktop itself asserts on its return value. Thus, the additional checks in unit tests are redundant, and only create noise unrelated to the tested functionality. Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-24hide MenuBar detailsCaolán McNamara
Change-Id: I409a4df7703300e920511c28263634a00c7c6da7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23Fix typoAndrea Gelmini
In all other places I see similar invocation written with right spell. I guess these are wrong. Change-Id: Ie0300d8ea0c42554dec0cd95c13a1be571e11536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111366 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-02-22weld colsmenuCaolán McNamara
Change-Id: I733e101905137abc0b3f93b9fe03e4a26c1bd520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22there is no way to activate ID_BROWSER_COLUMNINFO so its dead-codeCaolán McNamara
Change-Id: Ib06ab1f0e0b62324f910d5954a11cc698de8d764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22loplugin:refcounting in dbaccessNoel
Change-Id: I8d8b33b5488dd1568f0105425d033da42578b4e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-21Typo fix: supress -> suppressTor Lillqvist
Change-Id: I72aeaff1bc8ac67253265ea99de91b9b9906e5d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111275 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-20loplugin:refcounting in svxNoel
Change-Id: I79afd219a29ad176ce72020579d2b29a0b3ec09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19update pchesCaolán McNamara
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19weld rows menuCaolán McNamara
Change-Id: I0dd56e2c236b15b057ddd0f2d93019b783d457d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19nRow argument is unusedCaolán McNamara
Change-Id: I9401d5af8e537423e7198435457107e12817fc09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18Resolves: tdf#140444 return early before null-derefCaolán McNamara
Change-Id: I85c0d178c3d6e375beb3ad50c4bae9ba0ac29937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-17move statusbar into DBTreeListBox containerCaolán McNamara
and convert to weld::Label Change-Id: Ic3cacf2197895712c6e6b38226f65078320c590f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16convert m_aTypeImage to weld::Image and move inside OTableWindowTitleCaolán McNamara
Change-Id: Ib3370a2a44761b2f4f5c6d0ade86d2f640c9fc48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16weld OTableWindowTitleCaolán McNamara
Change-Id: I466b73b1135c1336e3c94432f220b52343fe00d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16show context menu on right click in treeviewCaolán McNamara
Change-Id: I2a124d63309130b0488e30169aa54ffbc736999f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15tdf#119931 Fix accessibility warningshomeboy445
Change-Id: I897cc51f6c338e82896591d79b6e167f27189122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15loplugin:referencecasting in dbaccessNoel
Change-Id: Ib4e751ce4ce83db4af66d2fd969108a86dcd2296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-12ignore row-activated with no active cursor positionCaolán McNamara
to reproduce: under gen launch base wizard, "open an existing database file", and use the "open" button, double click a .odb. base launches on the 2nd button down, on mouse *release* base has appeared and has a treeview under the mouse which gets button up and triggers "onSelected" with the unexpected no-row selected case https: //crashreport.libreoffice.org/stats/crash_details/a6282ff5-d0aa-4beb-9b44-6c5fd2ca0130 Change-Id: Ic4a5fa9fc8c9c6bb0e33c165559eda966b83e3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08update pchesCaolán McNamara
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-06drop some unneeded includesCaolán McNamara
Change-Id: I3cd72110ae2601b1b11539702c5fb91086d779eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-02tdf#86871 Replace ellipsis w/ meaningful labelOlivier Hallot
Change-Id: I7297d80d369e67762ebfa50fff208332a9096107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110268 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-31Resolves: tdf#139239 set correct search columnCaolán McNamara
Change-Id: I69703228a942f16efd7a9c6270639fadd5c6c51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110207 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-29loplugin:stringviewparam extend to new..Noel
O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-26loplugin:passstuffbyrefNoel
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25avoid some ref-countingNoel Grandin
can just return a pointer here, instead of VclPtr. Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24Use ContainerType().swap and avoid local variablesMike Kaganski
Change-Id: I773555180758a97aff37f9bc27de83c355d71521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-22tdf#138409 numerical ControlFormat strings shouldn't be localizedCaolán McNamara
i.e. input fr/de 12,34 should be stored as 12.34 Change-Id: I20c97d2d604998a40e3a15963aa3d8716101e3c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21_yes -> _YesCaolán McNamara
Change-Id: Ie85ea2b8a2620d0a62f39b39ebbb2ac41ab85d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21tdf#139298 New created query doesn't show any rowCaolán McNamara
regression from... commit 5f7cf9ccba25a94c275ec67936dc29f0adb4129a Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Aug 10 19:49:25 2020 +0100 use InterimDBTreeListBox Change-Id: I755879699aa6fcc9b42b5845ae60406794e11cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20set parent for database authentication user/password dialogCaolán McNamara
Change-Id: Idd351405dbdccdf75d350ace876f8a8d00d9e549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109700 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-01-18Related: tdf#66813 this dialog should be modalCaolán McNamara
if we truly want it to be modeless, then unset this bit and use the runAsync mechanism Change-Id: I7d1cae1975d6ac20ef34b7744981ee72b9f52c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16snap near 0.5 align values to 0.5Caolán McNamara
Change-Id: Idcedba97e1738f097a36845614a17f143c20c7c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16make the Color constructors explicitly specify transparencyNoel
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves: tdf#138675 crash on checking if focus is in OFieldDescControlCaolán McNamara
use has_child_focus instead, which didn't exist at the time of... commit 3fc63a7463149685b04c676968a82bc00a48a9af Date: Fri Aug 28 10:29:55 2020 +0100 weld OTableBorderWindow and so sidestep that m_pActFocusWindow has always fallen out of sync when OFieldDescControl clears its contents Change-Id: I274131c314a00bdfec2e877a2baa3758d45c325f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves: tdf#139299 crash on gaining focus during disposeCaolán McNamara
Change-Id: I5fd2b3cec7dd0c2c10c88006ef1812e57b547e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11xmloff: "form:datasource" vs. "db:data-source"Michael Stahl
Recently xmloff started to use XML_DATASOURCE for "form:datasource" but it actually means "data-source". Add XML_DATA_SOURCE and use it for "db:data-source". (regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a) Change-Id: I893efd3fb0fb7c19ae998442459bf36cb1da0b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-09fix coverity parse errorsCaolán McNamara
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for dbaccess part b Change-Id: I31e7bd41923f8167db50da4701990ba20fc582de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-24drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for dbaccess part a Change-Id: I08c2faf9a82bc6f007ebe02c7ebac8d9a46430e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22split SotStorageStream into two classesNoel
since it has two completely different paths of control Change-Id: I89b739d318d52245208a4bda1230f69d19f3ae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-05-02 12:39:28 +0000