summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-22Revert "PythonTest_dbaccess_python: don't modify source document"Michael Stahl
This reverts commit 29474c7a227050b16fc341bdf7df68112793a23d. Removing the lock file fails on Windows because it is opened; it ought be possible to close the document instead to clean up the lock file? Change-Id: I2c93fc893c62d6a267be9723761e5ed7577086a7
2014-10-22Save precious vertical space by removing some redundant heading labelsAdolfo Jayme Barrientos
Change-Id: I6aaa7602f57f6cb2d0f9bc3ee897a9c3576d47d3 Reviewed-on: https://gerrit.libreoffice.org/12012 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21PythonTest_dbaccess_python: don't modify source documentMiklos Vajna
Change-Id: I4e8f94554141e41863c474c5f99be4b1974f3dd7
2014-10-21dbaccess: make sure fdo84315.odb.lck is removed after the test passedMiklos Vajna
Change-Id: I6c9a42625f10a3a30e2636a2a2be2b9bcba8f6af
2014-10-21connectivity: firebird: fix temp directory leakMichael Stahl
Dispose the dbaccess document, and recursively delete the temp directory in Connection::dispose(). Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-21dbaccess: surely the problem is that the storage could _not_ be committed?Michael Stahl
Change-Id: I03e7e09e185e9cb25868c86de0b402b89e7f5d75
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-12coverity#706421 Uncaught exceptionCaolán McNamara
Change-Id: I91a6ac9d9bda0ea25f1f5385bbac71ea9d22d573
2014-10-12coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I7717b61e89d95cb6d89bb273c22c0503b0853d96
2014-10-12coverity#706478 Uncaught exceptionCaolán McNamara
Change-Id: Ie37ebac80afb3e52668ae6ebeeb61eaddc892ef6
2014-10-12coverity#706476 Uncaught exceptionCaolán McNamara
Change-Id: I1461c99fccb57ccf5375e372e50948b0b355d4bb
2014-10-12coverity#706477 Uncaught exceptionCaolán McNamara
Change-Id: If44507458f8473d6fede3e430e69620f8fb1d698
2014-10-12Remove a GtkFrame and its redundant labelAdolfo Jayme Barrientos
It’s more than obvious that these are “Options”. Change-Id: I192a1864bc43b3e20e98e179282dac02abbdbbf4 Reviewed-on: https://gerrit.libreoffice.org/11925 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09forgotten part of previous commitLionel Elie Mamane
Change-Id: If050e630edacef67ab194c0b6941a6542e4ebceb
2014-10-09fdo#84073: change ODBC/JDBC escapes to lowercaseJulien Nabet
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8
2014-10-09Remove jvmfwk plugin featureStephan Bergmann
...which was effectively unused; there only ever was a single sunjavaplugin that is now folded directly into jvmfwk. Leaves room for further clean up. Change-Id: I14dd2a3a09bd1ce9a8c3f5c156628ec11d954a0b
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-07fdo84315: add integration test for basic LibreOffice Base functionalityBjoern Michaelsen
Thanks to Stephan for helping with the test environment setup: sbergman@redhat.com: Do the same "set UserInstallation to user profile dir in test/user-template" in UnoInProcess's setUp as is done in test::BootstrapFixtureBase::setUp (unotest/source/cpp/bootstrapfixturebase.cxx) for CppunitTests. That way, these tests all use the workdir/unittest/ UserInstallation concurrently, but they at least do not run into the gotcha in SubstitutePathVariables::SetPredefinedPathVariables (framework/source/services/substitutepathvars.cxx) to only set the PREDEFVAR_USERPATH if PATH_EXISTS. Change-Id: Iad058098a4c69cb567e2d3222af3c7d4ba993271
2014-10-06fdo#84658 on reexec, cancel modification before resetting IsModification stateLionel Elie Mamane
Change-Id: I878bff4d36ca1c2dd9474c937b03d0b366a6e911
2014-10-03coverity#1242480 Dereference null return valueCaolán McNamara
Change-Id: I9818e647915bd2b973c617feb7efd256621cf2de
2014-10-03loplugin: cstylecastNoel Grandin
Change-Id: Ie478d1fcfd3b64d7a2128887c216b5e0b4501ab9
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01coverity#1242747 Uninitialized pointer fieldCaolán McNamara
Change-Id: I1530d071ad44afc114f1916bf234e0616b7dce90
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29MSVC 2012 apparently isn't ready yet for std::vector<std::unique_ptr<T>>Stephan Bergmann
...producing error messages about trying to access private undefined unique_ptr copy ctor etc. Partial revert of 014e7933af751bfe0a03867373b82efa806f3a3d "svtools: std::auto_ptr -> std::unique_ptr: ...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr," going the awkward std::unique_ptr x(...); push_back(x.get()); x.release(); route instead (which could be simplified if boost::ptr_vector::push_back ever started to support unique_ptr). Change-Id: I15693030a0bbfdedbfdfbe76ede5d0c74f4e5b41
2014-09-29svtools: std::auto_ptr -> std::unique_ptrStephan Bergmann
...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr. Change-Id: Ie5f92bc40ce5425dc1c634b17addc2b0dd9bbda3
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-26factorise odbc headers inclusionLionel Elie Mamane
it is complicated enough that we should implement that logic only once Change-Id: I0cc5ffb871223b27df825f21612e3c8f6f2febb3
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26SvStream - rename WriteNumber methodsNoel Grandin
to Write?Int32AsString. Since the original name was so generic as to be meaningless. Change-Id: Iaaaf592904af51f2b9988fa8efb344c1b2bf9b0f
2014-09-25dbaccess: C2668: ambiguous call to overloaded functionMichael Stahl
Change-Id: I49522f0cd3c5749a5a0116e134fa2a93bd3e50c3
2014-09-25dbaccess: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I2b27aaf589fcbe4da1680f624a57be7ae62b0dc5
2014-09-24Add missing include to avoid compile error on windowsPeter Foley
Change-Id: If338b41e416362fc36da25b16f119187a358206c Reviewed-on: https://gerrit.libreoffice.org/11617 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22Resolves: #i121492# Base can not filter by datesKay Schenk
Patch by: hanya Fixed date filter problems in table view. Now processes old style date format and "normal" for database as expected. (cherry picked from commit 79ff7fc76c74a012933230d6f3c37977eccc6398) Conflicts: dbaccess/source/core/api/SingleSelectQueryComposer.cxx Change-Id: I2ae1b50b9e85ff2c543aaea90894a7edd5bc7524
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-17TyposJulien Nabet
Change-Id: Icf850c4b7b146a82a5638a3cd88ad02f3171aff3
2014-09-12dbaccess: remove optimization disabling workaround for GCC 4.2 bugMichael Stahl
i#102305 was filed against OOo Linux baseline (some GCC 4.2.x); let's hope the current GCC versions that are required for C++11 work fine. Change-Id: I0ff00a44bb8fbb48845756cebd4ad69e0ab0c7aa Reviewed-on: https://gerrit.libreoffice.org/11395 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-12dbaccess: sal_Bool -> boolStephan Bergmann
Change-Id: Ifad71823e72be71cbd9f9f58a51f4553ff54e4d4