summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2015-07-07tdf#92431 Keep thumbnail for modified but unsaved docMaxim Monastirsky
A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2. We need to consider 2 use-cases: 1. Protecting an existing document with a password (by overwriting the original file). In this case we don't want to generate a thumbnail from the now encrypted file, but we do want to erase the stored thumbnail and show a generic icon instead. 2. Closing a modified document without saving the changes. Here we don't want to generate a thumbnail either, because it may contain the unsaved changes, but either we don't want to replace the stored thumbnail, because most likely it correctly represents the last saved state of the document. Conflicts: sfx2/source/appl/newhelp.cxx sfx2/source/appl/sfxpicklist.cxx Reviewed-on: https://gerrit.libreoffice.org/16659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit d9c476bfbb4a8f1858c072d2fba33aa9e8e0ae92) Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826 Reviewed-on: https://gerrit.libreoffice.org/16765 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-03-06tdf#89391 : Datasource URL in Database Properties window cannot be viewedSzymon Kłos
Change-Id: Ia3e978e3fd9c0ce19ec679c41d40a34338147c37 (cherry picked from commit 1ac9985ade97f91869a11ce45231ffd6a5440959) Reviewed-on: https://gerrit.libreoffice.org/14768 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-03-04gbuild: CppunitTest: always use unittest configurationMichael Stahl
The sc_subsequent_filters_test was failing because of a lock file because it did not use the unittest configuration. Refactor gb_CppunitTest_use_configuration so it uses both the instdir and unittest configuration to prevent such errors. In case there ever is a test that does not work with the unittest configuration it should call gb_CppunitTest_use_instdir_configuration. (cherry picked from commit f0a60415597bae7ca54767b397a217882578ce97) Conflicts: dbaccess/CppunitTest_dbaccess_RowSetClones.mk sc/CppunitTest_sc_condformats.mk sc/CppunitTest_sc_recordchanges.mk Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e Reviewed-on: https://gerrit.libreoffice.org/14738 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-09tdf#73059 isDBReadOnly ensure connection before trying to retrieve itLionel Elie Mamane
Change-Id: I03f9b8ea72bd6906df61ccf05ead3670d7f90eb7 Reviewed-on: https://gerrit.libreoffice.org/14178 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-02-09tdf#89070 Table filter dialog: properly initialise OTableTreeListBoxLionel Elie Mamane
regression from .ui conversion: commit 5c72a213c7c4b588d0c1e0884ff2c46c22425faf Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 21 14:41:16 2014 +0000 convert table filter page to .ui Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52 Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a Reviewed-on: https://gerrit.libreoffice.org/14342 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-02-09not all OrCriteria have three childrenLionel Elie Mamane
and some contain a column in the second child Change-Id: I60aca574815251902aa7dd1056903bdade9e21a1 Reviewed-on: https://gerrit.libreoffice.org/14340 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-02-05Resolves: tdf#88825 absent datasource causes exception / abortCaolán McNamara
::dbtools::ensureRowSetConnection throws on failure, and it can fail of course if the database doesn't exist its not generally useful to throw through a vcl event handler as that just leads back to the dispatch loop. (cherry picked from commit 863122b9adecedfcf35ffac1354ef8a85d5b6827) Conflicts: dbaccess/source/ui/browser/sbagrid.cxx Change-Id: I8e8f4cff06de5684f163ed1b658a8794f54a7df2 Reviewed-on: https://gerrit.libreoffice.org/14329 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-03Query Design: use correct name for columns that come from another query.Lionel Elie Mamane
Change-Id: I25b4ccdc2f50ba89687e1f4c871f286251a28e21 Reviewed-on: https://gerrit.libreoffice.org/14232 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-27tdf#70236 propertly recognise full Access 2007 URLLionel Elie Mamane
Change-Id: If1f4986cfffada6a6ab507296a54589bdd5404ff Reviewed-on: https://gerrit.libreoffice.org/14212 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-23fdo#88475 RowSetBase: reposition cache before interrogating itLionel Elie Mamane
This partially reverts: commit d20232a77565f46fedc0b556f4d50addff4d3559 Author: Lionel Elie Mamane <lionel@mamane.lu> Date: Thu Dec 6 13:22:06 2012 +0100 Don't force refresh when higher up code did not request it Change-Id: I0f415c96fc05c1d776d14885751aef020c42f4ae which did not take into account that the cache is shared with the clones. This is not a cherry-pick from master, but a more conservative version of commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f. Change-Id: I1fa5c3169806760d35dd07e1fc1b8d5522dd3641 Reviewed-on: https://gerrit.libreoffice.org/14102 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Resolves: fdo#87840 by default hide all feature checkboxesCaolán McNamara
and explicitly show the supported ones Change-Id: I93d998472a82085da9bd5a8ec7ad4cb39998e198 (cherry picked from commit fef5c2b81d1ac7d64e01521da792f470b03a1841) Reviewed-on: https://gerrit.libreoffice.org/13788 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-05Related fdo#87840: mix between ignorecurrency and inputchecksJulien Nabet
Cherry-picked from 0f9ce69b327ee14f028c26e6af275779b8047def Change-Id: I38501b371b8c63ab2e6fb019e17416e139120908 Reviewed-on: https://gerrit.libreoffice.org/13710 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-12-15dbaccess: the PythonTest requires Java for hsqldbMichael Stahl
Change-Id: Idaea12aae68ad21ee06f785167cdf1867101ec4b (cherry picked from commit 6d8ab70f1da785767e539383087258bd666fbf62)
2014-12-02fdo#86852 correctly recognise NULL values in query parameter values dialogLionel Elie Mamane
Change-Id: I3c0cf976e0a9fbafe6eee768799a2f48c2ee0ea9 Reviewed-on: https://gerrit.libreoffice.org/13251 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-12-02Correct error message: the name is the parameter's, not the column'sLionel Elie Mamane
Change-Id: Ia26fb2dcd443f5c5b5cc48dff209d022388c7519 Reviewed-on: https://gerrit.libreoffice.org/13250 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-12-02Don't accept invalid value just because user insistsLionel Elie Mamane
Change-Id: I0693f0e00226148faff2038cea320a506aabaea9 Reviewed-on: https://gerrit.libreoffice.org/13249 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-26Add missing space in translatable stringAdolfo Jayme Barrientos
Change-Id: I88dabd5612069a7de3cad188344cc5c33ba22a7e Reviewed-on: https://gerrit.libreoffice.org/13127 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> (cherry picked from commit 9303192c4f1ff623f20ef4501723c003678140de) Reviewed-on: https://gerrit.libreoffice.org/13139
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I331c96a09be7a4971c3cc3c577f8f9d91333d175
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10coverity#1242423 Dereference after null checkCaolán McNamara
Change-Id: If9c09fc56067610d36e3f8bd2a4e22ea743ddf5b
2014-11-10Resolves fdo#82500: Operators missing in Standard FilterJulien Nabet
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=be88126e80b1f6b9a3090ba4617d9a87dfb0a0bd Change-Id: I4f03fbf4e6e6a0f6a901cadb87494baa92d66895
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06loplugin:salboolNoel Grandin
Change-Id: Ib1cb796c53ace96002c3c99c84ce090a11fb1e84
2014-11-06WaE: VarDecl, use bool instead of sal_Bool [loplugin:salbool]Tor Lillqvist
Apparently the salbool plug-in warns if a sal_Bool is initialized in the C++ fashion. Change to the C fashion and no warning, huh? Change-Id: I0f4e33cb33ffb1e0d5571d3757a6bb3bc9c44a64
2014-11-05coverity#706401 Uncaught exceptionCaolán McNamara
Change-Id: Iacbaf56a23d6f1878c5a5ec6f00db8211cb8ed62
2014-11-05coverity#706388 Uncaught exceptionCaolán McNamara
Change-Id: I4382645e47ae81e3f15bf69aaa2432dcebd40712
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04covertiy#705369: dbaccess: move XML_TOK_ENCODING to enum XMLDataSourceInfoMichael Stahl
Looks like Commit 94e8385d56098b6a51c539b5374dbf03151d2559 added this to the wrong enum. Change-Id: I46dd82313aaa659e84c719ba9215682becf8ec6c
2014-11-03I think this should be Left()David Tardon
Change-Id: I603215180e86ca28b94b129378ec48b7658e37b5
2014-11-03I think this should be Left()David Tardon
Change-Id: Ifd83a4a28414ffa5d8cc3cec3def4361737a333e
2014-11-03coverity#1242510 arguments in wrong orderDavid Tardon
Change-Id: I898f3e383f5ff3451860e49b0ea00111ed1b52c2
2014-11-03callcatcher: update unused codeCaolán McNamara
Change-Id: Ida4221bfbfe30f7e1abd5c367d8cb8b9edd310bb
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-28coverity#706465 Uncaught exceptionCaolán McNamara
Change-Id: Ic328c8a68fac462c402b70f85093cd8b14d2882d
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83