summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2019-08-17loplugin:unusedmethodsNoel Grandin
Change-Id: I781a514787c83063dadd549ee043bbb264eee060 Reviewed-on: https://gerrit.libreoffice.org/77619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-17move RoadmapWizard to vclCaolán McNamara
Change-Id: Iae2f5e0ac52dcf862035508db3a22cfd86d02d8f Reviewed-on: https://gerrit.libreoffice.org/76903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-17tdf#125340 transport preferred dialog parent down the migration dialogCaolán McNamara
Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3 Reviewed-on: https://gerrit.libreoffice.org/77606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-17Use simplified syntax for SequenceJulien Nabet
Change-Id: I92ac60fafcc404439c101d1950ed214fce140c91 Reviewed-on: https://gerrit.libreoffice.org/77621 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16move WizardMachine to vclCaolán McNamara
Change-Id: I55cc4a6c1ad111a22a43fd66a3cd01b5b02fb7cb Reviewed-on: https://gerrit.libreoffice.org/76902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-16Fix typosAndrea Gelmini
Change-Id: I207333e9bafc5d6c38ffa53a303046e437b7a815 Reviewed-on: https://gerrit.libreoffice.org/77607 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet
in dbaccess Change-Id: I7f91b5fd8ac1dfbf6244c408391a595f5250aa71 Reviewed-on: https://gerrit.libreoffice.org/77563 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16tdf#126940: export ansicpg in RTF when copying databaseMike Kaganski
This allows correctly detect encoding of 8-bit characters on paste Change-Id: I586fd2ec140848e9097927818c492ab2fc7cf8ea Reviewed-on: https://gerrit.libreoffice.org/77545 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-15loplugin:sequenceloop dbaccess..extensionsNoel Grandin
Change-Id: I0eb33a8e293eb8afd0cf5a933384c44e023a2e6b Reviewed-on: https://gerrit.libreoffice.org/77498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-13warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77131 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07move WizardDialog to vclCaolán McNamara
Change-Id: I93d03601cb429687a9a73b7d28c595e69977bf87 Reviewed-on: https://gerrit.libreoffice.org/76901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07tdf#126579 contextmenu query: create as view missingandreas kainz
Change-Id: I5a078f94307fd1b432dffe411e2d8651acf063a7 Reviewed-on: https://gerrit.libreoffice.org/76984 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-08-03some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Idb652586ff659874750779d30cb2b38b3df8892e Reviewed-on: https://gerrit.libreoffice.org/76893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OGeneralPageDialogCaolán McNamara
Change-Id: I1a5342f9f009234b2c8b1231155a11c9283c4ec8 Reviewed-on: https://gerrit.libreoffice.org/76856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02dispose MySQLNativePageCaolán McNamara
Change-Id: I2506d08b8c2e5b501bccb8b5ef2e6d829a912852 Reviewed-on: https://gerrit.libreoffice.org/76854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02remove newly unused OGenericAdministrationPage ctorCaolán McNamara
Change-Id: Ibb1353e5b14648253cb455664693271fd4482c51 Reviewed-on: https://gerrit.libreoffice.org/76850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop some newly unused functionsCaolán McNamara
Change-Id: I2ee32a9fdac6ff85927a5755ce341a591a462544 Reviewed-on: https://gerrit.libreoffice.org/76849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02void* -> weld::Widget*Caolán McNamara
Change-Id: I1341fa27fd184ff1302b867aea6c215c22fb477d Reviewed-on: https://gerrit.libreoffice.org/76847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02rename DBMySQLNativeSettings back to MySQLNativeSettingsCaolán McNamara
Change-Id: I00d6de729a1d650d479663b6e1d05f8087e7fe9a Reviewed-on: https://gerrit.libreoffice.org/76846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused MySQLNativeSettingsCaolán McNamara
Change-Id: I11801ea43d69b3f79d8fba1305d4d9c8c199d29b Reviewed-on: https://gerrit.libreoffice.org/76845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld MySQLNativeSetupPageCaolán McNamara
Change-Id: Ie27649de602241936378f1e937100718d0c95d5e Reviewed-on: https://gerrit.libreoffice.org/76844 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused LayoutHelperCaolán McNamara
Change-Id: I602c9a3f9df79ad8c268c6902adac9046abd34ea Reviewed-on: https://gerrit.libreoffice.org/76841 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OLDAPConnectionPageSetupCaolán McNamara
Change-Id: Id1b5becb2e9978cf4713a35d4f89125658d3de17 Reviewed-on: https://gerrit.libreoffice.org/76840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OGeneralSpecialJDBCConnectionPageSetupCaolán McNamara
Change-Id: Ie4c2a34127a79d290105f0f032b4edf22d5871cd Reviewed-on: https://gerrit.libreoffice.org/76838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OAuthentificationPageSetupCaolán McNamara
Change-Id: Ib5de669f22abeaae3716918702066ce608910874 Reviewed-on: https://gerrit.libreoffice.org/76830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OMySQLIntroPageSetupCaolán McNamara
Change-Id: I8378860bfc5cb087b5c04a73e99965afdee4c23f Reviewed-on: https://gerrit.libreoffice.org/76822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Ie5e66723ad497f927bc26bbe01c8194712455caf Reviewed-on: https://gerrit.libreoffice.org/76821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OFinalDBPageSetupCaolán McNamara
Change-Id: Ie05e086c393ef6572c92e7c4975b1c9dd9e3ad48 Reviewed-on: https://gerrit.libreoffice.org/76818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OGeneralPage and OGeneralPageWizardCaolán McNamara
Change-Id: I7caa08a5e060371c9b80ff83b141c27af09246bf Reviewed-on: https://gerrit.libreoffice.org/76817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31crash on missing reset buttonCaolán McNamara
in database user admin dialog Change-Id: Icbacf37d23994ddb81fa0aa3f67468aeaf1d71f2 Reviewed-on: https://gerrit.libreoffice.org/76767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): dbaccessStephan Bergmann
Change-Id: I85262c1f8d875fc8556773eab8636738340068c1 Reviewed-on: https://gerrit.libreoffice.org/76686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#121599, tdf#123099: ignore migration dialog whenXisco Fauli
1. a new HSQLDB database is created 2. the HSQLDB database is not opened interactively Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b Reviewed-on: https://gerrit.libreoffice.org/75643 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-24"Basic macros" instead of "$Productname Basic macros"Samuel Mehrbrodt
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros". Remove that confusion by using just "Basic macro" in the UI. Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596 Reviewed-on: https://gerrit.libreoffice.org/76216 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19loplugin:referencecasting in dbaccessNoel Grandin
Change-Id: If44176f85f460afca92cfa77b3cc1f7107a41690 Reviewed-on: https://gerrit.libreoffice.org/75938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19tdf#42949 Fix IWYU warnings in include/dbaccessGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie537e44054c0d1735f42e74385cc1bd8c8000c16 Reviewed-on: https://gerrit.libreoffice.org/75180 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-18cid#703937 Unchecked return valueCaolán McNamara
Change-Id: I38be419c6ed4857c52ac555696a614008aaad907 Reviewed-on: https://gerrit.libreoffice.org/75835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448482 silence Using invalid iteratorCaolán McNamara
Change-Id: I78c5fa16e035cebe71869bfea57ef2741b5b7f58 Reviewed-on: https://gerrit.libreoffice.org/75829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#123020 dbahsql: Support string delimiterTamas Bunth
Support multi-word table names while migrating HSQLDB data. Change-Id: I5129f995ea90a3fdbcbcb844774cf074f3ffddb2 Reviewed-on: https://gerrit.libreoffice.org/75734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-13dbaccess: use local variable aBytesXisco Fauli
Change-Id: Idffdb1cf7edf2c6cd39c1c417158069fed5445fa Reviewed-on: https://gerrit.libreoffice.org/75528 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-12tdf#126268: Add support for negative decimalXisco Fauli
basically reintroduce the code deleted in 2e26ef34bf1a2e5d1293e45cf3b1415d9514b056 and check at the right place the sign values Change-Id: Idf613a3a087b428d1f85abe9b43342fb67538a63 Reviewed-on: https://gerrit.libreoffice.org/75488 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-11tdf#126268: first byte is not used for the sign symbolXisco Fauli
This code is just broken, negative numbers and positive numbers above 25 are incorrectly migrated if using decimal. E.g: -1 -> 24,6 26 -> -6527'6 thus, delete it and pass the 8 bytes as they are to lcl_double_dabble. Note: this only fixes the positive numbers, -1 still returns 24,6 Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09 Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650 Reviewed-on: https://gerrit.libreoffice.org/75375 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24move SvtIconChoiceCtrl to vclCaolán McNamara
Change-Id: I5ed8af625cb46998649c4f11255d7676a11bdc94 Reviewed-on: https://gerrit.libreoffice.org/74605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Resolves: tdf#125168 label mnemonic appearing in database urlCaolán McNamara
Change-Id: I39531ae2a656c16c7355d73b76cb918d3535f7b0 Reviewed-on: https://gerrit.libreoffice.org/74602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23tdf#39593 Remove dbaccess::OContentHelper::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I533bfcd3959037a2621eb3fd42bf7172b5396c5f Reviewed-on: https://gerrit.libreoffice.org/74539 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-15Removed duplicated includeAndrea Gelmini
Change-Id: I9054caf8ae1ed5833399de1f749c82ac367b5dd9 Reviewed-on: https://gerrit.libreoffice.org/74106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15loplugin:logexceptionnicely in dbaccessNoel Grandin
Change-Id: I2d702b699c2e61dbb363eff671bb43d4ddbf8ee3 Reviewed-on: https://gerrit.libreoffice.org/74045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>