summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2020-10-08we only should have one has_default==True in these dialogsCaolán McNamara
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. where the code does no special show/hide of buttons Change-Id: Iacc37e5250468f2b626c3212c30bdd254966fdb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104067 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Revert "lint-ui: check that we only have one has_default==True"Noel Grandin
This reverts commit c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. Reason for revert: Some of the code manipulates visibility programmatically, and it is quite fine to has more than one has_default if only one of them is visible at a time. Change-Id: Ia4f565c7d21d232d3038c3489952782c8e2a7be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103977 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-05lint-ui: check that we only have one has_default==TrueNoel
Change-Id: Ic61e14c3b98a85a5f05b448db9805ac296c041ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel
Change-Id: Id83c478af5d04ad548c7cf4239fe2fb3ee154dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel
Change-Id: I8b5cde993c13e0b7c8c830b1ff698933a6b7cfd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02loplugin:reducevarscope in dbaccessNoel
Change-Id: I22163b3303ae0c2326d079a18fa8906f38aa1d4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-01Use the new single-instance="true" attribute in dbaccessStephan Bergmann
Change-Id: Idd42ae243859ee0a0798568f71460c93981c636f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103736 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-28Related: tdf#137016 check if subcontrol has the focusCaolán McNamara
Change-Id: I632188bc0512c9d8935bd0898c96e066881ebeb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22OUStringLiteral/OStringLiteral coverity PARSE_ERROR workaroundCaolán McNamara
do more like commit 121771e37f7e2de41cd5643475861062bf25627b Date: Mon Sep 21 09:17:54 2020 +0200 Make some OUStringLiteral vars constexpr cause coverity can live with that Change-Id: I9efd7f848289c4865997a44c6780373068422227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-21update pchesCaolán McNamara
Change-Id: I41a204fbc5e2c9b819fb948c5288f8d7b4195489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ibb705ac92365b7f71e8e5561bd150142a65a50ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101807 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/uiGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I7508acd84f2264ba807951d9b933b1ee76560c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102552 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/coreGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I44efd0f0536df127be57fafc193eeb985292cc22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102550 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/filterGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Idd45e204ae80a33784e896c70d104aa1b22513ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102551 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-10remove image_position top from GtkButtonandreas kainz
Change-Id: Ib7a8eb77b31a8abb08be501b1e0ce8d480f163c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102340 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-06treelist hidden in data browserCaolán McNamara
Change-Id: I1f01f4f57d9e711ead86d9d7abf9ef9c7f630fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-05Drop some seemingly redundant OUString(OUString::getStr()) constructionStephan Bergmann
...assuming it was not chosen deliberately to cut of the input string at a potential embedded NUL (or for whatever other arcane reason). (This change is a prerequisite for making the OUString ctor taking a raw pointer explicit.) Change-Id: I74411e590cedc4394a240435a837a406dc18cfb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102079 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-04TabPage no longer needs to inherit from VclBuilderContainerCaolán McNamara
Change-Id: Iaab26ade1109daf732e58a2f3741cc43243e374c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102023 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-04tdf#136442 a null return from GetEntryPosByName is allowedCaolán McNamara
Change-Id: Id3e5255f1551eaa3e2f2bbd314634bdf921bffac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02Do layout immediately in resizeCaolán McNamara
the wait for the idle is too long, keep idle for re-layout when the container size doesnt change but the contents do Change-Id: I6ed4806e96d10937e825192de86a3d602acf1689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02drop some unused forward declsCaolán McNamara
Change-Id: Id8c3e726e0542dc9bdc36490aa10dde075617630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02drop some unused methodsCaolán McNamara
Change-Id: I4da391591d30db9e51c1dd543bcf128f2e8621c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101914 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02move Edit into toolkit only headersCaolán McNamara
Change-Id: If51bf7143116721e8f16272cf8aff797651d5ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typoAndrea Gelmini
Change-Id: I03dc9ad3ad496524efbbb2f1a48f76fb95d1bfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I3482e32e3ce4a7ebfa04f9d54e2ab23c164f50c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101808 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8be2457de5018e1e764e378e609c3a41c3cb9d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101802 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01FIx typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I055db4ca15e2e8c4c66d5970404c292255c15628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Idf44d88678de415e38ddb542c198c0eac642aaae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101785 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-30use more fastparser in SvXMLStyleContext subclassesNoel Grandin
Change-Id: I6a1596bdbfa4db128730a663fc590c9e5bfa249d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ie6f03d64818ca88ada6e929dc061be851451a75c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-28move FixedLine into .uiCaolán McNamara
Change-Id: Ibc22de48f1ef92d8efbe0167aff3a434ecef9afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101503 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28weld OTableBorderWindowCaolán McNamara
Change-Id: I8008d9ea1e1c5418c960ec9c80b55602a11f15f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28tab should be just used to move focusCaolán McNamara
Change-Id: I3f079a3bfcabd82015a0da6ddd5c4ac2a51a9b93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28drop newly unused VertSplitViewCaolán McNamara
Change-Id: Ib70905dd22ddd7a5f529501be10bdbfb9164a65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-27remove some unused includes and update pchesCaolán McNamara
Change-Id: I786548bef39fa711aabcff32b592b3fdc4a6f9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27weld dbu ui clusterCaolán McNamara
making the dbaccess a wholely welded hierarchy Change-Id: I87ea94d7775e38c8eb3342d91a730457481407f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27use monoborder widget css name as a WindowBorderStyle::MONO replacementCaolán McNamara
Change-Id: I563f917c741130909a9d726754cd3eb23a651a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26shouldn't be able to tab into scrolled preview windowCaolán McNamara
Change-Id: I0d4f1cdd75411687328b576b032f9b70bf17086d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101413 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26add focus rect to icon controlCaolán McNamara
Change-Id: I080dfb40db20626f99f93beab1baf2102d6695ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26weld OApplicationSwapWindowCaolán McNamara
Change-Id: I71d24494b5fe7dd2949876944ab9aff41330ad50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26use fastparser in OTableStyleContextNoel Grandin
Change-Id: Ied05d161811c3b87d00cd99c56940a9f66cb4e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25use more fastparser in OReportStylesContextNoel Grandin
Change-Id: Ie8126206d9144ccba1fb120d47af9ebe35a345d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-24restore translatable="no"Caolán McNamara
Change-Id: I42b46c0cada25703e8e9600533a220252796457e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-27 23:26:49 +0000