summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2014-06-13Fix memory leakStephan Bergmann
Change-Id: Idc75fd0735452ffdf6a21e3597cd3fe74f651581
2014-06-12coverity#982455 Dereference after null checkCaolán McNamara
Change-Id: If4ad2fe763bffdb64119f7f2a5797aae588fbbf8
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10tweak things to allow switching between small and large toolbar iconsCaolán McNamara
Change-Id: Ife4da4c6f4acc3b3f9fde18cdfc09635cf9b6776
2014-06-10DLG_INDEXDESIGN conversion to .uisk94
Change-Id: I84d6531a73e6e726359bd20664b6299ad8a390ee Reviewed-on: https://gerrit.libreoffice.org/9699 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-09Translated German comments dbaccess/source/ui clean nowLuc Castermans
Change-Id: Ida2d2dbe95f290e2f32ed2259b8f9bdb27cbf2f9 Reviewed-on: https://gerrit.libreoffice.org/9689 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09fdo#79786 implement getFormOperations for data grid (table view)Lionel Elie Mamane
Change-Id: I704057b25ca11633ba62fbb834bd2e6095f348f3 Reviewed-on: https://gerrit.libreoffice.org/9685 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-05coverity#1103693 Missing break in switch, assuming its intentionalCaolán McNamara
Change-Id: Ie61305f367e2a07a61599433bd83e1ea13bffd71
2014-06-05coverity#705147 Missing break in switch, assuming its intentionalCaolán McNamara
Change-Id: I9041f18eb4aae73b795245c589b28a3d02d8397e
2014-06-05coverity#705146 Missing break in switch, assuming its intentionalCaolán McNamara
Change-Id: I09a2cacc3aa18796c06a1f1cc9315b3628865621
2014-06-05dbaccess: remove SAL_THROW macroNoel Grandin
Change-Id: I01e43d6171dc2381ff8c151d5716e9ffede24822
2014-06-04update_pch: add a bunch of pch filesThomas Arnhold
connectivity: 3m52s -> 2m47s cppcanvas: 28s -> 13s cppuhelper: 20s -> 14s dbaccess: 2m38s -> 2m01s hwpfilter: 16s -> 13s sot: 21s -> 16s Change-Id: I49286bfe6be73dd1b861be632b95e17a99e82f8a
2014-06-04coverity#1000657 Missing break in switchCaolán McNamara
Change-Id: I03acdc2769e893fc7ecb2885302951852804867b
2014-06-04loplugin:literaltoboolconversionStephan Bergmann
Change-Id: Ie871fa9378bbb34eacd3205f9485a6f89f833674
2014-06-04fix index dialog regressionCaolán McNamara
thanks to sk94 for noticing this when trying to convert this to .ui Change-Id: If7130d53acb7c194cf0a9a4301f3573789888b86
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04WaE: warning C4101: 'e' : unreferenced local variableThomas Arnhold
Change-Id: Ib5aa5f401eabedfdaebea1dea8f48f284dbccdd5
2014-06-03coverity#1219794 Uncaught exceptionCaolán McNamara
Change-Id: Icc9e5faf9ef15840c359b7766112278094d52dea
2014-06-03coverity#1219801 Uncaught exceptionCaolán McNamara
Change-Id: I372c1891e41510c24daf256d00f3ca98e8a374a9
2014-05-31fdo#73352 don't crash if clearWarnings throws an SQLExceptionLionel Elie Mamane
Change-Id: If67bda43589834e4c922056145bc60884728cb8a Reviewed-on: https://gerrit.libreoffice.org/9591 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-30coverity#706394 Uncaught exceptionCaolán McNamara
and hopefully a bunch more of those in dbaccess Change-Id: I5aefcfe56a697f9e6b18dfe167fdd8a4f54ab6e0
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-28Prefer cppu::UnoType<T>::get() to ::getCppuType(&T)Julien Nabet
See http://nabble.documentfoundation.org/Questions-about-getCppuType-td4106361i20.html Change-Id: I05d0b026e1ef2088472a42ee20e0823df1588428
2014-05-27coverity#1213514 Uncaught exceptionCaolán McNamara
Change-Id: I475b8c9bdcea120ac7ba24862000a16d9f4127c0
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-24cppcheck: unreadVariableThomas Arnhold
Change-Id: Iedb0eaa740943964b9f6242f7908099a92077413
2014-05-24coverity#1000843 Uncaught exceptionCaolán McNamara
Change-Id: Iad3368c1345b0c9674c069ff7981d3c40f7f7139
2014-05-24coverity#1000844 Uncaught exceptionCaolán McNamara
Change-Id: I2e322d4861da05e04dfe19fa15f9bc281e1ef0d8
2014-05-24coverity#1000845 Uncaught exceptionCaolán McNamara
Change-Id: I968baef18f9a14301d69a5eaad07ceb8b9633062
2014-05-24coverity#1000846 Uncaught exceptionCaolán McNamara
Change-Id: I4e92ad97e7b3567c028d63ac0936fa9cdef12e24
2014-05-23coverity#1215312 Uncaught exceptionCaolán McNamara
Change-Id: I844561cc6f858b6aed55caaf0d92529486cb486e
2014-05-22FixJulien Nabet
Change-Id: Ib4d7c2da71a6fa083fc1ed56f058c8dfbc6e58fb
2014-05-22Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22cppcheck: The scope of the variable 'fOutNumber' can be reducedThomas Arnhold
Change-Id: Ifece039a99f9796d3d41fdf9fae128ad2c2f7c44
2014-05-22cppcheck: Variable 'fOutNumber' is assigned a value that is never usedThomas Arnhold
Change-Id: Idb5e4ae3266ab714c392abca76993c3037fea7b2
2014-05-21fix spellingNoel Grandin
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-20fdo#78971 There's even a git hook to prevent commits containing SAL_DEBUGStephan Bergmann
Change-Id: I5a46e1eed129edf3648c68c36951d6fdf9bd370d
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-19WaE: -Wunused-variableThomas Arnhold
Change-Id: Iece721dea1c8cc7601352849ca4fc0398375d320
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-18hrc files should have hrc suffixThomas Arnhold
Change-Id: Iadbedc145c85c5f333e4449704fd01d5e12ddde5
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17Comment why it's not a copy paste errorJulien Nabet
See http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-td4109071.html Thank you Lionel! Change-Id: I999bad0d6de0327bea7ba04a6c61a497d45f53a0
2014-05-15Minor utl::TempFile clean upStephan Bergmann
Change-Id: I20de8b2321d2656d17d25c6343d72c534d47e597
2014-05-14dbaccess: remove SAL_INFO's that only make function entryNoel Grandin
Change-Id: Ibdf92698446d0a7aed7c474ec7d3ea720cd2c2a6
2014-05-13Typo: shoud -> shouldJulien Nabet
Change-Id: I44f4fb9682a56af6654e1f7462dc37557d60e735