summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2024-07-11cid#1607892 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607910 COPY_INSTEAD_OF_MOVE cid#1607818 COPY_INSTEAD_OF_MOVE cid#1557402 COPY_INSTEAD_OF_MOVE cid#1556530 COPY_INSTEAD_OF_MOVE cid#1557396 COPY_INSTEAD_OF_MOVE cid#1556522 COPY_INSTEAD_OF_MOVE cid#1555628 COPY_INSTEAD_OF_MOVE cid#1554705 COPY_INSTEAD_OF_MOVE Change-Id: Iae3fbf4a04bf3714f416995640b9d70fe204cf73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-09Simplify comphelper::query_aggregationMike Kaganski
Change-Id: Id673c27e21c6706367f2effc92bbea61c83a5482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170133 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-08sd: function to return a presentation info in a JSON documentMarco Cecchetti
The presentation info includes properties like document size, if the slide is visible, master slide information and similar. [ Miklos: don't refer to removed tools::ScopedJsonWriterArray. ] Change-Id: I5b0acff2ee0df351dd1859e02695ca249e17c391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170155 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-08cid#1557639 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I02c8486503a54d1ddcdf80f9d7c7ee6389e4e05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170104 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-08cid#1556887 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I7e93494191e11c82af9e66ddd467a73f6bc60490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07dbaccess complex/DataSource.java to extras/dataSource.cxxAdam Seskunas
Port the Junit test in DataSource.java over to CppUnit. In order to port the test as written in Java the CRM Database was ported, so add a test for that here as well. Change-Id: Ib9ac369e3faaa30207b83368889763f0eb063876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169071 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-06DBTestBase: call close at tearDownXisco Fauli
Otherwise, calling different tests one after the other will fail with warn:vcl:994718:994718:vcl/source/app/svmain.cxx:497: DeInitVCL: some top Windows are still alive text = "lu9947181i0ytl.tmp — LibreOfficeDev Base" type = "10WorkWindow", ptr = 0x555b3ab76810 Change-Id: I6124b768e165ed841738d29c6071e7950b58229f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170058 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-05CppunitTest_dbaccess_embeddeddb_performancetest: fix dependenciesXisco Fauli
Otherwise it fails with EmbeddedDBPerformanceTest::testPerformance finished in: 426ms macros_test.cxx:74:Assertion Test name: EmbeddedDBPerformanceTest::testPerformance assertion failed - Expression: xComponent.is() After this patch, the tests still fail, but for another reason. Change-Id: I4fc11a9feef79efd71be8d6bab76f8777c92d115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170012 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-07-04fix --disable-firebird-sdbc buildNoel Grandin
Change-Id: I92e4f1b834b9afe806c29f45af94a562fcb3d78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-04cid#1608601 silence Unchecked return valueCaolán McNamara
Change-Id: Iab18edb8ddb0860b337c0caf5c1fcf661521541f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169982 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-02Port CRMDatabase from Java to C++Adam Seskunas
--Port createTables and createQueries --Add a general test for the CRMDatabase --Edit Make file Change-Id: Ifbbb9010c8d8b8a4a199af73539b1f6a9ec45a0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169573 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-29Fix "lets" -> "let's"Andrea Gelmini
Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-06-26Resave with newer Glade versionBogdan Buzea
Change-Id: I79863a21c54986c24ba437f4ce3c0d9ce7f8708c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169394 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-26Resave with newer Glade versionBogdan Buzea
Change-Id: I143d715d8b5b8630f5153af525b83521555cabb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169378 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-25Resave with newer Glade versionBogdan Buzea
Change-Id: I5e97ebd5cb357673d7bfda563e83c2e75934b88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169391 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Add newline at end of fileTaichi Haradaguchi
Change-Id: I731d8d80e075c8df8a104ec963b89337a91d536c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169376 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: Ieaa8a90ddef6a49a3dfbb59575bf8defebeaa854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169382 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: I86065d81a449360f09268fe617f8f09e7a917411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169385 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: I56f5bbeed4850a742403ffd7dd43fca25101ad17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169380 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: I011489b4d87a078af6083001d076f71140b98a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169401 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-21tdf#158237 Use C++20 contains() instead of find() and end()Zainab Abbasi
Change-Id: I9ebe5e8c966a21b99a5229a4418738e4178716a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169312 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-06-20DBTestBase: Add createDBDocumentXisco Fauli
it can be used later on when porting the java tests to CppUnittest Change-Id: I17420fdf490d979392f5aeb90c3b3bfb319d7764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169274 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-06-20CppunitTest_dbaccess_embeddeddb_performancetest: use maTempFileXisco Fauli
Change-Id: Ib63008ddaf9aeb0ed02dd5cbc9680eda2cefbfac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169269 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-20loplugin:unusedfieldsNoel Grandin
Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I84a64e6a2e90d462ed7eb5fe4adeb3c6966c91c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169215 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19Fix typoAndrea Gelmini
Change-Id: I339f7b48db82d52faea5343412554c4c4939068e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169181 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-18loplugin:ostr in variousNoel Grandin
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-18Add SfxItemType to SfxPoolItemOliver Specht
The SfxPoolItem has a new member SfxItemType m_eItemType to compare types based on enums instead of typeinfo() which consumes a lot of time e.g. while AutoFormat is running Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-06-11CppunitTest_dbaccess_macros_test: remove redundant testXisco Fauli
This was added in 0f4451c0b3bda3d14c7672ca670b4de959495365 "first part of a c++ based test for base" as an example on how to test base documents. At this point we already have other base tests doing more interesting stuff so I believe this test is not needed anymore Change-Id: Ice747800f3ab6d887d63595fe9dbdd531acf9014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168684 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-11dbaccess: use createTempCopy instead of doing it in makeXisco Fauli
Change-Id: Ib1e550dbe5ea74827562e3706c4a310171df77af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168675 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-17WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I4bb077ea634d9ca3e238981cfcc307a1b6caf7c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-16Drop unneeded 'using' instancesGabor Kelemen
found with bin/find-unused-using.sh Change-Id: I647f493ee313e79e7a9967960ea089b729de59a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167637 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-12cid#1597307 silence Unchecked return valueCaolán McNamara
and cid#1597304 Unchecked return value cid#1597303 Unchecked return value cid#1597306 Unchecked return value cid#1597305 Unchecked return value Change-Id: I2fa1c467751405d3b69f1d9b552232e4d52b610e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in OpenDocumentButtonNoel Grandin
Change-Id: I989f5f82fe65e0f877d86b7eb98ba8ad57147988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in SbaTableQueryBrowserNoel Grandin
Change-Id: Ic822faea02d1d598e7b5deb846a88ae59994535d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ReadThroughComponentNoel Grandin
Change-Id: Ic92b15ea369e420faf6bfc40f509bba6e454710f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in SubComponentManagerNoel Grandin
Change-Id: I165b93ff8986f288b03fb001e8ceda12b5076872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167502 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ResourceManagerNoel Grandin
Change-Id: Iea6430d5f56a1f30a5dd168fcf2fee2ba7198f18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167499 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in DBContentLoaderNoel Grandin
Change-Id: Iaa1169be4ab9db824af4406dd18e6c36326bdcd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in OApplicationDetailViewNoel Grandin
Change-Id: Icb7961ad247711e6a3b4761e7d6922ba7e4848a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167501 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ODsnTypeCollectionNoel Grandin
Change-Id: I943e784bf3becd48e617b814b008f1f946987d28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167498 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ODatabaseModelImplNoel Grandin
Change-Id: I861bf52bb49a54ec546a4465fb9053a5ebdaa641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in DocumentEventsNoel Grandin
Change-Id: I5cf5401afafc1c6d2d72445e898903c95288531b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167494 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ODatabaseDocumentNoel Grandin
Change-Id: I57f1de3781ee413ad987222b8b960a266ef21e5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167492 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-10replace createFromAscii with OUString literals in DocumentEventNotifierNoel Grandin
Change-Id: I6987033a461ec91b59de8e2aabef513471f887f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167493 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-10cid#1597273 Unchecked return valueCaolán McNamara
Change-Id: Ia48abe54185c23f740b1385ca2bfd45950209f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-09workaround segfault in compiler on macos-clang-intelNoel Grandin
Change-Id: I291599cd35d3f8be44949a57514bab5ac9f1a7e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-08WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ia64d863baa72a2d32a8bee40968af4f6aacd88bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167332 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-08return early on empty ORelationTableConnectionData*Caolán McNamara
we test for pData existing, but it it doesn't then we continue and will typically dereference it, so test looks inverted Change-Id: Iddcab25d5620942bb617bd1e9985322f5e497839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167331 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins