summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in dbaccessNoel Grandin
Change-Id: Ice52ebbfeca45c8587fdcd0d3dea5c02c7de27e3
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I15609fb6b11606d865d8817f4a63ba8816f7384e
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I443d7d82de72841b1ac1f2ed026c647e3f1957fc
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I5e6938385ce870579982f21ad824081f4cc1ef60
2016-04-12clang-tidy performance-unnecessary-value-param in dbaccessNoel Grandin
Change-Id: I9cec61867b4e6e8abde7749047974c6de87b9669
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#49554 Fix misleading error messageMuhammet Kara
Fix misleading error message about primary key on first page of table import wizard, and give additional info about the process by adding an info label. Change-Id: I7c511abc512b7ab87321c055057bae4f42e29af1 Reviewed-on: https://gerrit.libreoffice.org/23969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-04-11cppcheck: silence warnings assertWithSideEffectJochen Nitschke
Mark some class methods as pure. warnings look like this: > dbaccess/source/core/api/RowSetBase.cxx > 593 assertWithSideEffect 398 warning Assert statement calls > a function which may have desired side effects: 'isAfterLast'. Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857 Reviewed-on: https://gerrit.libreoffice.org/23981 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-08tdf#94306 replace boost::noncopyable in d...Jochen Nitschke
dbaccess, desktop and drawinglayer. Replace with C++11 delete copy-constructur and copy-assignment. Nothing special, only one unused include in dbaccess/source/filter/xml/xmlfilter.cxx. Change-Id: Iebabbc658215162450d4caf08d4fb2f116c456d9 Reviewed-on: https://gerrit.libreoffice.org/23918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-08SfxTabDialog: rename members missing their prefixesMiklos Vajna
Change-Id: I6c739d4c64fb0b460e993f2a326a0acfec98b1c7 Reviewed-on: https://gerrit.libreoffice.org/23902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-05loplugin:constantparamNoel Grandin
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05tdf#99073 fix double-click tree node expansion in baseNoel Grandin
fallout from commit cf0c04a428754dfd5aa477cebc5441bc74e27005 "convert Link<> to typed" Change-Id: I3452b76320c5355aaf84a0bd67c99b281bb46d0f
2016-04-04loplugin:constantparam in sfx2Noel Grandin
Change-Id: I9a5a9fd1f4f43e0b7ef13d14979cb231f6aa9d46 Reviewed-on: https://gerrit.libreoffice.org/23801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04tdf#97361 Refactor dbaccess test againslideon
Remove duplicate code, add helper functions and constants Change-Id: Ib8702e2ce9918b47a608f6eb6fd2af7fd4dd1d0d Reviewed-on: https://gerrit.libreoffice.org/23727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01Remove erroneously added dbaccess/qa/unit/data/hsqldb_empty.odb.lckStephan Bergmann
...from 9e596250a6e968c5d1e2fb0de582ae242e02acf9 "tdf#97966 Drop static keywords" Change-Id: I04d3559bceb214743695e2a008c1a1383535a635
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: Icff7c0308843d6a7608be24d7fcf11fa079c7b72 Reviewed-on: https://gerrit.libreoffice.org/23672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-29Avoid reserved identifiersStephan Bergmann
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-28Use const_iterator when possible (whole dbaccess)Julien Nabet
Change-Id: I3d10a7914353b384fc7a2195a70398869f675211 Reviewed-on: https://gerrit.libreoffice.org/23570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-28Reduce scope in QueryDesignView.cxxJulien Nabet
Change-Id: Ia7f3ee29427dbe103560fe5d831eb40e771b3aba Reviewed-on: https://gerrit.libreoffice.org/23568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-28Use const_iterator when possibleJulien Nabet
Change-Id: I7454a8e5547da95b747eeb3b1d9dabe3a56a69f3 Reviewed-on: https://gerrit.libreoffice.org/23567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-23loplugin:constantparam in dbaccessNoel Grandin
Change-Id: I81c1385ec6881fe9b8f75b5506268f5e7b03e2cb
2016-03-21off-by-one error: columns are numbered from one, but the array from 0Lionel Elie Mamane
Change-Id: I14ef451999fa1f9d57757a9e231fc66be4e53f3a
2016-03-18convert SvButtonState to scoped enumNoel Grandin
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-18loplugin:constantparam in dbaccessNoel Grandin
Change-Id: Icfe7d3d4630f4b5b3b2491ba56245257bad31bb8 Reviewed-on: https://gerrit.libreoffice.org/23349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17Resolves: tdf#92617 don't crash if insertRow gets triggered during insertRowCaolán McNamara
insertRow notifies listeners that it is going to insert contents, if a script listens to that and eventually triggers insertRow again then one inside the other causes corruption and pestilence Change-Id: I6b568d0a67f6108536d58c407b79d02bf29f297a
2016-03-16loplugin:constantparam in xmloff/Noel Grandin
Change-Id: I376f1d4ac65de584f9caa6ba8e25e43216374112 Reviewed-on: https://gerrit.libreoffice.org/23295 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14tdf#95845 Use CommandInfoProvider to receive UNO command labelsSusobhan Ghosh
Added GetCommandPropertyFromModule to CommandInfoProvider. Removed GetCommandText. Change-Id: Ie987984b6465d540029196df371c0c0467999a59 Reviewed-on: https://gerrit.libreoffice.org/22918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-12tdf#97978: add support for opening mde and accde files in basepasqualm
This patch modifies the base 'open existing database' wizard so accde and mde files can be chosen as targets for access and access 2007 databases. Both file types are the runtime-only equivalents to accdb and mdb files so base can use them in the same way as does with the former Change-Id: I5b6002089a2d3c19498ff6e05bae3facc5a4e2d0 Reviewed-on: https://gerrit.libreoffice.org/22957 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-12Let's use the iterator return by erase method (final)Julien Nabet
Change-Id: I1934b0c2a9ae9fa089d7e9ded4a289908fb2709a Reviewed-on: https://gerrit.libreoffice.org/23173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack
Change-Id: I0d9837a7ccecd606e0d43b53f8b920547b0d0bcd Reviewed-on: https://gerrit.libreoffice.org/23132 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09fix debugging stl iterators assert in bibliography toolbarCaolán McNamara
bibliography: click autofilter toolbar icon to get drop down, select an entry and assert on use of invalid iterators. In this specific case we want to reset them all, so add a new simpler method to just do that and not do the (always supposed to be true) comparison note: in ORowSet::checkUpdateIterator at m_aCurrentRow = m_pCache->m_aInsertRow; these iterators are then invalid the whole iterator caching and fiddling here is concerning. Change-Id: I74952896f47ac482b6bacb26afe5b1cfcf6bc49c
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in dbaccessNoel Grandin
Change-Id: I44b5a586a1b0da47e032dff097ebf545f5fe76fc
2016-03-09Add missing includesDavid Ostrovsky
These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08loplugin:nullptrStephan Bergmann
Change-Id: I0c78ddab5efb7a295ccf42b6539b5aa3b7009bf9
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I either replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 statements or i used SAL_INFO(..)s Change-Id: Iefb6b83e86e1767e55600b6e1989ee91207fb220 Reviewed-on: https://gerrit.libreoffice.org/23000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-07drop now-needless depsDavid Tardon
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07remove remaining uses of gb_SrsTemplateTarget_get_targetDavid Tardon
Change-Id: I5ddf0ba5fc289a124b39b9c14b7f5fdd3d7b54a4
2016-03-07expand src templatesDavid Tardon
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
generated by cgit (git 2.34.1) at 2025-01-15 04:28:54 +0000