summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2019-08-07move WizardDialog to vclCaolán McNamara
Change-Id: I93d03601cb429687a9a73b7d28c595e69977bf87 Reviewed-on: https://gerrit.libreoffice.org/76901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07tdf#126579 contextmenu query: create as view missingandreas kainz
Change-Id: I5a078f94307fd1b432dffe411e2d8651acf063a7 Reviewed-on: https://gerrit.libreoffice.org/76984 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-08-03some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Idb652586ff659874750779d30cb2b38b3df8892e Reviewed-on: https://gerrit.libreoffice.org/76893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OGeneralPageDialogCaolán McNamara
Change-Id: I1a5342f9f009234b2c8b1231155a11c9283c4ec8 Reviewed-on: https://gerrit.libreoffice.org/76856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02dispose MySQLNativePageCaolán McNamara
Change-Id: I2506d08b8c2e5b501bccb8b5ef2e6d829a912852 Reviewed-on: https://gerrit.libreoffice.org/76854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02remove newly unused OGenericAdministrationPage ctorCaolán McNamara
Change-Id: Ibb1353e5b14648253cb455664693271fd4482c51 Reviewed-on: https://gerrit.libreoffice.org/76850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop some newly unused functionsCaolán McNamara
Change-Id: I2ee32a9fdac6ff85927a5755ce341a591a462544 Reviewed-on: https://gerrit.libreoffice.org/76849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02void* -> weld::Widget*Caolán McNamara
Change-Id: I1341fa27fd184ff1302b867aea6c215c22fb477d Reviewed-on: https://gerrit.libreoffice.org/76847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02rename DBMySQLNativeSettings back to MySQLNativeSettingsCaolán McNamara
Change-Id: I00d6de729a1d650d479663b6e1d05f8087e7fe9a Reviewed-on: https://gerrit.libreoffice.org/76846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused MySQLNativeSettingsCaolán McNamara
Change-Id: I11801ea43d69b3f79d8fba1305d4d9c8c199d29b Reviewed-on: https://gerrit.libreoffice.org/76845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld MySQLNativeSetupPageCaolán McNamara
Change-Id: Ie27649de602241936378f1e937100718d0c95d5e Reviewed-on: https://gerrit.libreoffice.org/76844 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused LayoutHelperCaolán McNamara
Change-Id: I602c9a3f9df79ad8c268c6902adac9046abd34ea Reviewed-on: https://gerrit.libreoffice.org/76841 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OLDAPConnectionPageSetupCaolán McNamara
Change-Id: Id1b5becb2e9978cf4713a35d4f89125658d3de17 Reviewed-on: https://gerrit.libreoffice.org/76840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OGeneralSpecialJDBCConnectionPageSetupCaolán McNamara
Change-Id: Ie4c2a34127a79d290105f0f032b4edf22d5871cd Reviewed-on: https://gerrit.libreoffice.org/76838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OAuthentificationPageSetupCaolán McNamara
Change-Id: Ib5de669f22abeaae3716918702066ce608910874 Reviewed-on: https://gerrit.libreoffice.org/76830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OMySQLIntroPageSetupCaolán McNamara
Change-Id: I8378860bfc5cb087b5c04a73e99965afdee4c23f Reviewed-on: https://gerrit.libreoffice.org/76822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Ie5e66723ad497f927bc26bbe01c8194712455caf Reviewed-on: https://gerrit.libreoffice.org/76821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OFinalDBPageSetupCaolán McNamara
Change-Id: Ie05e086c393ef6572c92e7c4975b1c9dd9e3ad48 Reviewed-on: https://gerrit.libreoffice.org/76818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OGeneralPage and OGeneralPageWizardCaolán McNamara
Change-Id: I7caa08a5e060371c9b80ff83b141c27af09246bf Reviewed-on: https://gerrit.libreoffice.org/76817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31crash on missing reset buttonCaolán McNamara
in database user admin dialog Change-Id: Icbacf37d23994ddb81fa0aa3f67468aeaf1d71f2 Reviewed-on: https://gerrit.libreoffice.org/76767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): dbaccessStephan Bergmann
Change-Id: I85262c1f8d875fc8556773eab8636738340068c1 Reviewed-on: https://gerrit.libreoffice.org/76686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#121599, tdf#123099: ignore migration dialog whenXisco Fauli
1. a new HSQLDB database is created 2. the HSQLDB database is not opened interactively Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b Reviewed-on: https://gerrit.libreoffice.org/75643 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-24"Basic macros" instead of "$Productname Basic macros"Samuel Mehrbrodt
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros". Remove that confusion by using just "Basic macro" in the UI. Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596 Reviewed-on: https://gerrit.libreoffice.org/76216 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19loplugin:referencecasting in dbaccessNoel Grandin
Change-Id: If44176f85f460afca92cfa77b3cc1f7107a41690 Reviewed-on: https://gerrit.libreoffice.org/75938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19tdf#42949 Fix IWYU warnings in include/dbaccessGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie537e44054c0d1735f42e74385cc1bd8c8000c16 Reviewed-on: https://gerrit.libreoffice.org/75180 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-18cid#703937 Unchecked return valueCaolán McNamara
Change-Id: I38be419c6ed4857c52ac555696a614008aaad907 Reviewed-on: https://gerrit.libreoffice.org/75835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448482 silence Using invalid iteratorCaolán McNamara
Change-Id: I78c5fa16e035cebe71869bfea57ef2741b5b7f58 Reviewed-on: https://gerrit.libreoffice.org/75829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#123020 dbahsql: Support string delimiterTamas Bunth
Support multi-word table names while migrating HSQLDB data. Change-Id: I5129f995ea90a3fdbcbcb844774cf074f3ffddb2 Reviewed-on: https://gerrit.libreoffice.org/75734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-13dbaccess: use local variable aBytesXisco Fauli
Change-Id: Idffdb1cf7edf2c6cd39c1c417158069fed5445fa Reviewed-on: https://gerrit.libreoffice.org/75528 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-12tdf#126268: Add support for negative decimalXisco Fauli
basically reintroduce the code deleted in 2e26ef34bf1a2e5d1293e45cf3b1415d9514b056 and check at the right place the sign values Change-Id: Idf613a3a087b428d1f85abe9b43342fb67538a63 Reviewed-on: https://gerrit.libreoffice.org/75488 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-11tdf#126268: first byte is not used for the sign symbolXisco Fauli
This code is just broken, negative numbers and positive numbers above 25 are incorrectly migrated if using decimal. E.g: -1 -> 24,6 26 -> -6527'6 thus, delete it and pass the 8 bytes as they are to lcl_double_dabble. Note: this only fixes the positive numbers, -1 still returns 24,6 Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09 Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650 Reviewed-on: https://gerrit.libreoffice.org/75375 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24move SvtIconChoiceCtrl to vclCaolán McNamara
Change-Id: I5ed8af625cb46998649c4f11255d7676a11bdc94 Reviewed-on: https://gerrit.libreoffice.org/74605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Resolves: tdf#125168 label mnemonic appearing in database urlCaolán McNamara
Change-Id: I39531ae2a656c16c7355d73b76cb918d3535f7b0 Reviewed-on: https://gerrit.libreoffice.org/74602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23tdf#39593 Remove dbaccess::OContentHelper::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I533bfcd3959037a2621eb3fd42bf7172b5396c5f Reviewed-on: https://gerrit.libreoffice.org/74539 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-15Removed duplicated includeAndrea Gelmini
Change-Id: I9054caf8ae1ed5833399de1f749c82ac367b5dd9 Reviewed-on: https://gerrit.libreoffice.org/74106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-15loplugin:logexceptionnicely in dbaccessNoel Grandin
Change-Id: I2d702b699c2e61dbb363eff671bb43d4ddbf8ee3 Reviewed-on: https://gerrit.libreoffice.org/74045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-13add link to hsqldb->firebird migration dialogCaolán McNamara
1. keep presenting the migration dialog 2. but, default to 'later' 3. add a link to a URL that someone will have to fill in Change-Id: I4c67fe0b65fd78e942ca0760c0f9e128e5ac7be6 Reviewed-on: https://gerrit.libreoffice.org/73610 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-12has_default needs can_defaultCaolán McNamara
Change-Id: Id841d214b8d88a986c07d2827b281e5805c3c941 Reviewed-on: https://gerrit.libreoffice.org/73810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-11Fix typoAndrea Gelmini
Change-Id: I47dc0bc0b94dd1ceb40efdae4b5e0e14ac920e81 Reviewed-on: https://gerrit.libreoffice.org/73789 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-09loplugin:constantparamNoel Grandin
Change-Id: I7bbc4e1546acf58f1ca24bfec5e465bad5ca90de Reviewed-on: https://gerrit.libreoffice.org/73732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08tdf#125381: Manage URLs beginning with an "~" in cutPrefix (dbaccess/dsntypes)Julien Nabet
On Windows or with other renderings than gtk3, the urls may begin with an ~ In this case, cutPrefix returns only empty string When trying to access Index management for odb files related to dBase indexes don't display because cutPrefix returns empty url in dbaccess/source/ui/dlg/detailpages.cxx line 200 198 ::dbaccess::ODsnTypeCollection* pTypeCollection = pTypesItem ? pTypesItem->getCollection() : nullptr; 199 if (pTypeCollection && pUrlItem && pUrlItem->GetValue().getLength()) 200 m_sDsn = pTypeCollection->cutPrefix(pUrlItem->GetValue()); Change-Id: I47360e205ddea7b060a31da697bbe9857ad3f4c0 Reviewed-on: https://gerrit.libreoffice.org/72568 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06drop never used dialogCaolán McNamara
Change-Id: I2474887914ec74e62667fd6f68ecb57bad89ca0d Reviewed-on: https://gerrit.libreoffice.org/73561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-05Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03tdf#39593 use UNO3_GETIMPLEMENTATION* macrosArkadiy Illarionov
Change-Id: I4e9af3b43a5baf19e100f42b3f37a2ade89ada5d Reviewed-on: https://gerrit.libreoffice.org/73320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-31dbaccess: fix more memory leaks caused by circular ReferenceMichael Stahl
Followup to 96ae2a3300811897c24cccb20f8c2faf382483df; more overridden acquire() creating cycles in dbaccess. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) Change-Id: I134343b3afbcd5ee3f71212ec18e551455eaee5b Reviewed-on: https://gerrit.libreoffice.org/73158 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-29tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)Xisco Fauli
Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53 Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890 Reviewed-on: https://gerrit.libreoffice.org/73146 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-16 16:30:04 +0000