summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2020-05-13aInfo should be usedTomoyuki Kubota
Change-Id: I6a62a65462fde741b3425f9095195c29924ce85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13loplugin:unusedvariableplusNoel Grandin
Change-Id: I58a466ac18debafa3bc2ff31c648ff51e126ab8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-11remove archaic Content.xml fallbackCaolán McNamara
there's no evidence that Content.xml (or Meta.xml) was written by any released version to necessitate the fallback reportdesign Settings.xml and Style.xml fallbacks appear to be cargocult influenced by the Content.xml/Meta.xml examples Change-Id: I51d138344edaffc6d21e17c2d28047ea6316304e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93970 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10CopyTableWizard: make code less confusingLionel Elie Mamane
createTable looked into the requested operation, and depending on that, either created the table or fetched the existing one. For a function named createTable, that made for confusing reading. Split that into: * createTable that creates the table * getTable that fetches the existing table * returnTable that automagically creates or fetches an existing table, depending on the requested operation. Change-Id: I91be67c24026c850530dcaef5ec95ab508e81434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93882 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09Fix mapping CompositionType->EComposeRule (dbaccess/tablename)Julien Nabet
Digging in git history, I got this: commit bf7690bc1b444278bef1e355c7463d27381a8700 Author: Noel Grandin <noel@peralex.com> Date: Thu Feb 25 09:38:09 2016 +0200 convert EComposeRule to scoped enum Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9 but the bug was there from the beginning: commit ce7d8915eadfa24c27e7ae261fa222344a3f2e22 Author: Oliver Bolte <obo@openoffice.org> Date: Mon Jul 10 14:20:25 2006 +0000 INTEGRATION: CWS qiq (1.1.2); FILE ADDED 2006/05/24 06:54:32 fs 1.1.2.1: XTableName implementation Change-Id: I3f253f0fc6659d8853798ade3ad2bf2e72a8be82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93841 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-08replace ODFDefaultVersion usage with ODFSaneDefaultVersion...Michael Stahl
... in SvXMLExportPropertyMapper. The condition nCurrentVersion == SvtSaveOptions::ODFVER_UNKNOWN is impossible since d571a509aa324db9a425110a67ea142d157256b2. ODFVER_UNKNOWN isn't a value of ODFSaneDefaultVersion so use std::optional to handle the remaining usage. Change-Id: I1e33cb707c289224664a385b4e4425e6788b2943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92728 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08improve loplugin:referencecastingNoel Grandin
to catch a few more cases Change-Id: I0323fba51bb2b4ba255e1db5aa0d890c5c6a2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in dbaccess..dtransNoel Grandin
Change-Id: Ie4b619dd19cc4d12d240759abea9c3ffdedd5c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92727 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-29simplify handling of comparing XML_NAMESPACE valuesNoel Grandin
Change-Id: I18bbf1ee206285842250891ce556d523489855b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-29weld SfxTemplatePanelControlCaolán McNamara
Change-Id: Ib3f6d01ddec37afc3987423dc15ab84ad6475f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-28Fix typo in codeAndrea Gelmini
Change-Id: I857308750454f913be574547a9ac4e7437ddf3a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92936 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-28move the castToFastAttributeList functionNoel Grandin
to the slightly higher namespace, to make it easy and more readable to use directly in a for-loop-range expression. And make it return a reference rather than a pointer, since it is never allowed to be nullptr. Change-Id: I15d0b32493ef65cfc601b247c272b318f1eadfd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27loplugin:unusedfieldsNoel Grandin
Change-Id: I47034909e6258fc4d65d39f484d71290f793107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27loplugin:makeshared in dbaccessNoel Grandin
Change-Id: Idf5f6179771edaf7af85d95e10b092ce0e3344f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27tdf#42949 Fix IWYU warnings in dbaccess/source/ui/[m-u]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bf360b331589692141f6fca52eee5b8e11ef7bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26update pchesCaolán McNamara
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25Typo: *Comparsion* -> *Comparison* in dbaccess/connectivityJulien Nabet
Change-Id: I9dfe37b290dbb83b1dfb2f92669ae254898ee72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-24loplugin:unusedmethodsNoel Grandin
Change-Id: Ieec5099a8ce9fa3f07e36be244071efc1b101cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23loplugin:makeshared in dbaccessNoel Grandin
Change-Id: If4208532d2905410a07b846afee46fba2fe1e549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92748 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22move InterimItemWindow to svtoolsCaolán McNamara
Change-Id: I058b1d96a3ddfaa1aa96f66d0ebc6fa68900a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21Fix storage access after savingSamuel Mehrbrodt
Change-Id: I2cd664ac2ca5e80c566efee35bd34e7223501d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92605 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-21Fix macro signature getting lost when inserting data into tableSamuel Mehrbrodt
Change-Id: Iec514bfc0edd4f10a09809c68b8501667d978e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92573 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-20Restore this header for Windows onlyMike Kaganski
... after commit 644db9df9ccce3d10c92ff365d0ac2e1b1fa33de Change-Id: Iecaaacaffd494afafcb779c41d59af8e9dbbc6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92529 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-20tdf#42949 Fix IWYU warnings in dbaccess/source/ui/[a-d]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifd96569ecdbbcde3c7fc9462a29e42386d1ae3a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-20tdf#131814 Remove Close button from Table Data toolbarGabor Kelemen
Change-Id: I3e387da217fdbbbb37db1f61f85fc957c5969c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92327 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-17loplugin:buriedassign in dbaccessNoel Grandin
Change-Id: Ia97da8d228a8c4e3ced31718a756fb13757beb8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:flatten in dbaccessNoel Grandin
Change-Id: Ifcfd3637fbce6dc3a07a1859f102a6ac85149190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-12improve fastparser loggingNoel Grandin
so we print out the full namespace, which is quite handy when tracking down attributes that are not being parsed. Change-Id: I085d39b365d43c1a53a7c176b633ea38e6a7fb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09tdf#75280 Clean up usage of sal_uIntPtr.shivammore
Change-Id: I671fbca67846f7f105c06a2423e7c7ee5c8d6894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91223 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08Related tdf#97694 Fix macro preservation on WindowsSamuel Mehrbrodt
Change-Id: Ief183c75e0c3ce6c42868b7c60c5f66f9684d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91795 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-07new loplugin:unusedvariableplusNoel Grandin
a particularly aggressive checker, which is why it is off by default Change-Id: Id5a0faa50b3ecc75e01f4aedc6579c5209e585da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06loplugin:unusedvariableplus in dbaccessNoel Grandin
Change-Id: Id2c2416443b2c9d6d516513ee543542e9681f69a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01Related tdf#97694 Preserve macro signatures in BaseSamuel Mehrbrodt
Change-Id: I139ac003d1c95144e6cb1beec774f3cf142625b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91466 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-01tdf#42949 Fix IWYU warnings in dbaccess/source/[f-s]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I2a527ddf039674bba2346a846859a6f7b2e024ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-31Fix reading ODF versionSamuel Mehrbrodt
Change-Id: I5787737d3f689fba93bf4be56c018967b5e37ab1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91407 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-31Related tdf#97694 Show dialog when signed macros are blockedSamuel Mehrbrodt
Change-Id: I7b9dd4872a58eff93ab8818f0286781c6ff4c9bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91385 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-31Remove outdated commentSamuel Mehrbrodt
Macro signatures are evaluated since f2f93434f4795646255e5d8edd31fa08b8b2ffab Change-Id: I83eb84bc96e466da58fa77067f07245b023ebbe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91406 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-30tdf#131576 Fields not displayed as expected in Base's Table WizardCaolán McNamara
this is similar to the problem of tdf#130623 "Base: Empty Field Properties" so take that solution and move it down the the shared component Change-Id: I15e26ca1c781b3a90ece2073112953cc40083d15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91362 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-28Fix is_typed_flags for MessBoxStyle (dbaccess)Julien Nabet
Change-Id: Ic788677b540588ddddae963a3fc983879cd77c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-27cid#1460975 Unchecked return valueCaolán McNamara
Change-Id: I37fbce514318609d3b6c99a11070e43e2a03ee03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460977 Unchecked return valueCaolán McNamara
Change-Id: I8399df5aabae57df79c5e45a9b85fead482cde8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460969 Uninitialized scalar fieldCaolán McNamara
multiple ctor's strikes again Change-Id: Ieaae6d5c9e76a3ade17289ce7d1bdffad1168cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91191 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27these methods can take a const argumentCaolán McNamara
Change-Id: I0ec68d40dcc34075c72c0d60d3a4b6e8262a8e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23Fix typosAndrea Gelmini
Change-Id: Iba46fbe8559211403118a23cd198a2217b333a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2025-01-09 18:17:44 +0000