summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2014-11-06loplugin:salboolNoel Grandin
Change-Id: Ib1cb796c53ace96002c3c99c84ce090a11fb1e84
2014-11-06WaE: VarDecl, use bool instead of sal_Bool [loplugin:salbool]Tor Lillqvist
Apparently the salbool plug-in warns if a sal_Bool is initialized in the C++ fashion. Change to the C fashion and no warning, huh? Change-Id: I0f4e33cb33ffb1e0d5571d3757a6bb3bc9c44a64
2014-11-05coverity#706401 Uncaught exceptionCaolán McNamara
Change-Id: Iacbaf56a23d6f1878c5a5ec6f00db8211cb8ed62
2014-11-05coverity#706388 Uncaught exceptionCaolán McNamara
Change-Id: I4382645e47ae81e3f15bf69aaa2432dcebd40712
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04covertiy#705369: dbaccess: move XML_TOK_ENCODING to enum XMLDataSourceInfoMichael Stahl
Looks like Commit 94e8385d56098b6a51c539b5374dbf03151d2559 added this to the wrong enum. Change-Id: I46dd82313aaa659e84c719ba9215682becf8ec6c
2014-11-03I think this should be Left()David Tardon
Change-Id: I603215180e86ca28b94b129378ec48b7658e37b5
2014-11-03I think this should be Left()David Tardon
Change-Id: Ifd83a4a28414ffa5d8cc3cec3def4361737a333e
2014-11-03coverity#1242510 arguments in wrong orderDavid Tardon
Change-Id: I898f3e383f5ff3451860e49b0ea00111ed1b52c2
2014-11-03callcatcher: update unused codeCaolán McNamara
Change-Id: Ida4221bfbfe30f7e1abd5c367d8cb8b9edd310bb
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-28coverity#706465 Uncaught exceptionCaolán McNamara
Change-Id: Ic328c8a68fac462c402b70f85093cd8b14d2882d
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-22Revert "PythonTest_dbaccess_python: don't modify source document"Michael Stahl
This reverts commit 29474c7a227050b16fc341bdf7df68112793a23d. Removing the lock file fails on Windows because it is opened; it ought be possible to close the document instead to clean up the lock file? Change-Id: I2c93fc893c62d6a267be9723761e5ed7577086a7
2014-10-22Save precious vertical space by removing some redundant heading labelsAdolfo Jayme Barrientos
Change-Id: I6aaa7602f57f6cb2d0f9bc3ee897a9c3576d47d3 Reviewed-on: https://gerrit.libreoffice.org/12012 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21PythonTest_dbaccess_python: don't modify source documentMiklos Vajna
Change-Id: I4e8f94554141e41863c474c5f99be4b1974f3dd7
2014-10-21dbaccess: make sure fdo84315.odb.lck is removed after the test passedMiklos Vajna
Change-Id: I6c9a42625f10a3a30e2636a2a2be2b9bcba8f6af
2014-10-21connectivity: firebird: fix temp directory leakMichael Stahl
Dispose the dbaccess document, and recursively delete the temp directory in Connection::dispose(). Change-Id: Id283289e44b8ca09b88da19920da7f27b551aa7e
2014-10-21dbaccess: surely the problem is that the storage could _not_ be committed?Michael Stahl
Change-Id: I03e7e09e185e9cb25868c86de0b402b89e7f5d75
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-12coverity#706421 Uncaught exceptionCaolán McNamara
Change-Id: I91a6ac9d9bda0ea25f1f5385bbac71ea9d22d573
2014-10-12coverity#706404 Uncaught exceptionCaolán McNamara
Change-Id: I7717b61e89d95cb6d89bb273c22c0503b0853d96
2014-10-12coverity#706478 Uncaught exceptionCaolán McNamara
Change-Id: Ie37ebac80afb3e52668ae6ebeeb61eaddc892ef6
2014-10-12coverity#706476 Uncaught exceptionCaolán McNamara
Change-Id: I1461c99fccb57ccf5375e372e50948b0b355d4bb
2014-10-12coverity#706477 Uncaught exceptionCaolán McNamara
Change-Id: If44507458f8473d6fede3e430e69620f8fb1d698
2014-10-12Remove a GtkFrame and its redundant labelAdolfo Jayme Barrientos
It’s more than obvious that these are “Options”. Change-Id: I192a1864bc43b3e20e98e179282dac02abbdbbf4 Reviewed-on: https://gerrit.libreoffice.org/11925 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09forgotten part of previous commitLionel Elie Mamane
Change-Id: If050e630edacef67ab194c0b6941a6542e4ebceb
2014-10-09fdo#84073: change ODBC/JDBC escapes to lowercaseJulien Nabet
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8
2014-10-09Remove jvmfwk plugin featureStephan Bergmann
...which was effectively unused; there only ever was a single sunjavaplugin that is now folded directly into jvmfwk. Leaves room for further clean up. Change-Id: I14dd2a3a09bd1ce9a8c3f5c156628ec11d954a0b
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-07fdo84315: add integration test for basic LibreOffice Base functionalityBjoern Michaelsen
Thanks to Stephan for helping with the test environment setup: sbergman@redhat.com: Do the same "set UserInstallation to user profile dir in test/user-template" in UnoInProcess's setUp as is done in test::BootstrapFixtureBase::setUp (unotest/source/cpp/bootstrapfixturebase.cxx) for CppunitTests. That way, these tests all use the workdir/unittest/ UserInstallation concurrently, but they at least do not run into the gotcha in SubstitutePathVariables::SetPredefinedPathVariables (framework/source/services/substitutepathvars.cxx) to only set the PREDEFVAR_USERPATH if PATH_EXISTS. Change-Id: Iad058098a4c69cb567e2d3222af3c7d4ba993271
2014-10-06fdo#84658 on reexec, cancel modification before resetting IsModification stateLionel Elie Mamane
Change-Id: I878bff4d36ca1c2dd9474c937b03d0b366a6e911
2014-10-03coverity#1242480 Dereference null return valueCaolán McNamara
Change-Id: I9818e647915bd2b973c617feb7efd256621cf2de
2014-10-03loplugin: cstylecastNoel Grandin
Change-Id: Ie478d1fcfd3b64d7a2128887c216b5e0b4501ab9
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01coverity#1242747 Uninitialized pointer fieldCaolán McNamara
Change-Id: I1530d071ad44afc114f1916bf234e0616b7dce90
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
generated by cgit (git 2.34.1) at 2025-02-03 03:28:54 +0000