summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-18tdf#57950 Replace chained O(U)StringBuffer::append() with operator+melikeyurtoglu
Change-Id: I2576c997d5b82fd8bdfd0c9430c7a1e11d7e07df Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/22049 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-17Fix missing iterator include on MSVC 14.0David Ostrovsky
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586 Reviewed-on: https://gerrit.libreoffice.org/22448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-15tdf#57950: Replace chained O(U)StringBuffer::append() with operator+Arnold Dumas
Change-Id: Ic76cf0130ebec4cf723b83d82f59ae45bfcb3ea1 Reviewed-on: https://gerrit.libreoffice.org/22350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09sequence->vector in OCacheSetNoel Grandin
Change-Id: I61c6486d42dbc404355809a80943885457e79384 Reviewed-on: https://gerrit.libreoffice.org/22184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-06vcl: split exception types from input typesChris Sherlock
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03fix previous commitMarkus Mohrhard
Change-Id: I3e3b0cf703162b5f01148aced9a1d5faabb5d50d
2016-02-03remove bogus nullprt checks for pContextJochen Nitschke
reported by Cppcheck Change-Id: I737c2bd7be197ef9d0b29b922acd8021fefb7af6 Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-on: https://gerrit.libreoffice.org/22059 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01boost::mem_fn->std::mem_fn in dbaccessNoel Grandin
Change-Id: I9156e106d12b670e94bab899a4f67a35701ae5ac
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-29whitespace fixupakki95
Change-Id: Ia5a2cd92e069c038f4ff0c97876b95c5d81e4db1
2016-01-29tdf#45775 PgSQL new DB allow empty Datasourceakki95
Change-Id: I5d672629ddf7f153f0ad1927f0f6c0ffc545c3ab
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13loplugin:unusedmethods unused return value in include/sfx2Noel Grandin
Change-Id: Id4017bdfe18f8224d28a9f787865c7a880aeeed8
2016-01-11loplugin:privatebase: Make various derivations publicStephan Bergmann
...assuming they were implicitly made private by accident rather than by design. (And private derivation can cause unexpected failure of dynamic_cast, cf. 63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove then-unnecessary downcasts.") Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-11-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I8d2870dc003185598977876e4ff54af74645bc90
2016-01-11loplugin:unusedmethods unused return value in dbaccessNoel Grandin
Change-Id: Ia7ec0209a635f8482b6ccbaa7ba48a8c6da79090
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ic6407a57440fbd887f9ec9d5963e5748aa89a29e
2015-12-31Typo: NOTIFY_LISTERNERS_CHECK->NOTIFY_LISTENERS_CHECKJulien Nabet
Change-Id: Ie4c7a7dee81c2a0890ddc8bd083c2e3fee584f7e
2015-12-24loplugin:unusedfieldsNoel Grandin
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-23New saving behaviorMaxim Monastirsky
Changes in this commit: - AlwaysAllowSave config is gone. Saving is always permitted, unless in a read only document. Also changed the behavior in dbaccess to match sfx2. - The toolbar save button is always enabled, to always give access to the dropdown. That's the case even in a read only document, except that it changes to DROPDOWNONLY, and the save as command icon+tooltip. In table/query designers we still disable the button in read only state. - When the document is modified, the toolbar button gets a special icon to indicate that. TODO: - Icons for the document modified state are still missing. I added some fake links to Tango's links.txt in order to test the new behavior. These links shouldn't stay as-is in a production version! Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e Reviewed-on: https://gerrit.libreoffice.org/20839 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-12-23loplugin:unusedfields in dbaccessNoel Grandin
Change-Id: I5f38bf33deaec17203e1bdcd3a61085266e42501
2015-12-18dbaccess: module_dba not used anymoreMatúš Kukan
Change-Id: I6f9222dd40c553e1d0ad63e00e5874be939a97c1
2015-12-18XComponentContext not needed for DataAccessDescriptorMatúš Kukan
Change-Id: If5ede0c308930d37bff9e97afc8a76cc5b709034
2015-12-16assert that no ODF import happens without a BaseURLMichael Stahl
Change-Id: I4520a9d0350349cb083ed627a19264a3a97e090f
2015-12-12OOneInstanceAutoRegistration is not usedMatúš Kukan
Change-Id: I6928dec92655e4655af6c519405712892bf7d870
2015-12-12tdf#74608 dbaccess: Constructor for singleton DataAccessDescriptorFactoryMatúš Kukan
Change-Id: Id1453e3cf1c8aef22536b4e0797cca7e654316c0
2015-12-11No need for a separate <vcl/graph.h>Tor Lillqvist
Change-Id: I962544005b5d408f7c044a02eefe09b87d8a81fe
2015-12-11Return std::unique_ptr from svt::AcceleratorExecute::createAcceleratorHelperStephan Bergmann
...to prevent errors like 5ac6e00274e732435b55c2908db9cea658fe549b "Memory leak" Change-Id: I3e20393af628849d8a387b491b75e1aacdea982a
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-05loplugin:defaultparamsMatúš Kukan
Change-Id: I9015579a93e58d382866cbebe7af462735b08700
2015-12-05tdf#74608 dbaccess: Constructor feature for ODatabaseDocumentMatúš Kukan
Change-Id: Id524a1a717c350cb0558ef5ff11da3e6c941c203
2015-12-05tdf#74608 dbaccess: Constructor feature for OComponentDefinitionMatúš Kukan
Change-Id: I150cdaa46a0d86e1a4b6598ac580a10b2e8f071f
2015-12-05Fix Treelist shouldn't use VCLEVENT_LISTBOX_SELECTJulien Nabet
warn:legacy.osl:21997:1:accessibility/source/extended/accessiblelistbox.cxx:103: Debug: Treelist shouldn't use VCLEVENT_LISTBOX_SELECT To reproduce: - Launch Base and create a brand new HsqlDb file or open an existing one - Select Tables pane - Click Table Design => the message appears in console Change-Id: If7fa99890bbec8795a62b83dbe193247adffb733 Reviewed-on: https://gerrit.libreoffice.org/20411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-12-05tdf#96234: Type Formatting, Primary key checkbox may be checkedJulien Nabet
Right click on a field in Type Formatting (Base, paste a table from Calc for eg) makes a popup which takes into account now if the field is a primary key or not. Handles multi-fields primary key, too: the selected fields must be exactly those in the primary key, no more, no less. Change-Id: I545b946bccd3fc02f4f6c3bdb99f914d181a3d40
2015-12-05tdf#74608 dbaccess: Constructor feature for OCommandDefinitionMatúš Kukan
Change-Id: Ibaa1fd8310fdba073190a7721891ebb835eb0e6e