summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)Author
2015-11-09Prevent += called on temporary O[U]String instancesStephan Bergmann
...found regression e31205f3ec1f941ab5a188bfde6329edf2acc55b "EditUndoRemoveChars::GetStr must return a reference" and dubious code 0e23f7b0839df68d277186b4df54ba391ac3406a "Lets assume this doesn't want to update m_pForcedPrefix->GetText() anyway" in addition to the apparent sillies directly fixed in this commit. Introduces HAVE_CXX11_REF_QUALIFIER. Change-Id: I564e98254fd53c1dd9b34193d7057c59721ee24c
2015-11-09Lets assume this doesn't want to update m_pForcedPrefix->GetText() anywayStephan Bergmann
The line was like that ever since the code was introduced with 13d20309158340fca42c44e7a9a460ddbeee5126 "edit control for connection urls," and Window::GetText() likely never in the past returned a reference to a string. Change-Id: Ideb5c6a279ac25c2439187a9182f988696818012
2015-11-09new loplugin: oncevarNoel Grandin
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I14bdbad2469d05eb25514d7ab995acb8c6ef7bd1
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-04loplugin:stringconstantNoel Grandin
Change-Id: Id5a07591a1d3a7264a0a979f25e8c2c859ec0492 Reviewed-on: https://gerrit.libreoffice.org/19767 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I3d45914e349a4268204af84b95b53ccce7b9d544
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-28dbaccess KeySet: on insert, set NULL only when there is no default valueLionel Elie Mamane
Change-Id: I4f9ea6760a7e47d28fe378c8429fb286d6e7f33e
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27inline SfxMediumRef typedefNoel Grandin
Change-Id: Id6dc03a5957adf657d12db7941273593a9f7c10f
2015-10-26remove extra spaces around ::Noel Grandin
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-21more removal of com::sun::star typedefsNoel Grandin
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21Fix indentation.Jan Holesovsky
Change-Id: Id33e58b6e298ff7b3a421a5cd96df1372a4a7923
2015-10-20tdf#89592: use initializer listmarstay
Change-Id: I5b2dece19512399f6646a8f7acf022d4230a760a Reviewed-on: https://gerrit.libreoffice.org/19430 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-20tdf#93724 KeySet insert: properly set default values: NULL & right typeLionel Elie Mamane
Change-Id: I933eed918e18b6923d4e0d24748297cf0dd0088d
2015-10-20convert Link<> to typedNoel Grandin
Change-Id: I9453beedfa059d4f260ca136c02a6104fc4d4829
2015-10-20convert Link<> to typedNoel Grandin
Change-Id: I822561725683231709343b80d7065c905226ebc1
2015-10-20convert Link<> to typedNoel Grandin
Change-Id: Id3ed50dc7fd4f783034797b2401ae05c96d002de
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I9dccf0538389063648e97575ff4c3765f0b1256b
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I83d411adf8ef882618bd48ab73602f7cf1531078
2015-10-19cleanup some local var declarationsNoel Grandin
found with git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19remove dead Link<> codeNoel Grandin
Change-Id: I01891cd34535ea08a07c3bb47976f6c9a70c3656
2015-10-19sfx items: Kill the SFX_ITEMSET_GET macro.Jan Holesovsky
Change-Id: I110a4f25646eb3f0fa93673c84dc67cf64a3b7a0
2015-10-17coverity#1327443 Division or modulo by zeroCaolán McNamara
Change-Id: Iefddcc2d66e77e3698dec9930898f63e0b7902f6
2015-10-16convert Link<> to typedNoel Grandin
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15simplify the CellController modify Link<> handlingNoel Grandin
in preparation for some more "make Link<> typed" work Change-Id: Ifdf58cc697c7172102bf9e4cc63f869c522517e6
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15simplify the way we override behaviour hereNoel Grandin
just send everything via callModifiedHdl() Change-Id: I011df1d1c376deae962b465e4a27e98af968de6f
2015-10-13Assumed fix of a clang-analyzer-deadcode.DeadStoresStephan Bergmann
...where the "bOk = false" from the leading "if" is always overwritten in the following check of "bOk = sTableRange == _sUpdateTableName". The code had been effectively like that ever since it got introduced with 4ae41a466ad659524809c23c9086df70c5456a39 "INTEGRATION: CWS dba30," but it looks broken. I assume the two checks of "sTableRange == _sUpdateTableName" for pNode->GetChild(0) and pNode->GetChild(2) shall only be done if the leading "if" is not hit. (And one remaining uncertainty is if really only one of those "sTableRange == _sUpdateTableName" checks needs to be true or if both should be true for bOk to be true.) Change-Id: I453690d65326ed67d7a074d4e4783a743a60d454
2015-10-13clang-analyzer-deadcode.DeadStoresStephan Bergmann
In 8b9e4e393eff8b89a37a5932548700c0b50bcab8 "initial import" the assignment to bCheck was in a for loop that used bCheck in its condition, sal_Int32 nPos = m_nStartPos+1; for(; aIter != m_pMatrix->end() && bCheck;) { if(!aIter->isValid()) ... m_pCacheSet->fillValueRow(*aIter++,nPos++); bCheck = m_pCacheSet->next(); } that loop was then replaced with sal_Int32 nPos = m_nStartPos; bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck); (without further use of bCheck) in 2facbebb88fe72614d566c3187c8f86c5c61f8bd "MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around { ORowSetMatrix::iterator aIter(aEnd); sal_Int32 nPos = m_nStartPos + 1; bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck); } introduced in 1234d599d4ee67bd725f0513431b2d4c56c9e09d "ORowSetCache: overhaul internals," presumably to limit the scope of that aIter introduced there). Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1
2015-10-13loplugin:mergeclasses, merge OOdbcLibWrapper with OOdbcEnumerationNoel Grandin
Change-Id: I2e564e90c11bb46022a5e258ad013aeb2fe4ca2e
2015-10-13loplugin:mergeclasses, merge ILabelProvider with LabelProviderNoel Grandin
Change-Id: I8fb231b4189c09d8e049855d38b0f1eb518ac2b9
2015-10-13loplugin:mergeclasses, merge IImageProvider with ImageProviderNoel Grandin
Change-Id: I6af8b1ab9198439af60e38a9adc6bdd29d20ab52
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12convert Link<> to typedNoel Grandin
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12loplugin:mergeclassesNoel Grandin
Change-Id: I1ce2e31e4dae780612e51b3806ee6044be9cf4bb
2015-10-12formattingNoel Grandin
Change-Id: Id712e25efc6ea99c0979b48e6cbec068864f4c46
2015-10-12unnecessary and confusing typedefNoel Grandin
Change-Id: Id16013c3e12312608eba2eda378debf362da7013
2015-10-12Related tdf#45775: PgSQL new DB allow empty DatasourceJulien Nabet
Declare PostgreSql in dsn stuff Change-Id: I72343bff0d5e6a65a45fc47cc1d346155330f1e5 Reviewed-on: https://gerrit.libreoffice.org/19310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-10-07tdf#94709 - protect TableWindowTitle Command execution.Michael Meeks
Change-Id: I202a154e18c1fbffc31abcc7ccd7f500b67a4c13
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I84dee96b7a1f72db46e3330ec5195367dfce894a
2015-10-06Fix typosAndrea Gelmini
Change-Id: I54c32259750c0863a39f56fabaa1a0df7d208c9a
2015-10-06loplugin:unusedmethodsNoel Grandin
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
generated by cgit (git 2.34.1) at 2025-01-07 22:48:01 +0000